--- Rob Richards <[EMAIL PROTECTED]> wrote: > To check the memory, I had _CrtDumpMemoryLeaks() log to a file after > the tsrm_shutdown to test final leaks. Had to step through the code > otherwise for other parts as the system would bail out without any > indication of where. For the patch, the code for the isapi and > apache2 sapi can be dumped as those added the ts_free_thread() calls,
> which I see are wrong. As I mentioned, the other changes work fine in > windows. If no one sees anything glaring in those changes, I will > gladly test them in another environment. Rob, It looks like most of these changes are PHP5 specific (either the code changes like many of the free()s were already in PHP4, or involve things like the global constants cache which don't exist there) which I haven't looked at enough to comment on. The only question I have is about the freeing of the BG(url_adapt_state_ex) tags hash. I see you added the code to basic_globals_dtor to free it after each request (which makes sense as it's wiped in basic_globals_ctor), but why only for the ZTS build? Is there a reason that this couldn't be used for all the builds (and remove the similar code for non-ZTS-only builds from the url_scanner shutdown)? Hummm... I also just saw the php_url_scanner_ex_deactivate() function. Maybe the hash free should be there instead? Michael __________________________________ Do you Yahoo!? Protect your identity with Yahoo! Mail AddressGuard http://antispam.yahoo.com/whatsnewfree -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
