Re: [PHP-DEV] is GD being actively maintained?

2012-09-06 Thread Alexey Shein
2012/9/6 Jannik Zschiesche : > Am Donnerstag, 6. September 2012 um 15:05 schrieb Alexey Shein: > > Hi, Rasmus, > > Just wanted to note that I've tested your script from > http://fontjazz.com/metrics/test.php and couldn't reproduce the bug. > I'm on the Ubuntu 1

Re: [PHP-DEV] is GD being actively maintained?

2012-09-06 Thread Alexey Shein
Hi, Rasmus, Just wanted to note that I've tested your script from http://fontjazz.com/metrics/test.php and couldn't reproduce the bug. I'm on the Ubuntu 12.04 with PHP 5.3.10-1ubuntu3.2 with Suhosin-Patch Have you tried upgrading your FreeType library and recompiling latest stable PHP with it? G

Re: [PHP-DEV] [RFC] skipping optional parameters

2012-04-17 Thread Alexey Shein
18 апреля 2012 г. 11:40 пользователь Stas Malyshev написал: > Hi! > >> NULL or empty string? I.e. will optional parameters always get NULLs >> or their default values? > > Their default values. That's the whole point of it - if I wanted just > nulls, I could put nulls in the call, but if I want th

Re: [PHP-DEV] [RFC] skipping optional parameters

2012-04-17 Thread Alexey Shein
Hi! My opinion is that solution tries to overcome bad consequences of legacy code, when it's not feasible to change something without breakage a lot of code, although the real solution is to refactor functions with long variable lists (as Uncle Bob says), maybe this should be noted in documentatio

[PHP-DEV] Re: [PHP-DOC] Creating new remote branch: Fatal error.. but still seem to have worked

2012-04-08 Thread Alexey Shein
суббота, 7 апреля 2012 г. пользователь Hannes Magnusson писал: > Hello > > I pushed a new branch (with no changes) just now, and got the > following fatal error. > The branch seems to have been pushed just fine though? > > > vagrant@lucid32:~/src/phd$ git checkout -b PHD_1_1 > Switched to a new br

Re: [PHP-DEV] resume after exception

2012-04-02 Thread Alexey Shein
3 апреля 2012 г. 0:40 пользователь Johannes Schlüter написал: > On Mon, 2012-04-02 at 08:44 -0400, Rasmus Schultz wrote: >> I was just reading about the new async/await keywords in C# 5.0, and while >> this has no particular relevance to PHP as such, it got me thinking about >> this idea... >> >>

[PHP-DEV] Change all XFAIL tests to FAIL

2012-04-01 Thread Alexey Shein
1 апреля 2012 г. 14:27 пользователь Ferenc Kovacs > написал: > On Sun, Apr 1, 2012 at 9:39 AM, Christopher Jones < > christopher.jo...@oracle.com > wrote: > >> >> >> On 3/31/12 2:38 PM, Alexey Shein wrote: >> >>> 1 апреля 2012 г. 0:27 пользовател

Re: [PHP-DEV] Change all XFAIL tests to FAIL

2012-04-01 Thread Alexey Shein
1 апреля 2012 г. 2:38 пользователь Alexey Shein написал: > 1 апреля 2012 г. 0:27 пользователь Johannes Schlüter > написал: >> On Sat, 2012-03-31 at 13:21 +0500, Alexey Shein wrote: >>> By constantly publishing >>> newsletter with failed / xfail bugs you're t

Re: [PHP-DEV] Change all XFAIL tests to FAIL

2012-03-31 Thread Alexey Shein
1 апреля 2012 г. 0:27 пользователь Johannes Schlüter написал: > On Sat, 2012-03-31 at 13:21 +0500, Alexey Shein wrote: >> By constantly publishing >> newsletter with failed / xfail bugs you're telling them "That's our >> current problems. Maybe you could help

Re: [PHP-DEV] (*PATCH*) getters/setters Implementation

2012-03-31 Thread Alexey Shein
31 марта 2012 г. 18:19 пользователь Clint M Priest написал: > The patches are applied to this fork if anyone wants to check it out: > > https://github.com/cpriest/php-src > It would be easier to discuss/review your patch if you'd make pull request: https://wiki.php.net/vcs/gitworkflow#workflow_fo

Re: [PHP-DEV] Change all XFAIL tests to FAIL

2012-03-31 Thread Alexey Shein
31 марта 2012 г. 12:34 пользователь Rasmus Lerdorf написал: > On 03/30/2012 11:25 PM, Alexey Shein wrote: >> Hmm, that's different. You get a notification if there's some change >> on that bug (new comment/state changed/patch etc.). If bug didn't >>

Re: [PHP-DEV] Change all XFAIL tests to FAIL

2012-03-31 Thread Alexey Shein
31 марта 2012 г. 12:50 пользователь Stas Malyshev написал: > Hi! > >> 2) Keep devs' attention on known failures - XFAIL doesn't solve that. >> You remember about them when you run tests and if you want make >> attention at them. > > Which devs you are referring to? Why you assume their attention n

Re: [PHP-DEV] Change all XFAIL tests to FAIL

2012-03-30 Thread Alexey Shein
30 марта 2012 г. 22:16 пользователь Christopher Jones написал: > > > On 3/29/12 3:00 PM, Alexey Shein wrote: >> >> Hi, internals! >> >> I've got a suggestion about refactoring our tests suite. I'd like to >> remove XFAIL institution and mark all f

Re: [PHP-DEV] Change all XFAIL tests to FAIL

2012-03-30 Thread Alexey Shein
30 марта 2012 г. 5:55 пользователь Stas Malyshev написал: > Hi! > >> The difference started from 5.3.9 release when we start to pay *much >> more* attention to tests. >> You now can cleanly see failing tests, it's not that huge list, so >> it's big difference. > > Yes, and removing XFAILs would ki

Re: [PHP-DEV] Change all XFAIL tests to FAIL

2012-03-29 Thread Alexey Shein
30 марта 2012 г. 3:19 пользователь Stas Malyshev написал: > Hi! > >> I've got a suggestion about refactoring our tests suite. I'd like to >> remove XFAIL institution and mark all failing tests just as FAIL. >> XFAIL has a problem that it hides attention from failing tests >> depending on not yet f

[PHP-DEV] Change all XFAIL tests to FAIL

2012-03-29 Thread Alexey Shein
Hi, internals! I've got a suggestion about refactoring our tests suite. I'd like to remove XFAIL institution and mark all failing tests just as FAIL. XFAIL has a problem that it hides attention from failing tests depending on not yet fixed bugs (most important), not yet implemented features (less

Re: [PHP-DEV] Git merging fun and a local clone-per branch workflow

2012-03-27 Thread Alexey Shein
28 марта 2012 г. 0:18 пользователь Christopher Jones написал: > > > On 03/24/2012 11:17 AM, Alexey Shein wrote: > >> Done: https://wiki.php.net/vcs/gitfaq#multiple_working_copies_workflow > > > I tried it out today.  It mostly went smoothly. Hi! Glad to hear that.

Re: [PHP-DEV] Adopt GitFlow process

2012-03-26 Thread Alexey Shein
26 марта 2012 г. 4:30 пользователь Stas Malyshev написал: > Hi! > >> Main problem is that our current workflow doesn't allow branch-only >> changes. I.e. if you make a bugfix and want to stay it in PHP-5.3 only >> you can't merge 5.3 with 5.4 anymore, otherwise your bugfix will go >> there. > > Wh

Re: [PHP-DEV] Adopt GitFlow process

2012-03-25 Thread Alexey Shein
26 марта 2012 г. 2:04 пользователь Stas Malyshev написал: > Hi! > >> There was a discussion recently on IRC that our current git working >> process is not perfect (especially about keeping one branch-only >> bugfixes) so that's a > > One thing with discussions on IRC is that nobody except those pr

[PHP-DEV] Adopt GitFlow process

2012-03-25 Thread Alexey Shein
Hi, internals! There was a discussion recently on IRC that our current git working process is not perfect (especially about keeping one branch-only bugfixes) so that's a suggestion to use (and modify to better suit our needs) nvie's gitflow process and git-flow tool he developed to ease the proces

Re: [PHP-DEV] Re: cvs.php.net

2012-03-25 Thread Alexey Shein
25 марта 2012 г. 23:33 пользователь Ferenc Kovacs написал: > On Sun, Mar 18, 2012 at 8:20 PM, Ferenc Kovacs wrote: > >> Hi, >> >> Now that the git migration is reaching php-src, I would like to know what >> will we do with cvs.php.net (eg. the pserver still running on it). >> There is also a ment

Re: [PHP-DEV] Git merging fun and a local clone-per branch workflow

2012-03-24 Thread Alexey Shein
> Nice work Alexey. > > Can you expand on the "if necessary" part of the setting the > pushurl? I removed that part and added some explanation about clone urls in the beginning. Since this workflow is generally for core devs ssh/https are read/write so you don't need separate setting push-urls. >

Re: [PHP-DEV] Git merging fun and a local clone-per branch workflow

2012-03-24 Thread Alexey Shein
24 марта 2012 г. 18:23 пользователь David Soria Parra написал: > On 2012-03-24, Alexey Shein wrote: >> Hello, >> >> Just wanted to say that I updated multiple working dirs scenario here >> https://gist.github.com/2165086/, which is *much* more simplified now, >>

Re: [PHP-DEV] Git merging fun and a local clone-per branch workflow

2012-03-24 Thread Alexey Shein
Hello, Just wanted to say that I updated multiple working dirs scenario here https://gist.github.com/2165086/, which is *much* more simplified now, thanks to dsp for hint about git-new-workdir script. It should work fine if all changes from downstream branches (such as PHP-5.3) are always merged i

Re: [PHP-DEV] ECDSA support in the openssl extension

2012-03-21 Thread Alexey Shein
21 марта 2012 г. 12:43 пользователь Sergey Ryazanov написал: > 21 марта 2012 г. 10:27 пользователь Alexey Shein написал: >> 21 марта 2012 г. 3:34 пользователь Sergey Ryazanov >> написал: >>> Hello all. >>> >>> Openssl starting from version 0.9.8

Re: [PHP-DEV] ECDSA support in the openssl extension

2012-03-20 Thread Alexey Shein
21 марта 2012 г. 3:34 пользователь Sergey Ryazanov написал: > Hello all. > > Openssl starting from version 0.9.8 supports the ECDSA signature > algorithm. Return value of the openssl_get_md_methods() also includes > "ecdsa-with-SHA1" string. But if I call openssl_sign() with EC key > then I have a

Re: [PHP-DEV] Release process nit

2012-03-12 Thread Alexey Shein
13 марта 2012 г. 3:00 пользователь Stas Malyshev написал: > Hi! > >> are they in svn? I can't see them in 5.4 > > > They are not in SVN, but at least for autom4te.cache ones they seem to be > generated when configure script is generated, and the packing script happily > picks them up. I have no id

Re: [PHP-DEV] Git Migration Status Update

2012-01-26 Thread Alexey Shein
+1, Thanks David! 2012/1/26 Paul Dragoonis : > Hi David, > > Thanks for the great push on the DVCS push to git. I believe I speak for > many people when I say your hard work is really appreciated. > > Look forward to testing out the git installation. > > - Paul. > > On Wed, Jan 25, 2012 at 11:36 P

Re: [PHP-DEV] Git Migration: An Update

2011-12-15 Thread Alexey Shein
AFAIK, git natively supports rsync protocol, see man git pull. 2011/12/15 Johannes Schlüter : > On Thu, 2011-12-15 at 18:11 +0100, Hannes Magnusson wrote: > >> >  1. Compile a list of scripts/sites that need to be changed in order >> >     to work with the git repo. Some sites are already on the l

Re: [PHP-DEV] 5.4 regression: non-existent sub-sub keys now have values

2011-11-24 Thread Alexey Shein
2011/11/24 : > On 24 November 2011 01:38, Stas Malyshev wrote: >> Hi! >> >>> But neither is introducing a potential bomb of the kind that the 'date' >>> saga >>> created. The problem this change IS causing is likely to hit many live >>> sites >> >> The claim that many live sites actually regularl

Re: [PHP-DEV] Re: Character lost while convert from cp936 to utf-8 using mb_convert_encoding

2011-11-18 Thread Alexey Shein
Well done! :) 2011/11/18 Laruence : > Hi: > >   I have fixed the bug(it is a simple fix that I didn't expect before > I look into it ),  ignore me... > > thanks > > On Fri, Nov 18, 2011 at 1:09 PM, Laruence wrote: >> Hi: >> >>   I have filed a bug about this issue: https://bugs.php.net/bug.php?id=

Re: [PHP-DEV] PHP CLI webserver test failures

2011-11-16 Thread Alexey Shein
2011/11/17 Christopher Jones : > > > On 11/16/2011 01:09 PM, Alexey Shein wrote: >> >> 2011/11/17 Ferenc Kovacs: >>> >>> >>> On Wed, Nov 16, 2011 at 9:31 PM, Alexey Shein  wrote: >>>> >>>> 2011/11/17 Ferenc Kovacs: >>>

Re: [PHP-DEV] PHP CLI webserver test failures

2011-11-16 Thread Alexey Shein
2011/11/17 Ferenc Kovacs : > > > On Wed, Nov 16, 2011 at 9:31 PM, Alexey Shein wrote: >> >> 2011/11/17 Ferenc Kovacs : >> > \o/ >> > You could also ask Alex Shein, he was "volunteered" to update the http >> > tests >> > to use

Re: [PHP-DEV] PHP CLI webserver test failures

2011-11-16 Thread Alexey Shein
2011/11/17 Ferenc Kovacs : > \o/ > You could also ask Alex Shein, he was "volunteered" to update the http tests > to use our new embedded developer server instead. > Hi, I'm still into that, but unfortunately is very busy at work :( server-tests.php is a big outdated mess, and I still want to writ

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-16 Thread Alexey Shein
2011/9/15 Hannes Magnusson : > On Wed, Sep 14, 2011 at 12:36, Alexey Shein wrote: >> 2011/9/14 Ferenc Kovacs : >>>> >>>> Why do we even have this tmp-php.ini? Why not just make test without >>>> any .ini files, i.e. just with -n option? >>>

Re: [PHP-DEV] [PATCH] Autoguessing TEST_PHP_EXECUTABLE if none is provided in run-tests.php

2011-09-16 Thread Alexey Shein
It seems last message didn't go to the list, resending 2011/9/12 Alexey Shein : > Created bug report here, included Christopher's suggestion into the patch: > https://bugs.php.net/bug.php?id=55672 Please, review the patch and tell me if there are any objections not to ta

Re: [PHP-DEV] Running mhash tests

2011-09-15 Thread Alexey Shein
It's very strange but after 5-6 recompiles with different configurations (I tried to reduce "breaking" setup) my current configuration started to work itself. Thanks everybody for help. 2011/9/15 Scott MacVicar : > > On 14 Sep 2011, at 13:46, Alexey Shein wrote: >

Re: [PHP-DEV] Running mhash tests

2011-09-14 Thread Alexey Shein
2011/9/15 Pierre Joye : > hi, > > On Wed, Sep 14, 2011 at 9:58 PM, Alexey Shein wrote: > >> Should we delete these tests (and, maybe deprecate/move to pecl the >> extension itself)? > > I don't think we should, they are here to make sure that the emulation &

[PHP-DEV] Running mhash tests

2011-09-14 Thread Alexey Shein
Hello, I tried to run skipped mhash tests in ext/hash, these ones in trunk: SKIP mhash() test [ext/hash/tests/mhash_001.phpt] reason: mhash extension is not available SKIP mhash_get_block_size() & mhash_get_hash_name() test [ext/hash/tests/mhash_002.phpt] reason: mhash extension is not available SK

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-14 Thread Alexey Shein
2011/9/14 Ferenc Kovacs : >> >> Why do we even have this tmp-php.ini? Why not just make test without >> any .ini files, i.e. just with -n option? > > [20:44:09] Tyrael: tmp-php.ini is built from the system ini > [20:44:45] Tyrael: if he builds php with > --with-config-file-scan-dir=/where/ever/he

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-14 Thread Alexey Shein
2011/9/13 Ferenc Kovacs : > On Tue, Sep 13, 2011 at 6:23 PM, Stas Malyshev wrote: >> Hi! >> >> On 9/13/11 7:49 AM, Ferenc Kovacs wrote: >>> >>> Stas, I still don't know why do have a custom php.ini, and why is it used. >>> The make test should create tmp-php.ini for you (and copy your >> >> Everyb

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-13 Thread Alexey Shein
Just wanted to say, that I managed to reproduce your results for ./PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt by adding date.timezone=UTC error_log=file settings into --INI-- section, this way test passes. I.e. logged message should go into the file and do not mess the output which is

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-12 Thread Alexey Shein
Hello, these tests fail for me too, ubuntu 11.04 x86, both trunk and 5.4 branches. 2011/9/12 Ferenc Kovacs : > On Sun, Sep 11, 2011 at 11:04 PM, Stas Malyshev > wrote: >> Hi! >> >> On 9/11/11 8:44 AM, Ferenc Kovacs wrote: >>> >>> AFAIK you shoud get it(as I did on my debian machines), as both >>

Re: [PHP-DEV] Using source code ...

2011-09-09 Thread Alexey Shein
Hello, Lester, I've managed to setup pdo_firebird, here's the process for the ubuntu if you're interested: 1) setup firebird superclassic: $ sudo apt-get install firebird2.5-superclassic firebird2.5-dev firebird2.5-examples superclassic is the server itself, dev package contains headers to compile

Re: [PHP-DEV] [PATCH] Autoguessing TEST_PHP_EXECUTABLE if none is provided in run-tests.php

2011-09-09 Thread Alexey Shein
2011/9/9 Christopher Jones : > > > On 09/08/2011 05:07 AM, Alexey Shein wrote: >> >> Hello! >> I've made some improvements to run-tests.php: >> 1) Autoguessing TEST_PHP_EXECUTABLE and TEST_PHP_CGI_EXECUTABLE if >> they're not provided, i.e. assume t

Re: [PHP-DEV] Running PDO tests ....

2011-09-09 Thread Alexey Shein
2011/9/9 Christopher Jones : > > > On 09/09/2011 10:02 AM, Lester Caine wrote: >> >> I'm not having much luck running the pdo_firebird tests ... >> >> I've got as far as building with >> ./configure --disable-all --with-interbase=/opt/fb25cs --enable-pdo >> --with-pdo-firebird=/opt/fb25cs --with-sq

Re: [PHP-DEV] Using source code ...

2011-09-09 Thread Alexey Shein
Hello, Lester, try to start from scratch by running ./vcsclean first, often it helps to solve all cache issues from previous builds. 2011/9/9 Lester Caine : > I probably need to roll back a bit further, but I already have the current > hg cone of php-src on the main repo here, so I've cloned a PHP

[PHP-DEV] [PATCH] Autoguessing TEST_PHP_EXECUTABLE if none is provided in run-tests.php

2011-09-08 Thread Alexey Shein
Hello! I've made some improvements to run-tests.php: 1) Autoguessing TEST_PHP_EXECUTABLE and TEST_PHP_CGI_EXECUTABLE if they're not provided, i.e. assume they have value 'auto'. You can still pass your own value as usual. 2) Added option -n (use no php.ini) to the shebang line (#!/usr/bin/php -n) s

Re: [PHP-DEV] ext/pcre/tests/006.phpt

2011-09-04 Thread Alexey Shein
It fails for me too, but only in PHP_5_3 branch, PHP_5_4 and trunk are ok. It seems it starts to fail after Rasmus's default backtrack limit increasion (as Tyrael pointed in his message), which was fixed for PHP_5_4 and trunk in this commit: http://svn.php.net/viewvc?view=revision&revision=312110.

Re: [PHP-DEV] New run-tests.php feature

2011-09-01 Thread Alexey Shein
2011/9/1 Ferenc Kovacs : > On Thu, Sep 1, 2011 at 1:35 PM, Hannes Magnusson wrote: >> Throw qa and internals@ into the loop to. >> >> I'd also like to move the XFAIL section (printed out in the end) above >> the FAIL section. >> We have bucketloads of xfailed tests, I actually have to scroll up to

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Alexey Shein
2011/8/24 Ferenc Kovacs : > 2011/8/24 Johannes Schlüter : >> On Wed, 2011-08-24 at 12:24 +0200, Ferenc Kovacs wrote: >>> we could have spotted this via two ways: >>> - those who participated in fixing >>> https://bugs.php.net/bug.php?id=53727 could have spotted this >>> - our tests should have star

Re: [PHP-DEV] Add \Countable support to \Closure

2011-08-08 Thread Alexey Shein
I think it's just a bad habit inherited from Javascript, where you can do like this: var a = function(a, b) { }; alert(a.length); // shows 2 I don't think that PHP needs it, explicit method is way better. 2011/8/8 Sebastian Bergmann : > On 08/08/2011 04:49 AM, Etienne Kneuss wrote: >> >> I don't

Re: [PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes

2011-07-12 Thread Alexey Shein
2011/7/12 Michael Wallner : > On Mon, 11 Jul 2011 22:33:31 +0100, Paul Dixon wrote: >> personally long term, I would aim to remove the position index entries >> completely. > > Which would make it unusable with list(). > +1 this will be huge BC break for this function. Please, don't remove positio

Re: [PHP-DEV] preg_match

2011-07-08 Thread Alexey Shein
2011/7/8 Rafael Dohms : > Still, this is preg_match it only returns one match, why should i get > a array and have to use ugly things like $matches[0] afterwards? > It just makes for very ugly syntax and extra code, a simple function > would make this cleaner and more intuitive, first time using >

Re: [PHP-DEV] [VOTE] voting rfc

2011-06-21 Thread Alexey Shein
separate pages for rfc and voting? > > On Tue, Jun 21, 2011 at 12:25 PM, Alexey Shein wrote: >> Hi! >> Wouldn't it be better if wiki voting mechanism would be embedded in >> the page with rfc? Under the block "Table of contents", for example. >> Just now

Re: [PHP-DEV] [VOTE] voting rfc

2011-06-21 Thread Alexey Shein
Hi! Wouldn't it be better if wiki voting mechanism would be embedded in the page with rfc? Under the block "Table of contents", for example. Just now green link "Votes are open" is not so noticeable, so having a chance to vote without leaving the page would better inspire people to take part in vot

Re: [PHP-DEV] [IDEA/PRE-RFC] PHP Core Mentorship Program

2011-06-12 Thread Alexey Shein
Really great idea. I'd like to be a part of it (as a newcomer of course :)) 2011/6/10 David Coallier : > Hey all, > > Let me start by saying that this is merely an idea I'm trying to put > together and before doing so, I need to see who would be interested. > > A short while ago, the Python commun

Re: [PHP-DEV] Callable type

2011-06-08 Thread Alexey Shein
2011/6/8 Hannes Magnusson : > We have the situation in the docs that parameters declared as arrays > do not follow the typehinting rules, but parameters as class names do. > Re-using the callback from the docs could get confusing when > extensions start to typehint on it, but not the core.. > > I t

Re: [PHP-DEV] Callable type

2011-06-07 Thread Alexey Shein
2011/6/8 David Zülke : > On 08.06.2011, at 00:38, dukeofgaming wrote: > >> On Tue, Jun 7, 2011 at 4:41 PM, Matthew Weier O'Phinney < >> weierophin...@php.net> wrote: >> >>> On 2011-06-07, dukeofgaming wrote: >>> +1 for "callable", it is really more consistent. >>> >>> I was actually agreeing

Re: [PHP-DEV] Voting does not belong on the wiki! (Was: [PHP-DEV] 5.4 moving forward)

2011-06-03 Thread Alexey Shein
2011/6/3 Derick Rethans : > On Thu, 2 Jun 2011, Stas Malyshev wrote: > >> I'd like to set up a vote for the undecided TODO features on >> wiki.php.net, anybody could help me with setting up the voting module >> there if there's such thing on the wiki? Or set me up with the access >> to wiki machine

Re: [PHP-DEV] Need karma for committing test patches

2011-05-30 Thread Alexey Shein
> Greetings Alexey, > > I'm unable to provide useful comments for this patch, but am CCing the > official ext/curl maintainer (Ilia) and you now have karma for committing > tests. > Thank you, Philip, for karma and for pushing that forward, I really appreciate that. -- Regards, Shein Alexey -

Fwd: [PHP-DEV] Need karma for committing test patches

2011-05-27 Thread Alexey Shein
le is incorrect in %s on line %d + +Warning: curl_multi_exec(): %d is not a valid stream resource in %s on line %d + +Warning: curl_multi_exec(): CURLOPT_INFILE handle is incorrect in %s on line %d +Ok for CURLOPT_INFILE Index: trunk/ext/curl/tests/curl_file_deleted_before_curl_close.phpt === --- trunk/ext/c

Re: [PHP-DEV] Need karma for committing test patches

2011-05-20 Thread Alexey Shein
So what do you think should be done here? Check closed streams and reset them to default as in my first try? -- Regards, Shein Alexey -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Need karma for committing test patches

2011-05-20 Thread Alexey Shein
>> * I think a better strategy would be to just dup the file descriptor gotten >> after the cast in curl_setopt, store it (instead of storing the zval) and >> close it on curl handle destruction. This way we wouldn't have to worry >> about zval refcounts or whether the file descriptor obtained is s

Re: [PHP-DEV] Need karma for committing test patches

2011-05-17 Thread Alexey Shein
> A few remarks: > > * Isn't this supposed to be fixed? Was there something that triggered a > regression? As far as I can see Jani checked only case when already closed file descriptor was passed to curl_setopt. Here's the check is performed in curl_exec, i.e. in curl_setopt file descriptor was v

Re: [PHP-DEV] Need karma for committing test patches

2011-05-17 Thread Alexey Shein
Created http://bugs.php.net/bug.php?id=54798. -- Regards, Shein Alexey -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Need karma for committing test patches

2011-05-17 Thread Alexey Shein
2011/5/17 Pierre Joye : > hi, > > On Tue, May 17, 2011 at 3:40 PM, Alexey Shein wrote: >> I need karma to commit test fixes: >> 1) session_encode_basic - added serialize_precision=100 ini setting > > Is it not fixed already? > As Tyrael already said this one w

[PHP-DEV] Need karma for committing test patches

2011-05-17 Thread Alexey Shein
I need karma to commit test fixes: 1) session_encode_basic - added serialize_precision=100 ini setting 2) fix for http://bugs.php.net/48203: there's a segfault when CURLOPT_STDERR file pointer is closed before calling curl_exec, i.e. like this: $fp = fopen(dirname(__FILE__) . '/bug48203.tmp', 'w'

Re: [PHP-DEV] 5.4 again

2011-05-16 Thread Alexey Shein
? File pointer is stored in zval as I can see (ch->handlers->std_err in /ext/curl/interface.c around line 1852) . 2011/5/13 Alexey Shein : > Hi, list. > > I've fixed some datetime tests in the trunk in answer to "Rasmus call > for devs" :) > There are two patch

Re: [PHP-DEV] 5.4 again

2011-05-13 Thread Alexey Shein
Hi, list. I've fixed some datetime tests in the trunk in answer to "Rasmus call for devs" :) There are two patches here. First patch is quite trivial - it fixes some relative/absolute path misconfiguration in phpt tests. Second patch fixes some timezone errors in bug51819 - some timezones like GB