It seems Rasmus already patched some date tests here:
http://svn.php.net/viewvc?view=revision&revision=311014
And my second patch (in previous letter) about bug 51819 is wrong,
will try to investigate it further.
More test fixes:
/trunk/ext/curl/tests/curl_setopt_basic001.phpt should probably be
deleted, since it checked curl behavior in safe_mode and there's no
safe_mode anymore in trunk.
/trunk/ext/date/tests/DateInterval_format_a.phpt needs timezone set
(see attached patch)
/trunk/ext/session/tests/session_encode_basic.phpt - needs precision
serialize to be set (see attached patch)
I need some help with another bug. I'm looking into curl bug
http://bugs.php.net/48203 (test /trunk/ext/curl/tests/bug48203.phpt).
The bug is when std_err file pointer given to curl is closed before
calling curl_exec then curl causes segfault. How I can check that file
is already closed? File pointer is stored in zval as I can see
(ch->handlers->std_err in /ext/curl/interface.c around line 1852) .
2011/5/13 Alexey Shein <con...@gmail.com>:
> Hi, list.
>
> I've fixed some datetime tests in the trunk in answer to "Rasmus call
> for devs" :)
> There are two patches here.
> First patch is quite trivial - it fixes some relative/absolute path
> misconfiguration in phpt tests.
> Second patch fixes some timezone errors in bug51819 - some timezones
> like GB were not parsed correctly. Tests are ok now but don't know if
> my solution is correct.
> Hope these patches would be useful.
>
> P.S. Please, note I'm very new to C and will be happy if someone can
> answer to some of my newbie questions and gently point my mistakes :)
>
> 2011/5/12 Rasmus Lerdorf <ras...@lerdorf.com>:
>> On 05/11/2011 02:10 PM, Philip Olson wrote:
>>
>>> So, that's the concern there. But if the alpha is simply a trick to
>>> convince people to test out a specific PHP 5.4 snapshot, and feel 5.4 is
>>> real, then do it. ;)
>>
>> There are still quite a few test failures in trunk. Some of them are also in
>> the 5_3 branch. In some cases the tests are simply bad. In a few the test
>> case contains binary data that got mangled in the move to Subversion. It
>> would be nice if just 1 in 10 people reading the list here would grab both
>> trunk and 5_3 and run "make test" in each tree and then fix at least 1 test
>> each. We would have no test failures by the end of the day other than a few
>> tricky ones. If an alpha release will encourage this, great. If we could get
>> people to just do it on their own without the alpha, even better.
>>
>> And yes, I know the tests take forever to run. Get yourself a fast machine
>> with an SSD, and remember you can run partial tests using:
>>
>> make test TESTS=ext/hash
>>
>> for example to just run the tests for the hash extension.
>>
>> Also, when a test fails, cd into the ext/hash/tests directory and you will
>> see .out, .exp, .diff and .php files for the failed test. That is, the
>> output, the expected output, the diff between them and the php script itself
>> extracted from the .phpt file containing the failed test case.
>>
>> And if you can't figure out how to fix a test, post the details here. I'd
>> love to point some of the obvious talents and energy of this list towards
>> the code. If you don't have an svn account for committing your fixed test,
>> go to http://www.php.net/svn-php.php and fill in the little form at the
>> bottom there and put in the test that you fixed and a 1-liner about how you
>> fixed it and I will set you up with an account right away. Info on how to
>> check out the code from svn is here:
>> https://wiki.php.net/vcs/svnfaq
>>
>> -Rasmus
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>
>
>
> --
> Regards,
> Shein Alexey
>
--
Regards,
Shein Alexey
Index: ext/date/tests/DateInterval_format_a.phpt
===================================================================
--- ext/date/tests/DateInterval_format_a.phpt (revision 311069)
+++ ext/date/tests/DateInterval_format_a.phpt (working copy)
@@ -9,6 +9,7 @@
Windows VC6 libs' floor()/ceil() choke on floats
--FILE--
<?php
+date_default_timezone_set('UTC');
$date1 = new DateTime('2000-01-01 00:00:00');
$date2 = new DateTime('2001-03-04 04:05:06');
Index: ext/session/tests/session_encode_basic.phpt
===================================================================
--- ext/session/tests/session_encode_basic.phpt (revision 311069)
+++ ext/session/tests/session_encode_basic.phpt (working copy)
@@ -1,5 +1,7 @@
--TEST--
Test session_encode() function : basic functionality
+--INI--
+serialize_precision=100
--SKIPIF--
<?php include('skipif.inc'); ?>
--FILE--
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
