On 2023/02/09 23:09, Matthew Weier O'Phinney wrote:
> I'm not directly involved in maintenance, but my take on the scenario was
> that these were rejected and reverted because they caused breakage
Your take is not quite correct.
No PR was rejected due to breakage.
There was exactly one (interna
On Thu, Feb 9, 2023 at 1:33 PM Max Kellermann wrote:
> On 2023/02/09 19:04, Tim Düsterhus wrote:
> > However based on the discussion of the RFC I believe that voters may have
> > assumed that a "No" means "A cleanup is not allowed", because several
> > participants expressed an active aversion t
Hi,
On Thu, Feb 9, 2023 at 10:19 AM Max Kellermann wrote:
> Hi,
>
> what happens if there is a bug in a vendored library, but upstream
> refuses to fix it?
>
> Last month, my PR for removing obsolete C99 integer checks was merged:
>
> https://github.com/php/php-src/pull/10304
>
> This change sp
On 2023/02/09 19:04, Tim Düsterhus wrote:
> However based on the discussion of the RFC I believe that voters may have
> assumed that a "No" means "A cleanup is not allowed", because several
> participants expressed an active aversion to a cleanup during the
> discussion. As for myself I've certain
Hi
On 2/1/23 13:13, Max Kellermann wrote:
On 2023/01/30 11:26, Max Kellermann wrote:
If nobody objects, I'll announce the start of voting on February 1st.
That's today.
Voting starts now, please vote on my RFC:
https://wiki.php.net/rfc/include_cleanup
Original discussion: https://news-we
On Thu, 9 Feb 2023 at 16:05, Max Kellermann wrote:
> > OK, that seems clear. As far as I can see, this is the first time on this
> > thread or either of the PR threads that you've actually explained that
> > violation.
>
> I explained it already:
>
> https://github.com/derickr/timelib/pull/141#i
On Thu, 9 Feb 2023 at 16:18, Sergii Shymko wrote:
>
> IMO, other variations of array_column() returning a map don't seem to be
> useful in practice.
> Particularly, what is knowing the case name good for? Do you propose to
> resolve it to the case instance like so?
> $case = constant(ExampleEnum:
Hi
On 2/9/23 17:18, Sergii Shymko wrote:
BackedEnum::values() is much more convenient than
array_column(BackedEnum::cases(), 'value');
I suspect the answer is "preference", but I have to ask: Why?
Personally looking at that I find it more convenient to use an existing
function that I can ap
From: Rowan Tommins
Sent: Thursday, February 9, 2023 12:56 AM
To: internals@lists.php.net
Subject: Re: [PHP-DEV] RFC proposal: values getter in BackedEnum
On Thu, 9 Feb 2023 at 01:30, Sergii Shymko wrote:
> I'd like to propose an improvement to backed enumera
Hi Max,
On Thu, 9 Feb 2023 at 16:05, Max Kellermann wrote:
> - Jan 19 7:49 PM: commit
> https://github.com/php/php-src/commit/0df92d218e88a0 pushed to
> php-src
>
> Look how the commit is exactly a revert of the timelib PR that Derick
> Rethans closed and locked just the day before.
>
Ahh
On 2023/02/09 16:29, Rowan Tommins wrote:
> This is where I'm suggesting you assume good faith: what looks like a
> "secret revert" probably feels like something entirely different to Derick.
Timeline:
- Jan 13 11:34 AM: PR https://github.com/derickr/timelib/pull/141/files
- Jan 18 4:34 PM: PR
On Thu, 9 Feb 2023 at 13:14, Max Kellermann wrote:
> The issue still exists, and I'm here
> for your advice on how to resolve this. I'm desperate.
>
Is this a critical security issue? If not, there's no need to be desperate;
just take a breath, explain what you were trying to achieve, and be
g
On 2023/02/09 14:49, Michael Voříšek - ČVUT FJFI wrote:
> One good way to maintain some quality standard is to enforce it thru CI
Agree, the CI is a nice tool for enforcing certain policies, but first
there needs to be a decision on what is the desired quality standard.
Finding such a decision i
One good way to maintain some quality standard is to enforce it thru CI
:)
This also applies to https://github.com/php/php-src/pull/10549/files and
https://github.com/php/php-src/pull/10531/files for example, such
problems should fail the CI and enforce the contributors to fix the code
before t
On 2023/02/09 13:37, Rowan Tommins wrote:
> Firstly, let's try to keep this discussion civil, and assume good faith on
> both sides. Parts of your e-mail read like accusations of bad behaviour,
> rather than genuinely trying to understand what happened, and how we can
> collectively avoid it happe
Hi,
On Thu, 9 Feb 2023 at 12:38, Rowan Tommins wrote:
> On Thu, 9 Feb 2023 at 10:19, Max Kellermann wrote:
>
> > Hi,
> >
>
>
> Firstly, let's try to keep this discussion civil, and assume good faith on
> both sides.
>
>
> That a kind of constant with you, Max, through your PR too.
If you could
On Thu, 9 Feb 2023 at 10:19, Max Kellermann wrote:
> Hi,
>
> what happens if there is a bug in a vendored library, but upstream
> refuses to fix it?
>
I don't have an answer to the procedural question, or the specific
technical issue, but I would like to say three things:
Firstly, let's try to
Hi,
what happens if there is a bug in a vendored library, but upstream
refuses to fix it?
Last month, my PR for removing obsolete C99 integer checks was merged:
https://github.com/php/php-src/pull/10304
This change speeds up configure and removes code that violates the C99
spec.
It included a
On Thu, 9 Feb 2023 at 01:30, Sergii Shymko wrote:
> I'd like to propose an improvement to backed enumerations introduced in
> PHP 8.1.
> When using enums, it's very common to get all values using the following
> boilerplate:
> $enumValues = array_map(
> fn (\BackedEnum $case) => $case->value,
19 matches
Mail list logo
