On Thu, 9 Feb 2023 at 10:19, Max Kellermann <max+...@blarg.de> wrote:
> Hi, > > what happens if there is a bug in a vendored library, but upstream > refuses to fix it? > I don't have an answer to the procedural question, or the specific technical issue, but I would like to say three things: Firstly, let's try to keep this discussion civil, and assume good faith on both sides. Parts of your e-mail read like accusations of bad behaviour, rather than genuinely trying to understand what happened, and how we can collectively avoid it happening in future. Secondly, note that Derick Rethans is the maintainer of both timelib and the ext/date extension in php-src. So while we can discuss the hypothetical question of how to handle a disagreement between php-src and upstream library maintainers, it wouldn't apply in this case anyway, because it would require Derick to disagree with himself. Thirdly, it's not clear to me which of the following statements is true of this change, and it might help the conversation to clarify more precisely: a) The code you removed *violates* the C99 spec? b) The code you removed is *guaranteed to be pointless* under the C99 spec (but does not violate it)? c) The code you removed is *pointless in this particular case* because of a combination of the C99 spec and other factors (but might be reasonable in other circumstances)? Regards, -- Rowan Tommins [IMSoP]
