Hi Max, On Thu, 9 Feb 2023 at 16:05, Max Kellermann <max+...@blarg.de> wrote:
> - Jan 19 7:49 PM: commit > https://github.com/php/php-src/commit/0df92d218e88a0 pushed to > php-src > > Look how the commit is exactly a revert of the timelib PR that Derick > Rethans closed and locked just the day before. > Ahh so it seems to be a big misunderstanding. Derrick didn't undo your commit. Derrick simply synched timelib. The file in the commit belongs to timelib not PHP. Derrick is the author and the maintainer of that library. As the author, he decides on what is merged into timelib. You submitted a PR that was declined. No big deal. But the file should not be modified in PHP because PHP has a readonly copy of that library. It will be overwritten whenever Derrick syncs it up. I'm not sure what impact this has on PHP, but as long as it compiles fine and there are no bugs, I see no reason to pressure the maintainer of timelib library to change their code. If it meant that the current release of timelib suddenly becomes inoperable with PHP then we would have an issue. Regards, Kamil
