Re: [PHP-DEV] Deprecate or remove mbstring function overloads in PHP 7

2015-03-24 Thread Pierre Joye
On Wed, Mar 25, 2015 at 9:47 AM, Masaki Kagaya wrote: > Rui agreed the deprecation and Yasuo gave notice to PHP internal in April > 2012. > > https://bugs.php.net/bug.php?id=65785 > http://marc.info/?l=php-internals&m=133548185505478&w=2 Deprecation is fine and I am sure we will have more until w

Re: [PHP-DEV] Deprecate or remove mbstring function overloads in PHP 7

2015-03-24 Thread Masaki Kagaya
Rui agreed the deprecation and Yasuo gave notice to PHP internal in April 2012. https://bugs.php.net/bug.php?id=65785 http://marc.info/?l=php-internals&m=133548185505478&w=2 2015-03-25 0:25 GMT+09:00 Zeev Suraski : > > -Original Message- > > From: Nikita Popov [mailto:nikita@gmail.c

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Dmitry Stogov
These opcodes hardly ever would throw exceptions their selves. This real problem should be fixed in HANDLE_EXCEPTION handler. There we will need to get the list of "active" temporary variables. I don't have a good solution for this yet. Thanks. Dmitry. On Tue, Mar 24, 2015 at 10:45 PM, Nikita Po

Re: [PHP-DEV] Deprecate or remove mbstring function overloads in PHP 7

2015-03-24 Thread Levi Morrison
On Tue, Mar 24, 2015 at 11:30 AM, Rowan Collins wrote: > François Laupretre wrote on 24/03/2015 16:30: >>> >>> De : Bob Weinand [mailto:bobw...@hotmail.com] >>> >>> No, he isn't asking for delaying the timeline. He's asking if we can do >>> this >>> without RFC. Minimal self-contained changes don'

Re: [PHP-DEV] [VOTE] Reclassify E_STRICT notices

2015-03-24 Thread Pascal MARTIN
Le 15/03/2015 16:46, Nikita Popov a écrit : https://wiki.php.net/rfc/reclassify_e_strict#vote Voting is open for ten days :) Hi, We talked about this RFC with other people at AFUP, and it seems we are on the +1 side. Basically, with "strict" warnings, one might wonder whether or not his cod

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Nikita Popov
On Tue, Mar 24, 2015 at 1:08 PM, Dmitry Stogov wrote: > > > On Tue, Mar 24, 2015 at 2:51 PM, Nikita Popov > wrote: > >> On Tue, Mar 24, 2015 at 10:28 AM, Dmitry Stogov wrote: >> >>> I thought about something like this :) >>> In my opinion UString is really not a proper way to implement Unicoide

Re: [PHP-DEV] Deprecate or remove mbstring function overloads in PHP 7

2015-03-24 Thread Rowan Collins
François Laupretre wrote on 24/03/2015 16:30: De : Bob Weinand [mailto:bobw...@hotmail.com] No, he isn't asking for delaying the timeline. He's asking if we can do this without RFC. Minimal self-contained changes don't need a RFC and can go as well into alpha/beta phase without issues. Sorry, I

RE: [PHP-DEV] Deprecate or remove mbstring function overloads in PHP 7

2015-03-24 Thread François Laupretre
> De : Bob Weinand [mailto:bobw...@hotmail.com] > > No, he isn't asking for delaying the timeline. He's asking if we can do this > without RFC. Minimal self-contained changes don't need a RFC and can go as > well into alpha/beta phase without issues. Sorry, I don't understand when a change is supp

RE: [PHP-DEV] Deprecate or remove mbstring function overloads in PHP 7

2015-03-24 Thread Zeev Suraski
> -Original Message- > From: Nikita Popov [mailto:nikita@gmail.com] > Sent: Tuesday, March 24, 2015 4:45 AM > To: PHP internals > Subject: [PHP-DEV] Deprecate or remove mbstring function overloads in PHP > 7 > > Hi internals! > > The mbstring extension supports replacing PHP string func

Re: [PHP-DEV] Deprecate or remove mbstring function overloads in PHP 7

2015-03-24 Thread Bob Weinand
> Am 24.03.2015 um 14:39 schrieb François Laupretre : > >> De : Nikita Popov [mailto:nikita@gmail.com] >> >> The mbstring extension supports replacing PHP string functions with >> multibyte variants through the mbstring.func_overload ini option. >> >> This ini setting is a real PITA for code

Re: [PHP-DEV] Deprecate or remove mbstring function overloads in PHP 7

2015-03-24 Thread Kalle Sommer Nielsen
Hi 2015-03-24 14:39 GMT+01:00 François Laupretre : > Probably fine, but how does your suggestion fit in the PHP 7 timeline ? The > BC break requires it is introduced in 7.0. And it is too late for this. As > everyone seems to be against delaying the timeline, I hope we won't accept > exceptions

RE: [PHP-DEV] Deprecate or remove mbstring function overloads in PHP 7

2015-03-24 Thread François Laupretre
> De : Nikita Popov [mailto:nikita@gmail.com] > > The mbstring extension supports replacing PHP string functions with > multibyte variants through the mbstring.func_overload ini option. > > This ini setting is a real PITA for code compatibility, as it makes it > impossible to rely on the outpu

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Dmitry Stogov
On Tue, Mar 24, 2015 at 2:51 PM, Nikita Popov wrote: > On Tue, Mar 24, 2015 at 10:28 AM, Dmitry Stogov wrote: > >> I thought about something like this :) >> In my opinion UString is really not a proper way to implement Unicoide, >> but I agree not break anything in current stage. >> Anyway, plea

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Xinchen Hui
Hey: On Tue, Mar 24, 2015 at 7:51 PM, Nikita Popov wrote: > On Tue, Mar 24, 2015 at 10:28 AM, Dmitry Stogov wrote: >> >> I thought about something like this :) >> In my opinion UString is really not a proper way to implement Unicoide, >> but I agree not break anything in current stage. >> Anyway

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Nikita Popov
On Tue, Mar 24, 2015 at 10:28 AM, Dmitry Stogov wrote: > I thought about something like this :) > In my opinion UString is really not a proper way to implement Unicoide, > but I agree not break anything in current stage. > Anyway, please review the first PR (in my opinion it is safe to commit), >

[PHP-DEV] Deprecate or remove mbstring function overloads in PHP 7

2015-03-24 Thread Nikita Popov
Hi internals! The mbstring extension supports replacing PHP string functions with multibyte variants through the mbstring.func_overload ini option. This ini setting is a real PITA for code compatibility, as it makes it impossible to rely on the output of even the most basic PHP functions, like st

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Xinchen Hui
Hey: On Tue, Mar 24, 2015 at 5:28 PM, Xinchen Hui wrote: > Hey > > Sent from my iPhone > > On Mar 24, 2015, at 5:11 PM, Nikita Popov wrote: > > On Mon, Mar 23, 2015 at 11:41 PM, Dmitry Stogov wrote: >> >> Hi, >> >> Recently, Xinchen and me worked on optimization that eliminates useless >> reall

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Xinchen Hui
Hey Sent from my iPhone > On Mar 24, 2015, at 5:11 PM, Nikita Popov wrote: > >> On Mon, Mar 23, 2015 at 11:41 PM, Dmitry Stogov wrote: >> Hi, >> >> Recently, Xinchen and me worked on optimization that eliminates useless >> reallocations and copying during string concatenation (ZEND_ADD_STRIN

Re: [PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Pierre Joye
On Mar 24, 2015 4:11 PM, "Nikita Popov" wrote: > > On Mon, Mar 23, 2015 at 11:41 PM, Dmitry Stogov wrote: > > > Hi, > > > > Recently, Xinchen and me worked on optimization that eliminates useless > > reallocations and copying during string concatenation (ZEND_ADD_STRING and > > family + ZEND_CONC

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Dmitry Stogov
I thought about something like this :) In my opinion UString is really not a proper way to implement Unicoide, but I agree not break anything in current stage. Anyway, please review the first PR (in my opinion it is safe to commit), but you may find some other issues. Thanks. Dmitry. On Tue, Ma

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Nikita Popov
On Mon, Mar 23, 2015 at 11:41 PM, Dmitry Stogov wrote: > Hi, > > Recently, Xinchen and me worked on optimization that eliminates useless > reallocations and copying during string concatenation (ZEND_ADD_STRING and > family + ZEND_CONCAT). > > The idea comes from ropes, but adopted especially for

Re: [PHP-DEV] Use "ropes" for string concatenation

2015-03-24 Thread Pierre Joye
On Tue, Mar 24, 2015 at 1:14 PM, Xinchen Hui wrote: > Hey: > > On Tue, Mar 24, 2015 at 2:04 PM, Pierre Joye wrote: >> On Tue, Mar 24, 2015 at 1:01 PM, Xinchen Hui wrote: >>> Hey: >>> >>> On Tue, Mar 24, 2015 at 1:54 PM, Pierre Joye wrote: On Tue, Mar 24, 2015 at 12:35 PM, Xinchen Hui wrot

Re: [PHP-DEV] Use "ropes" for string concatenation

2015-03-24 Thread Rasmus Lerdorf
On 03/23/2015 11:14 PM, Xinchen Hui wrote: >>> from user land. this won't change anything.. >> >> Nothing to do with userland or not but code stabilization > In that case, yeah. you might be right. > > but from my opinion, simpler always means easier for maintaining > > anyway, I hope this