On Tue, Mar 24, 2015 at 10:28 AM, Dmitry Stogov <dmi...@zend.com> wrote:
> I thought about something like this :) > In my opinion UString is really not a proper way to implement Unicoide, > but I agree not break anything in current stage. > Anyway, please review the first PR (in my opinion it is safe to commit), > but you may find some other issues. > > Thanks. Dmitry. > First PR looks okay to me. One question: Why the separate INIT and ADD opcodes? They seem pretty much the same, just one using a hardcoded 0 instead of ex_val. Regarding exception-safety - is the problem that doing an EG(exception) check and releasing the rope is too expensive? Nikita
