Re: [PHP-DEV] Bug 55700 fix

2014-09-01 Thread Lior Kaplan
On Sep 2, 2014 8:55 AM, "Michael Wallner" wrote: > > On 2 Sep 2014 00:13, "Chris Wright" wrote: > > > > If no-one has any objections to this, I would like to merge it into > > 5.6 and master. > > > > +1 Why not 5.5 ? Kaplan

Re: [PHP-DEV] Bug 55700 fix

2014-09-01 Thread Michael Wallner
On 2 Sep 2014 00:13, "Chris Wright" wrote: > > Good evening all > > I've put together a patch for bug 55600 which can be seen here: > https://github.com/php/php-src/pull/779 > > The patch has been updated based on various feedback and afaict is now > ready to be merged. Does anyone have any more f

Re: [PHP-DEV] Bug 67855 fix

2014-09-01 Thread Michael Wallner
On 2 Sep 2014 00:19, "Chris Wright" wrote: > > Good evening all > > I've put together a patch for bug 67855 which can be seen here: > https://github.com/php/php-src/pull/778 > > The patch has so far received no feedback - does anyone have any? > > If no-one has any objections to this, I would like

[PHP-DEV] Bug 67855 fix

2014-09-01 Thread Chris Wright
Good evening all I've put together a patch for bug 67855 which can be seen here: https://github.com/php/php-src/pull/778 The patch has so far received no feedback - does anyone have any? If no-one has any objections to this, I would like to merge it into master. This patch has a very minor BC br

[PHP-DEV] Bug 55700 fix

2014-09-01 Thread Chris Wright
Good evening all I've put together a patch for bug 55600 which can be seen here: https://github.com/php/php-src/pull/779 The patch has been updated based on various feedback and afaict is now ready to be merged. Does anyone have any more feedback on the implementation? If no-one has any objectio

[PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

2014-09-01 Thread Stas Malyshev
Hi! > I was wondering about that myself (back when it was changed last, March > 2013) when a few members were removed from that structure, so I figured it > was OK to put one back. :-) No problem with binary compatibility then...? > > http://git.php.net/?p=php-src.git;a=commitdiff;h=b903d2d6cd

[PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

2014-09-01 Thread Matt Wilmas
Hi Stas, - Original Message - From: "Stas Malyshev" Sent: Monday, September 01, 2014 Hi! I'm also not sure how important it is how have it for 5.4. Does the problem that this patch fixes exist only in older versions of Windows or on all versions? What are the actual effects of this pr

[PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

2014-09-01 Thread Matt Wilmas
Hi Stas, - Original Message - From: "Stas Malyshev" Sent: Monday, September 01, 2014 Hi! It's much more optimized than what's there now, and slightly over the old implementation. Not sure if I should give the saved patch link, or the "live compare" (?) on Github, so I'll do both for

[PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

2014-09-01 Thread Stas Malyshev
Hi! > I'm also not sure how important it is how have it for 5.4. Does the > problem that this patch fixes exist only in older versions of Windows or > on all versions? What are the actual effects of this problem - is it > just lower resolution of microtime or there can be something seriously > wro

[PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

2014-09-01 Thread Stas Malyshev
Hi! > It's much more optimized than what's there now, and slightly over the old > implementation. Not sure if I should give the saved patch link, or the > "live compare" (?) on Github, so I'll do both for now: > http://realplain.com/php/microtime_5_4.diff > https://github.com/matt-moo/php-src/c

Re: [PHP-DEV] 5.4 non-security issues - last call

2014-09-01 Thread Stas Malyshev
Hi! > I have one fix for imagecrop, should be applied by tomorrow. OK, go ahead and commit it, I'll wait until it's in. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.ne

Re: [PHP-DEV] 5.4 non-security issues - last call

2014-09-01 Thread Pierre Joye
Hi Stas, I have one fix for imagecrop, should be applied by tomorrow. Cheers. Pierre On Aug 28, 2014 11:13 PM, "Stas Malyshev" wrote: > Hi! > > 5.6.0 has been released, and first thing I'd like to congratulate all > who participated in it with this great milestone. > > Second thing, that means

Re: [PHP-DEV] 5.4 non-security issues - last call

2014-09-01 Thread Matt Wilmas
Hi Stas! - Original Message - From: "Matt Wilmas" Sent: Friday, August 29 Hi Stas, all! - Original Message - From: "Stas Malyshev" Sent: Thursday, August 28, 2014 Hi! 5.6.0 has been released, and first thing I'd like to congratulate all who participated in it with this great

[PHP-DEV] [PATCH] Microsecond resolution and accuracy on Windows

2014-09-01 Thread Matt Wilmas
Hi all! I'm back after several years, and will have a few more changes for Windows, at least. (It was CVS back then, so I still have to figure some things out... Just had to edit files on Github site. :-/) Anyway, this patch is for microtime, etc. on Windows XP-7. In March 2013, the fix f

Re: [PHP-DEV] Make zend_parse_parameters emit E_RECOVERABLE_ERROR

2014-09-01 Thread Andrea Faulds
On 1 Sep 2014, at 17:29, Chris Wright wrote: > It's also worth noting that the "return NULL on zpp failure" > convention is not followed to the letter, I have seen places that > RETURN_FALSE - I can't remember exactly where I have seen this but I > will dig a ref out if anyone wants it. Good po

Re: [PHP-DEV] Re: 64 bit string offsets

2014-09-01 Thread Anatol Belski
Hi Dmitry, On Mon, September 1, 2014 16:17, Dmitry Stogov wrote: > Hi Anatol, > > > what do you mean? heap allocated structure? I think, it's not a good > option :( > > I didn't have time to think about this yet. > I thought about creating an extended zend_string struct with an appended offset mem

Re: [PHP-DEV] Make zend_parse_parameters emit E_RECOVERABLE_ERROR

2014-09-01 Thread Chris Wright
On 1 September 2014 17:18, Andrea Faulds wrote: > > On 1 Sep 2014, at 04:56, Xinchen Hui wrote: > >> On Mon, Sep 1, 2014 at 6:01 AM, Andrea Faulds wrote: >>> Good evening, >>> >>> Here’s a suggestion: Why don’t we make zend_parse_parameters emit >> >> ""Why not" is usually not a very good reason

Re: [PHP-DEV] Make zend_parse_parameters emit E_RECOVERABLE_ERROR

2014-09-01 Thread Andrea Faulds
On 1 Sep 2014, at 04:56, Xinchen Hui wrote: > On Mon, Sep 1, 2014 at 6:01 AM, Andrea Faulds wrote: >> Good evening, >> >> Here’s a suggestion: Why don’t we make zend_parse_parameters emit > > ""Why not" is usually not a very good reason for a change in the language > syntax. " — Stas The rea

Re: [PHP-DEV] Some good analysis using PVS

2014-09-01 Thread Arvids Godjuks
2014-09-01 17:12 GMT+03:00 Lester Caine : > On 01/09/14 13:44, Pierre Joye wrote: > > A quick ping about some anaylise done by the PVS team: > > > > http://www.viva64.com/en/b/0277/ > > > > The ones listed are all valid so far. We will fix some of them in the > > next days but feel free to go ahea

Re: [PHP-DEV] Re: 64 bit string offsets

2014-09-01 Thread Dmitry Stogov
Hi Anatol, what do you mean? heap allocated structure? I think, it's not a good option :( I didn't have time to think about this yet. Thanks. Dmitry. On Mon, Sep 1, 2014 at 5:37 PM, Anatol Belski wrote: > On Sun, August 31, 2014 22:31, Anatol Belski wrote: > > Hi Pierre, > > > > > > On Sun,

Re: [PHP-DEV] Some good analysis using PVS

2014-09-01 Thread Lester Caine
On 01/09/14 13:44, Pierre Joye wrote: > A quick ping about some anaylise done by the PVS team: > > http://www.viva64.com/en/b/0277/ > > The ones listed are all valid so far. We will fix some of them in the > next days but feel free to go ahead, FIFC :) It's pleasing to see that there is nothing

Re: [PHP-DEV] Re: 64 bit string offsets

2014-09-01 Thread Anatol Belski
On Sun, August 31, 2014 22:31, Anatol Belski wrote: > Hi Pierre, > > > On Sun, August 31, 2014 14:12, Pierre Joye wrote: > >> Hi Anatol, >> >> >> >> Thanks! >> >> >> >> For what I see it should have no impact, either mem usage or perf but >> when such offset is used, in 64bit. >> >> However some nu

[PHP-DEV] Some good analysis using PVS

2014-09-01 Thread Pierre Joye
hi A quick ping about some anaylise done by the PVS team: http://www.viva64.com/en/b/0277/ The ones listed are all valid so far. We will fix some of them in the next days but feel free to go ahead, FIFC :) Cheers. -- Pierre @pierrejoye | http://www.libgd.org -- PHP Internals - PHP Runtime D

Re: [PHP-DEV] Making parse_ini_*() aware of types

2014-09-01 Thread Paul Dragoonis
Seems like a no brainer and since its gone through voting then you could go ahead with it. On 30 Aug 2014 15:37, "Tjerk Meesters" wrote: > Hi internals, > > I was going through the bug list and found this report: > > https://bugs.php.net/bug.php?id=38409 > > It discusses the fact that `parse_ini_

Re: [PHP-DEV] Making parse_ini_*() aware of types

2014-09-01 Thread Julien Pauli
On Sat, Aug 30, 2014 at 4:36 PM, Tjerk Meesters wrote: > Hi internals, > > I was going through the bug list and found this report: > > https://bugs.php.net/bug.php?id=38409 > > It discusses the fact that `parse_ini_file()` and `parse_ini_string()` throw > away type information; for instance, the