Hi! > It's much more optimized than what's there now, and slightly over the old > implementation. Not sure if I should give the saved patch link, or the > "live compare" (?) on Github, so I'll do both for now: > http://realplain.com/php/microtime_5_4.diff > https://github.com/matt-moo/php-src/compare/PHP-5.4.diff > > Against 5.4 since that's what I quickly worked on so it's ready for the next > 5.4 release (Stas?). (Although I guess we're supposed to change the oldest > branch usually?)
Looking at the patch, it looks like unfortunately it changes a global structure (_php_win32_core_globals) which breaks binary compatibility. I think if you move the additional value to the end of the structure it should be ok though, since other offsets should not change then. I'm also not sure how important it is how have it for 5.4. Does the problem that this patch fixes exist only in older versions of Windows or on all versions? What are the actual effects of this problem - is it just lower resolution of microtime or there can be something seriously wrong with the whole result? If it's just lower resolution, I'd prefer this to go into 5.5 as the change is pretty extensive. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
