Re: [PHP-DEV] master is broken on Travis

2014-08-20 Thread Lior Kaplan
On Thu, Aug 21, 2014 at 12:29 AM, Stas Malyshev wrote: > Hi! > > > Removed phpdbg build from configure, and master builds fine. > > > > Removed its tests as well to have travis finish green. > > Did you commit it? I see Travis CI build is still broken. > Committed and it works, the build done at

Re: [PHP-DEV] ext/standard/tests/http/bug60570.phpt failure

2014-08-20 Thread Dmitry Stogov
done. Dmitry. On Thu, Aug 21, 2014 at 12:50 AM, Stas Malyshev wrote: > Hi! > > > array of registered resources of particular type. See patch: > > > > https://gist.github.com/dstogov/f96c04f5979e726909ab > > It would be better as a pull, it's be easier to comment on it. > For the function get_r

Re: [PHP-DEV] master is broken on Travis

2014-08-20 Thread Stas Malyshev
Hi! > Removed phpdbg build from configure, and master builds fine. > > Removed its tests as well to have travis finish green. Did you commit it? I see Travis CI build is still broken. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ -- PHP Internals - PHP Runtime D

Re: [PHP-DEV] ext/standard/tests/http/bug60570.phpt failure

2014-08-20 Thread Stas Malyshev
Hi! > array of registered resources of particular type. See patch: > > https://gist.github.com/dstogov/f96c04f5979e726909ab It would be better as a pull, it's be easier to comment on it. For the function get_resources, the proto says it has no arguments, but it actually has one S argument that i

Re: [PHP-DEV] 5.4 security only

2014-08-20 Thread Stas Malyshev
Hi! > Apparently the fix for #67724 [2] caused #67865 [1], but I already have > a fix for the fix (oh my) [3]. I've reverted it from 5.4.32, but please commit this fix in 5.4. As phar is currently broken, fix for this qualifies as important. -- Stanislav Malyshev, Software Architect SugarCRM: h

Re: [PHP-DEV] Improved logarithm of base 2|10 of standard math function

2014-08-20 Thread Marc Bennewitz
On 19.08.2014 00:41, Stas Malyshev wrote: > Hi! > >> I opted for master-only on the grounds that while it's an improvement, >> it's not really a bugfix, and released versions (or versions as near >> to release as 5.6 is) should be bug-fix only. I know there's an >> argument for this *being* a b

Re: [PHP-DEV] [RFC] Binary String Comparison

2014-08-20 Thread Andrea Faulds
On 20 Aug 2014, at 19:36, Marc Bennewitz wrote: > > On 20.08.2014 19:50, Ferenc Kovacs wrote: >> >> Maybe it was already mentionex, but just to make sure: this would fix >> issues like https://bugs.php.net/bug.php?id=54547 >> > Yes, such comparison issues will go away! It would, however, in

Re: [PHP-DEV] [VOTE][RFC] Closure::apply() (re-opening)

2014-08-20 Thread Levi Morrison
On Wed, Aug 20, 2014 at 11:51 AM, Nathan wrote: > The only thing I'd suggest is like I said in the last email is to make the > syntax more like Closure::bind(Closure $closure, object $newThis, [mixed > $newScope = 'static']) and make it Closure::apply(mixed $newObjectOrScope > [, mixed ... $parame

Re: [PHP-DEV] ext/standard/tests/http/bug60570.phpt failure

2014-08-20 Thread Markus Fischer
Hello Dmitry, On 20.08.2014 12:08, Dmitry Stogov wrote: > To have a robust way to detect resource leaks I propose a new > function - > get_resources() that returns an array of all registered resources or > an > array of registered resources of particular type. See patch: > > https://gist.github.co

Re: [PHP-DEV] [RFC] Binary String Comparison

2014-08-20 Thread Marc Bennewitz
On 20.08.2014 19:50, Ferenc Kovacs wrote: > > 2014.08.17. 21:59 ezt írta ("Marc Bennewitz" ): >> >> Hi internals! >> >> I've created a draft RFC and patch to change the behavior of > non-strict string to string comparison to be binary safe (as the strict > comparison operator does): >> >> ht

Re: [PHP-DEV] 5.4 security only

2014-08-20 Thread Michael Wallner
On 19/08/14 01:59, Stas Malyshev wrote: > > - EFFECTIVE IMMEDIATELY, we do not accept new non-security bugfixes into > 5.4 branch unless they are very important ones (and that is only because > people may, in theory, have pending patches and we didn't give advance > notice). Importance would have t

Re: [PHP-DEV] [VOTE][RFC] Closure::apply() (re-opening)

2014-08-20 Thread Nathan
The only thing I'd suggest is like I said in the last email is to make the syntax more like Closure::bind(Closure $closure, object $newThis, [mixed $newScope = 'static']) and make it Closure::apply(mixed $newObjectOrScope [, mixed ... $parameters]) $newObjectOrScope would then allow a user to suppl

Re: [PHP-DEV] [RFC] Binary String Comparison

2014-08-20 Thread Marc Bennewitz
On 20.08.2014 12:46, Michael Wallner wrote: > On 20/08/14 11:12, Marc Bennewitz wrote:> >> >> On 18.08.2014 17:43, Johannes Schlüter wrote: >>> On Mon, 2014-08-18 at 17:30 +0200, Johannes Schlüter wrote: foreach ($db->query("SELECT id, title FROM entries") as $row) { echo ">>

Re: [PHP-DEV] [VOTE] Abstract Syntax Tree

2014-08-20 Thread Levi Morrison
On Wed, Aug 20, 2014 at 7:30 AM, Paul Dragoonis wrote: > On Tue, Aug 19, 2014 at 3:32 AM, Andi Gutmans wrote: > >> Hi Nikita, >> >> I reviewed the AST RFC on my way to vote but there was something that >> wasn’t clear to me. >> This patch introduces some semantic/behavioral changes in addition to

Re: [PHP-DEV] [VOTE] Abstract Syntax Tree

2014-08-20 Thread Paul Dragoonis
On Wed, Aug 20, 2014 at 2:57 PM, Nikita Popov wrote: > On Wed, Aug 20, 2014 at 3:30 PM, Paul Dragoonis > wrote: > >> Hi Nikita, >> >> I second some of Andi's concerns about behavioural changes, some things >> working from right-to-left and not left-to-right. Are these things that we >> can adapt

Re: [PHP-DEV] [VOTE] Abstract Syntax Tree

2014-08-20 Thread Nikita Popov
On Wed, Aug 20, 2014 at 3:30 PM, Paul Dragoonis wrote: > Hi Nikita, > > I second some of Andi's concerns about behavioural changes, some things > working from right-to-left and not left-to-right. Are these things that we > can adapt the AST part or tweak another part to make this more consistent

Re: [PHP-DEV] [VOTE] Abstract Syntax Tree

2014-08-20 Thread Paul Dragoonis
On Tue, Aug 19, 2014 at 3:32 AM, Andi Gutmans wrote: > Hi Nikita, > > I reviewed the AST RFC on my way to vote but there was something that > wasn’t clear to me. > This patch introduces some semantic/behavioral changes in addition to the > AST. > Are these as a side-effect of how AST was implemen

[PHP-DEV] [VOTE][RFC] Closure::apply() (re-opening)

2014-08-20 Thread Andrea Faulds
Good afternoon, I’m putting this RFC to a vote again as I haven’t heard any objections in the past three days, and in the event something’s been missed, one week would be long enough to spot it. Vote is here: https://wiki.php.net/rfc/closure_apply#vote It ends 2014-08-27. Thanks! -- Andrea Fau

Re: [PHP-DEV] [RFC] Binary String Comparison

2014-08-20 Thread Michael Wallner
On 20/08/14 11:12, Marc Bennewitz wrote:> > > On 18.08.2014 17:43, Johannes Schlüter wrote: >> On Mon, 2014-08-18 at 17:30 +0200, Johannes Schlüter wrote: >>> foreach ($db->query("SELECT id, title FROM entries") as $row) { >>> echo ">> if ($row[0] == $_GET['highlight_id']) { >>>

Re: [PHP-DEV] master is broken on Travis

2014-08-20 Thread Lior Kaplan
On Tue, Aug 19, 2014 at 1:46 AM, Bob Weinand wrote: > Am 19.8.2014 um 00:09 schrieb Stas Malyshev : > > Hi! > > > > Since we've had phpng branch merged to master the build on Travis CI is > > broken for master (as in, doesn't even build). Could it be fixed? It's > > not a good thing that we have

Re: [PHP-DEV] ext/standard/tests/http/bug60570.phpt failure

2014-08-20 Thread Dmitry Stogov
The are not defined. They are open (or closed but not freed yet). You probably meant get_defined_resorce_types() Thanks. Dmitry. On Wed, Aug 20, 2014 at 1:12 PM, Julien Pauli wrote: > On Wed, Aug 20, 2014 at 7:24 AM, Dmitry Stogov wrote: > > Anyone objects about it or thinks it needs RFC? >

Re: [PHP-DEV] [RFC] Integer Semantics

2014-08-20 Thread Dmitry Stogov
On Wed, Aug 20, 2014 at 1:20 PM, Andrea Faulds wrote: > > On 20 Aug 2014, at 06:52, Dmitry Stogov wrote: > > > 1) INF conversion to zero seems wrong. May be +INF should be converted > to MAX_LONG and -INF to MIN_LONG? > > I think of Infinity as more of an error value than an actual number. Not >

Re: [PHP-DEV] [RFC] Integer Semantics

2014-08-20 Thread Pierre Joye
On Wed, Aug 20, 2014 at 11:24 AM, Andrea Faulds wrote: > > On 20 Aug 2014, at 03:53, Laruence wrote: > >> On Wed, Aug 20, 2014 at 6:36 AM, Andrea Faulds wrote: >>> Good evening, >>> >>> I have made an RFC which would make some small changes to how integers are >>> handled, targeted at PHP 7: >>

Re: [PHP-DEV] [RFC] Binary String Comparison

2014-08-20 Thread Tjerk Meesters
On Tue, Aug 19, 2014 at 11:07 AM, Tjerk Meesters wrote: > > On Mon, Aug 18, 2014 at 11:30 PM, Johannes Schlüter < > johan...@schlueters.de> wrote: > >> On Mon, 2014-08-18 at 23:09 +0800, Tjerk Meesters wrote: >> > > On 18 Aug, 2014, at 10:47 pm, Johannes Schlüter < >> johan...@schlueters.de> wrot

Re: [PHP-DEV] [RFC] Integer Semantics

2014-08-20 Thread Andrea Faulds
On 20 Aug 2014, at 03:53, Laruence wrote: > On Wed, Aug 20, 2014 at 6:36 AM, Andrea Faulds wrote: >> Good evening, >> >> I have made an RFC which would make some small changes to how integers are >> handled, targeted at PHP 7: >> >> https://wiki.php.net/rfc/integer_semantics > > I'd like do

Re: [PHP-DEV] [RFC] Binary String Comparison

2014-08-20 Thread Marc Bennewitz
On 19.08.2014 05:07, Tjerk Meesters wrote: On Mon, Aug 18, 2014 at 11:30 PM, Johannes Schlüter mailto:johan...@schlueters.de>> wrote: On Mon, 2014-08-18 at 23:09 +0800, Tjerk Meesters wrote: > > On 18 Aug, 2014, at 10:47 pm, Johannes Schlüter mailto:johan...@schlueters.de>> wrote

Re: [PHP-DEV] [RFC] Integer Semantics

2014-08-20 Thread Andrea Faulds
On 20 Aug 2014, at 06:52, Dmitry Stogov wrote: > 1) INF conversion to zero seems wrong. May be +INF should be converted to > MAX_LONG and -INF to MIN_LONG? I think of Infinity as more of an error value than an actual number. Not using MAX_LONG and MIN_LONG means it casts to the same value mat

Re: [PHP-DEV] ext/standard/tests/http/bug60570.phpt failure

2014-08-20 Thread Julien Pauli
On Wed, Aug 20, 2014 at 7:24 AM, Dmitry Stogov wrote: > Anyone objects about it or thinks it needs RFC? > > Thanks. Dmitry. > > > On Wed, Aug 20, 2014 at 6:48 AM, Laruence wrote: > >> Hey: >> >> >> On Tue, Aug 19, 2014 at 10:10 PM, Dmitry Stogov wrote: >> > Hi, >> > >> > Yesterday we discussed w

Re: [PHP-DEV] [RFC] Binary String Comparison

2014-08-20 Thread Marc Bennewitz
On 18.08.2014 17:43, Johannes Schlüter wrote: On Mon, 2014-08-18 at 17:30 +0200, Johannes Schlüter wrote: foreach ($db->query("SELECT id, title FROM entries") as $row) { echo "".htmlentities($row[1]).""; } will suddenly fail. How wonderful! (irony) Just to make this more fun

Re: [PHP-DEV] [RFC] Binary String Comparison

2014-08-20 Thread Marc Bennewitz
On 18.08.2014 14:53, Pierre Joye wrote: hi, On Mon, Aug 18, 2014 at 2:44 PM, Marc Bennewitz wrote: On 17.08.2014 22:18, Sara Golemon wrote: On Sun, Aug 17, 2014 at 12:58 PM, Marc Bennewitz wrote: I've created a draft RFC and patch to change the behavior of non-strict string to string c

Re: [PHP-DEV] ext/standard/tests/http/bug60570.phpt failure

2014-08-20 Thread Pierre Joye
On Wed, Aug 20, 2014 at 7:24 AM, Dmitry Stogov wrote: > Anyone objects about it or thinks it needs RFC? No, goahead :) -- Pierre @pierrejoye | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php