[PHP-DEV] Re: 5.4 does not support Digest WWW-Authenticate anymore?

2011-09-22 Thread Laruence
Hi: this bug has been fixed, see http://svn.php.net/viewvc?view=revision&revision=317172 it was introduced by a mistake when removing PG(safe_mod): if (PG(saf_mod)) { #if PCRE { } #else { //this should removed too, that is what does

Re: [PHP-DEV] Re: is_a() - again - a better fix

2011-09-22 Thread Alan Knowles
This patch adds an extra parameter 'allow_string' to is_a (default off) and is_subclass_of (default on) , https://bugs.php.net/patch-display.php?bug_id=55475&patch=Is_a_with_allow_string_argument_v3&revision=latest

Re: [PHP-DEV] Re: is_a() - again - a better fix

2011-09-22 Thread Rasmus Lerdorf
I don't see the harm in reverting back to the previous behaviour in the 5.3 tree. It's not like it will break code that has been fixed to work with the new behaviour. -Rasmus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/calendar/tests/easter_date.phpt branches/PHP_5_4/ext/calendar/tests/easter_date.phpt trunk/ext/calendar/tests/easter_date.phpt

2011-09-22 Thread Ferenc Kovacs
ext/intl/tests/dateformat_parse.phpt seems also affected by this: http://news.php.net/php.cvs/66617 On Thu, Sep 22, 2011 at 11:06 PM, Ferenc Kovacs wrote: > Derick, could you look into this? > I think that the easter_days should take the date.timezone account > when calculating a timestamp > > On

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/calendar/tests/easter_date.phpt branches/PHP_5_4/ext/calendar/tests/easter_date.phpt trunk/ext/calendar/tests/easter_date.phpt

2011-09-22 Thread Ferenc Kovacs
Derick, could you look into this? I think that the easter_days should take the date.timezone account when calculating a timestamp On Thu, Sep 22, 2011 at 10:59 PM, Ferenc Kovacs wrote: > tyrael                                   Thu, 22 Sep 2011 20:59:10 + > > Revision: http://svn.php.net/view

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug55509.phpt branches/PHP_5_3/Zend/zend_alloc.c branches/PHP_5_4/Zend/tests/bug55509.phpt branches/PHP_5_4

2011-09-22 Thread Ferenc Kovacs
I just stumbled upon on this test as it timed out for me(my test vm started swapping, so run-tests.php terminated after 60 sec). I think it would be good if we could somehow check the available ram, and skipif if it isn't enough, and I think we could also save off an str_repeat call: each str_repea

Re: [PHP-DEV] Re: is_a() - again - a better fix

2011-09-22 Thread Pierre Joye
2011/9/22 Johannes Schlüter : > On Thu, 2011-09-22 at 10:27 -0700, Clint Byrum wrote: >> So I'm not sure what you would expect from distros, but please share >> and we'll setup automated tests, call for our users to test, whatever >> it takes to avoid this type of situation. > > This issue is not a

Re: [PHP-DEV] Re: is_a() - again - a better fix

2011-09-22 Thread Johannes Schlüter
On Thu, 2011-09-22 at 10:27 -0700, Clint Byrum wrote: > So I'm not sure what you would expect from distros, but please share > and we'll setup automated tests, call for our users to test, whatever > it takes to avoid this type of situation. This issue is not about packagers specifically. What we

Re: [PHP-DEV] Re: is_a() - again - a better fix

2011-09-22 Thread Clint Byrum
Excerpts from Kalle Sommer Nielsen's message of Thu Sep 22 08:03:19 -0700 2011: > Hi > > 2011/9/22 Daniel Convissor : > > Breaking PHP for untold thousands upon thousands of applications created > > over the past nine years is a FAR bigger problem for our image. > > While don't like the change du

[PHP-DEV] Re: 5.4 does not support Digest WWW-Authenticate anymore?

2011-09-22 Thread Laruence
Hi: if no ideas, I will be going to revert this. thanks 2011/9/22 Laruence : > +kalle > > Hi : >  I found this was introduce in r298625,and seems to be a mistake, kalle , > can you verify this?  Thanks > > http://svn.php.net/viewvc/php/php-src/trunk/main/SAPI.c?r1=298625&r2=298624&pathrev=29

Re: [PHP-DEV] Re: is_a() - again - a better fix

2011-09-22 Thread Kalle Sommer Nielsen
Hi 2011/9/22 Daniel Convissor : > Breaking PHP for untold thousands upon thousands of applications created > over the past nine years is a FAR bigger problem for our image. While don't like the change due the break in a stable branch which I also wrote about in the bug report. Then I don't see wh

RE: [PHP-DEV] Re: is_a() - again - a better fix

2011-09-22 Thread Jonathan Bond-Caron
On Wed Sep 21 09:57 AM, Matthew Weier O'Phinney wrote: > > > It then reverts is_a() back to the previous behavior, and clarifies > > the documentation. > > > To respect the release RFC, we shouldn't introduce a new BC break > (breaking behavior with something already released). > That's just

Re: [PHP-DEV] Re: is_a() - again - a better fix

2011-09-22 Thread Daniel Convissor
Hi Folks: On Thu, Sep 22, 2011 at 02:41:14AM +0200, Kalle Sommer Nielsen wrote: > > While I respect from a package maintainer standpoint the thought of > reverting to the pre 5.3.8 behaviour would help the Ubuntu project, > however, in the whole image it does not help the PHP project Breaking PHP

Re: [PHP-DEV] Revert Tokenizer behavior for 5.4

2011-09-22 Thread Nikita Popov
So, is there any consensus about this? Nikita On Fri, Sep 16, 2011 at 10:07 AM, Ferenc Kovacs wrote: >> >> Wait wait wait. Thats the point here? >> __COMPILER_HALT_OFFSET__ already tells you where the data starts. >> >> -Hannes >> > > I didn't sent this message first, but after reading the mail

Re: [PHP-DEV] Re: is_a() - again - a better fix

2011-09-22 Thread Rune Kaagaard
> Wearing my package maintainer hat and given that Alan's points above are > true, I would very much like for is_a's behaviour to be reverted to > pre-5.3.8 state as well. I also believe that reverting would cause less > damage than keeping current behaviour. The hugest of +1's! -- PHP Internals