[PHP-DEV] [PATCH]#55651

2011-09-10 Thread Avi Brender
Hi Laruence, Sure thing - I was just using the above code that verified the AUTOSEEK option as a template. I've changed it to use convert_to_boolean_ex as per your suggestion :) Thanks! Avi Brender Elite Hosts, Inc www.elitehosts.com On 09/10/2011 11:59 PM, Laruence wrote: Hi: after

[PHP-DEV] proposal for change the argument of parse_str/mb_parse_str

2011-09-10 Thread Rui Hirokawa
Hello, I think the second argument of parse_str/mb_parse_str should be changed from optional to mandatory. parse_str(string encoded_string [, array result]) -> parse_str(string encoded_string , array result) It is to reduce the risk of vulnerability, and it has neary same risk as register_globa

Re: [PHP-DEV] [PATCH]#55651

2011-09-10 Thread Laruence
Hi: after a quick look, I have one suggestion, if the (Z_TYPE_P(z_value) != IS_BOOL), you should call convert_to_boolean_ex to convert it to a boolean otherwise, people can not use a interge 1 as a true flag. thanks 2011/9/11 Avi Brender : > Hi, > > I've submitted bug #55651 alon

Re: [PHP-DEV] Re: Bug #55661 [Opn]: mysqli/tests/bug54674.phpt failed when link against libmysql

2011-09-10 Thread Laruence
Hi: it seems due to EXPLAIN , since other normal sql has a valid catalog . and I found it also generate a segfault when linked against mysqlnd the most difficult part is, when the catalog in field struct is not valid, it is not a NULL pointer,,, I can't distinguish this from a valid

[PHP-DEV] [PATCH]#55651

2011-09-10 Thread Avi Brender
Hi, I've submitted bug #55651 along with a patch to implement a fix (also attached) for the passive FTP mode issue. I was hoping that someone could review the bug report and consider the patch for inclusion in future PHP releases. Thanks so much! Avi Brender Elite Hosts, Inc www.elitehosts.

Re: [PHP-DEV] Re: Bug #55661 [Opn]: mysqli/tests/bug54674.phpt failed when link against libmysql

2011-09-10 Thread Pierre Joye
hi, Can you discuss that in the bug tracker please? so we have a BT :) On Sat, Sep 10, 2011 at 4:15 PM, Laruence wrote: > Hi: >   got, thanks, :-) > >    and I found the seg fault is cause by "catalog", which was > introduced by > http://svn.php.net/viewvc/php/php-src/trunk/ext/mysqli/mysqli_ap

Re: [PHP-DEV] Re: Bug #55661 [Opn]: mysqli/tests/bug54674.phpt failed when link against libmysql

2011-09-10 Thread Laruence
Hi: got, thanks, :-) and I found the seg fault is cause by "catalog", which was introduced by http://svn.php.net/viewvc/php/php-src/trunk/ext/mysqli/mysqli_api.c?r1=307475&r2=307532 I am not sure, the catalog is for what? thanks 2011/9/10 Kalle Sommer Nielsen : > Hi Laruence > > 2011

Re: [PHP-DEV] Re: Bug #55661 [Opn]: mysqli/tests/bug54674.phpt failed when link against libmysql

2011-09-10 Thread Kalle Sommer Nielsen
Hi Laruence 2011/9/10 Laruence : > Hi: >   somebody of mysqli plz look at #55661, #55662 > >   they are test failed , and a segfault when use mysqli linked > against libmysql in Linux redhat(64bit) Assign such bugs to "mysql" (the username) and the MySQL guys will normally get to it pretty quickl

Re: [PHP-DEV] PDO_firebird testing

2011-09-10 Thread Lester Caine
Lester Caine wrote: Still have rowCount.phpt to finish off, but I think that is just killing the connection with an open transaction. https://bugs.php.net/bug.php?id=55664 That covers it ... The basic problem that needs to be resolved is what the pdo driver tests should be using to test the pd

[PHP-DEV] PDO_firebird testing

2011-09-10 Thread Lester Caine
This by way of a crib sheet as I'm checking each test ... I've posted a patch which should updated the 5.3 branch, and I can't see why it should not work with 5.4 and trunk as nothing here should have changed between branches? https://bugs.php.net/bug.php?id=55663 has the patch ... why the f**