Hi: after a quick look, I have one suggestion, if the (Z_TYPE_P(z_value) != IS_BOOL), you should call convert_to_boolean_ex to convert it to a boolean otherwise, people can not use a interge 1 as a true flag.
thanks 2011/9/11 Avi Brender <abren...@elitehosts.com>: > Hi, > > I've submitted bug #55651 along with a patch to implement a fix (also > attached) for the passive FTP mode issue. I was hoping that someone could > review the bug report and consider the patch for inclusion in future PHP > releases. > > Thanks so much! > > Avi Brender > Elite Hosts, Inc > www.elitehosts.com > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Laruence Xinchen Hui http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php