Re: [PHP-DEV] [RFC] Removal of deprecated features

Hi, on my previous mail I missed one thing: On Fri, 2010-04-09 at 00:48 +0200, Kalle Sommer Nielsen wrote: > magic_quotes_* > - Something we have long time been wanted to remove from PHP, I don't > see a big reason to keep those in the next version, even if its going > to be a 5.4, since we alre

Re: [PHP-DEV] [RFC] FPM INI syntax

2010/4/15 Christopher Jones : > > > On 04/13/2010 12:01 PM, Zeev Suraski wrote: >> >> At 21:46 13/04/2010, Christopher Jones wrote: >> >> >>> Jérôme Loyet wrote: Le 13 avril 2010 20:17, Christopher Jones a écrit : > > Jérôme Loyet wrote: >> >> Hi guys, >> >>

Re: [PHP-DEV] [RFC] FPM INI syntax

On 04/13/2010 12:01 PM, Zeev Suraski wrote: At 21:46 13/04/2010, Christopher Jones wrote: Jérôme Loyet wrote: Le 13 avril 2010 20:17, Christopher Jones a écrit : Jérôme Loyet wrote: Hi guys, As dreamcast4 advises me in the previous FPM conversation, I just wrote the RFC for the FPM INI

Re: [PHP-DEV] [RFC] FPM INI syntax

2010/4/15 Zeev Suraski : > At 17:00 15/04/2010, Ferenc Kovacs wrote: > > >> On Thu, Apr 15, 2010 at 1:38 PM, Zeev Suraski >> <z...@zend.com> wrote: >> At 14:30 15/04/2010, Ferenc Kovacs wrote: >> Yep, this what I'm trying to say. I thought that the include parameter in >> the

Re: [PHP-DEV] [RFC] FPM INI syntax

On Apr 15, 2010, at 4:55 AM, Zeev Suraski wrote: Agreed that it's a big change, but it's certainly possible. Requires its own discussion... Fwiw +1 Mysql's ini file supports includes (!includedir and it supports wildcards), so people are used to the syntax and it can follow a pseudo-

Re: [PHP-DEV] [RFC] FPM INI syntax

On Thu, Apr 15, 2010 at 4:13 PM, Zeev Suraski wrote: > At 17:00 15/04/2010, Ferenc Kovacs wrote: > > > On Thu, Apr 15, 2010 at 1:38 PM, Zeev Suraski < >> z...@zend.com> wrote: >> At 14:30 15/04/2010, Ferenc Kovacs wrote: >> Yep, this what I'm trying to say. I thought that t

Re: [PHP-DEV] [RFC] FPM INI syntax

At 17:00 15/04/2010, Ferenc Kovacs wrote: On Thu, Apr 15, 2010 at 1:38 PM, Zeev Suraski <z...@zend.com> wrote: At 14:30 15/04/2010, Ferenc Kovacs wrote: Yep, this what I'm trying to say. I thought that the include parameter in the global.ini is just a normal config vari

Re: [PHP-DEV] [RFC] FPM INI syntax

On Thu, Apr 15, 2010 at 1:38 PM, Zeev Suraski wrote: > At 14:30 15/04/2010, Ferenc Kovacs wrote: > >> Yep, this what I'm trying to say. I thought that the include parameter in >> the global.ini is just a normal config variabla, which isn't interpreted by >> the php parse ini method, only just tel

Re: [PHP-DEV] One suggestion to PHP-FPM

On Thu, Apr 15, 2010 at 1:36 PM, Antony Dovgal wrote: > On 15.04.2010 15:17, Ferenc Kovacs wrote: > > If this is the case, then it should be stable for now, isn't it? > > I guess you can call it that, yes. > > I mean this should be reflected in the pecl package status field. Tyrael

Re: [PHP-DEV] [RFC] FPM INI syntax

Le 15 avril 2010 13:55, Zeev Suraski a écrit : > At 14:47 15/04/2010, Jérôme Loyet wrote: >> >> > 1.  In the .ini parser;  That means it'll work for anything that uses >> > the >> > .ini parser, including php.ini, fpm.ini, parse_ini_file(), etc. >> >> It's a huge change, it's has to be tested a lo

Re: [PHP-DEV] [RFC] FPM INI syntax

At 14:47 15/04/2010, Jérôme Loyet wrote: > 1. In the .ini parser; That means it'll work for anything that uses the > .ini parser, including php.ini, fpm.ini, parse_ini_file(), etc. It's a huge change, it's has to be tested a lot ... too much complicated= Agreed that it's a big change, but it

Re: [PHP-DEV] array_seek function

2010/4/15 Derick Rethans : > On Tue, 13 Apr 2010, Felix De Vliegher wrote: > >> Update: http://phpbenelux.eu/array_seek-return.patch.txt >> I've kept the fseek()-style return values (0 when fine, -1 when seek >> fails) >> >>> >> >>> Any reason why you picked that over the (IMO more

Re: [PHP-DEV] [RFC] FPM INI syntax

2010/4/15 Zeev Suraski : > At 14:30 15/04/2010, Ferenc Kovacs wrote: >> >> Yep, this what I'm trying to say. I thought that the include parameter in >> the global.ini is just a normal config variabla, which isn't interpreted by >> the php parse ini method, only just tells the fpm, to include that f

Re: [PHP-DEV] [RFC] FPM INI syntax

At 14:30 15/04/2010, Ferenc Kovacs wrote: Yep, this what I'm trying to say. I thought that the include parameter in the global.ini is just a normal config variabla, which isn't interpreted by the php parse ini method, only just tells the fpm, to include that files manualy and merge the contents

Re: [PHP-DEV] One suggestion to PHP-FPM

On 15.04.2010 15:17, Ferenc Kovacs wrote: > If this is the case, then it should be stable for now, isn't it? I guess you can call it that, yes. -- Wbr, Antony Dovgal --- http://pinba.org - realtime statistics for PHP -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit

Re: [PHP-DEV] [RFC] FPM INI syntax

On Thu, Apr 15, 2010 at 1:21 PM, Zeev Suraski wrote: > BTW - I think the include discussion is very much secondary here. I'm not > sure why we really need include for this particular config file, and it may > make sense to separate these two things altogether - moving to fpm.ini, and > whether o

Re: [PHP-DEV] [RFC] FPM INI syntax

BTW - I think the include discussion is very much secondary here. I'm not sure why we really need include for this particular config file, and it may make sense to separate these two things altogether - moving to fpm.ini, and whether or not we want .ini files to support include. Zeev At 14

Re: [PHP-DEV] [RFC] FPM INI syntax

At 14:12 15/04/2010, Ferenc Kovacs wrote: Agree, I thought that the include part will be handled from the application. Not sure what you mean by that. I mean you parse the global config, read the include param, and read each of the matching ini for merging them to the original config format.

Re: [PHP-DEV] One suggestion to PHP-FPM

On Thu, Apr 15, 2010 at 1:08 PM, Antony Dovgal wrote: > On 15.04.2010 15:03, Ferenc Kovacs wrote: > > Yeah, this could be implemented there, but it seems that its not > > actively developed, last release 0.1 beta more than a year ago. > > In this case 'not actively developed' means 'it works and

Re: [PHP-DEV] [RFC] FPM INI syntax

2010/4/15 Derick Rethans > On Tue, 13 Apr 2010, Zeev Suraski wrote: > > > At 21:46 13/04/2010, Christopher Jones wrote: > > > > > Jérôme Loyet wrote: > > > > Le 13 avril 2010 20:17, Christopher Jones > > > > a écrit : > > > > > > > > > > Jérôme Loyet wrote: > > > > > > > > > > > > As dreamcast4

Re: [PHP-DEV] [RFC] FPM INI syntax

At 13:56 15/04/2010, Derick Rethans wrote: Uh, so what you're saying is that you want to use INI syntax for FPM so that it is inline with php's INI sytanx, but then modify it with extra statements so that it isn't the same anymore—not only with include,, but section headers are totally ignored in

Re: [PHP-DEV] array_seek function

On Tue, 13 Apr 2010, Felix De Vliegher wrote: > Update: http://phpbenelux.eu/array_seek-return.patch.txt > I've kept the fseek()-style return values (0 when fine, -1 when seek > fails) > >>> > >>> Any reason why you picked that over the (IMO more logical) true/false > >>> approac

Re: [PHP-DEV] One suggestion to PHP-FPM

On 15.04.2010 15:03, Ferenc Kovacs wrote: > Yeah, this could be implemented there, but it seems that its not > actively developed, last release 0.1 beta more than a year ago. In this case 'not actively developed' means 'it works and no bugs were found/reported', so I don't see it as a disadvantag

Re: [PHP-DEV] One suggestion to PHP-FPM

On Thu, Apr 15, 2010 at 10:57 AM, Antony Dovgal wrote: > On 15.04.2010 12:54, Ferenc Kovacs wrote: > > Adding this to FPM won't help anyway - FPM doesn't use threads. > > > > You meant won't hurt? > > No, I mean implementing it in PECL/memtrack would be better since this way > you add it to a

Re: [PHP-DEV] [RFC] Removal of deprecated features

On Fri, 9 Apr 2010, Kalle Sommer Nielsen wrote: > safe_mode/register_globals/register_long_arrays/magic_quotes_*/allow_call_time_pass_reference > - Something we have long time been wanted to remove from PHP, I don't > see a big reason to keep those in the next version, even if its going > to be a

Re: [PHP-DEV] [RFC] FPM INI syntax

On Tue, 13 Apr 2010, Zeev Suraski wrote: > At 21:46 13/04/2010, Christopher Jones wrote: > > > Jérôme Loyet wrote: > > > Le 13 avril 2010 20:17, Christopher Jones > > > a écrit : > > > > > > > > Jérôme Loyet wrote: > > > > > > > > > > As dreamcast4 advises me in the previous FPM conversation,

[PHP-DEV] Re: [RFC] FPM INI syntax

hi I made the first release of the patch to convert fpm syntax from xml to ini. Everything is in the RFC: http://wiki.php.net/rfc/fpm/ini_syntax The patch is directly viewable at the following address: http://www.fatbsd.com/fpm/fpm-ini-v1.patch This patch does not make everything described in th

Re: [PHP-DEV] [RFC] Removal of deprecated features

2010/4/15 Kalle Sommer Nielsen : > Hi Patrick > > 2010/4/15 Patrick ALLAERT : >> Hi! >> >> I think we should also keep an eye on removing dead code. >> Removing the useless: main/mergesort.c for example (Patch in attachment). > > I agree we should remove dead code, like Johannes commit to remove >

Re: [PHP-DEV] [RFC] Removal of deprecated features

Hi Patrick 2010/4/15 Patrick ALLAERT : > Hi! > > I think we should also keep an eye on removing dead code. > Removing the useless: main/mergesort.c for example (Patch in attachment). I agree we should remove dead code, like Johannes commit to remove php3_compat.h. As for the mergesort patch, is i

Re: [PHP-DEV] [RFC] Removal of deprecated features

2010/4/9 Kalle Sommer Nielsen : > Hey Everyone > > I've put together a simple RFC[1] that lists features thats been > deprecated in 5.3, someone of them which I propose we remove in the > next version of PHP, depending on the version number. Most of the > features, which is listed below are taken f

Re: [PHP-DEV] One suggestion to PHP-FPM

On 15.04.2010 12:54, Ferenc Kovacs wrote: > Adding this to FPM won't help anyway - FPM doesn't use threads. > > You meant won't hurt? No, I mean implementing it in PECL/memtrack would be better since this way you add it to all non-threaded SAPIs. While adding it to FPM means that other non-t

Re: [PHP-DEV] One suggestion to PHP-FPM

2010/4/15 Antony Dovgal > On 15.04.2010 12:23, Jérôme Loyet wrote: > > 2010/4/15 Antony Dovgal : > >> On 06.04.2010 11:11, 滕路遥 wrote: > >>> So I suggest that if we could add a config option to PHP-FPM, so that > >>> PHP-FPM could just kill a PHP process if it consumes too much memory > >>> (say m

Re: [PHP-DEV] One suggestion to PHP-FPM

On 15.04.2010 12:23, Jérôme Loyet wrote: > 2010/4/15 Antony Dovgal : >> On 06.04.2010 11:11, 滕路遥 wrote: >>> So I suggest that if we could add a config option to PHP-FPM, so that >>> PHP-FPM could just kill a PHP process if it consumes too much memory >>> (say more than 256M). >> >> I personally don

Re: [PHP-DEV] One suggestion to PHP-FPM

2010/4/15 Antony Dovgal : > On 06.04.2010 11:11, 滕路遥 wrote: >> So I suggest that if we could add a config option to PHP-FPM, so that >> PHP-FPM could just kill a PHP process if it consumes too much memory >> (say more than 256M). > > I personally don't think this belongs to any SAPI. > How about ad

Re: [PHP-DEV] One suggestion to PHP-FPM

On 06.04.2010 11:11, 滕路遥 wrote: > So I suggest that if we could add a config option to PHP-FPM, so that > PHP-FPM could just kill a PHP process if it consumes too much memory > (say more than 256M). I personally don't think this belongs to any SAPI. How about adding another ini option to PECL/memt

Re: [PHP-DEV] One suggestion to PHP-FPM

On Thu, Apr 15, 2010 at 9:41 AM, Jérôme Loyet wrote: > 2010/4/15 Ferenc Kovacs : > > > > > > On Thu, Apr 15, 2010 at 9:25 AM, Jérôme Loyet wrote: > >> > >> 2010/4/15 Ferenc Kovacs : > >> > > >> > > >> > On Thu, Apr 15, 2010 at 9:09 AM, Ferenc Kovacs > wrote: > >> >> > >> >> > >> >> 2010/4/15 Jé

Re: [PHP-DEV] One suggestion to PHP-FPM

On Thu, Apr 15, 2010 at 9:28 AM, Michael Shadle wrote: > On Thu, Apr 15, 2010 at 12:09 AM, Ferenc Kovacs wrote: > > > My suggestion is more about releasing the allocated memory as soon as > > possible. That is, this option is similar to "max_requests". > > PHP-FPM would kill the PHP process if t

Re: [PHP-DEV] One suggestion to PHP-FPM

2010/4/15 Ferenc Kovacs : > > > On Thu, Apr 15, 2010 at 9:25 AM, Jérôme Loyet wrote: >> >> 2010/4/15 Ferenc Kovacs : >> > >> > >> > On Thu, Apr 15, 2010 at 9:09 AM, Ferenc Kovacs wrote: >> >> >> >> >> >> 2010/4/15 Jérôme Loyet >> >>> >> >>> 2010/4/15 滕路遥 : >> >>> > We check error log after our s

Re: [PHP-DEV] One suggestion to PHP-FPM

On Thu, Apr 15, 2010 at 9:25 AM, Jérôme Loyet wrote: > 2010/4/15 Ferenc Kovacs : > > > > > > On Thu, Apr 15, 2010 at 9:09 AM, Ferenc Kovacs wrote: > >> > >> > >> 2010/4/15 Jérôme Loyet > >>> > >>> 2010/4/15 滕路遥 : > >>> > We check error log after our server crashed, and we found that php > heap

Re: [PHP-DEV] One suggestion to PHP-FPM

On Thu, Apr 15, 2010 at 12:09 AM, Ferenc Kovacs wrote: > My suggestion is more about releasing the allocated memory as soon as > possible. That is, this option is similar to "max_requests". > PHP-FPM would kill the PHP process if the requests a process handled > exceed max_requests, and similarly

Re: [PHP-DEV] One suggestion to PHP-FPM

2010/4/15 Ferenc Kovacs : > > > On Thu, Apr 15, 2010 at 9:09 AM, Ferenc Kovacs wrote: >> >> >> 2010/4/15 Jérôme Loyet >>> >>> 2010/4/15 滕路遥 : >>> > We check error log after our server crashed, and we found that php heap >>> > memory is out of limit, >>> > so I think imagick use emalloc to allocat

Re: [PHP-DEV] One suggestion to PHP-FPM

When allocate memory from PHP memory heap, PHP runtime check the memory_limit which in php.ini, but this can only give a error message and not to continue to excute php code, it can't control the PHP-FPM child process, my idea is that when the memory out of limit we set, kill this child process,

Re: [PHP-DEV] One suggestion to PHP-FPM

On Thu, Apr 15, 2010 at 9:09 AM, Ferenc Kovacs wrote: > > > 2010/4/15 Jérôme Loyet > > 2010/4/15 滕路遥 : >> > We check error log after our server crashed, and we found that php heap >> > memory is out of limit, >> > so I think imagick use emalloc to allocate php heap memory, to check the >> > zend

Re: [PHP-DEV] One suggestion to PHP-FPM

2010/4/15 Jérôme Loyet > 2010/4/15 滕路遥 : > > We check error log after our server crashed, and we found that php heap > > memory is out of limit, > > so I think imagick use emalloc to allocate php heap memory, to check the > > zend_memory_usage is > > not a method for imagick, other circumstances