At 17:00 15/04/2010, Ferenc Kovacs wrote:
On Thu, Apr 15, 2010 at 1:38 PM, Zeev Suraski
<<mailto:z...@zend.com>z...@zend.com> wrote:
At 14:30 15/04/2010, Ferenc Kovacs wrote:
Yep, this what I'm trying to say. I thought that
the include parameter in the global.ini is just
a normal config variabla, which isn't
interpreted by the php parse ini method, only
just tells the fpm, to include that files
manualy and merge the contents of that files
into the original configuration parsed from the global.ini.
But as far as I understand the patch and the
discussion, it seems that Jerome proposed to
change the internal working of the ini parsing,
to add general support for includes.
Actually as far as I understand what you wrote
in the 1st paragraph is exactly what was
planned. Â There weren't any plans to touch the .ini parser itself in any way.
- the include directive is not yet implemented because the
zend_ini_parser is not able to handle recursive calls (because of the
the state env which is global)
This seems to like that Jerome is implying to
change the zend_ini_parser to support includes.
Not quite - he only wants to make the parser
reentrant, so that it would be possible to
implement include in a certain way. It doesn't
mean the parser itself will support include. BTW
- I think there are other ways to implement
include that don't require making the ini parser
reentrant but that's a different story.
If the includes are done by the fpm config
loader/parser, then I don't understand why
should the zend_ini_parser to be changed except
the one case that Jerome wants to implement a
general include support for the ini parser.
In Jerome's approach the include logic will still
be at the fpm config loader/parser level, but
he's modifying the ZE ini parser slightly to make
it easier for him to implement it at that
level. The behavior of the ZE ini parser won't change.
Zeev
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
