Re: [PHP-DEV] [PATCH] array_combine is not binary-key safe

2006-07-23 Thread bertrand Gugger
Matt W wrote: Hi Andrei, I see you applied my patch. Testing with a php5.2-200607222030 snaps having /* $Id: array.c,v 1.308.2.21.2.7 2006/07/22 16:58:39 andrei Exp $ */ Looks by me as the ext/standard/tests/array/array_combine.phpt fails Is it by me ? $ diff -W 60 -y --suppress-common-lines

Re: [PHP-DEV] [PATCH] number_format enhancements

2006-07-23 Thread bertrand Gugger
Matt W wrote: Hi, Give some basic userland examples about what you propose to change, please ... (I guess these are a part of the .phpt) In the .phpt file, it is userland code where you can see examples of how the changes work. :-) Sure, but I was meaning , in so far you extend the functionali

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.crfc1867.h

2006-07-23 Thread Ilia Alshanetsky
I reviewed the code and as far as I can tell it works fine. Certainly, some sort of an earlier courtesy notice to the RM would've been nice, but as Rasmus said this is till before RC1, so do I don't see a problem with the patch's inclusion. That said, if it becomes apparent that the code do

Re: [PHP-DEV] [v][sf]printf additions (#, E, g, G)

2006-07-23 Thread Gwynne
On Jul 23, 2006, at 5:38 AM, Matt W wrote: While we're on the subject, one of my favorite personal patches to PHP is one that adds the %n specifier. The parameter to %n is a reference which recieves the total length of the string with all replacements so far. %n itself is replaced by nothing at a

Re: [PHP-DEV] [PATCH] Typo in phpize.in

2006-07-23 Thread Jani Taskinen
Fixed. Thanks! --Jani On Sun, 23 Jul 2006, Stut wrote: I've just started developing a new extension, checked out the latest source and found this snafu. I assume it's a typo. -Stut -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/un

[PHP-DEV] [PATCH] Typo in phpize.in

2006-07-23 Thread Stut
I've just started developing a new extension, checked out the latest source and found this snafu. I assume it's a typo. -Stut Index: phpize.in === RCS file: /repository/php-src/scripts/phpize.in,v retrieving revision 1.32 diff -u -u -

Re: [PHP-DEV] [PATCH] array_combine is not binary-key safe

2006-07-23 Thread Ilia Alshanetsky
Most compiler (I know gcc and Visual C do) will optimize strlen ("static_string"). On 21-Jul-06, at 9:04 AM, Matt W wrote: Hi Richard, I think I've seen those instances that you're referring to. By fixed length string I assume you mean hard-coded "string_key". Yeah, I would think thos

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.crfc1867.h

2006-07-23 Thread Pierre
Hello, On 7/23/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: Hello Stefan, Sunday, July 23, 2006, 3:39:35 AM, you wrote: >> If you'd be grown up yourself, you would just commit to HEAD instead >> of spending time on meaningless insults. > Commiting to HEAD is not possible. How often do I have

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.crfc1867.h

2006-07-23 Thread Rasmus Lerdorf
Marcus Boerger wrote: Hello Stefan, Sunday, July 23, 2006, 3:39:35 AM, you wrote: If you'd be grown up yourself, you would just commit to HEAD instead of spending time on meaningless insults. Commiting to HEAD is not possible. How often do I have to tell that. Because of the unicode changes t

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.crfc1867.h

2006-07-23 Thread Marcus Boerger
Hello Stefan, Sunday, July 23, 2006, 3:39:35 AM, you wrote: >> If you'd be grown up yourself, you would just commit to HEAD instead >> of spending time on meaningless insults. > Commiting to HEAD is not possible. How often do I have to tell that. > Because of the unicode changes the patch has to

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.c rfc1867.h

2006-07-23 Thread Wez Furlong
I agree; this upload patch should be reverted. --Wez. On 7/23/06, Derick Rethans <[EMAIL PROTECTED]> wrote: On Sun, 23 Jul 2006, Stefan Esser wrote: > Antony, > > So this is the reason you think you can break the upcoming release now? > > Please revert it, as I don't want to see yet another br

Re: [PHP-DEV] Adding pecl/zip to 5.2

2006-07-23 Thread Lukas Smith
Hi, so it seems to me like several core developers think its a worthwhile addition to core if the class is renamed to ZipArchive (if I understood Pierre correctly in a private IRC exchange he is ok with renaming the class). The idea of a PDO for archives does not seem to generate much suppor

Re: [PHP-DEV] PHP Package Management (WAS: Re: [PHP-DEV] Adding pecl/zip to 5.2)

2006-07-23 Thread Marco
I think its important to understand why shared hosts dont like PECL. Some of the main reasons IME is that they 1. Dont know the author of the package 2. Dont trust the package to be secure 3. Dont know if the package will have a knock of effect on server stability. They know the core package an

[PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.c rfc1867.h

2006-07-23 Thread Derick Rethans
On Sun, 23 Jul 2006, Stefan Esser wrote: > Antony, > > So this is the reason you think you can break the upcoming release now? > > Please revert it, as I don't want to see yet another broken release > > just because you decided you can do what you want. > Instead of bothering me with your opinion

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.crfc1867.h

2006-07-23 Thread Lukas Smith
Hi Stefan, I will put rfc1867 updating on my PHP6 todo list so in case it somehow is forgotten I can try to remind you. As for PHP 5.2 the key question is if you deem this production ready and also if Ilia thinks its still in time to add this. From the words you used I think it sounded a lot

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.crfc1867.h

2006-07-23 Thread Pierre
On 7/23/06, Michael Wallner <[EMAIL PROTECTED]> wrote: Stefan Esser wrote: > Antony, > > grow up. > > Stefan If you'd be grown up yourself, you would just commit to HEAD instead of spending time on meaningless insults. Mikael, besides the (now common) bad words, I see no problem with working

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.crfc1867.h

2006-07-23 Thread Stefan Esser
> If you'd be grown up yourself, you would just commit to HEAD instead > of spending time on meaningless insults. Commiting to HEAD is not possible. How often do I have to tell that. Because of the unicode changes the patch has to be majorly rewritten. Additionally it is simply impossible to commi

Re: [PHP-DEV] [PATCH] number_format enhancements

2006-07-23 Thread Matt W
Hi, - Original Message - From: "bertrand Gugger" Sent: Saturday, July 22, 2006 > Bonsoir Matt, > Matt W wrote: > > Hi, > > > > Haven't heard any opinions on these functionality changes... (Though I know > > more significant things keep you busy!) > > > > Do many other people use number_

Re: [PHP-DEV] [v][sf]printf additions (#, E, g, G)

2006-07-23 Thread Matt W
Hi Gwynne, - Original Message - From: "Gwynne" Sent: Saturday, July 22, 2006 > On Jul 20, 2006, at 3:21 PM, Marcus Boerger wrote: > >> I've wished there was a *printf() float specifier that wouldn't > >> include > >> trailing zeros/point, as simply converting to string (echo, %s, > >> e

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.crfc1867.h

2006-07-23 Thread Michael Wallner
Stefan Esser wrote: Antony, grow up. Stefan If you'd be grown up yourself, you would just commit to HEAD instead of spending time on meaningless insults. -- Michael -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.c rfc1867.h

2006-07-23 Thread Stefan Esser
Antony, grow up. Stefan -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Optimizing add_assoc_* with static keys (WAS: Re: [PHP-DEV] [PATCH] array_combine is not binary-key safe)

2006-07-23 Thread Matt W
Hi Richard, Andrei, Hold on about a patch to optimize add_assoc_* and hard-coded keys. I just finished some testing to see what difference it makes: none! :-) Compilers must optimize strlen("static string") to the literal value; at least VC++ Express does. Using a dynamic string from estrdup(),

[PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.c rfc1867.h

2006-07-23 Thread Antony Dovgal
On 23.07.2006 11:16, Stefan Esser wrote: Antony, So this is the reason you think you can break the upcoming release now? Please revert it, as I don't want to see yet another broken release just because you decided you can do what you want. Instead of bothering me with your opinion Please stop

[PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.c rfc1867.h

2006-07-23 Thread Stefan Esser
Antony, > So this is the reason you think you can break the upcoming release now? > Please revert it, as I don't want to see yet another broken release > just because you decided you can do what you want. Instead of bothering me with your opinion have a look at my code and tell me where it is broke