I reviewed the code and as far as I can tell it works fine. Certainly, some sort of an earlier courtesy notice to the RM would've been nice, but as Rasmus said this is till before RC1, so do I don't see a problem with the patch's inclusion. That said, if it becomes apparent that the code does not work properly before we go for RC2, I will revert the patch and we can consider it for the next 5.X release.

Ilia Alshanetsky




Reply via email to