[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: fix heap overflow in e1000_set_eeprom

ael Wessel Signed-off-by: Vitaly Lifshits --- drivers/net/ethernet/intel/e1000e/ethtool.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c index 9364bc2b4eb1..a9f5ff047544 100644 --- a/drivers/ne

[Intel-wired-lan] [PATCH iwl-net v2 1/1] igc: disable L1.2 PCI-E link substate to avoid performance issue

, disable the L1.2 substate. The increased power draw between L1.1 and L1.2 is insignificant. Link: https://lore.kernel.org/intel-wired-lan/15248b4f-3271-42dd-8e35-02bfc92b2...@intel.com Signed-off-by: Vitaly Lifshits Fixes: 43546211738e ("igc: Add new device ID's") --- drivers/net

[Intel-wired-lan] [PATCH iwl-net v1 1/1] igc: disable L1.2 PCI-E link substate to avoid performance issue

, disable the L1.2 substate during both probe and resume flows. Link: https://lore.kernel.org/intel-wired-lan/15248b4f-3271-42dd-8e35-02bfc92b2...@intel.com Signed-off-by: Vitaly Lifshits Fixes: 43546211738e ("igc: Add new device ID's") --- drivers/net/ethernet/intel/igc/igc_main

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: set fixed clock frequency indication for Nahum 11 and Nahum 13

. Since the XTAL clock on these systems always runs at 38.4MHz, the driver may ignore the STRAP and just set the correct value. Fixes: cc23f4f0b6b9 ("e1000e: Add support for Meteor Lake") Signed-off-by: Vitaly Lifshits --- drivers/net/ethernet/intel/e1000e/netdev.c | 14 +++--- d

[Intel-wired-lan] [PATCH iwl-net v4 1/1] e1000e: change k1 configuration on MTP and later platforms

idle state (K1) parameters during device initialization. Hardware reset reverts this configuration, therefore it needs to be applied in a few places. Fixes: cc23f4f0b6b9 ("e1000e: Add support for Meteor Lake") Signed-off-by: Vitaly Lifshits --- v4: fix a typo v3: refactor code to avoid

[Intel-wired-lan] [PATCH iwl-net v3 1/1] e1000e: change k1 configuration on MTP and later platforms

idle state (K1) parameters during device initialization. Hardware reset reverts this configuration, therefore it needs to be applied in a few places. Fixes: cc23f4f0b6b9 ("e1000e: Add support for Meteor Lake") Signed-off-by: Vitaly Lifshits --- v3: refactor code to avoid edge case

[Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: change k1 configuration on MTP and later platforms

the Kumeran idle state (K1) parameters during device initialization. Hardware reset reverts this configuration, therefore it needs to be applied in a few places. Fixes: cc23f4f0b6b9 ("e1000e: Add support for Meteor Lake") Signed-off-by: Vitaly Lifshits --- drivers/net/ethernet/in

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: change k1 exit timeout on MTP and later platforms

timeout is reverted during the hardware reset, thus, it is required to be called in a few places. Fixes: cc23f4f0b6b9 ("e1000e: Add support for Meteor Lake") Signed-off-by: Vitaly Lifshits --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 78 +++-- drivers/net/ethernet/in

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: Remove Meteor Lake SMBUS workarounds

g system resume flow. Therefore, its functional impact is low, and the priority is given to stabilizing runtime suspend. Fixes: 76a0a3f9cc2f ("e1000e: fix force smbus during suspend flow") Signed-off-by: Vitaly Lifshits --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 17 - 1 fil

[Intel-wired-lan] [PATCH iwl-next v1 1/1] igc: remove autoneg parameter from igc_mac_info

on pointer, phy.ops.force_speed_duplex. Therefore, remove this parameter from the igc code. Signed-off-by: Vitaly Lifshits --- drivers/net/ethernet/intel/igc/igc_diag.c| 3 +- drivers/net/ethernet/intel/igc/igc_ethtool.c | 13 +- drivers/net/ethernet/intel/igc/igc_hw.h | 1 - drivers/net/ethe

[Intel-wired-lan] [PATCH iwl-net v3 1/1] e1000e: change I219 (19) devices to ADP

correctly reflect the LAN hardware, and flows, of these devices. Fixes: db2d737d63c5 ("e1000e: Separate MTP board type from ADP") Signed-off-by: Vitaly Lifshits --- v3: add an example to affected flows v2: elaborate on the meanings of this change v1: initial version --- drivers/net/ethe

Re: [Intel-wired-lan] [PATCH v1 net-next] e1000e: Remove duplicated writel() in e1000_configure_tx/rx()

On 9/4/2024 3:13 PM, Andrew Lunn wrote: On Wed, Sep 04, 2024 at 02:56:46PM +0900, Takamitsu Iwai wrote: So you have confirmed with the datsheet that the write is not needed? As i said, this is a hardware register, not memory. Writes are not always idempotent. It might be necessary to write it

[Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: change I219 (19) devices to ADP

hardware, and flows, of these devices. Fixes: db2d737d63c5 ("e1000e: Separate MTP board type from ADP") Signed-off-by: Vitaly Lifshits --- v2: elaborate on the meanings of this change v1: initial version --- drivers/net/ethernet/intel/e1000e/hw.h | 4 ++-- drivers/net/ethernet/intel/e1000

Re: [Intel-wired-lan] ACPI IRQ storm with 6.10

On 8/22/2024 11:33 AM, Petr Valenta wrote: Dne 22. 08. 24 v 9:44 Petr Valenta napsal(a): Dne 21. 08. 24 v 17:17 Vitaly Lifshits napsal(a): On 8/21/2024 5:59 PM, Bjorn Helgaas wrote: [+to Dima, Vitaly, Hui; beginning of thread at https://lore.kernel.org/r/60ac8988-ace4-4cf0-8c44

Re: [Intel-wired-lan] ACPI IRQ storm with 6.10

On 8/21/2024 5:59 PM, Bjorn Helgaas wrote: [+to Dima, Vitaly, Hui; beginning of thread at https://lore.kernel.org/r/60ac8988-ace4-4cf0-8c44-028ca741c...@kernel.org] On Wed, Aug 21, 2024 at 01:39:11PM +0200, Petr Valenta wrote: Dne 20. 08. 24 v 23:30 Bjorn Helgaas napsal(a): On Tue, Aug 20, 20

Re: [Intel-wired-lan] ACPI IRQ storm with 6.10

On 8/21/2024 8:09 AM, Jiri Slaby wrote: On 20. 08. 24, 23:30, Bjorn Helgaas wrote: On Tue, Aug 20, 2024 at 11:13:54PM +0200, Petr Valenta wrote: Dne 20. 08. 24 v 20:09 Bjorn Helgaas napsal(a): On Mon, Aug 19, 2024 at 07:23:42AM +0200, Jiri Slaby wrote: On 19. 08. 24, 6:50, Jiri Slaby wrote:

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: change I219 (19) devices to ADP

Change the MAC and board types of I219 (19) devices from MTP to ADP. These devices have hardware more closely related to ADP than MTP. Fixes: db2d737d63c5 ("e1000e: Separate MTP board type from ADP") Signed-off-by: Vitaly Lifshits --- drivers/net/ethernet/intel/e1000e/hw.h | 4 ++-

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: avoid failing the system during pm_suspend

Ruinskiy Signed-off-by: Vitaly Lifshits Link: https://bugzilla.kernel.org/show_bug.cgi?id=205015 --- drivers/net/ethernet/intel/e1000e/netdev.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet

[Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: fix force smbus during suspend flow

anges to Meteor Lake platforms only. Fixes: bfd546a552e1 ("e1000e: move force SMBUS near the end of enable_ulp function") Reported-by: Todd Brandt Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218940 Reported-by: Dieter Mummenschanz Closes: https://bugzilla.kernel.org/show_bug.cgi?i

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: fix force smbus during suspend flow

to fix the secondary regression, by limiting the scope of the changes in that commit to Meteor Lake platforms only. Fixes: bfd546a552e1 ("e1000e: move force SMBUS near the end of enable_ulp function") Signed-off-by: Vitaly Lifshits Link: https://bugzilla.kernel.org/show_bug.cgi?id=218940 ---

[Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: Fix S0ix residency on corporate systems

platforms as well. Fixes: cc23f4f0b6b9 ("e1000e: Add support for Meteor Lake") Signed-off-by: Dima Ruinskiy Signed-off-by: Vitaly Lifshits Link: https://bugzilla.kernel.org/show_bug.cgi?id=218589 --- v2: fixed typos and added a link to a bug report v1: initial version --- drivers/ne

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: Fix S0ix residency on Meteor Lake corporate systems

f-by: Dima Ruinskiy Signed-off-by: Vitaly.Lifshits Signed-off-by: Vitaly Lifshits --- drivers/net/ethernet/intel/e1000e/netdev.c | 132 ++--- 1 file changed, 66 insertions(+), 66 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000

[Intel-wired-lan] [PATCH iwl-next v1 1/1] igc: add support for ethtool.set_phys_id

igc_defines.h where they can be included by all of the igc module files. Signed-off-by: Vitaly Lifshits Signed-off-by: Menachem Fogel --- drivers/net/ethernet/intel/igc/igc_defines.h | 22 ++ drivers/net/ethernet/intel/igc/igc_ethtool.c | 32 drivers/net/ethernet/intel/igc

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: change usleep_range to udelay in PHY mdic access

e usage of usleep_range in an atomic content while trying to access the PHY. Change back the usleep_range calls to udelay. Fixes: 6dbdd4de0362 ("e1000e: Workaround for sporadic MDI error on Meteor Lake systems") Co-developed-by: Sasha Neftin Signed-off-by: Sasha Neftin Signed-off

[Intel-wired-lan] [PATCH RESEND iwl-net v2 1/1] e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue

the interface to settle and avoids adding a delay. Fixes: 6607c99e7034 ("e1000e: i219 - fix to enable both ULP and EEE in Sx state") Signed-off-by: Vitaly Lifshits Co-developed-by: Dima Ruinskiy Signed-off-by: Dima Ruinskiy --- v2: address community review v1: initial version --- d

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue

i219 - fix to enable both ULP and EEE in Sx state") Signed-off-by: Vitaly Lifshits Co-developed-by: Dima Ruinskiy Signed-off-by: Dima Ruinskiy --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 19 --- drivers/net/ethernet/intel/e1000e/netdev.c | 18 ++ 2 fil

[Intel-wired-lan] [PATH iwl-next v2 1/1] e1000e: Minor flow correction in e1000_shutdown function

Add curly braces to avoid entering to an if statement where it is not always required in e1000_shutdown function. This improves code readability and might prevent a non-deterministic behaviour in the future. Signed-off-by: Vitaly Lifshits --- v2: fix commit message v1: initial version

[Intel-wired-lan] [PATCH iwl-net v4 1/1] e1000e: Workaround for sporadic MDI error on Meteor Lake systems

Signed-off-by: Nir Efrati Signed-off-by: Vitaly Lifshits --- v4: rebase to latest changes in dev-queue v3: rebase to dev-queue branch v2: fix checkpatch errors v1: initial version --- drivers/net/ethernet/intel/e1000e/hw.h | 2 + drivers/net/ethernet/intel/e1000e/ich8lan.c | 33 d

[Intel-wired-lan] [PATH iwl-next v1 1/1] e1000e: Minor flow correction in e1000_shutdown function

Added a missing curly braces to avoid entering to an if statement where it is not always required in e1000_shutdown function. This improves code readability and might prevent a non-deterministic behaviour in the future. Signed-off-by: Vitaly Lifshits --- drivers/net/ethernet/intel/e1000e

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: fix non-deterministic behavior in e1000_shutdown

code. Fixes: 74f350ee08e2 ("e1000e: Feature Enable PHY Ultra Low Power Mode (ULP)") Signed-off-by: Vitaly Lifshits --- drivers/net/ethernet/intel/e1000e/netdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/d

[Intel-wired-lan] [PATCH iwl-net v3 1/1] e1000e: Workaround for sporadic MDI error on Meteor Lake systems

Signed-off-by: Nir Efrati Signed-off-by: Vitaly Lifshits --- v3: rebase to dev-queue branch v2: fix checkpatch errors v1: initial version --- drivers/net/ethernet/intel/e1000e/hw.h | 2 + drivers/net/ethernet/intel/e1000e/ich8lan.c | 33 drivers/net/ethernet/intel/e1000e/phy.c

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: remove force SMBUS from ULP enable flow to avoid PHY loss issue

ned-off-by: Vitaly Lifshits Co-developed-by: Dima Ruinskiy Signed-off-by: Dima Ruinskiy --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 25 - 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethe

[Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: Workaround for sporadic MDI error on Meteor Lake systems

Signed-off-by: Nir Efrati Signed-off-by: Vitaly Lifshits --- v2: fix checkpatch errors v1: initial version --- drivers/net/ethernet/intel/e1000e/hw.h | 2 + drivers/net/ethernet/intel/e1000e/ich8lan.c | 33 drivers/net/ethernet/intel/e1000e/phy.c | 185 d

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: Workaround for sporadic MDI error on Meteor Lake systems

Signed-off-by: Nir Efrati Signed-off-by: Vitaly Lifshits --- drivers/net/ethernet/intel/e1000e/hw.h | 2 + drivers/net/ethernet/intel/e1000e/ich8lan.c | 33 drivers/net/ethernet/intel/e1000e/phy.c | 186 drivers/net/ethernet/intel/e1000e/phy.h | 2