u Chan
Closes:
https://lore.kernel.org/intel-wired-lan/20231208031950.47410-1-chen...@kylinos.cn/
Reported-by: Wang Haoran
Closes:
https://lore.kernel.org/all/CANZ3JQRRiOdtfQJoP9QM=6LS1Jto8PGBGw6y7-TL=bcnzhq...@mail.gmail.com/
Reported-by: Amir Mohammad Jahangirzad
Closes:
https://lore.kernel.org/all/20250722115017.206969-1-a.jahangir...@gmail.com/
Signed-off-by: Jacob Keller
Reviewed-by: Dawid Osuchowski
Thanks,
Dawid
;
u16 msg_enable;
- /* Interrupt Throttle Rate */
- u32 eitr_param;
struct ixgbevf_hw_stats stats;
Reviewed-by: Dawid Osuchowski
Thanks,
Dawid
On 2025-05-22 9:01 AM, Paul Menzel wrote:
Dear Dawid,
Am 19.05.25 um 13:11 schrieb Dawid Osuchowski:
On 2025-05-16 10:57 PM, Paul Menzel wrote:
Am 14.05.25 um 12:46 schrieb Dawid Osuchowski:
E835 is an enhanced version of the E830.
It continues to use the same set of commands, registers and
rface.
Co-developed-by: Martyna Szapar-Mudlaw
Signed-off-by: Martyna Szapar-Mudlaw
Reviewed-by: Michal Swiatkowski
Signed-off-by: Dawid Osuchowski
---
Based on series [1] from Martyna where this was implemented for ixgbe
and ice drivers.
[1]
https://lore.kernel.org/netdev/20250515105011.1310
(R) Ethernet Controller E835-L for QSFP
- 0x1267: Intel(R) Ethernet Controller E835-L for SFP
Reviewed-by: Konrad Knitter
Reviewed-by: Simon Horman
Signed-off-by: Dawid Osuchowski
---
v2 changes:
- v1:
https://lore.kernel.org/netdev/20250514104632.331559-1-dawid.osuchow...@linux.intel.com
On 2025-05-16 10:57 PM, Paul Menzel wrote:
Am 14.05.25 um 12:46 schrieb Dawid Osuchowski:
E835 is an enhanced version of the E830.
It continues to use the same set of commands, registers and interfaces
as other devices in the 800 Series.
Following device IDs are added:
- 0x1248: Intel(R
On 2025-05-16 7:30 PM, Tony Nguyen wrote:
On 5/14/2025 3:46 AM, Dawid Osuchowski wrote:
diff --git a/drivers/net/ethernet/intel/ice/ice_devids.h b/drivers/
net/ethernet/intel/ice/ice_devids.h
index 34fd604132f5..7761c3501174 100644
--- a/drivers/net/ethernet/intel/ice/ice_devids.h
+++ b
(R) Ethernet Controller E835-L for QSFP
- 0x1267: Intel(R) Ethernet Controller E835-L for SFP
Reviewed-by: Konrad Knitter
Signed-off-by: Dawid Osuchowski
---
drivers/net/ethernet/intel/ice/ice_common.c | 9 +
drivers/net/ethernet/intel/ice/ice_devids.h | 18 ++
drivers
On 2025-05-13 3:31 PM, Zilin Guan wrote:
If this change is required, should I submit it as a new standalone patch,
or include it in a v2 of the existing patch series?
I think you could include it with the v2, as it touches the same stack
SA structs (if you decide to reuse memzero_explicit() on
On 2025-05-13 2:24 PM, Zilin Guan wrote:
OK, I will resend the patch to the iwl-net branch and include the Fixes
tag. Before I do that, I noticed that in ixgbe_ipsec_add_sa() we clear
the Tx SA struct with memset 0 on key-parsing failure but do not clear
the Rx SA struct in the corresponding erro
a));
As for the code change itself, LGTM.
Acked-by: Dawid Osuchowski
Thanks,
Dawid
return ret;
}
On 2025-04-29 5:52 PM, Maciej Fijalkowski wrote:
Currently ixgbe driver checks periodically in its watchdog subtask if
there is anything to be transmitted (consdidering both Tx and XDP rings)
typo: s/consdidering/considering
under state of carrier not being 'ok'. Such event is interpreted as
On 2025-04-17 3:24 PM, Thomas Weißschuh wrote:
acquire sleeping looks in atomic contexts.
typo? s/sleeping looks/sleeping locks/
present in patch descriptions as well
ethtool support")
Suggested-by: Jakub Kicinski
Reviewed-by: Igor Bagnucki
Signed-off-by: Dawid Osuchowski
---
Changes since v1:
* Changed Fixes tag to point to another commit
* Minified the stacktrace
Changes since v2:
* Moved netif_device_attach() directly into ice_rebuild() and perform
On 21.08.2024 08:22, Maciej Fijalkowski wrote:
On Tue, Aug 20, 2024 at 06:15:24PM +0200, Dawid Osuchowski wrote:
@@ -7591,6 +7594,7 @@ static void ice_rebuild(struct ice_pf *pf, enum
ice_reset_req reset_type)
{
struct device *dev = ice_pf_to_dev(pf);
struct ice_hw *hw = &am
ethtool support")
Suggested-by: Jakub Kicinski
Reviewed-by: Igor Bagnucki
Signed-off-by: Dawid Osuchowski
---
Changes since v1:
* Changed Fixes tag to point to another commit
* Minified the stacktrace
Changes since v2:
* Moved netif_device_attach() directly into ice_rebuild() and perform
On 19.08.2024 10:47, Przemek Kitszel wrote:
On 8/19/24 10:21, Dawid Osuchowski wrote:
@@ -7731,6 +7733,10 @@ static void ice_rebuild(struct ice_pf *pf, enum
ice_reset_req reset_type)
ice_rebuild_arfs(pf);
}
+ struct ice_vsi *vsi = ice_get_main_vsi(pf);
you should separate
ethtool support")
Suggested-by: Jakub Kicinski
Reviewed-by: Igor Bagnucki
Signed-off-by: Dawid Osuchowski
---
Changes since v1:
* Changed Fixes tag to point to another commit
* Minified the stacktrace
Changes since v2:
* Moved netif_device_attach() directly into ice_rebuild() and perform
On 13.08.2024 21:24, Maciej Fijalkowski wrote:
On Tue, Aug 13, 2024 at 05:31:37PM +0200, Dawid Osuchowski wrote:
On 13.08.2024 13:49, Maciej Fijalkowski wrote:
What about other intel drivers tho?
I have not performed detailed analysis of other intel ethernet drivers in
this regard, but it is
On 14.08.2024 05:19, Kalesh Anakkur Purayil wrote:
On Mon, Aug 12, 2024 at 3:52 PM Dawid Osuchowski
wrote:
@@ -7568,11 +7570,13 @@ static void ice_update_pf_netdev_link(struct ice_pf *pf)
ice_get_link_status(pf->vsi[i]->port_info, &link_up);
i
On 13.08.2024 13:49, Maciej Fijalkowski wrote:
What about other intel drivers tho?
I have not performed detailed analysis of other intel ethernet drivers
in this regard, but it is surely a topic worth investigating.
--Dawid
ethtool support")
Suggested-by: Jakub Kicinski
Signed-off-by: Dawid Osuchowski
Reviewed-by: Igor Bagnucki
---
Changes since v1:
* Changed Fixes tag to point to another commit
* Minified the stacktrace
Suggestion from Kuba:
https://lore.kernel.org/netdev/20240610194756.5be5b...@kernel.
On 12.08.2024 12:22, Dawid Osuchowski wrote:
Ethtool callbacks can be executed while reset is in progress and try to
access deleted resources, e.g. getting coalesce settings can result in a
NULL pointer dereference seen below.
Please disregard this submission, I have been made aware of
+0.000271] RIP: 0033:0x7faee60d8e27
Fixes: 67fe64d78c43 ("ice: Implement getting and setting ethtool coalesce")
Suggested-by: Jakub Kicinski
Signed-off-by: Dawid Osuchowski
Reviewed-by: Igor Bagnucki
---
drivers/net/ethernet/intel/ice/ice_main.c | 4
1 file changed, 4 insertio
On 22.07.2024 16:35, Paul Menzel wrote:
Maybe "Add netif_device_attach/detach" would be the best for this, as
the attaching and detaching doesn't happen only during reset.
I’d consider it too generic and would mention the place. But if it’s not
possible, then it’s not. Maybe:
Attach/detach
uld be the best for this, as
the attaching and detaching doesn't happen only during reset.
Am 22.07.24 um 14:28 schrieb Dawid Osuchowski:
Ethtool callbacks can be executed while reset is in progress and try to
access deleted resources, e.g. getting coalesce settings can result in a
NULL
0d8e27
Fixes: 67fe64d78c43 ("ice: Implement getting and setting ethtool coalesce")
Suggested-by: Jakub Kicinski
Signed-off-by: Dawid Osuchowski
Reviewed-by: Alexander Lobakin
---
drivers/net/ethernet/intel/ice/ice_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/et
On 11.06.2024 04:47, Jakub Kicinski wrote:
Why does the reset not call netif_device_detach()?
Then core will know not to call the driver.
Will use this approach in new patch, thanks.
--Dawid
hang time of the timeout value.
Fixes: 67fe64d78c43 ("ice: Implement getting and setting ethtool coalesce")
Signed-off-by: Ngai-Mint Kwan
Reviewed-by: Mateusz Polchlopek
Signed-off-by: Pawel Chmielewski
Reviewed-by: Simon Horman
Signed-off-by: Dawid Osuchowski
---
Changes since v
On 09.05.2024 18:11, Tony Nguyen wrote:
Seems like commit message, and probably title, need to get updated for
this change?
During testing of the change, it turns out at the current state our
driver is in we have to use the approach with returning -EBUSY. Will
update the description in v5 to
y: Mateusz Polchlopek
Signed-off-by: Pawel Chmielewski
Reviewed-by: Simon Horman
Co-developed-by: Dawid Osuchowski
Signed-off-by: Dawid Osuchowski
---
Changes since v1:
* Added "Fixes:" tag
Changes since v2:
* Rebased over current IWL net branch
* Confirmed that the issue previously report
y: Mateusz Polchlopek
Signed-off-by: Pawel Chmielewski
Reviewed-by: Simon Horman
Signed-off-by: Dawid Osuchowski
---
Changes since v1:
* Added "Fixes:" tag
Changes since v2:
* Rebased over current IWL net branch
* Confirmed that the issue previously reported for this patch [1] by
Himasekhar Re
32 matches
Mail list logo
