On 22.07.2024 16:35, Paul Menzel wrote:
Maybe "Add netif_device_attach/detach" would be the best for this, as the attaching and detaching doesn't happen only during reset.

I’d consider it too generic and would mention the place. But if it’s not possible, then it’s not. Maybe:

Attach/detach device before starting/stopping queues


Okay, will wait for some more feedback from other folks, maybe they'll have some input about the naming of the title as well.

Once the driver is fully initialized:
# echo 1 > /sys/class/net/ens1f0np0/device/reset
and then once that is in progress, from another terminal:
# ethtool -c ens1f0np0

Would you like me to include those in the commit message as well?

I’d find it helpful, but I am no maintainer.

I will include it in the commit message.


Kind regards,

Paul

--Dawid

Reply via email to