On 22.07.2024 14:37, Paul Menzel wrote:
Dear Dawid,
Thank you for your patch.
Introduce … into
sounds a little strange to me. Maybe:
> Attach to device in reset flow
or just
> Add netif_device_attach/detach
> Serialize …
Maybe "Add netif_device_attach/detach" would be the best for this, as
the attaching and detaching doesn't happen only during reset.
Am 22.07.24 um 14:28 schrieb Dawid Osuchowski:
Ethtool callbacks can be executed while reset is in progress and try to
access deleted resources, e.g. getting coalesce settings can result in a
NULL pointer dereference seen below.
What command did you execute?
Once the driver is fully initialized:
# echo 1 > /sys/class/net/ens1f0np0/device/reset
and then once that is in progress, from another terminal:
# ethtool -c ens1f0np0
Would you like me to include those in the commit message as well?
--Dawid
