Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix max values for dpll pin phase adjust

2024-11-26 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of > Arkadiusz Kubalewski > Sent: 20 November 2024 13:21 > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Kubalewski, Arkadiusz > ; Kitszel, Przemyslaw > > Subject: [Intel-wired-lan] [PATCH iwl-net] ice: fix max

Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix incorrect PHY settings for 100 GB/s

2024-11-26 Thread Andrew Lunn
On Tue, Nov 26, 2024 at 11:23:11AM +0100, Przemyslaw Korba wrote: > ptp4l application reports too high offset when ran on E823 device > with a 100GB/s link. Those values cannot go under 100ns, like in a > PTP working case when using 100 GB/s cable. > This is due to incorrect frequency settings on t

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS cef3450b7554872344aa4679940972a6f59af285

2024-11-26 Thread kernel test robot
haps_hs_smp_defconfiggcc-14.2.0 archsdk_defconfiggcc-14.2.0 arc randconfig-001-20241126gcc-14.2.0 arc randconfig-002-20241126gcc-14.2.0 arcvdk_hs38_defconfiggcc-14.2.0 arm

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS be9bc5f29544142931d3958e972623a1db595af4

2024-11-26 Thread kernel test robot
allnoconfigclang-20 hexagon allyesconfigclang-20 i386buildonly-randconfig-001-20241126gcc-12 i386buildonly-randconfig-002-20241126gcc-12 i386buildonly-randconfig-003-20241126clang-19 i386buildonly-randconfig-003-20241126gcc

Re: [Intel-wired-lan] [PATCH iwl-net 2/2] idpf: trigger SW interrupt when exiting wb_on_itr mode

2024-11-26 Thread Alexander Lobakin
From: Joshua Hay Date: Mon, 25 Nov 2024 15:58:55 -0800 > There is a race condition between exiting wb_on_itr and completion write > backs. For example, we are in wb_on_itr mode and a Tx completion is > generated by HW, ready to be written back, as we are re-enabling > interrupts: > > HW

Re: [Intel-wired-lan] [PATCH v2 iwl-next 08/10] idpf: add Tx timestamp flows

2024-11-26 Thread Vadim Fedorenko
On 26/11/2024 03:58, Milena Olech wrote: Add functions to request Tx timestamp for the PTP packets, read the Tx timestamp when the completion tag for that packet is being received, extend the Tx timestamp value and set the supported timestamping modes. Tx timestamp is requested for the PTP packe

[Intel-wired-lan] [PATCH v2 iwl-next 00/10] add initial PTP support

2024-11-26 Thread Milena Olech
This patch series introduces support for Precision Time Protocol (PTP) to Intel(R) Infrastructure Data Path Function (IDPF) driver. PTP feature is supported when the PTP capability is negotiated with the Control Plane (CP). IDPF creates a PTP clock and sets a set of supported functions. During the

[Intel-wired-lan] [PATCH v2 iwl-next 02/10] virtchnl: add PTP virtchnl definitions

2024-11-26 Thread Milena Olech
PTP capabilities are negotiated using virtchnl commands. There are two available modes of the PTP support: direct and mailbox. When the direct access to PTP resources is negotiated, virtchnl messages returns a set of registers that allow read/write directly. When the mailbox access to PTP resources

[Intel-wired-lan] [PATCH v2 iwl-next 07/10] idpf: add Tx timestamp capabilities negotiation

2024-11-26 Thread Milena Olech
Tx timestamp capabilities are negotiated for the uplink Vport. Driver receives information about the number of available Tx timestamp latches, the size of Tx timestamp value and the set of indexes used for Tx timestamping. Add function to get the Tx timestamp capabilities and parse the uplink vpor

[Intel-wired-lan] [PATCH v2 iwl-next 08/10] idpf: add Tx timestamp flows

2024-11-26 Thread Milena Olech
Add functions to request Tx timestamp for the PTP packets, read the Tx timestamp when the completion tag for that packet is being received, extend the Tx timestamp value and set the supported timestamping modes. Tx timestamp is requested for the PTP packets by setting a TSYN bit and index value in

[Intel-wired-lan] [PATCH v2 iwl-next 05/10] idpf: add mailbox access to read PTP clock time

2024-11-26 Thread Milena Olech
When the access to read PTP clock is specified as mailbox, the driver needs to send virtchnl message to perform PTP actions. Message is sent using idpf_mbq_opc_send_msg_to_peer_drv mailbox opcode, with the parameters received during PTP capabilities negotiation. Add functions to recognize PTP mess

[Intel-wired-lan] [PATCH v2 iwl-next 10/10] idpf: change the method for mailbox workqueue allocation

2024-11-26 Thread Milena Olech
Since workqueues are created per CPU, the works scheduled to this workqueues are run on the CPU they were assigned. It may result in overloaded CPU that is not able to handle virtchnl messages in relatively short time. Allocating workqueue with WQ_UNBOUND and WQ_HIGHPRI flags allows scheduler to qu

[Intel-wired-lan] [PATCH v2 iwl-next 09/10] idpf: add support for Rx timestamping

2024-11-26 Thread Milena Olech
Add Rx timestamp function when the Rx timestamp value is read directly from the Rx descriptor. In order to extend the Rx timestamp value to 64 bit in hot path, the PHC time is cached in the receive groups. Add supported Rx timestamp modes. Reviewed-by: Alexander Lobakin Signed-off-by: Milena Olec

[Intel-wired-lan] [PATCH v2 iwl-next 06/10] idpf: add PTP clock configuration

2024-11-26 Thread Milena Olech
PTP clock configuration operations - set time, adjust time and adjust frequency are required to control the clock and maintain synchronization process. Extend get PTP capabilities function to request for the clock adjustments and add functions to enable these actions using dedicated virtchnl messa

[Intel-wired-lan] [PATCH v2 iwl-next 03/10] idpf: move virtchnl structures to the header file

2024-11-26 Thread Milena Olech
Move virtchnl structures to the header file to expose them for the PTP virtchnl file. Reviewed-by: Alexander Lobakin Reviewed-by: Willem de Bruijn Signed-off-by: Milena Olech --- v1 -> v2: fix commit message title .../net/ethernet/intel/idpf/idpf_virtchnl.c | 86 +-- .../net

[Intel-wired-lan] [PATCH v2 iwl-next 04/10] idpf: negotiate PTP capabilities and get PTP clock

2024-11-26 Thread Milena Olech
PTP capabilities are negotiated using virtchnl command. Add get capabilities function, direct access to read the PTP clock time and direct access to read the cross timestamp - system time and PTP clock time. Set initial PTP capabilities exposed to the stack. Reviewed-by: Alexander Lobakin Tested-

[Intel-wired-lan] [PATCH v2 iwl-next 01/10] idpf: add initial PTP support

2024-11-26 Thread Milena Olech
PTP feature is supported if the VIRTCHNL2_CAP_PTP is negotiated during the capabilities recognition. Initial PTP support includes PTP initialization and registration of the clock. Reviewed-by: Alexander Lobakin Reviewed-by: Vadim Fedorenko Reviewed-by: Willem de Bruijn Signed-off-by: Milena Ole

Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix incorrect PHY settings for 100 GB/s

2024-11-26 Thread Paul Menzel
Dear Przemyslaw, Thank you for your patch. Am 26.11.24 um 11:23 schrieb Przemyslaw Korba: ptp4l application reports too high offset when ran on E823 device with a 100GB/s link. Those values cannot go under 100ns, like in a PTP working case when using 100 GB/s cable. This is due to incorrect f

[Intel-wired-lan] [PATCH iwl-net] ice: fix incorrect PHY settings for 100 GB/s

2024-11-26 Thread Przemyslaw Korba
ptp4l application reports too high offset when ran on E823 device with a 100GB/s link. Those values cannot go under 100ns, like in a PTP working case when using 100 GB/s cable. This is due to incorrect frequency settings on the PHY clocks for 100 GB/s speed. Changes are introduced to align with the