On Wed, 3 Apr 2024 09:19:20 -0400 Mateusz Polchlopek wrote:
> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> @@ -145,6 +145,7 @@ int iavf_send_vf_config_msg(struct iavf_adapter *adapter)
> VIRTCHNL_VF_OFFLOAD_CRC |
>
On Wed, 3 Apr 2024 12:19:57 +0200 Wojciech Drewek wrote:
> You're saying that if min_pwr_allowed or max_pwr_allowed taken from get op
> are 0 than we should not allow to set max_pwr_reset and max_pwr_set?
Yes, return -EOPNOTSUPP and point extack at whatever max_pwr attr user
sent. If driver doesn'
On 3/29/2024 9:09 AM, Karol Kolacinski wrote:
From: Sergey Temerkhanov
E825C products feature a new PHY model - ETH56G.
Introduces all necessary PHY definitions, functions etc. for ETH56G PHY,
analogous to E82X and E810 ones with addition of a few HW-specific
functionalities for ETH56G like
On 3/29/2024 9:09 AM, Karol Kolacinski wrote:
From: Jacob Keller
Add a new helper for getting base clock increment value for specific HW.
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
Reviewed-by: Arkadiusz Kubalewski
Signed-off-by: Karol Kolacinski
---
drivers/net/ethernet
On 3/29/2024 9:09 AM, Karol Kolacinski wrote:
From: Jacob Keller
Multiple places in the driver code need to convert enum ice_ptp_tmr_cmd
values into register bits for both the main timer and the PHY port
timers. The main MAC register has one bit scheme for timer commands,
while the PHY comma
On 3/29/2024 9:09 AM, Karol Kolacinski wrote:
...
@@ -1229,7 +1229,7 @@ static u64 ice_base_incval(struct ice_pf *pf)
*/
static int ice_ptp_check_tx_fifo(struct ice_ptp_port *port)
{
- int quad = port->port_num / ICE_PORTS_PER_QUAD;
+ int quad = ICE_GET_QUAD_NUM(port->port
On 4/2/2024 5:31 AM, Kolacinski, Karol wrote:
The only thing that changed between V1 and V4 was patch 07/12, which had
only minor changes and it has the changelog.
Should I also include which patches were changed in the cover letter?
Yes, please. It's nice to be able to see what changed wit
On Wed, Mar 27, 2024, at 16:23, Alexander Lobakin wrote:
> +static int pfcp_encap_recv(struct sock *sk, struct sk_buff *skb)
> +{
> + IP_TUNNEL_DECLARE_FLAGS(flags) = { };
> + struct metadata_dst *tun_dst;
> + struct pfcp_metadata *md;
> + struct pfcphdr *unparsed;
> + struct p
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Pavan Kumar Linga
> Sent: Wednesday, March 20, 2024 5:09 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Tantilov, Emil S ; Kitszel, Przemyslaw
> ; Hay, Joshua A ;
> Daniele, Salvatore ; Nemeth, Balazs
> ; Linga, Pavan Kumar
>
>
> > $ ethtool --set-module enp1s0f0np0 power-max-set 4000
> >
> > actually talk to the SFP module and tell it the maximum power it can
> > consume. So in this case, it is not the cage, but the module?
>
> It does not work that way in ice example.
> >
> > Or is it talking to some entity which is
On Wed, Apr 03, 2024 at 03:18:44PM +0200, Wojciech Drewek wrote:
>
>
> On 02.04.2024 16:46, Andrew Lunn wrote:
> > On Tue, Apr 02, 2024 at 01:38:59PM +0200, Wojciech Drewek wrote:
> >>
> >>
> >> On 30.03.2024 22:57, Andrew Lunn wrote:
> >>> On Fri, Mar 29, 2024 at 10:23:18AM +0100, Wojciech Drewe
From: Jacob Keller
Using VIRTCHNL_VF_OFFLOAD_FLEX_DESC, the iAVF driver is capable of
negotiating to enable the advanced flexible descriptor layout. Add the
flexible NIC layout (RXDID=2) as a member of the Rx descriptor union.
Also add bit position definitions for the status and error indication
From: Jacob Keller
Add handlers for the SIOCSHWTSTAMP and SIOCGHWTSTAMP ioctls which allow
userspace to request timestamp enablement for the device. This
support allows standard Linux applications to request the timestamping
desired.
As with other devices that support timestamping all packets, t
From: Jacob Keller
Add support for receive timestamps to the Rx hotpath. This support only
works when using the flexible descriptor format, so make sure that we
request this format by default if we have receive timestamp support
available in the PTP capabilities.
In order to report the timestamp
From: Jacob Keller
Implement support for reading the PHC time indirectly via the
VIRTCHNL_OP_1588_PTP_GET_TIME operation.
Based on some simple tests with ftrace, the latency of the indirect
clock access appears to be about ~110 microseconds. This is due to the
cost of preparing a message to send
Rx timestamping introduced in PF driver caused the need of refactoring
the VF driver mechanism to check packet fields.
The function to check errors in descriptor has been removed and from
now only previously set struct fields are being checked. The field DD
(descriptor done) needs to be checked at
From: Jacob Keller
The Rx timestamps reported by hardware may only have 32 bits of storage
for nanosecond time. These timestamps cannot be directly reported to the
Linux stack, as it expects 64bits of time.
To handle this, the timestamps must be extended using an algorithm that
calculates the co
From: Jacob Keller
Add a new extended capabilities negotiation to exchange information from
the PF about what PTP capabilities are supported by this VF. This
requires sending a VIRTCHNL_OP_1588_PTP_GET_CAPS message, and waiting
for the response from the PF. Handle this early on during the VF
init
From: Jacob Keller
Add the iavf_ptp.c file and fill it in with a skeleton framework to
allow registering the PTP clock device.
Add implementation of helper functions to check if a PTP capability
is supported and handle change in PTP capabilities.
Enabling virtual clock would be possible, though i
From: Jacob Keller
Enable support for VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC, to enable the VF
driver the ability to determine what Rx descriptor formats are
available. This requires sending an additional message during
initialization and reset, the VIRTCHNL_OP_GET_SUPPORTED_RXDIDS. This
operation requ
From: Simei Su
To support Rx timestamp offload, VIRTCHNL_OP_1588_PTP_CAPS is sent by
the VF to request PTP capability and responded by the PF what capability
is enabled for that VF.
Hardware captures timestamps which contain only 32 bits of nominal
nanoseconds, as opposed to the 64bit timestamps
From: Jacob Keller
Support for allowing VF to negotiate the descriptor format requires that
the VF specify which descriptor format to use when requesting Rx queues.
The VF is supposed to request the set of supported formats via the new
VIRTCHNL_OP_GET_SUPPORTED_RXDIDS, and then set one of the sup
From: Jacob Keller
Add support for allowing a VF to enable PTP feature - Rx timestamps
The new capability is gated by VIRTCHNL_VF_CAP_PTP, which must be
set by the VF to request access to the new operations. In addition, the
VIRTCHNL_OP_1588_PTP_CAPS command is used to determine the specific
cap
Add support for Rx timestamping for both ice and iavf drivers.
Initially, during VF creation it registers the PTP clock in
the system and negotiates with PF it's capabilities. In the
meantime the PF enables the Flexible Descriptor for VF.
Only this type of descriptor allows to receive Rx timestamp
On 02.04.2024 16:46, Andrew Lunn wrote:
> On Tue, Apr 02, 2024 at 01:38:59PM +0200, Wojciech Drewek wrote:
>>
>>
>> On 30.03.2024 22:57, Andrew Lunn wrote:
>>> On Fri, Mar 29, 2024 at 10:23:18AM +0100, Wojciech Drewek wrote:
Some ethernet modules use nonstandard power levels [1]. Extend eth
On 02.04.2024 16:34, Jakub Kicinski wrote:
> On Tue, 2 Apr 2024 13:25:07 +0200 Wojciech Drewek wrote:
>> On 29.03.2024 23:29, Jakub Kicinski wrote:
>>> On Fri, 29 Mar 2024 10:23:20 +0100 Wojciech Drewek wrote:
Some modules use nonstandard power levels. Adjust ethtool
module implement
From: Jakub Buchocki
Add support for 'flow-type ether' Flow Director rules via ethtool.
Create packet segment info for filter configuration based on ethtool
command parameters. Reuse infrastructure already created for
ipv4 and ipv6 flows to convert packet segment into
extraction sequence, which
Passing v6 argument is unnecessary as flow_type is still
analyzed inside the function.
Reviewed-by: Przemek Kitszel
Signed-off-by: Lukasz Plachno
Reviewed-by: Simon Horman
---
drivers/net/ethernet/intel/ice/ice_fdir.c | 85 +++
1 file changed, 39 insertions(+), 46 deletions
Ethtool allows creating rules with type=ether, add support for such
filters in ice driver.
Patch 1 allows extending ice_fdir_comp_rules() with handling additional
type of filters.
v8: Added check for vlan-etype when proto and vlan are specified,
vlan-etype is required by HW
v7: removed 0 initi
On 30.03.2024 23:14, Andrew Lunn wrote:
> On Fri, Mar 29, 2024 at 10:23:20AM +0100, Wojciech Drewek wrote:
>> Some modules use nonstandard power levels. Adjust ethtool
>> module implementation to support new attributes that will allow user
>> to change maximum power.
>>
>> Add three new get attr
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Michal Swiatkowski
> Sent: Monday, March 25, 2024 10:20 PM
> To: poros
> Cc: Drewek, Wojciech ;
> net...@vger.kernel.org; linux-ker...@vger.kernel.org;
> eduma...@google.com; Nguyen, Anthony L ;
> ho...@kernel.org; intel-wired-..
> -Original Message-
> From: Marcin Szycik
> Sent: Wednesday, April 3, 2024 11:21 AM
> To: Loktionov, Aleksandr ; intel-
> wired-...@lists.osuosl.org
> Cc: Drewek, Wojciech ; Wang, Liang-min
> ; net...@vger.kernel.org; Chmielewski,
> Pawel ; Nguyen, Anthony L
> ; ho...@kernel.org; Kitsze
On 03.04.2024 08:37, Loktionov, Aleksandr wrote:
>
>
>> -Original Message-
>> From: Intel-wired-lan On
>> Behalf Of Marcin Szycik
>> Sent: Tuesday, April 2, 2024 6:52 PM
>> To: intel-wired-...@lists.osuosl.org
>> Cc: Drewek, Wojciech ; Wang, Liang-min
>> ; net...@vger.kernel.org; Chmi
From: Michal Wilczynski
New driver specific parameter 'tx_scheduling_layers' was introduced.
Describe parameter in the documentation.
Signed-off-by: Michal Wilczynski
Acked-by: Jakub Kicinski
Reviewed-by: Jiri Pirko
Reviewed-by: Przemek Kitszel
Co-developed-by: Mateusz Polchlopek
Signed-off
From: Lukasz Czapnik
It was observed that Tx performance was inconsistent across all queues
and/or VSIs and that it was directly connected to existing 9-layer
topology of the Tx scheduler.
Introduce new private devlink param - tx_scheduling_layers. This parameter
gives user flexibility to choose
From: Michal Wilczynski
Introduce support for Tx scheduler topology change, based on user
selection, from default 9-layer to 5-layer.
Change requires NVM (version 3.20 or newer) and DDP package (OS Package
1.3.30 or newer - available for over a year in linux-firmware, since
commit aed71f296637 in
From: Raj Victor
There is a performance issue when the number of VSIs are not multiple
of 8. This is caused due to the max children limitation per node(8) in
9 layer topology. The BW credits are shared evenly among the children
by default. Assume one node has 8 children and the other has 1.
The p
From: Raj Victor
Adjust the VSI/Aggregator layers based on the number of logical layers
supported by the FW. Currently the VSI and Aggregator layers are
fixed based on the 9 layer scheduler tree layout. Due to performance
reasons the number of layers of the scheduler tree is changing from
9 to 5.
Extend devlink_param *set function pointer to take extack as a param.
Sometimes it is needed to pass information to the end user from set
function. It is more proper to use for that netlink instead of passing
message to dmesg.
Reviewed-by: Jiri Pirko
Reviewed-by: Przemek Kitszel
Signed-off-by: M
For performance reasons there is a need to have support for selectable
Tx scheduler topology. Currently firmware supports only the default
9-layer and 5-layer topology. This patch series enables switch from
default to 5-layer topology, if user decides to opt-in.
---
v9:
- rebased the code after de
On Wed Mar 27 2024, shenjian (K) wrote:
> 在 2024/3/26 21:34, Kurt Kanzenbach 写道:
>> Add support for offloading MQPRIO. The hardware has four priorities as well
>> as four queues. Each queue must be a assigned with a unique priority.
>>
>> However, the priorities are only considered in TSN Tx mode.
On Thu Mar 28 2024, Simon Horman wrote:
> On Tue, Mar 26, 2024 at 02:34:54PM +0100, Kurt Kanzenbach wrote:
>> Add support for offloading MQPRIO. The hardware has four priorities as well
>> as four queues. Each queue must be a assigned with a unique priority.
>>
>> However, the priorities are only
>-Original Message-
>From: Simon Horman
>Sent: Friday, March 29, 2024 7:28 PM
>To: Kwapulinski, Piotr
>Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Wegrzyn, Stefan
>; Jagielski, Jedrzej ;
>Michal Swiatkowski
>Subject: Re: [PATCH iwl-next v1 1/5] ixgbe: Add support for
43 matches
Mail list logo
