> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of > Pavan Kumar Linga > Sent: Wednesday, March 20, 2024 5:09 PM > To: intel-wired-...@lists.osuosl.org > Cc: Tantilov, Emil S <emil.s.tanti...@intel.com>; Kitszel, Przemyslaw > <przemyslaw.kits...@intel.com>; Hay, Joshua A <joshua.a....@intel.com>; > Daniele, Salvatore <sdani...@redhat.com>; Nemeth, Balazs > <bnem...@redhat.com>; Linga, Pavan Kumar > <pavan.kumar.li...@intel.com> > Subject: [Intel-wired-lan] [PATCH iwl-net] idpf: fix kernel panic on unknown > packet types > > From: Joshua Hay <joshua.a....@intel.com> > > In the very rare case where a packet type is unknown to the driver, > idpf_rx_process_skb_fields would return early without calling > eth_type_trans to set the skb protocol / the network layer handler. > This is especially problematic if tcpdump is running when such a > packet is received, i.e. it would cause a kernel panic. > > Instead, call eth_type_trans for every single packet, even when > the packet type is unknown. > > Fixes: 3a8845af66ed ("idpf: add RX splitq napi poll support") > Reported-by: Balazs Nemeth <bnem...@redhat.com> > Signed-off-by: Joshua Hay <joshua.a....@intel.com> > Reviewed-by: Jesse Brandeburg <jesse.brandeb...@intel.com> > Reviewed-by: Przemek Kitszel <przemyslaw.kits...@intel.com> > Tested-by: Salvatore Daniele <sdani...@redhat.com> > Signed-off-by: Pavan Kumar Linga <pavan.kumar.li...@intel.com> > --- > drivers/net/ethernet/intel/idpf/idpf_txrx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c > b/drivers/net/ethernet/intel/idpf/idpf_txrx.c > index 2f8ad79ae3f0..017a081d8580 100644 > --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c > +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
Tested-by: Krishneil Singh krishneil.k.si...@intel.com