Re: [Intel-gfx] [PATCH v2] drm/i915: Support Async Flip on Linear buffers

2022-06-14 Thread Murthy, Arun R
Any comments? Thanks and Regards, Arun R Murthy > -Original Message- > From: Murthy, Arun R > Sent: Wednesday, June 1, 2022 9:54 AM > To: intel-gfx@lists.freedesktop.org > Cc: ville.syrj...@linux.intel.com; B S, Karthik ; > Murthy, Arun R > Su

Re: [Intel-gfx] [RFC PATCH 4/5] drm/i915/display: prepend connector name to the backlight

2022-06-20 Thread Murthy, Arun R
> On Fri, 03 Jun 2022, "Murthy, Arun R" wrote: > >> On Thu, 02 Jun 2022, Animesh Manna > wrote: > >> > From: Arun R Murthy > >> > > >> > With the enablement of dual eDP, there will have to exist two > >> > entries of b

Re: [Intel-gfx] [PATCH] drm/i915/dp: Check for Low voltage IO only for eDP

2022-06-28 Thread Murthy, Arun R
> - if (intel_dp_is_edp(intel_dp) || is_low_voltage_sku(dev_priv, phy)) > + if (intel_dp_is_edp(intel_dp)) > return 54; Shouldn't the low voltage check be for both eDP and is low voltage sku? Thanks and Regards, Arun R Murthy

Re: [Intel-gfx] [PATCH 1/2] drm/i915/hpd: postpone HPD cancel work after last user suspension

2022-06-28 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Andrzej Hajda > Sent: Thursday, June 23, 2022 10:08 PM > To: Jani Nikula ; Ville Syrjälä > > Cc: Hajda, Andrzej ; intel- > g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Vivi, Rodrigo > > Subject: [Intel-gfx] [PATCH 1

Re: [Intel-gfx] [PATCH] drm/i915/dp: Check for Low voltage IO only for eDP

2022-06-28 Thread Murthy, Arun R
> On 6/29/2022 8:55 AM, Murthy, Arun R wrote: > >> - if (intel_dp_is_edp(intel_dp) || is_low_voltage_sku(dev_priv, phy)) > >> + if (intel_dp_is_edp(intel_dp)) > >>return 54; > > Shouldn't the low voltage check be for both eDP and is low v

Re: [Intel-gfx] [PATCH 2/2] drm/i915/fbdev: suspend HPD before fbdev unregistration

2022-06-28 Thread Murthy, Arun R
> void intel_fbdev_unregister(struct drm_i915_private *dev_priv) { > struct intel_fbdev *ifbdev = dev_priv->fbdev; @@ -573,6 +594,8 @@ > void intel_fbdev_unregister(struct drm_i915_private *dev_priv) > if (!ifbdev) > return; > > + intel_fbdev_hpd_set_suspend(dev_priv

Re: [Intel-gfx] [PATCH] drm/i915: free crtc on driver remove

2022-06-30 Thread Murthy, Arun R
> intel_crtc is being allocated as part of intel_modeset_init_nogem and not > freed as part of driver remove. This will lead to memory leak. Hence free up > the allocated crtc on driver remove as part of > intel_modeset_driver_remove_nogem. > > Signed-off-by: Arun R Murthy > --- Please discard t

Re: [Intel-gfx] [PATCHv2] drm/i915: free crtc on driver remove

2022-06-30 Thread Murthy, Arun R
> > intel_crtc is being allocated as part of intel_modeset_init_nogem and > > not freed as part of driver remove. This will lead to memory leak. > > Hence free up the allocated crtc on driver remove as part of > > intel_modeset_driver_remove_nogem. > > No, there's no leak and this is not needed. >

Re: [Intel-gfx] [PATCHv2] drm/i915: free crtc on driver remove

2022-06-30 Thread Murthy, Arun R
> On Thu, 30 Jun 2022, "Murthy, Arun R" wrote: > >> > intel_crtc is being allocated as part of intel_modeset_init_nogem > >> > and not freed as part of driver remove. This will lead to memory leak. > >> > Hence free

Re: [Intel-gfx] [PATCHv2] drm/i915: free crtc on driver remove

2022-06-30 Thread Murthy, Arun R
> >> >> > intel_crtc is being allocated as part of > >> >> > intel_modeset_init_nogem and not freed as part of driver remove. > This will lead to memory leak. > >> >> > Hence free up the allocated crtc on driver remove as part of > >> >> > intel_modeset_driver_remove_nogem. > >> >> > >> >> No, ther

Re: [Intel-gfx] [PATCH v2] drm/i915: Support Async Flip on Linear buffers

2022-06-30 Thread Murthy, Arun R
Gentle reminder! Any review comments? Thanks and Regards, Arun R Murthy > -Original Message- > From: Murthy, Arun R > Sent: Tuesday, June 14, 2022 3:11 PM > To: intel-gfx@lists.freedesktop.org > Cc: ville.syrj...@linux.intel.com; B S, Karthik > S

Re: [Intel-gfx] [PATCH v2] drm/i915: Support Async Flip on Linear buffers

2022-06-30 Thread Murthy, Arun R
> On Wed, Jun 01, 2022 at 09:54:11AM +0530, Arun R Murthy wrote: > > Starting from Gen12 Async Flip is supported on linear buffers. > > I was asking for justification for the gen12+ approach. Why not expose it on > earlier platforms? > Even Gen12- platforms do support async on linear, but the req

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/fbdev: suspend HPD before fbdev unregistration

2022-06-30 Thread Murthy, Arun R
> HPD event after fbdev unregistration can cause registration of deferred fbdev > which will not be unregistered later, causing use-after-free. > To avoid it HPD handling should be suspended before fbdev unregistration. > > It should fix following GPF: > [272.634530] general protection fault, prob

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use short PCH names consistently

2022-06-30 Thread Murthy, Arun R
> From: Ville Syrjälä > > The comments regarding PCH compatibility use long vs. > short names inconsistently. Just use short names always. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_pch.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --gi

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP

2022-06-30 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Thursday, June 30, 2022 8:36 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP > > From: Ville Syrjälä > > JSP is based on ICP and we don't really need to diffe

Re: [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry

2022-07-01 Thread Murthy, Arun R
> On Mon, 27 Jun 2022, Arun R Murthy wrote: > > On linktraining error/timeout before retry need to wait for 400usec as > > per the DP CTS spec1.2 The patch with commit id > > 74ebf294a1dd816bdc248ac733009a8915d59eb5 > > drm/i915: Add a delay in Displayport AUX transactions for compliance > > testi

Re: [Intel-gfx] [PATCHv3] drm/i915/dp: wait on timeout before retry

2022-07-04 Thread Murthy, Arun R
> > -Original Message- > > From: Nikula, Jani > > Sent: Friday, July 1, 2022 4:45 PM > > To: Murthy, Arun R ; > > intel-gfx@lists.freedesktop.org > > Cc: ville.syrj...@linux.intel.com; Zanoni, Paulo R > > ; tprev...@gmail.com; Shankar, Uma >

Re: [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry

2022-07-04 Thread Murthy, Arun R
> On Mon, Jul 04, 2022 at 12:53:52PM +0530, Arun R Murthy wrote: > > On linktraining error/timeout before retry need to wait for 400usec as > > per the DP CTS spec1.2 > > s/CTS// > > > Under section 2.7.2 AUX Transaction Response/Reply Time-outs AUX > > Replier (the uPacket RX) must start sending

Re: [Intel-gfx] [PATCH i-g-t] tests/i915/kms_big_fb: trigger async flip with a dummy flip

2022-07-05 Thread Murthy, Arun R
> On 6/28/2022 4:34 PM, Arun R Murthy wrote: > > In oder to trigger the async flip, a dummy flip is required after sync > > flip so as to update the watermarks for async in KMD which happens as > > part of this dummy flip. Thereafter async memory update will act as a > > trigger register. > > Captu

Re: [Intel-gfx] [PATCH i-g-t] tests/i915/kms_big_fb: trigger async flip with a dummy flip

2022-07-05 Thread Murthy, Arun R
> On 7/5/2022 3:08 PM, Murthy, Arun R wrote: > >> On 6/28/2022 4:34 PM, Arun R Murthy wrote: > >>> In oder to trigger the async flip, a dummy flip is required after > >>> sync flip so as to update the watermarks for async in KMD which > >>> happ

Re: [Intel-gfx] [PATCH i-g-t] tests/i915/kms_big_fb: trigger async flip with a dummy flip

2022-07-05 Thread Murthy, Arun R
> On 5.7.2022 12.49, Karthik B S wrote: > > On 7/5/2022 3:08 PM, Murthy, Arun R wrote: > >>> On 6/28/2022 4:34 PM, Arun R Murthy wrote: > >>>> In oder to trigger the async flip, a dummy flip is required after > >>>> sync flip so as to update the

Re: [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Add MeteorLake platform info

2022-07-06 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Radhakrishna Sripada > Sent: Thursday, July 7, 2022 6:01 AM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > ; Vivi, Rodrigo > Subject: [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Add MeteorLake platform info

Re: [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Add MeteorLake PCI IDs

2022-07-06 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Radhakrishna Sripada > Sent: Thursday, July 7, 2022 6:01 AM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > ; Vivi, Rodrigo > Subject: [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Add MeteorLake PCI IDs > > A

Re: [Intel-gfx] [PATCH] drm/i915/hdmi: Prune modes that require HDMI2.1 FRL

2022-07-07 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Ankit > Nautiyal > Sent: Thursday, July 7, 2022 10:57 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH] drm/i915/hdmi: Prune modes that require > HDMI2.1 FRL > > HDMI2.1 requires some higher resolution video mode

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add Wa_14016291713

2022-07-12 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Matt > Roper > Sent: Saturday, July 9, 2022 3:28 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 2/2] drm/i915: Add Wa_14016291713 > > We already disable FBC when PSR2 is enabled on display version 12 and > above;

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dg2: Add Wa_15010599737

2022-07-12 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Matt > Roper > Sent: Saturday, July 9, 2022 3:28 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 1/2] drm/i915/dg2: Add Wa_15010599737 > > This workaround may need to be extended to other platforms soon, but for >

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Handle the DG2 max bw properly

2022-03-24 Thread Murthy, Arun R
> } > > +static unsigned int dg2_max_bw(struct drm_i915_private *i915) { > + struct intel_bw_info *bi = &i915->max_bw[0]; > + > + return bi->deratedbw[0]; > +} Would it look better to have this as a macro rather than a function? Thanks and Regards, Arun R Murthy

Re: [Intel-gfx] [PATCH] drm/i915: Support Async Flip on Linear buffers

2022-05-04 Thread Murthy, Arun R
> > There is that GTT alignment restriction that should be mentioned > > somewhere. Can't quite remember where it was, maybe in PLANE_SURF. > > > I checked the BSpec, and don't find anything as such specific for Async flip. > I also cross verified with the hardware team. > > > But I guess the bigg

Re: [Intel-gfx] [PATCH] drm/i915: Support Async Flip on Linear buffers

2022-05-05 Thread Murthy, Arun R
> > Can I have your Reviewed-by for this patch? > > You didn't find the GTT alignment restriction yet which to me syas you didn't > really look hard enough. I checked in the BSpec and also clarified with the hardware team on this. > > And you haven't answered what the actual use case for this is.

Re: [Intel-gfx] [RFC PATCH 4/5] drm/i915/display: prepend connector name to the backlight

2022-06-02 Thread Murthy, Arun R
> On Thu, 02 Jun 2022, Animesh Manna wrote: > > From: Arun R Murthy > > > > With the enablement of dual eDP, there will have to exist two entries > > of backlight sysfs file. In order to avoid sysfs file name > > duplication, the file names are prepended with the connector name. > > Fixed by 20f

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/fbdev: suspend HPD before fbdev unregistration

2022-07-13 Thread Murthy, Arun R
> -Original Message- > From: Hajda, Andrzej > Sent: Wednesday, July 13, 2022 8:50 PM > To: Jani Nikula ; Ville Syrjälä > ; Murthy, Arun R > Cc: Hajda, Andrzej ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; Daniel Vetter > ; intel-gfx@lists

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/display: add hotplug.suspended flag

2022-07-13 Thread Murthy, Arun R
> -Original Message- > From: Hajda, Andrzej > Sent: Wednesday, July 13, 2022 8:50 PM > To: Jani Nikula ; Ville Syrjälä > ; Murthy, Arun R > Cc: Hajda, Andrzej ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; Daniel Vetter > ; intel-gfx@lists

Re: [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry

2022-07-18 Thread Murthy, Arun R
> -Original Message- > From: Ville Syrjälä > Sent: Monday, July 4, 2022 7:41 PM > To: Murthy, Arun R > Cc: intel-gfx@lists.freedesktop.org; Zanoni, Paulo R > ; tprev...@gmail.com; Shankar, Uma > ; Nikula, Jani > Subject: Re: [PATCH] drm/i915/dp: wait on timeout

Re: [Intel-gfx] [PATCH] drm/i915/hdmi: Prune modes that require HDMI2.1 FRL

2022-07-18 Thread Murthy, Arun R
> -Original Message- > From: Nautiyal, Ankit K > Sent: Friday, July 8, 2022 3:36 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/hdmi: Prune modes that require > HDMI2.1 FRL > > Hi Arun, > > Tha

Re: [Intel-gfx] [PATCH] drm/i915/display: Cleanup intel_phy_is_combo()

2022-07-18 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Anusha Srivatsa > Sent: Tuesday, July 19, 2022 12:42 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH] drm/i915/display: Cleanup intel_phy_is_combo() > > No functional change. Cleanup the intel_phy_is_combo to acc

Re: [Intel-gfx] [PATCH] drm/i915/hdmi: Prune modes that require HDMI2.1 FRL

2022-07-19 Thread Murthy, Arun R
> -Original Message- > From: Nautiyal, Ankit K > Sent: Tuesday, July 19, 2022 11:40 AM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/hdmi: Prune modes that require > HDMI2.1 FRL > > > On 7/19/2022

Re: [Intel-gfx] [PATCH] drm/i915/display: Cleanup intel_phy_is_combo()

2022-07-19 Thread Murthy, Arun R
> > -Original Message- > > From: Murthy, Arun R > > Sent: Monday, July 18, 2022 8:32 PM > > To: Srivatsa, Anusha ; intel- > > g...@lists.freedesktop.org > > Subject: RE: [Intel-gfx] [PATCH] drm/i915/display: Cleanup > > intel_phy_is_combo() >

Re: [Intel-gfx] [PATCH] drm/i915/display: Cleanup intel_phy_is_combo()

2022-07-20 Thread Murthy, Arun R
> > > > > -Original Message- > > > > > From: Intel-gfx On > > > > > Behalf Of Anusha Srivatsa > > > > > Sent: Tuesday, July 19, 2022 12:42 AM > > > > > To: intel-gfx@lists.freedesktop.org > > > > > Subject: [Intel-gfx] [PATCH] drm/i915/display: Cleanup > > > > > intel_phy_is_combo() > > >

Re: [Intel-gfx] [PATCH] drm/i915/display: Cleanup intel_phy_is_combo()

2022-07-24 Thread Murthy, Arun R
> -Original Message- > From: Srivatsa, Anusha > Sent: Friday, July 22, 2022 1:48 AM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Murthy, Arun R > ; Roper, Matthew D > > Subject: [PATCH] drm/i915/display: Cleanup intel_phy_is_combo() > >

Re: [Intel-gfx] [PATCH v6 4/4] drm/i915/fbdev: do not create fbdev if HPD is suspended

2022-07-25 Thread Murthy, Arun R
> -Original Message- > From: Hajda, Andrzej > Sent: Friday, July 22, 2022 6:22 PM > To: Jani Nikula ; Ville Syrjälä > ; Murthy, Arun R > Cc: Hajda, Andrzej ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; Daniel Vetter > ; intel-gfx@lists

Re: [Intel-gfx] [PATCHv2] drm/i915/display: add support for dual panel backlight

2022-08-03 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, August 2, 2022 8:31 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: Shankar, Uma ; Murthy, Arun R > > Subject: Re: [PATCHv2] drm/i915/display: add support for dual panel > backlig

Re: [Intel-gfx] [PATCHv3] drm/i915/display: add support for dual panel backlight

2022-08-07 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Wednesday, August 3, 2022 7:03 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: Re: [PATCHv3] drm/i915/display: add support for dual panel > backlight > > On W

Re: [Intel-gfx] [PATCH] drm/i915/d13: Fix unclaimed accesses while loading PIPEDMC-C/D

2022-08-09 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Monday, August 8, 2022 4:01 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH] drm/i915/d13: Fix unclaimed accesses while > loading PIPEDMC-C/D > > At the moment on DG2 at least loading the DMC fi

Re: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: split out hdcp registers to a separate file

2022-08-09 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 4, 2022 3:29 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: split out hdcp registers to a > separate file > > Reduce the bloat of i915

Re: [Intel-gfx] [PATCH 2/2] drm/i915/hdcp: replace BIT() with REG_BIT() in register definitions

2022-08-09 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 4, 2022 3:29 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH 2/2] drm/i915/hdcp: replace BIT() with REG_BIT() > in register definitions > > Registers conte

Re: [Intel-gfx] [PATCH] drm/i915/d13: Fix unclaimed accesses while loading PIPEDMC-C/D

2022-08-10 Thread Murthy, Arun R
Reviewed-by: Arun R Murthy > -Original Message- > From: Deak, Imre > Sent: Wednesday, August 10, 2022 6:05 PM > To: Murthy, Arun R > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/d13: Fix unclaimed accesses while > loading PI

Re: [Intel-gfx] [PATCH 0/4] Fix HFVSDB parsing

2022-08-11 Thread Murthy, Arun R
I think this series will have to be posted to dri-devel as well. Thanks and Regards, Arun R Murthy --- > -Original Message- > From: Intel-gfx On Behalf Of Ankit > Nautiyal > Sent: Thursday, August 11, 2022 10:30 AM > To: intel-gfx@lists.freedesktop.org > Cc: Lankhorst, Ma

Re: [Intel-gfx] [PATCH 01/39] drm/i915: add display sub-struct to drm_i915_private

2022-08-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 01/39] drm/i915: add display sub-struct to > drm_i915_private > > In ano

Re: [Intel-gfx] [PATCH 02/39] drm/i915: move cdclk_funcs to display.funcs

2022-08-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 02/39] drm/i915: move cdclk_funcs to > display.funcs > > Move display re

Re: [Intel-gfx] [PATCH 03/39] drm/i915: move dpll_funcs to display.funcs

2022-08-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 03/39] drm/i915: move dpll_funcs to display.funcs > > Move display relat

Re: [Intel-gfx] [PATCH 04/39] drm/i915: move hotplug_funcs to display.funcs

2022-08-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 04/39] drm/i915: move hotplug_funcs to > display.funcs > > Move display

Re: [Intel-gfx] [PATCH 05/39] drm/i915: move clock_gating_funcs to display.funcs

2022-08-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 05/39] drm/i915: move clock_gating_funcs to > display.funcs > > Move dis

Re: [Intel-gfx] [PATCH 06/39] drm/i915: move wm_disp funcs to display.funcs

2022-08-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 06/39] drm/i915: move wm_disp funcs to > display.funcs > > Move display

Re: [Intel-gfx] [PATCH 07/39] drm/i915: move fdi_funcs to display.funcs

2022-08-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 07/39] drm/i915: move fdi_funcs to display.funcs > > Move display relate

Re: [Intel-gfx] [PATCH 08/39] drm/i915: move color_funcs to display.funcs

2022-08-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 08/39] drm/i915: move color_funcs to > display.funcs > > Move display re

Re: [Intel-gfx] [PATCH 09/39] drm/i915: move and group gmbus members under display.gmbus

2022-08-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 09/39] drm/i915: move and group gmbus > members under display.gmbus > >

Re: [Intel-gfx] [PATCH 10/39] drm/i915: move and group pps members under display.pps

2022-08-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 10/39] drm/i915: move and group pps members > under display.pps > > Move

Re: [Intel-gfx] [PATCH 11/39] drm/i915: move dmc to display.dmc

2022-08-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 11/39] drm/i915: move dmc to display.dmc > > Move display related member

Re: [Intel-gfx] [PATCH 12/39] drm/i915: move and split audio under display.audio and display.funcs

2022-08-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 12/39] drm/i915: move and split audio under > display.audio and display.f

Re: [Intel-gfx] [PATCH 01/39] drm/i915: add display sub-struct to drm_i915_private

2022-08-15 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Friday, August 12, 2022 12:10 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: RE: [Intel-gfx] [PATCH 01/39] drm/i915: add display sub-struct to > drm_i915_private

Re: [Intel-gfx] [PATCH 02/39] drm/i915: move cdclk_funcs to display.funcs

2022-08-15 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Friday, August 12, 2022 12:14 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: RE: [Intel-gfx] [PATCH 02/39] drm/i915: move cdclk_funcs to > display.funcs > >

Re: [Intel-gfx] [PATCH 05/39] drm/i915: move clock_gating_funcs to display.funcs

2022-08-15 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Friday, August 12, 2022 12:21 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: RE: [Intel-gfx] [PATCH 05/39] drm/i915: move clock_gating_funcs to > display.funcs

Re: [Intel-gfx] [PATCH 06/39] drm/i915: move wm_disp funcs to display.funcs

2022-08-15 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Friday, August 12, 2022 12:25 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: RE: [Intel-gfx] [PATCH 06/39] drm/i915: move wm_disp funcs to > display.funcs > >

Re: [Intel-gfx] [PATCH 10/39] drm/i915: move and group pps members under display.pps

2022-08-15 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Friday, August 12, 2022 12:28 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: RE: [Intel-gfx] [PATCH 10/39] drm/i915: move and group pps > members under display.pps

Re: [Intel-gfx] [PATCH 11/39] drm/i915: move dmc to display.dmc

2022-08-15 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Friday, August 12, 2022 12:31 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: RE: [Intel-gfx] [PATCH 11/39] drm/i915: move dmc to display.dmc > > On Fri, 1

Re: [Intel-gfx] [PATCH 12/39] drm/i915: move and split audio under display.audio and display.funcs

2022-08-15 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Friday, August 12, 2022 12:33 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: RE: [Intel-gfx] [PATCH 12/39] drm/i915: move and split audio under > display.audio and d

Re: [Intel-gfx] [PATCH 01/39] drm/i915: add display sub-struct to drm_i915_private

2022-08-16 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, August 16, 2022 1:07 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: RE: [Intel-gfx] [PATCH 01/39] drm/i915: add display sub-struct to > drm_i915_private

Re: [Intel-gfx] [PATCH 09/39] drm/i915: move and group gmbus members under display.gmbus

2022-08-16 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, August 16, 2022 1:21 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: RE: [Intel-gfx] [PATCH 09/39] drm/i915: move and group gmbus > members under display.g

Re: [Intel-gfx] [PATCH 12/39] drm/i915: move and split audio under display.audio and display.funcs

2022-08-16 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, August 16, 2022 1:32 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: RE: [Intel-gfx] [PATCH 12/39] drm/i915: move and split audio under > display.audio and d

Re: [Intel-gfx] [PATCHv3] drm/i915/display: add support for dual panel backlight

2022-08-21 Thread Murthy, Arun R
Gentle Reminder! Thanks and Regard, Arun R Murthy > -Original Message- > From: Murthy, Arun R > Sent: Monday, August 8, 2022 9:28 AM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; Murthy, Arun R > > Subject: [PATCHv3] drm/i915/dis

Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers

2022-08-21 Thread Murthy, Arun R
Gentle Reminder! Thanks and Regards, Arun R Murthy > -Original Message- > From: Murthy, Arun R > Sent: Monday, July 4, 2022 9:46 PM > To: intel-gfx@lists.freedesktop.org > Cc: ville.syrj...@linux.intel.com; Shankar, Uma ; > Murthy, Arun R > S

Re: [Intel-gfx] [PATCH 14/39] drm/i915: move and group fbdev under display.fbdev

2022-08-21 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 14/39] drm/i915: move and group fbdev under > display.fbdev > > Move dis

Re: [Intel-gfx] [PATCH 15/39] drm/i915: move wm to display.wm

2022-08-21 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 15/39] drm/i915: move wm to display.wm > > Move display related members

Re: [Intel-gfx] [PATCH 16/39] drm/i915: move and group hdcp under display.hdcp

2022-08-21 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 16/39] drm/i915: move and group hdcp under > display.hdcp > > Move displ

Re: [Intel-gfx] [PATCH 18/39] drm/i915: move overlay to display.overlay

2022-08-21 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; De Marchi, Lucas > > Subject: [Intel-gfx] [PATCH 18/39] drm/i915: move overlay to display.overlay > > Move display relate

Re: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-11 Thread Murthy, Arun R
> +static int output_bpc_show(struct seq_file *m, void *data) { Would it be better to have this function name as drm_output_bpc_show() Thanks and Regards, Arun R Murthy

Re: [Intel-gfx] [V2 2/3] drm/i915/display/debug: Expose crtc current bpc via debugfs

2022-04-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Bhanuprakash Modem > Sent: Monday, April 11, 2022 3:21 PM > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org; jani.nik...@linux.intel.com; > ville.syrj...@linux.intel.com; harry.wen

Re: [Intel-gfx] [PATCH] drm/i915: Support Async Flip on Linear buffers

2022-04-26 Thread Murthy, Arun R
> On Tue, Apr 26, 2022 at 05:34:07PM +0530, Arun R Murthy wrote: > > Starting from Gen12 Async Flip is supported on linear buffers. > > It's supported earlier than that. But IIRC there was some kind of GTT > alignment vs. async flip vs. FBC restriction that we weren't handling. > Should I enable

Re: [Intel-gfx] [PATCH] drm/i915: Support Async Flip on Linear buffers

2022-04-27 Thread Murthy, Arun R
> > > It's supported earlier than that. But IIRC there was some kind of > > > GTT alignment vs. async flip vs. FBC restriction that we weren't handling. > > > > > Should I enable it for earlier Gen also, or is it fine to keep it with > > starting > Gen 12. > > The only restriction that I see in Bs

Re: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-29 Thread Murthy, Arun R
> +static int output_bpc_show(struct seq_file *m, void *data) { Can we have a meaningful name instead of 'm' ? Upon changing this parameter name, you can have my Reviewed-By: Arun R Murthy Thanks and Regards, Arun R Murthy

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-04-29 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Bhanuprakash Modem > Sent: Monday, April 11, 2022 3:21 PM > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org; jani.nik...@linux.intel.com; > ville.syrj...@linux.intel.com; harry.

Re: [Intel-gfx] [PATCH] drm/i915: warn about missing ->get_buf_trans initialization

2022-05-04 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Tuesday, May 3, 2022 1:52 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH] drm/i915: warn about missing ->get_buf_trans > initialization > > Make sure each DDI platform

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Consolidate all pre plane update vblank waits

2022-02-09 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, February 9, 2022 5:05 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 7/7] drm/i915: Consolidate all pre plane update > vblank waits > > From: Ville Syrjälä > > There are seve

Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers

2022-08-23 Thread Murthy, Arun R
> -Original Message- > From: Ville Syrjälä > Sent: Tuesday, August 23, 2022 6:27 PM > To: Murthy, Arun R > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > Subject: Re: [PATCHv3] drm/i915: Support Async Flip on Linear buffers > > On Mon, Jul 04, 2022 at

Re: [Intel-gfx] [PATCH 09/39] drm/i915: move and group gmbus members under display.gmbus

2022-08-24 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Friday, August 12, 2022 12:26 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: RE: [Intel-gfx] [PATCH 09/39] drm/i915: move and group gmbus > members under display.g

Re: [Intel-gfx] [PATCH] drm/i915/backlight: split out backlight registers to a separate file

2022-08-24 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Monday, August 15, 2022 3:19 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH] drm/i915/backlight: split out backlight > registers to > a separate file > > Declutter i915_r

Re: [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Added restriction for plane downscaling

2022-08-28 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Animesh Manna > Sent: Friday, August 26, 2022 5:48 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Added restriction for plane > downscaling > > The second Scaler (i.e. Scaler 2) does not suppo

Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers

2022-08-29 Thread Murthy, Arun R
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, August 24, 2022 5:48 PM > To: Murthy, Arun R > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > Subject: Re: [PATCHv3] drm/i915: Support Async Flip on Linear buffers > > On Wed, Aug 24, 2022 at

Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers

2022-08-30 Thread Murthy, Arun R
> > > > > > Intel Gen do support Async Flip is supported on linear buffers. > > > > > > Since we didn't had a use case, it was not enabled. Now that > > > > > > as part of hybrid graphics for unsupported hardware pixel > > > > > > formats, its being converted to linear memory and then flipped, > he

Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers

2022-09-08 Thread Murthy, Arun R
Gentle Reminder! > -Original Message- > From: Murthy, Arun R > Sent: Tuesday, September 6, 2022 9:18 AM > To: intel-gfx@lists.freedesktop.org > Cc: ville.syrj...@linux.intel.com; Murthy, Arun R > Subject: [PATCHv3] drm/i915: Support Async Flip on Linear buffers >

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Define WD trancoder for i915

2022-09-09 Thread Murthy, Arun R
> From: Suraj Kandpal > > Adding WD Types, WD transcoder to enum list and WD Transcoder offsets. > Adding i915 register definitions related to WD transcoder > > Signed-off-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/display/intel_display.h | 6 + > .../drm/i915/display/intel_display_type

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915 : Changing intel_connector iterators

2022-09-09 Thread Murthy, Arun R
> From: Suraj Kandpal > > Changing intel_connector iterators as with writeback introduction not all > drm_connector will be embedded within intel_connector. > > Signed-off-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/display/intel_display.h | 7 ++--- > .../drm/i915/display/intel_display_t

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Define WD trancoder for i915

2022-09-09 Thread Murthy, Arun R
> On Fri, 09 Sep 2022, "Murthy, Arun R" wrote: > >> From: Suraj Kandpal > >> > >> Adding WD Types, WD transcoder to enum list and WD Transcoder > offsets. > >> Adding i915 register definitions related to WD transcoder > >> > >

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Enabling WD Transcoder

2022-09-12 Thread Murthy, Arun R
General: I think 'wd' has to be replaced with 'wb' which mean writeback > From: Suraj Kandpal > > Adding support for writeback transcoder to start capturing frames using > interrupt mechanism > > Signed-off-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/Makefile | 1 + > dri

Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers

2022-09-14 Thread Murthy, Arun R
Gentle Reminder! Any comments? Thanks and Regards, Arun R Murthy > -Original Message- > From: Intel-gfx On Behalf Of > Murthy, Arun R > Sent: Friday, September 9, 2022 9:17 AM > To: intel-gfx@lists.freedesktop.org > Cc: Syrjala, Ville > Su

Re: [Intel-gfx] [PATCH] drm/i915/dp: Fix LT debug print in SDP CRC enable

2023-07-25 Thread Murthy, Arun R
Any comments? Thanks and Regards, Arun R Murthy > -Original Message- > From: Murthy, Arun R > Sent: Friday, July 14, 2023 11:08 AM > To: intel-gfx@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCH] drm/i915/dp: Fix LT debug print

Re: [Intel-gfx] [PATCH] drm/i915/dp: Fix LT debug print in SDP CRC enable

2023-07-30 Thread Murthy, Arun R
> -Original Message- > From: Borah, Chaitanya Kumar > Sent: Friday, July 28, 2023 2:48 PM > To: Murthy, Arun R > Cc: intel-gfx@lists.freedesktop.org > Subject: RE: [Intel-gfx] [PATCH] drm/i915/dp: Fix LT debug print in SDP CRC > enable > > Hello Arun, &

Re: [Intel-gfx] [PATCH 1/4] drm/i915/hdcp: Use intel_connector argument in intel_hdcp_shim

2023-08-21 Thread Murthy, Arun R
Reviewed-by: Arun R Murthy Thanks and Regards, Arun R Murthy From: Kandpal, Suraj Sent: Thursday, August 10, 2023 1:17 PM To: intel-gfx@lists.freedesktop.org Cc: Nautiyal, Ankit K ; uma.sha...@intel.com ; Murthy, Arun R ; Kandpal, Suraj

Re: [Intel-gfx] [PATCH 2/4] drm/i915/hdcp: Propagate aux info in DP HDCP functions

2023-08-21 Thread Murthy, Arun R
> -Original Message- > From: Kandpal, Suraj > Sent: Thursday, August 10, 2023 1:18 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nautiyal, Ankit K ; uma.sha...@intel.com; > Murthy, Arun R ; Kandpal, Suraj > > Subject: [PATCH 2/4] drm/i915/hdcp: Propa

Re: [Intel-gfx] [PATCH 3/4] drm/i915/hdcp: Send the correct aux for DPMST HDCP scenario

2023-08-21 Thread Murthy, Arun R
> -Original Message- > From: Kandpal, Suraj > Sent: Thursday, August 10, 2023 1:18 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nautiyal, Ankit K ; uma.sha...@intel.com; > Murthy, Arun R ; Kandpal, Suraj > > Subject: [PATCH 3/4] drm/i915/hdcp: Send the co

  1   2   3   4   5   >