[Intel-gfx] [PATCH i-g-t v3 5/7] tests/kms_rotation_crc: Add TEST_ONLY flag

Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola --- tests/kms_rotation_crc.c | 139 +++ 1 file changed, 139 insertions(+) diff --git a/tests/kms_rotation_crc.c b/tests

[Intel-gfx] [PATCH] tests/kms_plane_multiple: Test only with maximum number of planes

To be more suitable for BAT testing, let's modify the test such a way that it only uses the maximum number of available planes. This reduces the total number of subtests. Cc: Robert Foss Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.c

[Intel-gfx] [PATCH i-g-t v2] tests/kms_plane_multiple: Test only with maximum number of planes

To be more suitable for BAT testing, let's modify the test such a way that it only uses the maximum number of available planes. This reduces the total number of subtests. v2: Fix broken kms_plane_multiple --list-subtests (Petri) Cc: Petri Latvala Cc: Robert Foss Signed-off-by: Mika K

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_lowres: Add DRM_MODE_ATOMIC_ALLOW_MODESET test

When doing a full atomic modeset, kernel should fail if the flag DRM_MODE_ATOMIC_ALLOW_MODESET is not set. Let's add this test as part of 'kms_plane_lowres' testset. The testcases are 'pipe-x-allow-modeset' where x stands for pipe in question. For: VIZ-6955 Signed-off-by

[Intel-gfx] [PATCH] lib/igt_kms: Fix regression on kms_plane_lowres test

count") Signed-off-by: Mika Kahola --- lib/igt_kms.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index dae8bf9..5388a83 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1331,6 +1331,7 @@ void kmstest_get_crtc(enum pipe pi

[Intel-gfx] [PATCH i-g-t] tests/kms_atomic: test that TEST_ONLY does not clobber state

none of that is clobbered Signed-off-by: Mika Kahola --- tests/kms_atomic.c | 79 ++ 1 file changed, 79 insertions(+) diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c index d6273f4..3531fa4 100644 --- a/tests/kms_atomic.c +++ b/tests

[Intel-gfx] [PATCH i-g-t] tests/kms_concurrent: Concurrent and interruptible subtests for atomic

ad changes resolution from higher to lower one and back. The delay between resolution changes is randomly selected between 20 and 50 milliseconds. The test runs by default 32 iterations to increase the coverage. Signed-off-by: Mika Kahola --- tests/Makefile.sources | 1 + tests/kms_concurre

[Intel-gfx] [PATCH i-g-t] benchmarks/gem_latency: Fix compiler warning

from ../lib/drmtest.h:39, from ../lib/igt.h:27, from gem_latency.c:31: Signed-off-by: Mika Kahola --- benchmarks/gem_latency.c | 1 - 1 file changed, 1 deletion(-) diff --git a/benchmarks/gem_latency.c b/benchmarks/gem_latency.c index 154c5f1..7be7

Re: [Intel-gfx] [PATCH 11/12] drm/i915: Keep track of the cdclk as if all crtc's were active.

_scale. The fix is to keep a atomic_cdclk that would be true > if all crtc's were active. > > This is required to get the same calculations done correctly regardless > of dpms mode. > Reviewed-by: Mika Kahola > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu

Re: [Intel-gfx] [PATCH 12/12] drm/i915: Calculate visibility in check_plane correctly regardless of dpms.

d but not active run check_plane as if it were on, > but afterwards set plane_state->visible = false for the checks. > Reviewed-by: Mika Kahola > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_atomic_plane.c | 4 ++-- > drivers/gpu/drm/i915/intel_dis

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: Check DP no aux transaction bit on link training

On Tue, 2015-12-22 at 16:53 +0100, Lukas Wunner wrote: > Hi Mika, > > On Mon, Dec 21, 2015 at 01:39:15PM +0200, Mika Kahola wrote: > > Check if no AUX transactions are required on DP link training. > > If this bit is set, we can reuse the known good drive current > >

[Intel-gfx] [PATCH v5 3/3] drm/i915: DP channel EQ check for use of DP link training optimization

https://bugs.freedesktop.org/show_bug.cgi?id=91393 Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 3137187..0cd1ccb 100644 --- a/drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCH v5 0/3] drm/i915: Disable link training optimization if DP config has changed

These three patches are fixes for DP link trainging failures and flickering issues reported by Mika Kahola (3): drm/i915: Disable fast link training if DP config changes drm/i915: Check DP no aux transaction bit on link training drm/i915: DP channel EQ check for use of DP link training

[Intel-gfx] [PATCH v5 1/3] drm/i915: Disable fast link training if DP config changes

parameters. Instead, disable fast link training feature when link parameters are set (Ville) v2: Readout DPCD register to check if no aux handshaking is required in link training (Ander) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91393 Signed-off-by: Mika Kahola --- drivers/gpu

[Intel-gfx] [PATCH v5 2/3] drm/i915: Check DP no aux transaction bit on link training

Check if no AUX transactions are required on DP link training. If this bit is set, we can reuse the known good drive current and pre-emphasis level from the last "full" link training. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91393 Signed-off-by: Mika Kahola --- drive

Re: [Intel-gfx] [PATCH v5 0/3] drm/i915: Disable link training optimization if DP config has changed

On Mon, 2016-01-04 at 13:11 +0100, Maarten Lankhorst wrote: > Op 04-01-16 om 12:21 schreef Mika Kahola: > > These three patches are fixes for DP link trainging failures and flickering > > issues > > reported by > Did your message get accidentally truncated here? It

Re: [Intel-gfx] [PATCH v5 3/3] drm/i915: DP channel EQ check for use of DP link training optimization

On Mon, 2016-01-04 at 18:44 +0200, Ville Syrjälä wrote: > On Mon, Jan 04, 2016 at 01:21:24PM +0200, Mika Kahola wrote: > > Don't use DP link training optimization if channel EQ is not ok. It has > > been reported that in case of failure in channel EQ check the link training >

Re: [Intel-gfx] [PATCH v5 3/3] drm/i915: DP channel EQ check for use of DP link training optimization

On Mon, 2016-01-04 at 18:53 +0200, Ville Syrjälä wrote: > On Mon, Jan 04, 2016 at 06:44:09PM +0200, Ville Syrjälä wrote: > > On Mon, Jan 04, 2016 at 01:21:24PM +0200, Mika Kahola wrote: > > > Don't use DP link training optimization if channel EQ is not ok. It has > >

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: Check DP no aux transaction bit on link training

On Mon, 2016-01-04 at 18:27 +0100, Thierry Reding wrote: > On Tue, Dec 22, 2015 at 04:53:41PM +0100, Lukas Wunner wrote: > > Hi Mika, > > > > On Mon, Dec 21, 2015 at 01:39:15PM +0200, Mika Kahola wrote: > > > Check if no AUX transactions are required on DP link trai

Re: [Intel-gfx] [PATCH v5 1/3] drm/i915: Disable fast link training if DP config changes

On Mon, 2016-01-04 at 18:42 +0200, Ville Syrjälä wrote: > On Mon, Jan 04, 2016 at 01:21:22PM +0200, Mika Kahola wrote: > > Disable DP link training optimization if DP link configuration > > changes. If one of the DP link parameters i.e. link rate or > > lane count changes the

[Intel-gfx] [PATCH v6 3/3] drm/i915: DP channel EQ check for use of DP link training optimization

case (Ville) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91393 Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 3137187..c995dbd 100644 --- a/dr

[Intel-gfx] [PATCH v6 0/3] drm/i915: Disable link training optimization if DP config has changed

These three patches are fixes for DP link trainging failures and flickering issues reported by https://bugs.freedesktop.org/show_bug.cgi?id=91393 Mika Kahola (3): drm/i915: Disable fast link training if DP config changes drm/i915: Check DP no aux transaction bit on link training drm/i915

[Intel-gfx] [PATCH v6 1/3] drm/i915: Disable fast link training if DP config changes

/show_bug.cgi?id=91393 Reviewed-by: Ville Syrjälä Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 5 + drivers/gpu/drm/i915/intel_dp_link_training.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCH v6 2/3] drm/i915: Check DP no aux transaction bit on link training

i?id=91393 Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dp_link_training.c | 19 +++ drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/gp

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: move VBT based TV presence check to intel_bios.c

On Mon, 2016-01-11 at 21:54 +0200, Jani Nikula wrote: > Hide knowledge about VBT child devices in intel_bios.c. > Tested-by: Mika Kahola > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.h | 1 + > drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915: move VBT based LVDS presence check to intel_bios.c

On Mon, 2016-01-11 at 21:54 +0200, Jani Nikula wrote: > Hide knowledge about VBT child devices in intel_bios.c. > Tested-by: Mika Kahola > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.h | 1 + > drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: hide away VBT private data in a separate header

a private header only to be included from intel_bios.c. > Tested-by: Mika Kahola > Signed-off-by: Jani Nikula > --- > Documentation/DocBook/gpu.tmpl| 2 +- > drivers/gpu/drm/i915/intel_bios.c | 2 +- > drivers/gpu/

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915: move VBT based eDP port check to intel_bios.c

On Mon, 2016-01-11 at 21:54 +0200, Jani Nikula wrote: > Hide knowledge about VBT child devices in intel_bios.c. > Tested-by: Mika Kahola > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.h | 1 + > drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2 4/6] drm/i915: move VBT based DSI presence check to intel_bios.c

On Mon, 2016-01-11 at 21:54 +0200, Jani Nikula wrote: > Hide knowledge about VBT child devices in intel_bios.c. > Tested-by: Mika Kahola > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.h | 2 +- > drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: lose the loose 666 format name in favor of packed

> > Follow suit with what's in enum mipi_dsi_pixel_format to avoid future > confusion. Rename > > VID_MODE_FORMAT_RGB666 -> VID_MODE_FORMAT_RGB666_PACKED > VID_MODE_FORMAT_RGB666_LOOSE -> VID_MODE_FORMAT_RGB666 > Tested-by: Mika Kahola > Signed-off-

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dsi: start using enum mipi_dsi_pixel_format

conversion with the VBT -> enum -> > register, since we have just shoved the VBT value into the register > directly. Longer term, all the VBT parsing and deciphering should be > done in intel_bios.c, and abstracted there. > Tested-by: Mika Kahola > Signed-off-by: Jani Nikula

Re: [Intel-gfx] [PATCH] drm/i915/bios: Fix the sequence size calculations for MIPI seq v3

o make it clearer. > Tested-by: Mika Kahola > Cc: Ville Syrjälä > Reported-by: Mika Kahola > Fixes: 2a33d93486f2 ("drm/i915/bios: add support for MIPI sequence block v3") > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_bios.c | 17 ++---

[Intel-gfx] [PATCH i-g-t] tools/intel_bios_reader: Fix typo on dump info

Fix typo on intel_bios_reader.c Signed-off-by: Mika Kahola --- tools/intel_bios_reader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/intel_bios_reader.c b/tools/intel_bios_reader.c index b31f648..5ca50ff 100644 --- a/tools/intel_bios_reader.c +++ b/tools

Re: [Intel-gfx] [BXT DSI timing fixes v1 3/3] drm/i915/bxt: Fixed dsi enc disable and blank at bootup

I applied this patch for testing BXT-M I received this error message [ 16.276906] Hardware name: Intel Corp. Broxton M/RVP, BIOS BXTM_IFWI_X64_R_2015_49_2_03 11/25/2015 [ 16.286793] task: 8801795a2640 ti: 88017830 task.ti: 88017830 [ 16.295047] RIP: 0010:[] [] skl_update

Re: [Intel-gfx] [BXT DSI timing fixes v1 2/3] drm/i915/bxt: Get pipe timing for BXT DSI

On Mon, 2015-10-12 at 22:55 +0530, Uma Shankar wrote: > For BXT DSI, vtotal, vactive, hactive registers are different. > Making changes to intel_crtc_mode_get() and get_pipe_timings(), > to read the correct registers for BXT DSI. > Tested-by: Mika Kahola > Signed-off-by: Uma Sh

Re: [Intel-gfx] [BXT MIPI PATCH 1/2] drm/i915: Set the Z inversion overlap field for BXT

On Wed, 2015-12-09 at 17:29 +0530, Deepak M wrote: > For broxton dual link Z-inversion overlap field is present > in MIPI_CTRL register unlike the other platforms, hence > setting the same in this patch. > Tested-by: Mika Kahola > Signed-off-by: Deepak M > --- > drivers/gp

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add DPI FIFO empty status check

On Fri, 2015-12-04 at 19:47 +0530, Deepak M wrote: > From: Gaurav K Singh > > After sending SHUTDOWN or TURN ON packet,check the DPI > FIFO empty status. > Tested-by: Mika Kahola > Signed-off-by: Gaurav K Singh > --- > drivers/gpu/drm/i915/intel_dsi.c | 6 +++

[Intel-gfx] [PATCH v4 1/6] drm/i915: DisplayPort pixel clock check

. V2: - removed computation for max DOT clock V3: - cleanup by removing unnecessary lines V4: - max_pixclk renamed as max_dotclk Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCH v4 0/6] Check pixel clock when setting mode

e max_pixclk variable is renamed as max_dotclk throughout the whole series Mika Kahola (6): drm/i915: DisplayPort pixel clock check drm/i915: HDMI pixel clock check drm/i915: DisplayPort-MST pixel clock check drm/i915: SDVO pixel clock check drm/i915: CRT pixel clock check drm/i915:

[Intel-gfx] [PATCH v4 3/6] drm/i915: DisplayPort-MST pixel clock check

MST. V2: - removed computation for max pixel clock V3: - cleanup by removing unnecessary lines V4: - max_pixclk variable renamed as max_dotclk Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp_mst.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v4 4/6] drm/i915: SDVO pixel clock check

: - removed computation for max pixel clock V3: - cleanup by removing unnecessary lines V4: - max_pixclk variable renamed as max_dotclk Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_sdvo.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b

[Intel-gfx] [PATCH v4 2/6] drm/i915: HDMI pixel clock check

: - removed computation for max dot clock V3: - cleanup by removing unnecessary lines V4: - max_pixclk variable renamed as max_dotclk - check for stereo mode added Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_hdmi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers

[Intel-gfx] [PATCH v4 5/6] drm/i915: CRT pixel clock check

: - removed computation for max pixel clock V3: - cleanup by removing unnecessary lines V4: - max_pixclk variable renamed as max_dotclk Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_crt.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers

[Intel-gfx] [PATCH v4 6/6] drm/i915: TV pixel clock check

: - removed computation for max pixel clock V3: - cleanup by removing unnecessary lines V4: - max_pixclk variable renamed as max_dotclk Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_tv.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers

Re: [Intel-gfx] [PATCH] drm/i915: Workaround VLV/CHV DSI scanline counter hardware fail

The patch does what it says. Tested-by: Mika Kahola Reviewed-by: Mika Kahola On Thu, 2016-12-15 at 19:47 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The scanline counter is bonkers on VLV/CHV DSI. The scanline counter > increment is not lined up with

[Intel-gfx] [PATCH i-g-t] tests/kms_pipe_crc_basic: Reset GPU before running subtests

://bugs.freedesktop.org/show_bug.cgi?id=100367 Signed-off-by: Mika Kahola --- tests/kms_pipe_crc_basic.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index f49b434..e1940e6 100644 --- a/tests/kms_pipe_crc_basic.c +++ b

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_pipe_crc_basic: Reset GPU before running subtests

On Tue, 2017-06-06 at 15:27 +0300, Ville Syrjälä wrote: > On Tue, Jun 06, 2017 at 03:20:46PM +0300, Mika Kahola wrote: > > > > It has been noticed by our CI BAT testing that in some 1%-3% > > probability > > kms_pipe_crc_basic subtest read-crc-pipe-x-frame-sequence f

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_pipe_crc_basic: Reset GPU before running subtests

On Tue, 2017-06-06 at 14:23 +0100, Chris Wilson wrote: > Quoting Mika Kahola (2017-06-06 13:33:14) > > > > On Tue, 2017-06-06 at 15:27 +0300, Ville Syrjälä wrote: > > > > > > On Tue, Jun 06, 2017 at 03:20:46PM +0300, Mika Kahola wrote: > > > > >

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_pipe_crc_basic: Reset GPU before running subtests

On Wed, 2017-06-07 at 11:24 +0100, Chris Wilson wrote: > Quoting Mika Kahola (2017-06-07 09:00:10) > > > > On Tue, 2017-06-06 at 14:23 +0100, Chris Wilson wrote: > > > > > > Quoting Mika Kahola (2017-06-06 13:33:14) > > > > > > > > >

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

platform. Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c index f6c6223..08f184a 100644 --- a/tests/kms_plane_multiple.c +++ b/tests

[Intel-gfx] [PATCH 1/5] drm/i915: Don't relay on I915_MAX_PIPES

Let's remove the dependency on I915_MAX_PIPES. Instead, get the number of pipes from platform information. Signed-off-by: Ramalingam C Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_audio.c| 2 +- drivers/gpu/drm/i915/intel_pipe_crc.c | 7 --- 2 files changed, 5 inser

[Intel-gfx] [PATCH 0/5] drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES

This patch series introduces fixes to reduce dependency for I915_MAX_PIPES and minor optimizations to reduce hardcoding. Kahola, Mika (1): drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation Mika Kahola (4): drm/i915: Don't relay on I915_MAX_PIPES drm/i915: Fold IRQ pipe

[Intel-gfx] [PATCH 4/5] drm/i915: Favor for_each_pipe() macro

Favor for_each_pipe() macro when looping through pipes. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_pipe_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_pipe_crc.c b/drivers/gpu/drm/i915/intel_pipe_crc.c index 24d781f..7efe3b7

[Intel-gfx] [PATCH 3/5] drm/i915: Fold IRQ pipe masks

Fold IRQ pipe masks into one loop instead of hardcoding per pipe. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/i915_irq.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 91a2c5d..1d560ff

[Intel-gfx] [PATCH 2/5] drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation

From: "Kahola, Mika" Remove dependency for I915_MAX_PIPES by replacing it with for_each_pipe() macro. Signed-off-by: Ramalingam C Signed-off-by: Kahola, Mika --- drivers/gpu/drm/i915/intel_display.c | 5 - drivers/gpu/drm/i915/intel_drv.h | 3 ++- drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH 5/5] drm/i915: Cleanup South Error Interrupts

Cleanup and parametrize the handling of South Error Interrupts (SERR_INT). Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/i915_irq.c | 12 drivers/gpu/drm/i915/i915_reg.h | 3 --- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES

wtotal:2313 pass:1242 > > dwarn:0   dfail:0   fail:12  skip:1059 time:9338s > > > > == Logs == > > > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patc > > hwork_5692/shards.html > > ___ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Mika Kahola - Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES

total:2313 pass:1242 > > dwarn:0   dfail:0   fail:12  skip:1059 time:9338s > > > > == Logs == > > > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patc > > hwork_5692/shards.html > > ___ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Mika Kahola - Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Try harder to collect CRC's

It seems that at least with GLK with MIPI/DSI display, the first collected CRC is bogus. To fix this, try to collect two CRC's instead of one. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101309 Signed-off-by: Mika Kahola --- tests/kms_frontbuffer_tracking.c | 12 +++- 1

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Try harder to collect CRC's

that seems to be affected by this https://bugs.freedesktop.org/show_bug.cgi?id=102374 > > On Fri, Sep 22, 2017 at 5:40 AM Mika Kahola > wrote: > > It seems that at least with GLK with MIPI/DSI display, the first > > collected > > CRC is bogus. To fix this, try t

Re: [Intel-gfx] [PATCH v7] drm/i915/edp: Be less aggressive about changing link config on eDP

ct the > > > real > > > culprits here were addressed by some of the recent link training > > > changes > > > that Manasi has implemented, and PSR on Skylake is definitely > > > more happy > > > with these changes in-place. > > > > > > v

Re: [Intel-gfx] [PATCH] drm/i915: Also discard second CRC on gen8+ platforms.

This fixes my issue with GLK+MIPI/DSI when running IGT test kms_frontbuffer_tracking --r basic Tested-by: Mika Kahola On Wed, 2017-09-27 at 17:20 -0700, Rodrigo Vivi wrote: > One of the differences I spotted for GEN8+ platforms when > compared to older platforms is that spec for BDW+ in

Re: [Intel-gfx] [PATCH] drm/i915: Also discard second CRC on gen8+ platforms.

V solution for all gen8+ platforms and > make our CI a bit more stable. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102374 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101309 > Cc: Mika Kahola > Signed-off-by: Rodrigo Vivi Reviewed-by: Mika Kahola > --- >  drive

Re: [Intel-gfx] [PATCH i-g-t v2 8/8] tests: Rename kms_pipe_color to kms_color

arten Lankhorst Reviewed-by: Mika Kahola > --- >  tests/Makefile.sources  | 2 +- >  tests/{kms_pipe_color.c => kms_color.c} | 4 ++-- >  2 files changed, 3 insertions(+), 3 deletions(-) >  rename tests/{kms_pipe_color.c => kms_color.c} (99%) > > d

Re: [Intel-gfx] [PATCH i-g-t v4 7/7] igt/kms_rotation_crc : Fix flip tests for sprite plane

arten Lankhorst Reviewed-by: Mika Kahola > --- >  tests/kms_rotation_crc.c | 23 +-- >  1 file changed, 17 insertions(+), 6 deletions(-) > > diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c > index 4932a0d44410..b8327dfa0d83 100644 > --- a/te

Re: [Intel-gfx] [PATCH i-g-t v4 1/7] tests: Stop looking at plane private members

On Fri, 2017-09-29 at 11:59 +0200, Maarten Lankhorst wrote: > Most of these tests have no reason to look at those members, > so try other ways of getting the information. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Mika Kahola > --- >  lib/igt_kms.h

Re: [Intel-gfx] [PATCH i-g-t v4 2/7] lib/igt_kms: Change output->pending_crtc_idx_mask to output->pending_pipe

better to change output->pending_crtc_idx_mask > to > an enum pipe, because only a single choice may be given for a pipe. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Mika Kahola > --- >  lib/igt_kms.c | 46 - > -- &g

Re: [Intel-gfx] [PATCH i-g-t v4 3/7] lib/igt_kms: Commit primary plane when a modeset is forced on a pipe

ll fail > on exhaust-fences because the bad-tiling subtest wasn't able to > disable pipe C correctly. > > Testcase: kms_rotation_crc > Signed-off-by: Maarten Lankhorst Reviewed-by: Mika Kahola > --- >  lib/igt_kms.c | 2 +- >  1 file changed, 1 insertion(+), 1

Re: [Intel-gfx] [PATCH i-g-t v4 4/7] lib/igt_kms: Rework connector properties to be more atomic, v2.

erty changed flags, and try to > commit all properties. > > Changs since v1: > - Mention which properties we set to what. > - Assert the property to be set is valid. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Mika Kahola > --- >

Re: [Intel-gfx] [PATCH 01/13] drm/i915: Let's use more enum intel_dpll_id pll_id.

On Tue, 2017-10-03 at 00:06 -0700, Rodrigo Vivi wrote: > No functional change expected. Just let's use this enum > when possible and also same standard pll_id name > so we can rework gen9+ port clock later. > > Cc: Mika Kahola > Cc: Paulo Zanoni > Signed-off-by: Rodri

Re: [Intel-gfx] [PATCH 02/13] drm/i915/cnl: Extract cnl_calc_pll_link following bxt style.

On Tue, 2017-10-03 at 00:06 -0700, Rodrigo Vivi wrote: > No functional change. Just spliting the function for > better port clock handling later. > > v2: Put link_clock *=2 inside the function only for DP, > otherwise we mess up clocks on HDMI. (Caught by CI). > > Cc:

Re: [Intel-gfx] [PATCH i-g-t v4 5/7] lib/igt_kms: Rework plane properties to be more atomic, v4.

d(plane, prop) \ > + (plane)->changed &= ~(1 << (prop)) > + > +#define igt_plane_set_prop_value(plane, prop, value) \ > + do { \ > + plane->values[prop] = value; \ > + igt_plane_set_prop_changed(plane, prop); \ > + } while (0) >   >  /**

Re: [Intel-gfx] [PATCH 03/13] drm/i915/skl: Extract skl_calc_pll_link following bxt, cnl style.

essing up the HDMI clocks. (Caught by CI). > > Cc: Mika Kahola > Signed-off-by: Rodrigo Vivi Reviewed-by: Mika Kahola > --- >  drivers/gpu/drm/i915/intel_ddi.c | 21 ++--- >  1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm

Re: [Intel-gfx] [PATCH 04/13] drm/i915: Unify and export gen9+ port_clock calculation.

On Tue, 2017-10-03 at 00:06 -0700, Rodrigo Vivi wrote: > On Cannonlake the DVFS level selection depends on the > port clock. > > So let's re-org in a way that we can easily export without > duplicating any code. > > v2: Rebased on changes on previous patches > &

Re: [Intel-gfx] [PATCH 09/13] drm/i915/cnl: Invert dvfs default level.

MHz, use level 1. Else, use level 2." Should we add check for DDI clock rate as well here? > > v2: Rebase moving it up to avoid some temporary code > duplication. > > Cc: Mika Kahola > Cc: Paulo Zanoni > Signed-off-by: Rodrigo Vivi > --- >  drivers/gpu/drm/

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_color: Unset plane fb on teardown, v2.

d 1's stack > ==1804==  160 bytes below stack pointer > > Add the missing calls to igt_plane_set_fb, and fix the crash. > > Changes since v1: > - Fix compilation! > Signed-off-by: Maarten Lankhorst Reviewed-by: Mika Kahola > --- >  tests/kms_color.c | 18 +

Re: [Intel-gfx] [PATCH i-g-t 2/2] lib/igt_kms: Disable crtc in legacy path when output is unset

olor.c:1053 > 7  0xf610 in __real_main1189 () at kms_color.c:1206 > 8  0xcbc7 in main (argc=, argv= out>) at kms_color.c:1189 > > Signed-off-by: Maarten Lankhorst Reviewed-by: Mika Kahola > --- >  lib/igt_kms.c | 2 +- >  1 file changed, 1

Re: [Intel-gfx] [PATCH 10/13] drm/i915/cnl: Unify dvfs level selection.

sounded ambiguous > because we could be getting the current level at pcode. > > Cc: Mika Kahola > Cc: Paulo Zanoni > Signed-off-by: Rodrigo Vivi > --- >  drivers/gpu/drm/i915/intel_cdclk.c| 28 +-- > - >  drivers/gpu/drm/i915/intel_dp

Re: [Intel-gfx] [PATCH 04/13] drm/i915: Unify and export gen9+ port_clock calculation.

On Wed, 2017-10-04 at 14:26 -0700, Rodrigo Vivi wrote: > On Wed, Oct 04, 2017 at 07:38:16PM +, Rodrigo Vivi wrote: > > > > On Wed, Oct 04, 2017 at 06:39:19AM +0000, Mika Kahola wrote: > > > > > > On Tue, 2017-10-03 at 00:06 -0700, Rodrigo Vivi wrote: > &

Re: [Intel-gfx] [PATCH 11/13] drm/i915/cnl: Only request voltage frequency switching when needed.

block > - s/need/needs: When adding doc needs sounded better. > > Cc: Mika Kahola > Cc: Paulo Zanoni > Signed-off-by: Rodrigo Vivi > --- >  drivers/gpu/drm/i915/intel_cdclk.c| 10 ++ >  drivers/gpu/drm/i915/intel_dpll_mgr.c | 16 +--- >  drivers/

[Intel-gfx] [PATCH v2] drm/i915/cnl: Symmetric scalers for each pipe

For Cannonlake the number of scalers for each pipe is 2. Let's increase the number of scalers for pipe C. v2: Use INTEL_GEN() instead of IS_CANNONLAKE() Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_device_info.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[Intel-gfx] [PATCH] drm/i915: Generalize transcoder looping

To make looping through transcoders in intel_ddi.c more generic, let's switch to use 'for_each_pipe()' macro to do this. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_ddi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_

Re: [Intel-gfx] [PATCH] drm/i915: Generalize transcoder looping

On Wed, 2017-11-01 at 17:26 +0200, Jani Nikula wrote: > On Wed, 01 Nov 2017, Mika Kahola wrote: > > > > To make looping through transcoders in intel_ddi.c more generic, > > let's switch > > to use 'for_each_pipe()' macro to do this. > > > >

[Intel-gfx] [PATCH v2] drm/i915: Generalize transcoder looping

To make looping through transcoders in intel_ddi.c more generic, let's switch to use 'for_each_pipe()' macro to do this. v2: Add a notion that we are dealing with transcoders instead of pipes (Jani) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_ddi.c | 11

Re: [Intel-gfx] [PATCH v2] drm/i915: Generalize transcoder looping

On Wed, 2017-11-08 at 21:54 +0200, Ville Syrjälä wrote: > On Mon, Nov 06, 2017 at 03:29:45PM +0200, Mika Kahola wrote: > > > > To make looping through transcoders in intel_ddi.c more generic, > > let's switch > > to use 'for_each_pipe()' macro to do t

[Intel-gfx] [PATCH FOR CI v2] drm/i915: Generalize transcoder looping

To make looping through transcoders in intel_ddi.c more generic, let's switch to use 'for_each_pipe()' macro to do this. v2: Add a notion that we are dealing with transcoders instead of pipes (Jani) Reviewed-by: Ville Syrjälä Signed-off-by: Mika Kahola --- drivers/gpu/drm/i

[Intel-gfx] [PATCH] drm/i915: Return early when pipes are not available

ing to read out ELD. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103206 Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_audio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 4705194..5e367

Re: [Intel-gfx] [PATCH] drm/i915: Return early when pipes are not available

On Thu, 2017-11-09 at 11:01 +, Chris Wilson wrote: > Quoting Mika Kahola (2017-11-09 10:49:52) > > > > At least in Coffee Lake it happens that we start initiliazing audio > > when > > no display is connected. This was discovered by CI when ru

Re: [Intel-gfx] [PATCH] drm/i915: Return early when pipes are not available

On Thu, 2017-11-09 at 15:15 +0200, Ville Syrjälä wrote: > On Thu, Nov 09, 2017 at 01:11:05PM +0200, Mika Kahola wrote: > > > > On Thu, 2017-11-09 at 11:01 +, Chris Wilson wrote: > > > > > > Quoting Mika Kahola (2017-11-09 10:49:52) > > > > > &

[Intel-gfx] [PATCH] drm/i915: Initialize audio only when display is present

when display is enabled. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103206 Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/i915_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index e7e9e06.

Re: [Intel-gfx] [PATCH] drm/i915: Return early when pipes are not available

On Fri, 2017-11-10 at 15:22 +0200, Jani Nikula wrote: > On Fri, 10 Nov 2017, Mika Kahola wrote: > > > > On Thu, 2017-11-09 at 15:15 +0200, Ville Syrjälä wrote: > > > > > > On Thu, Nov 09, 2017 at 01:11:05PM +0200, Mika Kahola wrote: > > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Initialize audio only when display is present

On Fri, 2017-11-10 at 13:37 +, Chris Wilson wrote: > Quoting Mika Kahola (2017-11-10 13:31:54) > > > > At least in Coffee Lake it happens that we start initiliazing audio > > when > > no display is connected. This was discovered by CI when ru

Re: [Intel-gfx] [PATCH 4/7] drm/i915/cnl: Fix wrpll math for higher freqs.

e HDMI 2.0 wasn't > working. > > This patch also replaces the use of "* KHz(1)" with the values > directly on KHz to avoid future confusion. > > Cc: Shashank Sharma > Cc: Mika Kahola > Cc: Manasi Navare > Cc: James Ausmus Reviewed-by: Mika Kahola &

Re: [Intel-gfx] [PATCH 4/7] drm/i915/cnl: Fix wrpll math for higher freqs.

On Wed, 2017-11-15 at 10:04 -0800, Rodrigo Vivi wrote: > On Wed, Nov 15, 2017 at 08:06:16AM +0000, Mika Kahola wrote: > > > > On Tue, 2017-11-14 at 11:47 -0800, Rodrigo Vivi wrote: > > > > > > Spec describe all values in MHz. We handle our >

[Intel-gfx] [PATCH] drm/i915/cnl: Symmetric scalers for each pipe

For Cannonlake the number of scalers for each pipe is 2. Let's increase the number of scalers for pipe C. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_device_info.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_device_info

Re: [Intel-gfx] [PATCH 0/5] drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES

On Tue, 2017-10-10 at 12:19 +0300, Ville Syrjälä wrote: > On Thu, Sep 14, 2017 at 10:53:01AM +0300, Mika Kahola wrote: > > > > This patch series introduces fixes to reduce dependency for > > I915_MAX_PIPES and minor optimizations to reduce hardcoding. > > > >

Re: [Intel-gfx] [PATCH 0/5] drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES

On Tue, 2017-10-10 at 02:20 -0700, Kenneth Graunke wrote: > On Thursday, September 14, 2017 12:53:01 AM PDT Mika Kahola wrote: > > > > This patch series introduces fixes to reduce dependency for > > I915_MAX_PIPES and minor optimizations to reduce hardcoding. > > >

[Intel-gfx] [PATCH FOR CI 0/5] drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES

This patch series introduces fixes to reduce dependency for I915_MAX_PIPES and minor optimizations to reduce hardcoding. Mika Kahola (5): drm/i915: Don't relay on I915_MAX_PIPES drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation drm/i915: Fold IRQ pipe masks drm/i915:

[Intel-gfx] [PATCH FOR CI 1/5] drm/i915: Don't relay on I915_MAX_PIPES

Let's remove the dependency on I915_MAX_PIPES. Instead, get the number of pipes from platform information. Reviewed-by: Ville Syrjälä Signed-off-by: Ramalingam C Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_audio.c| 2 +- drivers/gpu/drm/i915/intel_pipe_crc.c | 7 -

[Intel-gfx] [PATCH FOR CI 5/5] drm/i915: Cleanup South Error Interrupts

Cleanup and parametrize the handling of South Error Interrupts (SERR_INT). Reviewed-by: Ville Syrjälä Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/i915_irq.c | 12 drivers/gpu/drm/i915/i915_reg.h | 3 --- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a

<    1   2   3   4   5   6   7   8   9   10   >