the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/i915/display/intel_gen9_plane.c:712 skl_update_scaler_plane()
error: we previously assumed 'fb' could be null (see line 696)
vim +/fb +712 d
These error paths return success instead of negative error codes as
intended.
Fixes: c92724de6db1 ("drm/i915/selftests: Try to detect rollback during
batchbuffer preemption")
Fixes: 2d19a71ce68f ("drm/i915/selftests: Exercise long preemption chains")
Signed-off-by: Dan Car
This error path should return a negative error code instead of success.
Fixes: c92724de6db1 ("drm/i915/selftests: Try to detect rollback during
batchbuffer preemption")
Signed-off-by: Dan Carpenter
Reviewed-by: Chris Wilson
---
v2: The first version of the patch fixed some other e
mains);
440 mutex_unlock(&guc->send_mutex);
441
442 return ret;
443 }
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kind of feel like we shouldn't work around static checker bugs.
But when we do then there shouldn't be a Fixes tag.
regards,
dan carpenter
) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/gpu/drm/drm_hdcp.c:1208 drm_hdcp_helper_enable_hdcp() error:
uninitialized symbol 'check_link_interval'.
Old smatch warnings:
d
30 kfree(dig_port);
regards,
dan carpenter
On Fri, Oct 01, 2021 at 05:20:17PM +0300, Ville Syrjälä wrote:
> On Fri, Oct 01, 2021 at 04:25:35PM +0300, Dan Carpenter wrote:
> > Hello Imre Deak,
> >
> > This is a semi-automatic email about new static checker warnings.
> >
> > The patch 3e0abc7661c8: "d
The "digi_port" pointer can't be NULL and we have already dereferenced
it so checking for NULL is not necessary. Delete the check.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/display/intel_ddi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/
On Mon, Oct 04, 2021 at 01:52:27PM -0700, Lucas De Marchi wrote:
> Cc'ing Dan Carpenter
>
> On Fri, Oct 01, 2021 at 12:57:13PM +0300, Jani Nikula wrote:
> > On Fri, 01 Oct 2021, Chris Wilson wrote:
> > > Quoting Lucas De Marchi (2021-10-01 08:40:41)
> > &g
clear_and_wake_up_bit(bit, lock);
1623 }
1624 local_bh_enable();
1625 }
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
itialized
symbol 'vaddr'.
drivers/gpu/drm/i915/gt/selftest_migrate.c:182 clear() error: uninitialized
symbol 'rq'.
drivers/gpu/drm/i915/gt/selftest_migrate.c:193 clear() error: uninitialized
symbol 'vaddr'.
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:819
__unwind_incomplete_requests() error: uninitialized symbol 'pl'.
regards,
dan carpenter
If the intel_engine_create_pinned_context() function returns an error
pointer, then dereferencing "ce" will Oops. Use "vm" instead of
"ce->vm".
Fixes: cf586021642d ("drm/i915/gt: Pipelined page migration")
Signed-off-by: Dan Carpenter
---
drivers/gpu
9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/gpu/drm/i915/gt/selftest_migrate.c:102 copy() error: uninitialized
symbol 'rq'.
drivers/gpu/drm/i915/gt/selftest_migrate.
(Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/gpu/drm/i915/selftests/intel_memory_region.c:227 igt_mock_reserve()
error: 'mem' dereferencing possible ERR_PTR()
On Fri, Jul 02, 2021 at 11:32:45AM +0100, Matthew Auld wrote:
> On Fri, 2 Jul 2021 at 09:45, Dan Carpenter wrote:
> >
> > tree: git://anongit.freedesktop.org/drm-intel drm-intel-gt-next
> > head: 5cd57f676bb946a00275408f0dd0d75dbc466d25
> > commit: cf586021642d8017
On Fri, Jul 02, 2021 at 02:07:27PM +0300, Dan Carpenter wrote:
> On Fri, Jul 02, 2021 at 11:32:45AM +0100, Matthew Auld wrote:
> > On Fri, 2 Jul 2021 at 09:45, Dan Carpenter wrote:
> > > cf586021642d80 Chris Wilson 2021-06-17 84
> > > cf586021642d80 Chris Wilson 2021
f we
> see -EDEADLK(which involves dropping some locks), if we see any other
> error then the loop is terminated with ww->loop = false, which then
> hits the goto err_out.
>
Ah, yeah, you're right. False positive.
I hadn't looked at this code in context (I only had reviewe
te->update_planes |= BIT(plane->id);
341
342 new_crtc_state->data_rate[plane->id] =
343 intel_plane_data_rate(new_crtc_state, new_plane_state);
344
345 return intel_plane_atomic_calc_changes(old_crtc_state,
new_crtc_state,
34
-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/i915/display/intel_dp_hdcp.c:582 intel_dp_hdcp2_read_msg()
error: uninitialized symbol 'msg_end'.
vim
codes and make everything consistent.
Fixes: c5d71cb31723 ("drm/i915/gvt: Move vGPU type related code into gvt file")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gvt/gvt.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gvt/gvt.
This code should propagate the error from intel_overlay_pin_fb()
but currently it returns success.
Fixes: 1b321026e213 ("drm/i915: Pass ww ctx to intel_pin_to_display_plane")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/display/intel_overlay.c | 4 +++-
1 file changed, 3
,
> NR_PHY_TYPES
There is no need for NR_PHY_TYPES now so you could remove that as well.
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, May 10, 2019 at 09:13:26AM +, Ardelean, Alexandru wrote:
> On Wed, 2019-05-08 at 16:26 +0300, Alexandru Ardelean wrote:
> > On Wed, 2019-05-08 at 15:20 +0300, Dan Carpenter wrote:
> > >
> > >
> > > On Wed, May 08, 2019 at 02:28:35PM +0300, Alexa
robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/i915/intel_hdcp.c:1406 hdcp2_authenticate_repeater_topology()
warn: should this be a bitwise op?
git remote add drm-intel git://anongit.freedesktop.org/drm-intel
git remote update drm-intel
git checkout
Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/drm_hdcp.c:190 drm_hdcp_parse_hdcp2_srm() warn: mask and shift
to zero
git remote add drm-intel git://anongit.freedesktop.org/drm-intel
git remote update drm-intel
git checkout 6498bf5800a302ef69e7f4914e727893f278bb2f
vim +190 drivers/gpu
"ret" is uninitialized on this path but it should be -EINVAL.
Fixes: 930c8dfea4b8 ("drm/i915/gvt: Check if get_next_pt_type() always returns
a valid value")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gvt/gtt.c | 4 +++-
1 file changed, 3 insertions(+), 1 delet
following tag
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/i915/i915_query.c:290 query_perf_config_data() warn:
inconsistent returns 'mutex:&i915->perf.metrics_lock'.
Locked on: line 220
Unlocked on: line 170
#
https://github.
On Thu, May 23, 2019 at 12:25:44PM +0100, Lionel Landwerlin wrote:
> Hi Dan,
>
> Not quite sure if you read responses to what seems like an automated
> message.
> I have a question below.
>
> Thanks,
>
> -Lionel
>
> On 23/05/2019 11:32, Dan Carpenter wrote:
RTUAL is -2.
3339 ve->base.flags = I915_ENGINE_IS_VIRTUAL;
3340
3341 snprintf(ve->base.name, sizeof(ve->base.name), "virtual");
3342
3343 err = i915_timeline_init(ctx->i915, &ve->base.timeline, NULL);
3344
);
803 }
No else statement
804
805 GEM_BUG_ON(mask & ~INTEL_SUBPLATFORM_BITS);
806
--> 807 RUNTIME_INFO(i915)->platform_mask[pi] |= mask;
s also why GCC didn't trigger
an uninialized variable warning. The bug was reported to GCC years ago.
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
ize, int groupsize,
> if (j)
> lx--;
> }
> - if (!ascii)
> + if (!flags & HEXDUMP_ASCII)
^^
This is a precedence bug. It should be if (!(flags & HEXDUMP_ASCII)).
> goto nil;
>
regards,
dan
Hi Swati,
Thank you for the patch! Perhaps something to improve:
url:
https://github.com/0day-ci/linux/commits/Swati-Sharma/drm-i915-adding-state-checker-for-gamma-lut-values/20190416-021708
base: git://anongit.freedesktop.org/drm-intel for-linux-next
New smatch warnings:
drivers/gpu/drm/i
Hi Chris,
Thank you for the patch! Perhaps something to improve:
url:
https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-selftests-Verify-whitelist-of-context-registers/20190416-105231
base: git://anongit.freedesktop.org/drm-intel for-linux-next
New smatch warnings:
drivers/gpu
Hi David,
url:
https://github.com/0day-ci/linux/commits/David-Francis/Make-DRM-DSC-helpers-more-generally-usable/20190214-052541
smatch warnings:
drivers/gpu/drm/drm_dsc.c:306 drm_dsc_compute_rc_parameters() warn: impossible
condition '(vdsc_cfg->nfl_bpg_offset > 65535) => (0-u16max > u16max
ect_put(obj);
561 put_task_struct(work->task);
562 kfree(work);
563 }
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
-ci/linux/commits/Lionel-Landwerlin/drm-i915-Vulkan-performance-query-support/20190831-033234
base: git://anongit.freedesktop.org/drm-intel for-linux-next
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/gpu/drm
On Mon, Sep 16, 2019 at 10:31:35AM +0300, Jani Nikula wrote:
> On Sat, 14 Sep 2019, Dan Carpenter wrote:
> > tree:
> > https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git
> > master
> > head: a7f89616b7376495424f682b
The mock_context() function returns NULL on error, it doesn't return
error pointers.
Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback")
Signed-off-by: Dan Carpenter
---
.../gpu/drm/i915/selftests/i915_gem_context.c | 4 +-
drivers/staging/erofs/unzip_vle.c
On Thu, Mar 21, 2019 at 10:58:40AM +0200, Mika Kuoppala wrote:
> Dan Carpenter writes:
>
> > The mock_context() function returns NULL on error, it doesn't return
> > error pointers.
> >
> > Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier cal
The mock_context() function returns NULL on error, it doesn't return
error pointers.
Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback")
Signed-off-by: Dan Carpenter
---
V2: I accidentally sent a bunch of unrelated stuff...
diff --git a/drivers/gpu/drm
If gem_context_register() fails then "ctx" is a valid pointer, not an
error pointer. We should just return "err".
Fixes: 3aa9945a528e ("drm/i915: Separate GEM context construction and
registration to userspace")
Signed-off-by: Dan Carpenter
---
drivers/gpu/d
The live_context() function returns error pointers. It never returns
NULL.
Fixes: 9c1477e83e62 ("drm/i915/selftests: Exercise adding requests to a full
GGTT")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/selftests/i915_gem_evict.c | 2 +-
1 file changed, 1 insertion(+),
195 goto cleanup;
196 }
197
198 cleanup:
199 cleanup_objects(i915, &objects);
200 return err;
201 }
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Tue, Mar 26, 2019 at 02:53:49PM +, Chris Wilson wrote:
> Quoting Mika Kuoppala (2019-03-26 09:30:57)
> > Dan Carpenter writes:
> >
> > > The live_context() function returns error pointers. It never returns
> > > NULL.
> > >
> > > Fixes:
fast_timeout_us,
404 slow_timeout_ms,
405 &mbox))
406 return -ETIMEDOUT;
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
We should check "request[n]" instead of just "request".
Fixes: 78e41ddd2198 ("drm/i915: Apply an execution_mask to the virtual_engine")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gt/selftest_lrc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
I do think that these should be regular copy_to_user().
139 return -EFAULT;
140
141 return len;
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Wed, May 29, 2019 at 01:08:59PM +0100, Chris Wilson wrote:
> Quoting Dan Carpenter (2019-05-29 12:52:43)
> > Hello Tvrtko Ursulin,
> >
> > The patch c5d3e39caa45: "drm/i915: Engine discovery query" from May
> > 22, 2019, leads to the following static chec
i915_gem_object_free(obj);
247
248 GEM_BUG_ON(!atomic_read(&i915->mm.free_count));
249 atomic_dec(&i915->mm.free_count);
250
251 if (on)
^^
So hopefully "on" can'
133 if (!sq->queue)
134 return -ENOMEM;
135 sq->phys_addr = virt_to_phys(sq->queue);
136 dma_unmap_addr_set(sq, mapping, sq->dma_addr);
137 return 0;
138 }
Is this a bug?
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
This function is supposed to return zero or negative error codes but it
accidentally returns true on failure.
Fixes: 92a020747d6c ("drm/i915: Split shared dpll .get_dplls() into compute and
get phases")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/display/intel_dpll_mgr.c
The shmem_pin_map() function doesn't return error pointers, it returns
NULL.
Fixes: a0d3fdb628b8 ("drm/i915/gt: Split logical ring contexts from execlist
submission"
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gt/selftest_lrc.c | 8
1 file changed, 4 i
The shmem_pin_map() function returns NULL, it doesn't return error
pointers.
Fixes: 97ea656521c8 ("drm/i915/gvt: Parse default state to update reg
whitelist")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 +++---
1 file changed, 3 insertions(
On Fri, Jul 08, 2022 at 10:02:34AM +0100, Matthew Auld wrote:
> On 08/07/2022 09:40, Dan Carpenter wrote:
> > The shmem_pin_map() function doesn't return error pointers, it returns
> > NULL.
> >
> > Fixes: a0d3fdb628b8 ("drm/i915/gt: Split logical ring c
The shmem_pin_map() function doesn't return error pointers, it returns
NULL.
Fixes: be1cb55a07bf ("drm/i915/gt: Keep a no-frills swappable copy of the
default context state")
Signed-off-by: Dan Carpenter
Reviewed-by: Matthew Auld
---
v2: Correct the Fixes tag. Add Matthew&#x
mp;engine->sched_engine->tasklet);
1622 clear_and_wake_up_bit(bit, lock);
1623 }
1624 local_bh_enable();
1625 }
regards,
dan carpenter
s_bytes_to_cpy && (!it_ccs.sg ||
883
!sg_dma_len(it_ccs.sg) {
884 err = -EINVAL;
885 break;
886 }
887
888 cond_resched();
889 } while (1);
890
891 out_ce:
892 return err;
893 }
regards,
dan carpenter
The "ret" variable is checked on the previous line so we know it's
zero. No need to check again.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/display/intel_fb_pin.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/d
460c33821 ("drm/i915: Multi-BB execbuf")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
in
The intel_engine_create_virtual() function does not return NULL. It
returns error pointers.
Fixes: e5e32171a2cf ("drm/i915/guc: Connect UAPI to GuC multi-lrc interface")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 4 ++--
1 file changed, 2
cts are still on TTM's LRU
lists */
338 return i915_gem_object_evictable(obj);
339 }
regards,
dan carpenter
On Thu, Nov 18, 2021 at 03:15:31PM +, Matthew Auld wrote:
> On 18/11/2021 15:01, Dan Carpenter wrote:
> > Hello Matthew Auld,
> >
> > The patch 7ae034590cea: "drm/i915/ttm: add tt shmem backend" from Oct
> > 18, 2021, leads to the following Smatch static
This function returns a bool type so returning -EBUSY is equivalent to
returning true. It should return false instead.
Fixes: 7ae034590cea ("drm/i915/ttm: add tt shmem backend")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
1 file changed, 1 inser
ke there should be a
human reading them but it's not me... The system is broken, but who is
fixing it?
regards,
dan carpenter
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_10911_full -> Patchwork_21650_full
>
&
The "offset" is a u32 that comes from the user. The bug is that the
"offset + bytes" operation can have an integer overflow problem which
leads to an out of bounds access.
Fixes: 4d60c5fd3f87 ("drm/i915/gvt: vGPU PCI configuration space
virtualization"
cache_level,
^^
This older code dereferences it without checking.
1016 flags, work);
1017 if (err)
regards,
dan carpenter
^^
But now that relationship is not so clear so it causes a Smatch warning.
923 if (ret)
924 return ret;
925
926 data_rate = intel_bw_data_rate(dev_priv, new_bw_state);
927 data_rate = DIV_ROUND_UP(data_rate, 1000);
928
regards,
dan carpenter
work->vma_res = i915_vma_resource_get(vma->resource);
If "vma->resource" is NULL here then it leads to a crash in
i915_vma_resource_get().
488 work->cache_level = cache_level;
489 work->flags = bind_flags;
490
regards,
dan carpenter
break;
> + }
> }
> - if (&req->req != _req) {
> + if (!req) {
> ep->stopped = stopped;
> spin_unlock_irqrestore(&ep->dev->lock, flags);
> return -EINVAL;
> @@ -954,7 +957,6 @@ net2272_dequeue(struct usb_ep *_ep, struct usb_request
> *_req)
> dev_dbg(ep->dev->dev, "unlink (%s) pio\n", _ep->name);
> net2272_done(ep, req, -ECONNRESET);
> }
> - req = NULL;
Another unrelated change. These are all good changes but send them as
separate patches.
> ep->stopped = stopped;
>
> spin_unlock_irqrestore(&ep->dev->lock, flags);
regards,
dan carpenter
--
> drivers/media/pci/saa7134/saa7134-alsa.c | 4 ++--
> drivers/perf/xgene_pmu.c | 13 +++--
> 3 files changed, 11 insertions(+), 10 deletions(-)
These are all bug fixes.
1) Send them as 3 separate patches.
2) Add Fixes tags.
regards,
dan carpenter
nse, but it's out of date now. Just delete it.
> - if (group && &group->list == &rcd->tid_group_list.list)
> + if (!group)
> goto bail_eagain;
> group = list_prepare_entry(group, &rcd->tid_group_list.list,
> list);
regards,
dan carpenter
dev_name(&_phy->dev));
> BUG();
> }
> } else {
> - sas_port_create_link(port, phy);
> - list_add_tail(&phy->port_siblings, &port->phy_list);
> + s
een what is a related part of a
patch is a bit vague and some maintainers will ask you to add or subtract
from a patch depending on their individual tastes. I don't really have
an exact answer, but I felt like this patch needs to be subtracted from.
Especially if there is a whole chunk of the patch which can be removed,
then to me, that obviously should be in a different patch.
regards,
dan carpenter
On Mon, Feb 28, 2022 at 10:20:28AM -0800, Joe Perches wrote:
> On Mon, 2022-02-28 at 14:24 +0300, Dan Carpenter wrote:
>
> > a multi-line indent gets curly braces for readability even though
> > it's not required by C. And then both sides would get curly braces.
>
&
^^^
425
426 for (port = 0; port < r8a66597->max_root_hub; port++) {
427 if (r8a66597->root_hub[port].dev == dev) {
^^^
428 r8a66597->root_hub[port].dev = NULL;
429 break;
430 }
431 }
Printing the freed pointer in debug code is another thing people do.
regards,
dan carpenter
.c
index ddf5737c63d9..c9dffa5c40a2 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3771,6 +3771,9 @@ EXPORT_SYMBOL(kmem_cache_free_bulk);
*
* Don't free memory not originally allocated by kmalloc()
* or you will run into trouble.
+ *
+ * CHECKER information
+ * frees: $0
*/
void kfree(const void *objp)
{
regards,
dan carpenter
ly other places which
rely on the old behavior.
In an ideal world, with the new API the compiler would warn about
uninitialized variables, but unfortunately that warning is disabled by
default so we still have to rely on kbuild/Clang/Smatch to find the
bugs.
But hopefully the new API encourages people to write clearer code so it
prevents bugs in the long run.
regards,
dan carpenter
g()
error: potential divide by zero bug '/ rec->dst_width'.
Prevent this by ensuring that the dst height and width are non-zero.
Fixes: 02e792fbaadb ("drm/i915: implement drmmode overlay support v4")
Signed-off-by: Dan Carpenter
---
>From static analysis. Not
There were two error paths in __cancel_reset() which return success
instead of a negative error code as expected.
Fixes: 4e6835466771 ("drm/i915/selftests: Add a cancel request selftest that
triggers a reset")
Signed-off-by: Dan Carpenter
---
>From static analysis. I am not 1
This "ret" declaration shadows an existing "ret" variable at the top of
the function. Delete it.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/i915_vma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i
On Fri, Jan 28, 2022 at 07:20:02AM +0100, Thomas Hellström wrote:
> On Thu, 2022-01-27 at 17:26 -0500, Rodrigo Vivi wrote:
> > On Thu, Jan 27, 2022 at 11:51:15AM +0300, Dan Carpenter wrote:
> > > This "ret" declaration shadows an existing "ret" variable
-ci/archive/20220830/202208301957.ulaot2oy-...@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c:497
This code uses struct_size() but it stores the result in an int so the
integer overflow checks are not effective. Record the types as size_t
to prevent the size from being truncated.
Fixes: bf3c50837506 ("drm/i915/query: Use struct_size() helper")
Signed-off-by: Dan Carpenter
---
I d
if (!data[n].ce[m])
Toasted.
350 continue;
351
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
g tag
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/i915/i915_irq.c:2283 icp_irq_handler() error: uninitialized
symbol 'tc_port_hotplug_long_detect'.
git remote add drm-intel git://anongit.freedesktop.org/drm-intel
git remote update drm-int
up;
205 }
206
207 cleanup:
208 cleanup_objects(ggtt, &objects);
209 return err;
210 }
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
We should be unmapping "page" instead of "s". This code originally used
kmap_atomic() before it was changed to kmap(). The two mapping
functions are different which leads to this common mistake.
Fixes: 3e749f5199e1 ("drm/i915: Avoid atomic context for error cap
}
975
976 unlock:
977 mutex_unlock(&ctx->mutex);
978 out:
979 i915_vm_put(vm);
980 return err;
981 }
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https:
test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/gpu/drm/i915/gt/intel_lrc.c:4613 intel_execlists_create_virtual() warn:
assigning (-2) to unsigned variable 've->base.uabi_instance'
Old smatch warnings:
drivers/gpu/drm/i915/gt/intel_lrc.c:4612 intel_execlists_c
There is a cut and paste bug so we return the wrong error code.
Fixes: a603f5bd1691 ("drm/i915/dp: Make sure all tiled connectors get added to
the state with full modeset")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
1 file changed, 1 inser
The "num_dtd" variable is the number of elements in the
generic_dtd->dtd[] array so the > needs to be >= to prevent reading one
element beyond the end of the array.
Fixes: 33ef6d4fd8df ("drm/i915/vbt: Handle generic DTD block")
Signed-off-by: Dan Carpenter
---
We know that "err" is non-zero so there is no need to check.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/selftests/i915_request.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c
b/drivers/gpu/drm/i915
linux-next
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_lmem.c:40 vm_fault_lmem() error:
uninitialized symbol 'vmf_ret'.
#
https://github.com/
return "signaled";
76
77 return to_request(fence)->gem_context->name ?: "[" DRIVER_NAME
"]";
^^^^^^^^
Not possibly NULL.
78 }
regards,
dan carpenter
___
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/i915/selftests/i915_perf.c:26 alloc_empty_config() warn:
returning -1 instead of -ENOMEM is sloppy
drivers/gpu/drm/i915/selftests/i915_perf.c:43 alloc_empty_config() warn:
inconsistent returns '
ase: git://anongit.freedesktop.org/drm-intel for-linux-next
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:815 eb_lookup_vmas() error:
uninitialized symbol 'ob
y add following tag
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/i915/display/intel_tc.c:554 icl_tc_cold_request() error:
uninitialized symbol 'ret'.
#
https://github.com/0day-ci/linux/commit/29f27e6df6ad82b09a3c9ddaf5f51b2fc1647178
git r
This is a giant CC list.
There was one version where you CC'd me on patch 6/12 but after that you
just CC'd me on the cover page. Something is messed up in your scripts
because Cc'ing me on just the cover is pointless.
regards
1 - 100 of 320 matches
Mail list logo
