On Thu, May 23, 2019 at 12:25:44PM +0100, Lionel Landwerlin wrote: > Hi Dan, > > Not quite sure if you read responses to what seems like an automated > message. > I have a question below. > > Thanks, > > -Lionel > > On 23/05/2019 11:32, Dan Carpenter wrote: > > Hi Lionel, > > > > Thank you for the patch! Perhaps something to improve: > > > > url: > > https://github.com/0day-ci/linux/commits/Lionel-Landwerlin/drm-i915-Vulkan-performance-query-support/20190522-083115 > > base: git://anongit.freedesktop.org/drm-intel for-linux-next > > > > If you fix the issue, kindly add following tag > > Reported-by: kbuild test robot <l...@intel.com> > > Reported-by: Dan Carpenter <dan.carpen...@oracle.com> > > > > smatch warnings: > > drivers/gpu/drm/i915/i915_query.c:290 query_perf_config_data() warn: > > inconsistent returns 'mutex:&i915->perf.metrics_lock'. > > Locked on: line 220 > > Unlocked on: line 170 > > > > # > > https://github.com/0day-ci/linux/commit/2df5c78741c44ada4e0b3b7b016923cbbb30ab76 > > git remote add linux-review https://github.com/0day-ci/linux > > git remote update linux-review > > git checkout 2df5c78741c44ada4e0b3b7b016923cbbb30ab76 > > vim +290 drivers/gpu/drm/i915/i915_query.c > > > > 2df5c787 Lionel Landwerlin 2019-05-21 187 if (__get_user(flags, > > &user_query_config_ptr->flags)) > > 2df5c787 Lionel Landwerlin 2019-05-21 188 return -EFAULT; > > 2df5c787 Lionel Landwerlin 2019-05-21 189 > > 2df5c787 Lionel Landwerlin 2019-05-21 190 if (flags != 0) > > 2df5c787 Lionel Landwerlin 2019-05-21 191 return -EINVAL; > > 2df5c787 Lionel Landwerlin 2019-05-21 192 > > 2df5c787 Lionel Landwerlin 2019-05-21 193 ret = > > mutex_lock_interruptible(&i915->perf.metrics_lock); > > > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > Lock > > > What do you mean by that? >
Just observing that we take the lock on this line. :P regards, dan carpenter _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
