[Intel-gfx] [PATCH 06/16] drm/i915: Enforce going back to none before changing CRC source

This way we can have some init/fini code on those transitions. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 8c750d5..787c50d 100644

[Intel-gfx] [PATCH 08/16] drm/i915: Dynamically allocate the CRC circular buffer

So we don't eat that memory when not needed. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 12 drivers/gpu/drm/i915/i915_drv.h | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/driver

[Intel-gfx] [PATCH 11/16] drm/i915: Warn if we receive an interrupt after freeing the buffer

This shouldn't happen as the buffer is freed after disable pipe CRCs, but better be safe than sorry. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_irq.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c

[Intel-gfx] [PATCH 10/16] drm/i915: Rename i915_pipe_crc_ctl to i915_display_crc_ctl

rename the CRC control file to be more generic. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 42 ++--- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_de

[Intel-gfx] [PATCH 12/16] drm/i915: Add log messages when CRCs collection is started/stopped

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 471c258..dee85d7 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm

[Intel-gfx] [PATCH 13/16] drm/i915: Move drm_add_fake_info_node() higher in the file

Following commit needs drm_add_fake_info_node() higher in the file to avoid having a forward declaration. Move this helper near the top of the file. This also makes the next commit diff a bit easier to review. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 52

[Intel-gfx] [PATCH 14/16] drm/i915: Implement blocking read for pipe CRC files

rrupt hasn't been fired and we end up with an EOF. So, let's have the read on the pipe_crc file block until the interrupt gives us a new entry. At that point we can wake the reading process. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_

[Intel-gfx] [PATCH 16/16] drm/i915: Enable pipe CRCs

It's time to declare them ready. Unleash the beast. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 826ebce..d1674b6 100644 --- a/dr

[Intel-gfx] [PATCH 15/16] drm/i915: Only one open() allowed on pipe CRC result files

It doesn't really make sense to have two processes dequeueing the CRC values at the same time. Forbid that usage. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 16 drivers/gpu/drm/i915/i915_drv.h | 1 + 2 files changed, 17 insertions(+)

[Intel-gfx] pipe CRCs, intel-gpu-tools

And now the igt part, that adds a basic test using CRCs. -- Damien lib/Makefile.am | 4 + lib/drmtest.c| 8 ++ lib/drmtest.h| 16 +++ lib/igt_debugfs.c| 283 lib/igt_debugfs.h| 77 +++ lib/ig

[Intel-gfx] [PATCH 1/8] lib: Add a small helper to open debugfs files

Signed-off-by: Damien Lespiau --- lib/Makefile.am | 2 ++ lib/igt_debugfs.c | 75 +++ lib/igt_debugfs.h | 36 ++ 3 files changed, 113 insertions(+) create mode 100644 lib/igt_debugfs.c create mode 100644 lib

[Intel-gfx] [PATCH 3/8] lib: Add a igt_assert_cmpint()

Signed-off-by: Damien Lespiau --- lib/drmtest.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/lib/drmtest.h b/lib/drmtest.h index ff2827d..f45780b 100644 --- a/lib/drmtest.h +++ b/lib/drmtest.h @@ -193,6 +193,20 @@ void igt_exit(void) __attribute__((noreturn

[Intel-gfx] [PATCH 5/8] lib: Add a igt_display.h with a few enums and defines from the kernel

Signed-off-by: Damien Lespiau --- lib/Makefile.am | 1 + lib/igt_display.h | 55 +++ 2 files changed, 56 insertions(+) create mode 100644 lib/igt_display.h diff --git a/lib/Makefile.am b/lib/Makefile.am index 5710802..06d406f 100644 --- a

[Intel-gfx] [PATCH 7/8] lib: Add igt_wait_for_vblank() helper

Signed-off-by: Damien Lespiau --- lib/Makefile.am | 1 + lib/{igt_display.h => igt_display.c} | 38 lib/igt_display.h| 2 ++ 3 files changed, 15 insertions(+), 26 deletions(-) copy lib/{igt_displa

[Intel-gfx] [PATCH 4/8] lib: Add kmstest_paint_color()

Signed-off-by: Damien Lespiau --- lib/drmtest.c | 8 lib/drmtest.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/lib/drmtest.c b/lib/drmtest.c index 2660af7..435a745 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -1347,6 +1347,14 @@ static int create_bo_for_fb(int fd, int

[Intel-gfx] [PATCH 2/8] lib: Add igt_debugfs_fopen()

Signed-off-by: Damien Lespiau --- lib/igt_debugfs.c | 9 + lib/igt_debugfs.h | 4 2 files changed, 13 insertions(+) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index 33c4fc1..f194439 100644 --- a/lib/igt_debugfs.c +++ b/lib/igt_debugfs.c @@ -73,3 +73,12 @@ int

[Intel-gfx] [PATCH 6/8] lib: Make igt_debugfs_open() take the mode as argument

Signed-off-by: Damien Lespiau --- lib/igt_debugfs.c | 4 ++-- lib/igt_debugfs.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index f194439..7e625e1 100644 --- a/lib/igt_debugfs.c +++ b/lib/igt_debugfs.c @@ -66,12 +66,12

[Intel-gfx] [PATCH 8/8] debugfs_pipe_crc: Let's check CRCs!

Let's add a new test that sets a mode, wait for a few vblanks (3) and then make sure we read 3 identical CRCs. Some subtests check for various parsing errors. In the process, improve the debugfs helpers to deal with CRCs. Signed-off-by: Damien Lespiau --- lib/igt_debugfs.c

[Intel-gfx] [PATCH] drm/i915: Use pipe_name() instead of the pipe number

Yet other direct usages of the pipe number instead of pipe_name(). We've been tracking them lately but managed to miss these last ones. v2: Catch them all! (Ville) Reviewed-by: Ville Syrjälä (v1) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- drivers/gp

Re: [Intel-gfx] [PATCH 07/16] drm/i915: crc support for hsw

gt; but different interrupt source registers. So this little helper > function will come handy there. > > Also refactor the display error handler with a neat pipe loop. > > v2: Use for_each_pipe. > > Signed-off-by: Daniel Vetter Patches 1-7 are: Re

[Intel-gfx] [PATCH] drm/i915: Use a spin lock to protect the pipe crc struct

Daniel pointed out that it was hard to get anything lockless to work correctly, so don't even try for this non critical piece of code and just use a spin lock. Suggested-by: Daniel Vetter Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [PATCH v2] drm/i915: Use a spin lock to protect the pipe crc struct

Daniel pointed out that it was hard to get anything lockless to work correctly, so don't even try for this non critical piece of code and just use a spin lock. v2: Make intel_pipe_crc->opened a bool Suggested-by: Daniel Vetter Signed-off-by: Damien Lespiau --- drivers/gpu/

[Intel-gfx] [PATCH v3] drm/i915: Use a spin lock to protect the pipe crc struct

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 53 ++--- drivers/gpu/drm/i915/i915_drv.h | 5 ++-- drivers/gpu/drm/i915/i915_irq.c | 11 +--- 3 files changed, 49 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/

Re: [Intel-gfx] [PATCH] drm/i915: set active format aspect ratio same as picture aspect ratio

On Wed, May 22, 2013 at 04:48:15PM +0800, Xiong Zhang wrote: > HDMI Compliance Testing fail on i915 driver, the error log show: > M1-M0=0b00(NO Data) of AVI InfoFrame Packet should correspond to the > aspect ratio of the viewed image.Skip because AVI R3-R0 is no 1000 > (Same as picture aspect ratio

[Intel-gfx] [PATCH v4] drm/i915: Use a spin lock to protect the pipe crc struct

locking around the condition we are waiting for. (Daniel Vetter) Suggested-by: Daniel Vetter Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 66 ++--- drivers/gpu/drm/i915/i915_drv.h | 5 +-- drivers/gpu/drm/i915/i915_irq.c | 12 ++

Re: [Intel-gfx] [PATCH] drm/i915: Move the pipe CRC stuff to other pipe data

On Mon, Oct 21, 2013 at 09:10:20PM +0200, Daniel Vetter wrote: > Adding stuff to the bottom of struct drm_i915_driver_private is > nowadays considered uncool. > > Cc: Damien Lespiau > Signed-off-by: Daniel Vetter Ville was suggesting moving the pipe_crc struct into intel_crtc

[Intel-gfx] gem_render_copy

A few moons ago, Chris suggested to create a small, standalone, render copy test to add aub file support and help enabling new platforms instead of hijacking gem_render_linear_blits. So here it is. -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.

[Intel-gfx] [PATCH 1/5] lib: Add a function to dump a scratch buf into a png

Signed-off-by: Damien Lespiau --- lib/Makefile.am | 1 + lib/rendercopy.c | 49 + lib/rendercopy.h | 2 ++ 3 files changed, 52 insertions(+) create mode 100644 lib/rendercopy.c diff --git a/lib/Makefile.am b/lib/Makefile.am index 431fd93

[Intel-gfx] [PATCH 2/5] tests/gem_render_copy: Add a simple render copy test

The goal is here to both: demonstrate a simple usage of render copy with the possibility to write pngs to visualize what it's doing and to provide a test bed to port the render copy function to new architectures. Signed-off-by: Damien Lespiau --- tests/.gitignore| 1 +

[Intel-gfx] [PATCH 3/5] tests/gem_render_copy: Only dump pngs when the -d option is given

Signed-off-by: Damien Lespiau --- tests/gem_render_copy.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/tests/gem_render_copy.c b/tests/gem_render_copy.c index a693cee..b844fbb 100644 --- a/tests/gem_render_copy.c +++ b/tests/gem_render_copy.c

[Intel-gfx] [PATCH 4/5] tests/gem_render_copy: Add aub dump support

Signed-off-by: Damien Lespiau --- tests/gem_render_copy.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/tests/gem_render_copy.c b/tests/gem_render_copy.c index b844fbb..40c37f4 100644 --- a/tests/gem_render_copy.c +++ b/tests/gem_render_copy.c

[Intel-gfx] [PATCH 5/5] gem_render_linear_blits: Remove aub dump support

It's much easier to follow the new gem_render_copy test and acquire a aub dump from it. Suggested-by: Chris Wilson Signed-off-by: Damien Lespiau --- tests/gem_render_linear_blits.c | 16 1 file changed, 16 deletions(-) diff --git a/tests/gem_render_linear_blits.c b/

Re: [Intel-gfx] gem_render_copy

On Wed, Oct 23, 2013 at 04:05:11PM +0100, Damien Lespiau wrote: > A few moons ago, Chris suggested to create a small, standalone, render copy > test to add aub file support and help enabling new platforms instead of > hijacking gem_render_linear_blits. > > So here it is. A wh

[Intel-gfx] Using render nodes in i-g-t

Hi, This small series add the possibility for a test to ask for a render device. This allows us to run render tests as a regular users. -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/

[Intel-gfx] [PATCH 1/5] lib: Remove stale comment

Signed-off-by: Damien Lespiau --- lib/drmtest.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index abcbba9..b94981e 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -168,8 +168,6 @@ void gem_quiescent_gpu(int fd) /** * drm_get_card() - get an intel card

[Intel-gfx] [PATCH 2/5] lib: Close non intel fds in drm_get_card()

When going through card%u devices, close the ones that we were able to open but weren't intel devices. Signed-off-by: Damien Lespiau --- lib/drmtest.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index b94981e..3b80920 100644 ---

[Intel-gfx] [PATCH 3/5] lib: Add a drm_open_any_render() that will try to use render nodes

I was fedup with having to run my tests as root and not being able to use my usual setup for tests that only exercise the GT part of the GPU. Render nodes to the rescue! Signed-off-by: Damien Lespiau --- lib/drmtest.c | 58 ++ lib

[Intel-gfx] [PATCH 4/5] tests/gem_render_copy: Use render nodes

Signed-off-by: Damien Lespiau --- tests/gem_render_copy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gem_render_copy.c b/tests/gem_render_copy.c index 40c37f4..e481733 100644 --- a/tests/gem_render_copy.c +++ b/tests/gem_render_copy.c @@ -104,7 +104,7 @@ int main

[Intel-gfx] [PATCH 5/5] tests: Convert the ctx test to use render nodes when possible

Signed-off-by: Damien Lespiau --- tests/gem_ctx_bad_destroy.c | 2 +- tests/gem_ctx_bad_exec.c| 2 +- tests/gem_ctx_basic.c | 4 ++-- tests/gem_ctx_create.c | 2 +- tests/gem_ctx_exec.c| 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests

Re: [Intel-gfx] [PATCH 3/5] lib: Add a drm_open_any_render() that will try to use render nodes

On Thu, Oct 24, 2013 at 01:43:22PM -0700, Ben Widawsky wrote: > On Thu, Oct 24, 2013 at 03:40:54PM +0100, Damien Lespiau wrote: > > I was fedup with having to run my tests as root and not being able to > > use my usual setup for tests that only exercise the GT part of the GPU.

Re: [Intel-gfx] [PATCH 3/5] lib: Add a drm_open_any_render() that will try to use render nodes

On Thu, Oct 24, 2013 at 10:01:21PM +0100, Damien Lespiau wrote: > On Thu, Oct 24, 2013 at 01:43:22PM -0700, Ben Widawsky wrote: > > On Thu, Oct 24, 2013 at 03:40:54PM +0100, Damien Lespiau wrote: > > > I was fedup with having to run my tests as root and not being able to > &

Re: [Intel-gfx] Using render nodes in i-g-t

On Thu, Oct 24, 2013 at 03:40:51PM +0100, Damien Lespiau wrote: > Hi, > > This small series add the possibility for a test to ask for a render device. > This allows us to run render tests as a regular users. Pushed, there's a bit more work before we can run the right subset

Re: [Intel-gfx] [PATCH 2/4] drm/i915: scramble reset support for DP port CRC on g4x

On Fri, Nov 01, 2013 at 10:50:21AM +0100, Daniel Vetter wrote: > + /* DP port CRC needs slight spec mis-compliance to get stable CRCs. */ We could add a slighty better explanation. How about: /* * When the pipe CRC tap point is after the transcoders we need * to tweak symbol-level features

Re: [Intel-gfx] [PATCH 1/4] drm/i916: add "auto" pipe CRC source

configuration, since otherwise the auto mode won't do the right thing. > > v4: Don't leak the modeset mutex on error paths. > > v5: Spelling fix for the i9xx auto_source function. > > Cc: Damien Lespiau > Signed-off-by: Daniel Vetter On the series (the

Re: [Intel-gfx] [PATCH] prime_self_import: Assure no pending requests before object counting

On Fri, Nov 01, 2013 at 12:53:42PM +, oscar.ma...@intel.com wrote: > +static void retire_requests(void) > +{ > + char fname[FILENAME_MAX]; > + int drop_caches_fd; > + const char *data = "0x4"; > + > + snprintf(fname, FILENAME_MAX, "%s/%i/%s", > + "/sys/kernel/debug/

Re: [Intel-gfx] [PATCH 24/62] drm/i915/bdw: Initialize the PDEs

gt; Thanks to Ville for the quick correction when discussing on IRC. > > Cc: Ville Syrjälä > Reviewed-by: Imre Deak > Signed-off-by: Ben Widawsky With the small bikeshed below: Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 27

Re: [Intel-gfx] [PATCH 27/62] drm/i915/bdw: Implement PPGTT enable

y PPGTT PDPs with LRI commands. > > v4: Rebase around context differences conflicts. > > Cc: Ville Syrjälä > Signed-off-by: Ben Widawsky (v3) > Reviewed-by: Imre Deak > Signed-off-by: Daniel Vetter The bikeshed is a welcomed documentation addition (in a separate patch

Re: [Intel-gfx] [PATCH 00/62] Broadwell kernel driver support

On Sun, Nov 03, 2013 at 09:45:49AM +0100, Daniel Vetter wrote: > Damien: Patches 24-29 Patches were reviewed, had a glance at them to try to spot anything a rebase could have done to them with two small improvements that can be addressed with 2 patches on top if we want to merge things in the next

Re: [Intel-gfx] [PATCH 63/62] drm/i915/bdw: Enable trickle feed on Broadwell

On Sun, Nov 03, 2013 at 01:47:27PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Like on HSW, trickle feed should always be enabled on BDW. > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau -- Damien > --- > Not sure this applies di

Re: [Intel-gfx] [PATCH 2/2] drm/i915: add i915_get_reset_stats_ioctl

e comments for ioctl struct members > > Signed-off-by: Mika Kuoppala > Cc: Ian Romanick > Cc: Chris Wilson > Cc: Daniel Vetter The logic there looks good to me, I was just wondering if we wanted a bit more padding in case we want other counters or misc stuff. Reviewed-by: Damien

Re: [Intel-gfx] [PATCH 1/2] drm/i915: add i915_reset_count

should be safe, I believe. With this, you can add a: Reviewed-by: Damien Lespiau -- Damien > > Reset status ioctl introduced in following commit > needs to deliver global reset count to userspace so > use reset_counter to derive the actual reset count > for the gpu > > N

intel-gfx@lists.freedesktop.org

On Mon, Nov 11, 2013 at 03:36:55PM +, oscar.ma...@intel.com wrote: > From: Oscar Mateo > > Some shells do not understand "&>". For instance, my Ubuntu 12.04 > machine has /bin/sh pointing to dash, which makes a mess out of > "&>" (to the point that the helper processes cannot be killed). > >

[Intel-gfx] Sync the assembler with Mesa's opcode emission code

Hey, Some time ago, Daniel mentioned merging the assembler into intel-gpu-tools to lower maintenance cost and have more eyes on the code. This series is the aftermath of that with an effort to sync the opcode emission from Mesa with the assembler. It's also available in my fdo i-g-t tree: http:/

[Intel-gfx] [PATCH 01/90] build: Add CAIRO_FLAGS to the debugger compilation

The library in lib/ exposes in its main header and thus users must be able to include it. --- debugger/Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/debugger/Makefile.am b/debugger/Makefile.am index d76e2ac..f1e49b9 100644 --- a/debugger/Makefile.am +++ b/de

[Intel-gfx] [PATCH 03/90] build: Don't use AM_MAINTAINER_MODE

This does not bring us anything these days, not using the macro at all is the same thing as having it always on. See this discussion: https://www.redhat.com/archives/virt-tools-list/2010-October/msg00049.html Signed-off-by: Damien Lespiau --- autogen.sh |2 +- configure.ac |1 - 2

[Intel-gfx] [PATCH 02/90] gitignore: Ignore TAGS files

TAGS files are generated with "make tags" to quickly jump through the code. Ignore those by-products of automake/ctags. Signed-off-by: Damien Lespiau --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 611ab06..bfd5

[Intel-gfx] [PATCH 04/90] build: Only build the assembler if flex and bison are found

And start displaying a nice summary of what we are going to compile. Signed-off-by: Damien Lespiau --- Makefile.am |6 +- configure.ac | 15 +++ 2 files changed, 20 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index a135531..60fc03e 100644 --- a

[Intel-gfx] [PATCH 06/90] assembler: Sync brw_instruction's header with mesa's

Two changes there, a field has been renamed and one bit of padding is now used for compressed instructions. Signed-off-by: Damien Lespiau --- assembler/brw_structs.h | 34 +++--- assembler/disasm.c |8 assembler/gram.y| 30

[Intel-gfx] [PATCH 05/90] build: Add the debugger compilation status to the summary

Signed-off-by: Damien Lespiau --- configure.ac |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index ff7e779..832c6e4 100644 --- a/configure.ac +++ b/configure.ac @@ -109,6 +109,7 @@ AC_ARG_ENABLE(shader-debugger, AS_HELP_STRING([--enable

[Intel-gfx] [PATCH 07/90] assembler: Rename three_src_gen6 to da3src

Mesa's brw_structs.h has named/renamed this field to da3src. Sync with them. Signed-off-by: Damien Lespiau --- assembler/brw_structs.h |6 +++--- assembler/gram.y| 30 +++--- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/asse

[Intel-gfx] [PATCH 08/90] assembler: Rename dp_read_gen6 to gen6_dp_sampler_const_cache

The purpose of this commit is to synchronize opcode definitions across the gen4asm assembler and mesa. Signed-off-by: Damien Lespiau --- assembler/brw_structs.h | 27 --- assembler/gram.y|6 +++--- 2 files changed, 19 insertions(+), 14 deletions(-) diff

[Intel-gfx] [PATCH 09/90] assembler: Rename dp_gen6 to gen6_dp and sync with Mesa's

show any difference in the assembly created. Signed-off-by: Damien Lespiau --- assembler/brw_structs.h | 34 ++ assembler/gram.y|8 2 files changed, 26 insertions(+), 16 deletions(-) diff --git a/assembler/brw_structs.h b/assembler/brw_stru

[Intel-gfx] [PATCH 11/90] assembler: Remove struct dp_write_gen6 and struct use gen6_dp

We ended up with 2 structures that where exactly the same, so just use one, which happens to be the one Mesa has. Signed-off-by: Damien Lespiau --- assembler/brw_structs.h | 13 - assembler/gram.y| 16 2 files changed, 8 insertions(+), 21 deletions

[Intel-gfx] [PATCH 10/90] assembler: Rename dp_gen7 to gen7_dp and sync it with Mesa's

show any difference in the assembly created. Signed-off-by: Damien Lespiau --- assembler/brw_structs.h | 31 --- assembler/gram.y| 26 +- 2 files changed, 33 insertions(+), 24 deletions(-) diff --git a/assembler/brw_structs.h b/asse

[Intel-gfx] [PATCH 12/90] assembler: Rename gen5 DP pixel_scoreboard_clear to last_render_target

The purpose of this commit is to synchronize opcode definitions across the gen4asm assembler and mesa. Signed-off-by: Damien Lespiau --- assembler/brw_structs.h |4 ++-- assembler/disasm.c |2 +- assembler/gram.y| 16 3 files changed, 11 insertions(+), 11

[Intel-gfx] [PATCH 13/90] assembler: Rename branch to branch_gen6

The purpose of this commit is to synchronize opcode definitions across the gen4asm assembler and mesa. Signed-off-by: Damien Lespiau --- assembler/brw_structs.h | 17 - assembler/main.c|2 +- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/assembler

[Intel-gfx] [PATCH 15/90] assembler: Rename bits3.id and bits3.fd

As always, to sync with mesa. Signed-off-by: Damien Lespiau --- assembler/brw_structs.h |4 ++-- assembler/disasm.c |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/assembler/brw_structs.h b/assembler/brw_structs.h index 2815256..c442f4a 100644 --- a

[Intel-gfx] [PATCH 14/90] assembler: Rename branch_2_offset to break_cont

Once again, import the equivalent struct from mesa. Signed-off-by: Damien Lespiau --- assembler/brw_structs.h | 16 +--- assembler/main.c|8 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/assembler/brw_structs.h b/assembler/brw_structs.h index

[Intel-gfx] [PATCH 16/90] assembler: Adopt brw_structs.h from mesa

e made sure that re-generating libva's shaders don't show any difference. Signed-off-by: Damien Lespiau --- assembler/brw_structs.h | 1365 ++- 1 files changed, 624 insertions(+), 741 deletions(-) diff --git a/assembler/brw_structs.h b/assemb

[Intel-gfx] [PATCH 17/90] assembler: Remove trailing white spaces from brw_structs.h

Signed-off-by: Damien Lespiau --- assembler/brw_structs.h | 488 +++--- 1 files changed, 244 insertions(+), 244 deletions(-) diff --git a/assembler/brw_structs.h b/assembler/brw_structs.h index 218f11e..db7a9be 100644 --- a/assembler/brw_structs.h +++ b

[Intel-gfx] [PATCH 19/90] assembler: Rename BRW_ACCWRCTRL_ACCWRCTRL

To a more self-describing define. This hopefully will help its inclusion into Mesa. Signed-off-by: Damien Lespiau --- assembler/brw_defines.h |4 ++-- assembler/gram.y|2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/assembler/brw_defines.h b/assembler

[Intel-gfx] [PATCH 21/90] assembler: Remove trailing white space from brw_defines.h

Signed-off-by: Damien Lespiau --- assembler/brw_defines.h | 296 +++--- 1 files changed, 148 insertions(+), 148 deletions(-) diff --git a/assembler/brw_defines.h b/assembler/brw_defines.h index f0b358e..23402e3 100644 --- a/assembler/brw_defines.h +++ b

[Intel-gfx] [PATCH 23/90] assembler: Import ralloc from Mesa

This also add a new brw_compat.h that should help maintaining the diff between mesa's version and our as small as possible. Signed-off-by: Damien Lespiau --- assembler/Makefile.am |3 + assembler/brw_compat.h | 64 +++ assembler/ralloc.c |

[Intel-gfx] [PATCH 24/90] assembler: Remove white space from brw_eu.h

Signed-off-by: Damien Lespiau --- assembler/brw_eu.h | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/assembler/brw_eu.h b/assembler/brw_eu.h index b7009ff..262a40b 100644 --- a/assembler/brw_eu.h +++ b/assembler/brw_eu.h @@ -2,7 +2,7 @@ Copyright (C

[Intel-gfx] [PATCH 25/90] assembler: Introduce struct brw_context

A lot of the mesa code use struct brw_context to get the GPU generation and various information. Let's stub this structure and initialize it ourselves to be able to resuse mesa's code untouched. Signed-off-by: Damien Lespiau --- assembler/Makefile.am |2 + assembler/brw_contex

[Intel-gfx] [PATCH 26/90] assembler: Make an libbrw library

With the brw_* files imported from mesa. There are still a few things in that library that needs gen4asm.h, for instance the GLuint and GLint types. The hope is that eventually libbrw can be split out in its own directory and shared. Signed-off-by: Damien Lespiau --- assembler/Makefile.am

[Intel-gfx] [PATCH 27/90] assembler: Protect gen4asm.h from multiple inclusions

Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h index e47e9e6..71b8a4d 100644 --- a/assembler/gen4asm.h +++ b/assembler/gen4asm.h @@ -26,6 +26,9 @@ * */ +#ifndef

[Intel-gfx] [PATCH 18/90] assembler: Adopt enum brw_message_target from mesa

Signed-off-by: Damien Lespiau --- assembler/brw_defines.h | 44 + assembler/disasm.c | 26 +++--- assembler/gram.y| 84 +- 3 files changed, 81 insertions(+), 73 deletions(-) diff --git a/assembler

[Intel-gfx] [PATCH 28/90] assembler: Import brw_eu_compact.c

To be able to import brw_eu.c and brw_eu_emit.c later on. This could be used to get the assembler generate compact instructions at some point. Signed-off-by: Damien Lespiau --- assembler/Makefile.am | 23 +- assembler/brw_compat.h |2 + assembler/brw_context.h|4

[Intel-gfx] [PATCH 29/90] assembler: Import brw_eu.c

Another step the road of importing Mesa's emission code. Signed-off-by: Damien Lespiau --- assembler/Makefile.am |1 + assembler/brw_eu.c| 269 + 2 files changed, 270 insertions(+), 0 deletions(-) create mode 100644 assembler/brw

[Intel-gfx] [PATCH 30/90] assembler: Don't use -Wpointer-arith

Mesa's code uses the GNU C extension that allows additions and soustractions on void* (+/- 1). Signed-off-by: Damien Lespiau --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 832c6e4..cd1c201 100644 --- a/configu

[Intel-gfx] [PATCH 32/90] assembler: Use BRW_WRITEMASK_XYZW instead of the 0xf constant

Signed-off-by: Damien Lespiau --- assembler/gram.y |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/assembler/gram.y b/assembler/gram.y index 55708ca..a27375b 100644 --- a/assembler/gram.y +++ b/assembler/gram.y @@ -32,6 +32,7 @@ #include #include "gen4

[Intel-gfx] [PATCH 33/90] assembler: Remove the writemask_set field of struct dest_operand

writemask_set gets in the way of switching to using struct brw_reg and it's possible to derive it from the writemask value. Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |1 - assembler/gram.y| 10 -- 2 files changed, 4 insertions(+), 7 deletions(-) diff --

[Intel-gfx] [PATCH 34/90] assembler: Use subreg_nr to store the address register subreg

Another step towards using struct brw_reg for source and destination operands. Instead of having a separate field to store the sub register number of the address register in indirect access mode, we can reuse the subreg_nr field that was only used for direct access so far. Signed-off-by: Damien

[Intel-gfx] [PATCH 35/90] assembler: Simplify get_subreg_address()

This function can only be called to resolve subreg_nr in direct mode (there is an other function for the indirect case) and it makes no sense to call it with an immediate operand. Express those facts with asserts and simplify the logic. Signed-off-by: Damien Lespiau --- assembler/gram.y | 17

[Intel-gfx] [PATCH 36/90] assembler: Make print_instruction() take an instruction

No need to use a brw_program_instruction there as a brw_instruction is what you really dump anyway, espcially when the plan is to use brw_compile from Mesa sooner rather than later. Signed-off-by: Damien Lespiau --- assembler/main.c | 44 ++-- 1 files

[Intel-gfx] [PATCH 37/90] assembler: Refactor the code adding instructions and labels

Factoring out the code from the grammar will allow us to switch to using brw_compile in a cleaner way. Signed-off-by: Damien Lespiau --- assembler/gram.y | 84 - 1 files changed, 44 insertions(+), 40 deletions(-) diff --git a/assembler

[Intel-gfx] [PATCH 38/90] assembler: Make explicit that labels are part of the instructions list

the relocation bits into struct brw_program_instruction instead of having them in the structure representing the opcodes. Signed-off-by: Damien Lespiau --- assembler/disasm-main.c |2 +- assembler/gen4asm.h | 36 + assembler/gram.y|7 +++-- assembler

[Intel-gfx] [PATCH 39/90] assembler: Don't change the size of opcodes!

slowly emerged in the few previous commits to add a relocatable instruction with the needed fields. Signed-off-by: Damien Lespiau --- assembler/brw_structs.h |3 - assembler/gen4asm.h | 13 +++ assembler/gram.y| 193 ++ assembler/main.c

[Intel-gfx] [PATCH 40/90] assembler: Make sure nobody adds a field back to struct brw_instruction

Adding something there will break the library, so we might as check for it. Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h index aeb2b9c..388cc75 100644 --- a

[Intel-gfx] [PATCH 41/90] assembler: Don't expose functions only used in main.c

and make then static. Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |2 -- assembler/main.c|4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h index 388cc75..8dd08b7 100644 --- a/assembler/gen4asm.h +++ b

[Intel-gfx] [PATCH 42/90] assembler: Make struct declared_register use struct brw_reg

It's time to start converting the emission code in gram.y to use libbrw infrastructure. Let's start with using brw_reg for declared register. Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |4 +++- assembler/gram.y| 46 +++--

[Intel-gfx] [PATCH 43/90] assembler: Replace struct direct_reg by struct brw_reg

More code simplification can be layered on top of that (by using some brw_* helpers to create registers), that'd be for another commit. Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |8 -- assembler/gram.y| 202 +- 2 files ch

[Intel-gfx] [PATCH 44/90] assembler: Replace struct indirect_reg by struct brw_reg

More code simplification can be layered on top of that (by using some brw_* helpers to create registers), that'd be for another commit. Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |8 assembler/gram.y| 46 +++--- 2

[Intel-gfx] [PATCH 45/90] assembler: Unify the direct and indirect register type

They are all struct brw_reg registers now. Signed-off-by: Damien Lespiau --- assembler/gram.y | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/assembler/gram.y b/assembler/gram.y index 169026c..e015e0a 100644 --- a/assembler/gram.y +++ b/assembler

[Intel-gfx] [PATCH 46/90] assembler: Replace struct dst_operand by struct brw_reg

ff-by: Damien Lespiau --- assembler/gen4asm.h | 16 assembler/gram.y| 227 ++- 2 files changed, 97 insertions(+), 146 deletions(-) diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h index 8a3e95b..fe09d52 100644 --- a/assembler/gen4asm.h

[Intel-gfx] [PATCH 47/90] assembler: Consolidate the swizzling configuration on 8 bits

Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |2 +- assembler/gram.y| 67 +- 2 files changed, 24 insertions(+), 45 deletions(-) diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h index fe09d52..0048b4a 100644 --- a/assembler

[Intel-gfx] [PATCH 48/90] assembler: Get rid of src operand's swizzle_set

swizzle_set can be derived from the value of swizzle itself, no need for that field. Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |1 - assembler/gram.y| 14 -- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/assembler/gen4asm.h b/assembler

[Intel-gfx] [PATCH 49/90] assembler: Use brw_reg in the source operand

Last refactoring step in transition to struct brw_reg. Signed-off-by: Damien Lespiau --- assembler/gen4asm.h | 14 +-- assembler/gram.y| 532 ++- 2 files changed, 269 insertions(+), 277 deletions(-) diff --git a/assembler/gen4asm.h b

[Intel-gfx] [PATCH 50/90] assembler: Factor out the destination register validation

The goal is to use brw_set_dest(), so let's start by validating the register we have before generating the opcode. Signed-off-by: Damien Lespiau --- assembler/gram.y | 31 +++ 1 files changed, 19 insertions(+), 12 deletions(-) diff --git a/assembler/gra

<    5   6   7   8   9   10   11   12   13   14   >