[Intel-gfx] [PATCH 19/21] drm/i915: Enable skylake panel fitting using skylake shared scalers

2015-03-14 Thread Chandra Konduru
Modify skylake panel fitting implementation to use shared scalers. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 39 ++ 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers

[Intel-gfx] [PATCH 15/21] drm/i915: Update scaling ratio as part of crtc_compute_config

2015-03-14 Thread Chandra Konduru
Based on computed crtc config, stage any updates to scaling ratios. Also call intel_atomic_setup_scalers() to stage scaler assignments if crtc compute config staged any changes to its scaler needs. Above actions should be moved to atomic crtc once it is available. Signed-off-by: Chandra Konduru

[Intel-gfx] [PATCH 14/21] drm/i915: use current scaler state during readout_hw_state.

2015-03-14 Thread Chandra Konduru
. - some values directly from bspec To simplify things, for now using sw scaler state as readout state. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 00/21] skylake display scalers

2015-03-14 Thread Chandra Konduru
will revisit scalers and perform any additional testing after atomic crtc is in place. Thanks, Chandra Chandra Konduru (21): drm/i915: Adding drm helper function drm_plane_from_index(). drm/i915: Register definitions for skylake scalers drm/i915: Enable get_colorkey functions for primary

[Intel-gfx] [PATCH 12/21] drm/i915: Ensure colorkey and scaling aren't enabled at same time

2015-03-14 Thread Chandra Konduru
Plane scaling and colorkey are mutually exclusive. Ensure scaling isn't active at the time of enabling colorkey. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_sprite.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/driver

[Intel-gfx] [PATCH 08/21] drm/i915: Add helper function to update scaler_users in crtc_state

2015-03-14 Thread Chandra Konduru
This helper function stages a scaler request for a plane/crtc into crtc_state->scaler_users (which is a bit field). It also performs required checks before staging any change into scaler_state. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c |

[Intel-gfx] [PATCH 07/21] drm/i915: Helper function to update skylake scaling ratio.

2015-03-14 Thread Chandra Konduru
Helper function updates supported scaling ratios based on cdclk and crtc clocks. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 20/21] drm/i915: Enable skylake primary plane scaling using shared scalers

2015-03-14 Thread Chandra Konduru
This patch enables skylake primary plane display scaling using shared scalers atomic desgin. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 77 +++--- 1 file changed, 71 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 16/21] drm/i915: Ensure setting up scalers into staged crtc_state

2015-03-14 Thread Chandra Konduru
From intel_atomic_check, call intel_atomic_setup_scalers() to assign scalers based on staged scaling requests. Fail the transaction if setup returns error. Setting up of scalers should be moved to atomic crtc check once atomic crtc is ready. Signed-off-by: Chandra Konduru --- drivers/gpu/drm

[Intel-gfx] [PATCH 18/21] drm/i915: stage panel fitting scaler request for fixed mode panel

2015-03-14 Thread Chandra Konduru
This patch calls skl_update_scaler_users() to stage a panel fitting request for fixed mode panel. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_dp.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCH 04/21] drm/i915: skylake scaler structure definitions

2015-03-14 Thread Chandra Konduru
. scaler_id is used instead of scaler pointer in plane or crtc state to avoid updating scaler pointer everytime a new crtc_state is created. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_drv.h | 99 ++ 1 file changed, 99 insertions(+) diff --git

[Intel-gfx] [PATCH 06/21] drm/i915: Dump scaler_state too as part of dumping crtc_state

2015-03-14 Thread Chandra Konduru
Dumps scaler state as part of dumping crtc_state. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 47 -- 1 file changed, 45 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 05/21] drm/i915: Initialize skylake scalers

2015-03-14 Thread Chandra Konduru
Initializing scalers with supported values during crtc init. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 51 ++ 1 file changed, 51 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 10/21] drm/i915: Helper function to detach a scaler from a plane or crtc

2015-03-14 Thread Chandra Konduru
This function is called from commit path of a plane or crtc. It programs scaler registers to detach (aka. unbinds) scaler from requested plane or crtc if it isn't in use. It also resets scaler_id in crtc/plane state. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c |

[Intel-gfx] [PATCH 01/21] drm/i915: Adding drm helper function drm_plane_from_index().

2015-03-14 Thread Chandra Konduru
Adding drm helper function to return plane pointer from index where index is a returned by drm_plane_index. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/drm_crtc.c | 20 include/drm/drm_crtc.h |1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 02/21] drm/i915: Register definitions for skylake scalers

2015-03-14 Thread Chandra Konduru
Adding register definitions for skylake scalers. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/i915_reg.h | 114 +++ 1 file changed, 114 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index cc8ebab

[Intel-gfx] [PATCH 09/21] drm/i915: Add atomic function to setup scalers scalers for a crtc.

2015-03-14 Thread Chandra Konduru
d) to respective planes in hw - as part of crtc_commit, scaler will be either attached or detached to crtc in hw Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_atomic.c | 137 +++ drivers/gpu/drm/i915/intel_drv.h|3 + 2 files changed, 140 inser

[Intel-gfx] [PATCH 17/21] drm/i915: copy staged scaler state from drm state to crtc->config.

2015-03-14 Thread Chandra Konduru
This is required for commit to perform as per staged assignment of scalers until atomic crtc commit function is available. As a place holder doing this copy from intel_atomic_commit for scaling to operate correctly. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_atomic.c | 12

[Intel-gfx] [PATCH 03/21] drm/i915: Enable get_colorkey functions for primary plane.

2015-03-14 Thread Chandra Konduru
Made intel_colorkey_enabled and skl_get_colorkey functions available for primary plane. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_drv.h|3 +++ drivers/gpu/drm/i915/intel_sprite.c |9 + 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH 11/21] drm/i915: Ensure planes begin with no scaler.

2015-03-14 Thread Chandra Konduru
Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c |2 ++ drivers/gpu/drm/i915/intel_sprite.c |1 + 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 277c895..e07c24e 100644 --- a

[Intel-gfx] [PATCH 21/21] drm/i915: Enable skylake sprite plane scaling using shared scalers

2015-03-14 Thread Chandra Konduru
This patch enables skylake sprite plane display scaling using shared scalers atomic desgin. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_sprite.c | 79 +++ 1 file changed, 61 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 13/21] drm/i915: Preserve scaler state when clearing crtc_state

2015-03-14 Thread Chandra Konduru
crtc_state is cleared during mode set which wipes out complete scaler state too. This is causing issues. To fix, ensure scaler state is preserved because it contains not only crtc scaler usage, but also planes using scalers on this crtc. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 06/21 v2] drm/i915: Dump scaler_state too as part of dumping crtc_state

2015-03-20 Thread Chandra Konduru
Dumps scaler state as part of dumping crtc_state. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 47 -- 1 file changed, 45 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 01/21 v2] drm/i915: Adding drm helper function drm_plane_from_index().

2015-03-20 Thread Chandra Konduru
Adding drm helper function to return plane pointer from index where index is a returned by drm_plane_index. v2: -avoided nested loop by adding loop count (Daniel) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/drm_crtc.c | 22 ++ include/drm/drm_crtc.h |1 + 2

[Intel-gfx] [PATCH 00/21 v2] Adding support for skylake shared scalers

2015-03-20 Thread Chandra Konduru
ig_compare (Daniel) -use single copy of scaler limits (Matt) -do gen checks before calling a helper (Matt) -use skylake_pfit_update to control skylake panel fitter(me) -rebased on top of Ander's v3 patch series (me) Chandra Konduru (21): drm/i915: Adding drm

[Intel-gfx] [PATCH 03/21 v2] drm/i915: Enable get_colorkey functions for primary plane.

2015-03-20 Thread Chandra Konduru
Made intel_colorkey_enabled and skl_get_colorkey functions available for primary plane. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_drv.h|3 +++ drivers/gpu/drm/i915/intel_sprite.c |9 + 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH 15/21 v2] drm/i915: Update scaling ratio as part of crtc_compute_config

2015-03-20 Thread Chandra Konduru
check to caller (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index dfd24ed..c393480 100644 --- a/drivers

[Intel-gfx] [PATCH 11/21 v2] drm/i915: Ensure planes begin with no scaler.

2015-03-20 Thread Chandra Konduru
Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c |2 ++ drivers/gpu/drm/i915/intel_sprite.c |1 + 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 7150c33..ffaed7b 100644 --- a

[Intel-gfx] [PATCH 07/21 v2] drm/i915: Helper function to update skylake scaling ratio.

2015-03-20 Thread Chandra Konduru
Helper function updates supported scaling ratios based on cdclk and crtc clocks. v2: -update single copy of scaling ratios (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 18/21 v2] drm/i915: stage panel fitting scaler request for fixed mode panel

2015-03-20 Thread Chandra Konduru
This patch calls skl_update_scaler_users() to stage a panel fitting request for fixed mode panel. v2: -move gen check to caller (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_dp.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 08/21 v2] drm/i915: Add helper function to update scaler_users in crtc_state

2015-03-20 Thread Chandra Konduru
ble purpose (me) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 143 ++ drivers/gpu/drm/i915/intel_drv.h |3 + 2 files changed, 146 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i

[Intel-gfx] [PATCH 02/21 v2] drm/i915: Register definitions for skylake scalers

2015-03-20 Thread Chandra Konduru
Adding register definitions for skylake scalers. v2: -add #define for plane selection mask (me) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/i915_reg.h | 115 +++ 1 file changed, 115 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b

[Intel-gfx] [PATCH 13/21 v2] drm/i915: Preserve scaler state when clearing crtc_state

2015-03-20 Thread Chandra Konduru
crtc_state is cleared during mode set which wipes out complete scaler state too. This is causing issues. To fix, ensure scaler state is preserved because it contains not only crtc scaler usage, but also planes using scalers on this crtc. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 19/21 v2] drm/i915: Enable skylake panel fitting using skylake shared scalers

2015-03-20 Thread Chandra Konduru
(Daniel) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 81 ++ 1 file changed, 54 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index c393480..16dcd31 100644 --- a

[Intel-gfx] [PATCH 16/21 v2] drm/i915: Ensure setting up scalers into staged crtc_state

2015-03-20 Thread Chandra Konduru
) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_atomic.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_atomic.c b/drivers/gpu/drm/i915/intel_atomic.c index 407516a..73e94c4 100644 --- a/drivers/gpu/drm/i915/intel_atomic.c +++ b

[Intel-gfx] [PATCH 12/21 v2] drm/i915: Ensure colorkey and scaling aren't enabled at same time

2015-03-20 Thread Chandra Konduru
Plane scaling and colorkey are mutually exclusive. Ensure scaling isn't active at the time of enabling colorkey. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_sprite.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/driver

[Intel-gfx] [PATCH 20/21 v2] drm/i915: Enable skylake primary plane scaling using shared scalers

2015-03-20 Thread Chandra Konduru
This patch enables skylake primary plane display scaling using shared scalers atomic desgin. v2: -use single copy of scaler limits (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 77 +++--- 1 file changed, 71 insertions(+), 6

[Intel-gfx] [PATCH 10/21 v2] drm/i915: Helper function to detach a scaler from a plane or crtc

2015-03-20 Thread Chandra Konduru
This function is called from commit path of a plane or crtc. It programs scaler registers to detach (aka. unbinds) scaler from requested plane or crtc if it isn't in use. It also resets scaler_id in crtc/plane state. v2: -improved a log message (me) Signed-off-by: Chandra Konduru --- dr

[Intel-gfx] [PATCH 21/21 v2] drm/i915: Enable skylake sprite plane scaling using shared scalers

2015-03-20 Thread Chandra Konduru
This patch enables skylake sprite plane display scaling using shared scalers atomic desgin. v2: -use single copy of scaler limits (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_sprite.c | 79 +++ 1 file changed, 61 insertions(+), 18

[Intel-gfx] [PATCH 14/21 v2] drm/i915: use current scaler state during readout_hw_state.

2015-03-20 Thread Chandra Konduru
During readout_hw_state, rebuild crtc scaler_state from hw state: - crtc scaler id - scaler users - scaling ratios Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b

[Intel-gfx] [PATCH 05/21 v2] drm/i915: Initialize skylake scalers

2015-03-20 Thread Chandra Konduru
Initializing scalers with supported values during crtc init. v2: -initialize single copy of min/max values (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 53 ++ 1 file changed, 53 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 17/21 v2] drm/i915: copy staged scaler state from drm state to crtc->config.

2015-03-20 Thread Chandra Konduru
This is required for commit to perform as per staged assignment of scalers until atomic crtc commit function is available. As a place holder doing this copy from intel_atomic_commit for scaling to operate correctly. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_atomic.c | 12

[Intel-gfx] [PATCH 09/21 v2] drm/i915: Add atomic function to setup scalers scalers for a crtc.

2015-03-20 Thread Chandra Konduru
d) to respective planes in hw - as part of crtc_commit, scaler will be either attached or detached to crtc in hw v2: -removed a log message (me) -changed input parameter to crtc_state (me) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_atomic.c |

[Intel-gfx] [PATCH 04/21 v2] drm/i915: skylake scaler structure definitions

2015-03-20 Thread Chandra Konduru
. scaler_id is used instead of scaler pointer in plane or crtc state to avoid updating scaler pointer everytime a new crtc_state is created. v2: -made single copy of min/max values for scalers (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_drv.h | 99

[Intel-gfx] [PATCH 2/2] i-g-t: Adding panel fitting test case

2015-03-20 Thread Chandra Konduru
From: chandra konduru This patch is adding i-g-t test case to test panel fitting usages. Signed-off-by: chandra konduru --- tests/.gitignore |1 + tests/Android.mk |1 + tests/Makefile.sources|1 + tests/kms_panel_fitting.c | 270

[Intel-gfx] [PATCH 1/2] i-g-t: Adding plane scaling test case

2015-03-20 Thread Chandra Konduru
From: chandra konduru This patch is adding i-g-t plane scaling test case to test couple basic display plane scaling usages. Additional test scenarios can be added later. v2: -Added iterative scaling to visually observe scaling (me) v3: -Added a flag to control primary plane scaling. Signed

[Intel-gfx] [PATCH 05/21 v3] drm/i915: Initialize skylake scalers

2015-03-25 Thread Chandra Konduru
Initializing scalers with supported values during crtc init. v2: -initialize single copy of min/max values (Matt) v3: -moved gen check to callsite (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 52 ++ 1 file changed, 52

[Intel-gfx] [PATCH 07/21 v3] drm/i915: Helper function to update skylake scaling ratio.

2015-03-25 Thread Chandra Konduru
Helper function updates supported scaling ratios based on cdclk and crtc clocks. v2: -update single copy of scaling ratios (Matt) v3: -min scaling ratio is limited by either display engine limit or clocks, it is not related to previous ratio (Matt, me) Signed-off-by: Chandra Konduru

[Intel-gfx] [PATCH 08/21 v3] drm/i915: Add helper function to update scaler_users in crtc_state

2015-03-25 Thread Chandra Konduru
ble purpose (me) v3: -updated function header to kerneldoc format (Matt) -dropped need_scaling checks (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 143 ++ drivers/gpu/drm/i915/intel_drv.h |3 + 2 files changed,

[Intel-gfx] [PATCH 09/21 v3] drm/i915: Add atomic function to setup scalers scalers for a crtc.

2015-03-25 Thread Chandra Konduru
from drm_atomic_get_plane_state (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_atomic.c | 142 +++ drivers/gpu/drm/i915/intel_drv.h|3 + 2 files changed, 145 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_atomic.c b/drivers/gp

[Intel-gfx] [PATCH 10/21 v3] drm/i915: Helper function to detach a scaler from a plane or crtc

2015-03-25 Thread Chandra Konduru
case where scaler id needs to be reset (me) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 57 ++ drivers/gpu/drm/i915/intel_drv.h |1 + 2 files changed, 58 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/dr

[Intel-gfx] [PATCH v3] i-g-t: Adding test case to test background color.

2015-03-30 Thread Chandra Konduru
From: chandra konduru Adding i-g-t test case to test display crtc background color. v2: - Added IGT_TEST_DESCRIPTION() (Thomas Wood) - Added to .gitignore (Thomas Wood) - Added additional details to function header (Thomas Wood) - Simplified igt_main (Thomas Wood) v3: - rebased to latest

[Intel-gfx] [PATCH 1/2] i-g-t: Adding plane scaling test case

2015-03-30 Thread Chandra Konduru
From: chandra konduru This patch is adding i-g-t plane scaling test case to test couple basic display plane scaling usages. Additional test scenarios can be added later. v2: -Added iterative scaling to visually observe scaling (me) v3: -Added a flag to control primary plane scaling (me) v4

[Intel-gfx] [PATCH 2/2] i-g-t: Adding panel fitting test case

2015-03-30 Thread Chandra Konduru
From: chandra konduru This patch is adding i-g-t test case to test panel fitting usages. v2: -use new tiled types when calling igt_create_fb (me) Signed-off-by: chandra konduru --- tests/.gitignore |1 + tests/Android.mk |1 + tests/Makefile.sources|1

[Intel-gfx] [PATCH 01/20] drm/i915: Adding drm helper function drm_plane_from_index().

2015-04-01 Thread Chandra Konduru
Adding drm helper function to return plane pointer from index where index is a returned by drm_plane_index. v2: -avoided nested loop by adding loop count (Daniel) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/drm_crtc.c | 22 ++ include/drm/drm_crtc.h |1 + 2

[Intel-gfx] [PATCH 13/20] drm/i915: use current scaler state during readout_hw_state.

2015-04-01 Thread Chandra Konduru
During readout_hw_state, rebuild crtc scaler_state from hw state: - crtc scaler id - scaler users - scaling ratios Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b

[Intel-gfx] [PATCH 03/20] drm/i915: skylake scaler structure definitions

2015-04-01 Thread Chandra Konduru
. scaler_id is used instead of scaler pointer in plane or crtc state to avoid updating scaler pointer everytime a new crtc_state is created. v2: -made single copy of min/max values for scalers (Matt) v3: -updated commentary for scaler_id (me) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 15/20] drm/i915: Ensure setting up scalers into staged crtc_state

2015-04-01 Thread Chandra Konduru
) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_atomic.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_atomic.c b/drivers/gpu/drm/i915/intel_atomic.c index fab1f13..0b21cd6 100644 --- a/drivers/gpu/drm/i915/intel_atomic.c +++ b

[Intel-gfx] [PATCH 02/20] drm/i915: Register definitions for skylake scalers

2015-04-01 Thread Chandra Konduru
Adding register definitions for skylake scalers. v2: -add #define for plane selection mask (me) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/i915_reg.h | 115 +++ 1 file changed, 115 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b

[Intel-gfx] [PATCH 07/20] drm/i915: Dump scaler_state too as part of dumping crtc_state

2015-04-01 Thread Chandra Konduru
Dumps scaler state as part of dumping crtc_state. v2: -use regular ints from plane_state->src (me) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 47 -- 1 file changed, 45 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH 05/20] drm/i915: Initialize skylake scalers

2015-04-01 Thread Chandra Konduru
Initializing scalers with supported values during crtc init. v2: -initialize single copy of min/max values (Matt) v3: -moved gen check to callsite (Matt) v4: -squashed planes begin with no scaler to here (me) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 54

[Intel-gfx] [PATCH 18/20] drm/i915: Enable skylake panel fitting using skylake shared scalers

2015-04-01 Thread Chandra Konduru
(Daniel) v3: -use updated detach scalers function (me) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 81 ++ 1 file changed, 54 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 16/20] drm/i915: copy staged scaler state from drm state to crtc->config.

2015-04-01 Thread Chandra Konduru
This is required for commit to perform as per staged assignment of scalers until atomic crtc commit function is available. As a place holder doing this copy from intel_atomic_commit for scaling to operate correctly. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_atomic.c | 12

[Intel-gfx] [PATCH 11/20] drm/i915: Helper function to detach a scaler from a plane or crtc

2015-04-01 Thread Chandra Konduru
case where scaler id needs to be reset (me) v4: -changes made not to modify state in commit path (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 29 + drivers/gpu/drm/i915/intel_drv.h |1 + 2 files changed, 30 insertions(+)

[Intel-gfx] [PATCH 20/20] drm/i915: Enable skylake sprite plane scaling using shared scalers

2015-04-01 Thread Chandra Konduru
This patch enables skylake sprite plane display scaling using shared scalers atomic desgin. v2: -use single copy of scaler limits (Matt) v3: -detaching scalers moved to crtc commit path (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_sprite.c | 60

[Intel-gfx] [PATCH 14/20] drm/i915: Update scaling ratio as part of crtc_compute_config

2015-04-01 Thread Chandra Konduru
check to caller (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 834ea46..166b9d6 100644 --- a/drivers

[Intel-gfx] [PATCH 06/20] drm/i915: Convert primary plane 16.16 values to regular ints

2015-04-01 Thread Chandra Konduru
This patch converts intel_plane_state->src rect from 16.16 values into regular ints. This approach aligns with sprite_plane_state->src rects which are already in regular ints. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 13 +++-- 1 file chang

[Intel-gfx] [PATCH 17/20] drm/i915: stage panel fitting scaler request for fixed mode panel

2015-04-01 Thread Chandra Konduru
This patch calls skl_update_scaler_users() to stage a panel fitting request for fixed mode panel. v2: -move gen check to caller (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_dp.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 00/20] skylake display scalers

2015-04-01 Thread Chandra Konduru
tails on changes. This series should cleanly merge to latest drm-intel-nighly. Chandra Konduru (20): drm/i915: Adding drm helper function drm_plane_from_index(). drm/i915: Register definitions for skylake scalers drm/i915: skylake scaler structure definitions drm/i915: Initialize plane colork

[Intel-gfx] [PATCH 19/20] drm/i915: Enable skylake primary plane scaling using shared scalers

2015-04-01 Thread Chandra Konduru
This patch enables skylake primary plane display scaling using shared scalers atomic desgin. v2: -use single copy of scaler limits (Matt) v3: -move detach_scalers to crtc commit path (Matt) -use values in plane_state->src as regular integers (me) Signed-off-by: Chandra Konduru --- drivers/

[Intel-gfx] [PATCH 09/20] drm/i915: Add helper function to update scaler_users in crtc_state

2015-04-01 Thread Chandra Konduru
use values in plane_state->src as regular integers (me) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 144 ++ drivers/gpu/drm/i915/intel_drv.h |3 + drivers/gpu/drm/i915/intel_sprite.c |9 +++ 3 files changed, 156 inse

[Intel-gfx] [PATCH 10/20] drm/i915: Add atomic function to setup scalers scalers for a crtc.

2015-04-01 Thread Chandra Konduru
from drm_atomic_get_plane_state (Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_atomic.c | 142 +++ drivers/gpu/drm/i915/intel_drv.h|3 + 2 files changed, 145 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_atomic.c b/drivers/gp

[Intel-gfx] [PATCH 04/20] drm/i915: Initialize plane colorkey to NONE

2015-04-01 Thread Chandra Konduru
This patch initializes plane colorkey to NONE. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c |1 + drivers/gpu/drm/i915/intel_sprite.c |1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 08/20] drm/i915: Helper function to update skylake scaling ratio.

2015-04-01 Thread Chandra Konduru
Helper function updates supported scaling ratios based on cdclk and crtc clocks. v2: -update single copy of scaling ratios (Matt) v3: -min scaling ratio is limited by either display engine limit or clocks, it is not related to previous ratio (Matt, me) Signed-off-by: Chandra Konduru

[Intel-gfx] [PATCH 12/20] drm/i915: Preserve scaler state when clearing crtc_state

2015-04-01 Thread Chandra Konduru
crtc_state is cleared during mode set which wipes out complete scaler state too. This is causing issues. To fix, ensure scaler state is preserved because it contains not only crtc scaler usage, but also planes using scalers on this crtc. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915: reset drm state backpointer in crtc_state

2015-04-06 Thread Chandra Konduru
At end of intel_crtc_set_config, reset crtc_state's drm_state back pointer to null. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm

[Intel-gfx] [PATCH 07/14] drm/i915: Dump scaler_state too as part of dumping crtc_state

2015-04-07 Thread Chandra Konduru
Dumps scaler state as part of dumping crtc_state. v2: -use regular ints from plane_state->src (me) v3: -changes to align with updated scaler structures (Matt) -interpret plane_state->src as 16.16 format (Matt, Daniel) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_dis

[Intel-gfx] [PATCH 06/14] drm/i915: Keep sprite plane src rect in 16.16 format

2015-04-07 Thread Chandra Konduru
This patch keeps intel_plane_state->src rect back into 16.16 format. v2: -sprite src rect to match primary format (Matt, Daniel) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_sprite.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH 11/14] drm/i915: copy staged scaler state from drm state to crtc->config.

2015-04-07 Thread Chandra Konduru
This is required for commit to perform as per staged assignment of scalers until atomic crtc commit function is available. As a place holder doing this copy from intel_atomic_commit for scaling to operate correctly. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_atomic.c | 12

[Intel-gfx] [PATCH 08/14] drm/i915: Preserve scaler state when clearing crtc_state

2015-04-07 Thread Chandra Konduru
crtc_state is cleared during mode set which wipes out complete scaler state too. This is causing issues. To fix, ensure scaler state is preserved because it contains not only crtc scaler usage, but also planes using scalers on this crtc. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 03/14] drm/i915: skylake scaler structure definitions

2015-04-07 Thread Chandra Konduru
(Matt) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_drv.h | 68 ++ 1 file changed, 68 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index 4799b11..adca692 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 09/14] drm/i915: setup scalers for crtc_compute_config

2015-04-07 Thread Chandra Konduru
from drm_atomic_get_plane_state (Matt) v4: -changes to align with updated scaler structure (Matt, me) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_atomic.c | 137 ++ drivers/gpu/drm/i915/intel_display.c | 10 ++- drivers/gpu/drm/i915/intel_drv.h |3 + 3

[Intel-gfx] [PATCH 04/14] drm/i915: Initialize plane colorkey to NONE

2015-04-07 Thread Chandra Konduru
This patch initializes plane colorkey to NONE. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c |1 + drivers/gpu/drm/i915/intel_sprite.c |1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 00/14] skylake display scalers

2015-04-07 Thread Chandra Konduru
sprite src tect in 16.16 format Though changes are minor but they got sprinkled into multiple patches. Sending full patch series for completeness. Individual patch headers have additional details on changes. This series should cleanly merge to latest drm-intel-nighly. Chandra Konduru (14): drm

[Intel-gfx] [PATCH 01/14] drm: Adding drm helper function drm_plane_from_index().

2015-04-07 Thread Chandra Konduru
Adding drm helper function to return plane pointer from index where index is a returned by drm_plane_index. v2: -avoided nested loop by adding loop count (Daniel) v3: -updated patch header prefix to 'drm' (Matt) Cc: dri-de...@lists.freedesktop.org Signed-off-by: Chandra Konduru --

[Intel-gfx] [PATCH 05/14] drm/i915: Initialize skylake scalers

2015-04-07 Thread Chandra Konduru
: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 32 drivers/gpu/drm/i915/intel_sprite.c |1 + 2 files changed, 33 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index f6ff02d..9129501

[Intel-gfx] [PATCH 10/14] drm/i915: Ensure setting up scalers into staged crtc_state

2015-04-07 Thread Chandra Konduru
) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_atomic.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_atomic.c b/drivers/gpu/drm/i915/intel_atomic.c index ac317b4..9663d4d 100644 --- a/drivers/gpu/drm/i915/intel_atomic.c +++ b

[Intel-gfx] [PATCH 02/14] drm/i915: Register definitions for skylake scalers

2015-04-07 Thread Chandra Konduru
Adding register definitions for skylake scalers. v2: -add #define for plane selection mask (me) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/i915_reg.h | 115 +++ 1 file changed, 115 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b

[Intel-gfx] [PATCH 12/14] drm/i915: skylake panel fitting using shared scalers

2015-04-07 Thread Chandra Konduru
me) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 250 ++ drivers/gpu/drm/i915/intel_dp.c |8 ++ drivers/gpu/drm/i915/intel_drv.h |4 + 3 files changed, 235 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/i

[Intel-gfx] [PATCH 13/14] drm/i915: skylake primary plane scaling using shared scalers

2015-04-07 Thread Chandra Konduru
res (Matt, me) -keep plane src rect in 16.16 format (Matt, Daniel) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_atomic.c |5 +- drivers/gpu/drm/i915/intel_display.c | 96 -- drivers/gpu/drm/i915/intel_drv.h |1 + drivers/gpu/drm/i

[Intel-gfx] [PATCH 14/14] drm/i915: skylake sprite plane scaling using shared scalers

2015-04-07 Thread Chandra Konduru
(Matt, Daniel) Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_sprite.c | 64 +++ 1 file changed, 50 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c index 955965c..ae503ee

[Intel-gfx] [PATCH] drm/i915: Delete duplicate #defines added for DCx

2015-06-10 Thread Chandra Konduru
Delete the duplicate #defines introduced by: commit 6b457d31ea0465fcadcf6d5044f5f71398954727 Author: A.Sunil Kamath Date: Thu Apr 16 14:22:09 2015 +0530 drm/i915/skl: Implement enable/disable for Display C5 state. Signed-off-by: Chandra Konduru

[Intel-gfx] [PATCH v4] drm/i915: Add support for SKL background color

2015-06-26 Thread Chandra Konduru
This patch adds support for Skylake display pipe background color. Signed-off-by: Chandra Konduru --- Documentation/DocBook/drm.tmpl | 10 - drivers/gpu/drm/i915/i915_reg.h | 10 + drivers/gpu/drm/i915/intel_display.c | 73 ++ drivers/gpu

[Intel-gfx] [PATCH 0/2] Fix min dbuf, 90/270 wm calcs

2015-06-26 Thread Chandra Konduru
This patch series allocates minimum dbuf blocks required for tile-y, tile-yf buffers correctly as per bspec. Also in WM calculations, for 90/270, swaps source width and height. Chandra Konduru (2): drm/i915: Allocate min dbuf blocks per bspec drm/i915: In DBUF/WM calcs for 90/270, swap w &am

[Intel-gfx] [PATCH 1/2] drm/i915: Allocate min dbuf blocks per bspec

2015-06-26 Thread Chandra Konduru
Properly allocate min blocks per hw requirements. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_pm.c | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH 2/2] drm/i915: In DBUF/WM calcs for 90/270, swap w & h

2015-06-26 Thread Chandra Konduru
This patch swaps src width and height for dbuf/wm calculations when rotation is 90/270 as per hw requirements. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_pm.c | 32 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 0/2] Fix min dbuf, 90/270 wm calcs

2015-06-26 Thread Chandra Konduru
Resending with correct patches. This patch series allocates minimum dbuf blocks required for tile-y, tile-yf buffers correctly as per bspec. Also in WM calculations, for 90/270, swaps source width and height. Chandra Konduru (2): drm/i915: Allocate min dbuf blocks per bspec drm/i915: In

[Intel-gfx] [PATCH 1/2] drm/i915: Allocate min dbuf blocks per bspec

2015-06-26 Thread Chandra Konduru
Properly allocate min blocks per hw requirements. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_pm.c | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH 2/2] drm/i915: In DBUF/WM calcs for 90/270, swap w & h

2015-06-26 Thread Chandra Konduru
This patch swaps src width and height for dbuf/wm calculations when rotation is 90/270 as per hw requirements. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_pm.c | 32 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 09/15] drm/i915: Add NV12 as supported format for sprite plane

2015-08-19 Thread Chandra Konduru
This patch adds NV12 to list of supported formats for sprite plane. Signed-off-by: Chandra Konduru Testcase: igt/kms_nv12 --- drivers/gpu/drm/i915/intel_sprite.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sprite.c b

  1   2   3   >