Re: [Intel-gfx] [PATCH 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-29 Thread Daniel Vetter
On Tue, Jul 27, 2021 at 04:37:22PM +0200, Peter Zijlstra wrote: > On Thu, Jul 22, 2021 at 12:38:10PM +0200, Daniel Vetter wrote: > > On Thu, Jul 22, 2021 at 05:29:27PM +0800, Desmond Cheong Zhi Xi wrote: > > > Inside drm_is_current_master, using the outer drm_device.master_mutex > > > to protect re

Re: [Intel-gfx] refactor the i915 GVT support

2021-07-29 Thread Christoph Hellwig
On Wed, Jul 28, 2021 at 02:59:25PM -0300, Jason Gunthorpe wrote: > On Wed, Jul 28, 2021 at 01:38:58PM +, Wang, Zhi A wrote: > > > I guess those APIs you were talking about are KVM-only. For other > > hypervisors, e.g. Xen, ARCN cannot use the APIs you mentioned. Not > > sure if you have alread

Re: [Intel-gfx] [PATCH v3 02/14] vfio/mbochs: Fix missing error unwind of mbochs_used_mbytes

2021-07-29 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v3 04/14] vfio: Provide better generic support for open/release vfio_device_ops

2021-07-29 Thread Christoph Hellwig
> + device->open_count++; > + if (device->open_count == 1 && device->ops->open_device) { I would have written this as if (++device->open_count == 1 && device->ops->open_device) { to make the pattern more clear, but that is just a minor nitpick. Otherwise looks good: Reviewed-by

[Intel-gfx] ✗ Fi.CI.IGT: failure for Fix gem_ctx_persistence failures with GuC submission

2021-07-29 Thread Patchwork
== Series Details == Series: Fix gem_ctx_persistence failures with GuC submission URL : https://patchwork.freedesktop.org/series/93149/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10415_full -> Patchwork_20733_full Summar

Re: [Intel-gfx] refactor the i915 GVT support

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 09:20:22AM +0200, Christoph Hellwig wrote: > On Wed, Jul 28, 2021 at 02:59:25PM -0300, Jason Gunthorpe wrote: > > On Wed, Jul 28, 2021 at 01:38:58PM +, Wang, Zhi A wrote: > > > > > I guess those APIs you were talking about are KVM-only. For other > > > hypervisors, e.g.

Re: [Intel-gfx] [PATCH v3 09/14] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set

2021-07-29 Thread Christoph Hellwig
> +/* > + * vfio-core considers a group to be viable and will create a vfio_device > even > + * if some devices are bound to drivers like pci-stub or pcieport. Here we > + * require all PCI devices to be inside our dev_set since that ensures they > stay > + * put and that every driver controllin

Re: [Intel-gfx] [PATCH] drm/i915: Fix the 12 BPC bits for PIPE_MISC reg

2021-07-29 Thread Shankar, Uma
> -Original Message- > From: Nautiyal, Ankit K > Sent: Monday, July 19, 2021 9:55 AM > To: intel-gfx@lists.freedesktop.org > Cc: Shankar, Uma ; Nikula, Jani > ; > ville.syrj...@linux.intel.com > Subject: [PATCH] drm/i915: Fix the 12 BPC bits for PIPE_MISC reg Append display in header.

[Intel-gfx] ✓ Fi.CI.IGT: success for Provide core infrastructure for managing open/release (rev7)

2021-07-29 Thread Patchwork
== Series Details == Series: Provide core infrastructure for managing open/release (rev7) URL : https://patchwork.freedesktop.org/series/92556/ State : success == Summary == CI Bug Log - changes from CI_DRM_10415_full -> Patchwork_20734_full

Re: [Intel-gfx] refactor the i915 GVT support

2021-07-29 Thread Wang, Zhi A
On 7/28/2021 8:59 PM, Jason Gunthorpe wrote: > On Wed, Jul 28, 2021 at 01:38:58PM +, Wang, Zhi A wrote: > >> I guess those APIs you were talking about are KVM-only. For other >> hypervisors, e.g. Xen, ARCN cannot use the APIs you mentioned. Not >> sure if you have already noticed that VFIO is K

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/7] lib/i915/gem_mman: add FIXED mmap mode

2021-07-29 Thread Petri Latvala
On Wed, Jul 28, 2021 at 06:53:50PM -0700, Dixit, Ashutosh wrote: > On Tue, 27 Jul 2021 23:08:40 -0700, Petri Latvala wrote: > > > > On Tue, Jul 27, 2021 at 07:01:24PM -0700, Dixit, Ashutosh wrote: > > > On Mon, 26 Jul 2021 05:03:04 -0700, Matthew Auld wrote: > > > > > > > > diff --git a/lib/i915/ge

Re: [Intel-gfx] [PATCH i-g-t v2 04/11] lib/i915/gem_mman: add fixed mode to gem_mmap__cpu

2021-07-29 Thread Matthew Auld
On 29/07/2021 00:07, Dixit, Ashutosh wrote: On Wed, 28 Jul 2021 03:30:34 -0700, Matthew Auld wrote: diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c index 337d28fb..6f5e6d72 100644 --- a/lib/i915/gem_mman.c +++ b/lib/i915/gem_mman.c @@ -434,7 +434,13 @@ void *gem_mmap__device_coherent(int

[Intel-gfx] [PATCH rdma-next v3 0/3] SG fix together with update to RDMA umem

2021-07-29 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v3: * Rewrote to new API suggestion * Split for more patches v2: https://lore.kernel.org/lkml/cover.1626605893.git.leo...@nvidia.com * Changed implementation of first patch, based on our discussion with Christoph. https://lore.kernel.org/lkml/ynwavtt0qmqdx.

[Intel-gfx] [PATCH rdma-next v3 1/3] lib/scatterlist: Provide a dedicated function to support table append

2021-07-29 Thread Leon Romanovsky
From: Maor Gottlieb RDMA is the only in-kernel user that uses __sg_alloc_table_from_pages to append pages dynamically. In the next patch. That mode will be extended and that function will get more parameters. So separate it into a unique function to make such change more clear. Signed-off-by: Ma

[Intel-gfx] [PATCH rdma-next v3 2/3] lib/scatterlist: Fix wrong update of orig_nents

2021-07-29 Thread Leon Romanovsky
From: Maor Gottlieb orig_nents should represent the number of entries with pages, but __sg_alloc_table_from_pages sets orig_nents as the number of total entries in the table. This is wrong when the API is used for dynamic allocation where not all the table entries are mapped with pages. It wasn't

[Intel-gfx] [PATCH rdma-next v3 3/3] RDMA: Use the sg_table directly and remove the opencoded version from umem

2021-07-29 Thread Leon Romanovsky
From: Maor Gottlieb This allows using the normal sg_table APIs and makes all the code cleaner. Remove sgt, nents and nmapd from ib_umem. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe --- drivers/infiniband/core/umem.c | 32 +--

[Intel-gfx] ✗ Fi.CI.BUILD: failure for SG fix together with update to RDMA umem (rev3)

2021-07-29 Thread Patchwork
== Series Details == Series: SG fix together with update to RDMA umem (rev3) URL : https://patchwork.freedesktop.org/series/92682/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h

[Intel-gfx] [PATCH v2] drm/i915/selftests: prefer the create_user helper

2021-07-29 Thread Matthew Auld
No need to hand roll the set_placements stuff, now that that we have a helper for this. v2: add back the -ENODEV checking since it's possible for stolen to be probed, and yet still be non-functional Signed-off-by: Matthew Auld Cc: Jason Ekstrand Reviewed-by: Jason Ekstrand --- .../drm/i915/ge

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Introduce Intel PXP (rev2)

2021-07-29 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Intel PXP (rev2) URL : https://patchwork.freedesktop.org/series/90503/ State : success == Summary == CI Bug Log - changes from CI_DRM_10416_full -> Patchwork_20735_full Summary --- **S

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: prefer the create_user helper (rev2)

2021-07-29 Thread Patchwork
== Series Details == Series: drm/i915/selftests: prefer the create_user helper (rev2) URL : https://patchwork.freedesktop.org/series/93131/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0f9180249ece drm/i915/selftests: prefer the create_user helper -:6: WARNING:REPEATED_WORD: P

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: prefer the create_user helper (rev2)

2021-07-29 Thread Patchwork
== Series Details == Series: drm/i915/selftests: prefer the create_user helper (rev2) URL : https://patchwork.freedesktop.org/series/93131/ State : success == Summary == CI Bug Log - changes from CI_DRM_10418 -> Patchwork_20738 Summary

Re: [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp

2021-07-29 Thread Tvrtko Ursulin
Hi Matt, On 28/07/2021 16:50, Matthew Auld wrote: Since the object might still be active here, the shrink_all will simply ignore it, which blows up in the test, since the pages will still be there. Currently THP is disabled which should result in the test being skipped, but if we ever re-enabl

Re: [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp

2021-07-29 Thread Matthew Auld
On 29/07/2021 11:53, Tvrtko Ursulin wrote: Hi Matt, On 28/07/2021 16:50, Matthew Auld wrote: Since the object might still be active here, the shrink_all will simply ignore it, which blows up in the test, since the pages will still be there. Currently THP is disabled which should result in the

Re: [Intel-gfx] [PATCH v6 10/15] drm/i915/pxp: interfaces for using protected objects

2021-07-29 Thread Rodrigo Vivi
On Wed, Jul 28, 2021 at 07:01:01PM -0700, Daniele Ceraolo Spurio wrote: > This api allow user mode to create protected buffers and to mark > contexts as making use of such objects. Only when using contexts > marked in such a way is the execution guaranteed to work as expected. > > Contexts can onl

Re: [Intel-gfx] [PATCH 0/4] Remove CNL - for drm-intel-gt-next

2021-07-29 Thread Rodrigo Vivi
On Wed, Jul 28, 2021 at 03:03:22PM -0700, Lucas De Marchi wrote: > This the part of https://patchwork.freedesktop.org/series/93056/ > that should go through drm-intel-gt-next branch. Acked-by: Rodrigo Vivi > > Lucas De Marchi (4): > drm/i915/gt: remove explicit CNL handling from intel_mocs.c

[Intel-gfx] [PATCH 1/2] drm/i915/selftests: fixup igt_shrink_thp

2021-07-29 Thread Tvrtko Ursulin
From: Matthew Auld Since the object might still be active here, the shrink_all will simply ignore it, which blows up in the test, since the pages will still be there. Currently THP is disabled which should result in the test being skipped, but if we ever re-enable THP we might start seeing the fa

[Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-07-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Usage of Transparent Hugepages was disabled in 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it appears majority of performance regressions reported with an enabled IOMMU can be almost eliminated by turning them on, lets do that by adding a

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp

2021-07-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp URL : https://patchwork.freedesktop.org/series/93176/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2870e3292b14 drm/i915/selftests: fixup igt_shrink_thp 2b2db1afa93b drm/i915: Use

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 1:19 PM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Usage of Transparent Hugepages was disabled in 9987da4b5dcf > ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it > appears majority of performance regressions reported with an enabled IOMMU > c

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp

2021-07-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp URL : https://patchwork.freedesktop.org/series/93176/ State : success == Summary == CI Bug Log - changes from CI_DRM_10418 -> Patchwork_20739 S

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-07-29 Thread Tvrtko Ursulin
On 29/07/2021 13:07, Daniel Vetter wrote: On Thu, Jul 29, 2021 at 1:19 PM Tvrtko Ursulin wrote: From: Tvrtko Ursulin Usage of Transparent Hugepages was disabled in 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it appears majority of performance regressio

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 2:21 PM Tvrtko Ursulin wrote: > On 29/07/2021 13:07, Daniel Vetter wrote: > > On Thu, Jul 29, 2021 at 1:19 PM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Usage of Transparent Hugepages was disabled in 9987da4b5dcf > >> ("drm/i915: Disable THP until

[Intel-gfx] [PATCH v3 0/1] lpsp with hdmi/dp outputs

2021-07-29 Thread Anshuman Gupta
Squashes the patchset to a single patch to avoid any build failure. Anshuman Gupta (1): drm/i915/dg1: Adjust the AUDIO power domain drivers/gpu/drm/i915/display/intel_audio.c| 4 +- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c |

[Intel-gfx] [PATCH v3 1/1] drm/i915/dg1: Adjust the AUDIO power domain

2021-07-29 Thread Anshuman Gupta
DG1 and XE_PLD platforms has Audio MMIO/VERBS lies in PG0 power well. Adjusting the power domain accordingly to POWER_DOMAIN_AUDIO_VERBS for audio detection and POWER_DOMAIN_AUDIO for audio playback. While doing this it requires to use POWER_DOMAIN_AUDIO_MMIO power domain instead of POWER_DOMAIN_A

[Intel-gfx] ✗ Fi.CI.IGT: failure for Forcewake and shadowed register updates

2021-07-29 Thread Patchwork
== Series Details == Series: Forcewake and shadowed register updates URL : https://patchwork.freedesktop.org/series/93158/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10416_full -> Patchwork_20736_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for lpsp with hdmi/dp outputs

2021-07-29 Thread Patchwork
== Series Details == Series: lpsp with hdmi/dp outputs URL : https://patchwork.freedesktop.org/series/93179/ State : success == Summary == CI Bug Log - changes from CI_DRM_10418 -> Patchwork_20740 Summary --- **SUCCESS** No regres

[Intel-gfx] [PATCH 1/2] drm/i915/selftests: fixup igt_shrink_thp

2021-07-29 Thread Tvrtko Ursulin
From: Matthew Auld Since the object might still be active here, the shrink_all will simply ignore it, which blows up in the test, since the pages will still be there. Currently THP is disabled which should result in the test being skipped, but if we ever re-enable THP we might start seeing the fa

[Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-07-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Usage of Transparent Hugepages was disabled in 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it appears majority of performance regressions reported with an enabled IOMMU can be almost eliminated by turning them on, lets just do that. To e

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp

2021-07-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp URL : https://patchwork.freedesktop.org/series/93182/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1cac26e2f95f drm/i915/selftests: fixup igt_shrink_thp 054c89f72f0f drm/i915: Use

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 3:34 PM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Usage of Transparent Hugepages was disabled in 9987da4b5dcf > ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it > appears majority of performance regressions reported with an enabled IOMMU > c

Re: [Intel-gfx] [PATCH 1/6] drm/i915: correct name of GT forcewake domain in error messages

2021-07-29 Thread Yokoyama, Caz
Reviewed-by: Caz Yokoyama -caz On Wed, 2021-07-28 at 22:41 -0700, Matt Roper wrote: > For historical reasons, the GT forcewake domain used to be referred > to > as the "blitter" domain; that name is no longer accurate since the GT > domain contains a lot of additional registers and functionality

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp

2021-07-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp URL : https://patchwork.freedesktop.org/series/93182/ State : success == Summary == CI Bug Log - changes from CI_DRM_10418 -> Patchwork_20741 S

Re: [Intel-gfx] [PATCH 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-29 Thread Peter Zijlstra
On Thu, Jul 29, 2021 at 10:32:13PM +0800, Desmond Cheong Zhi Xi wrote: > Sounds good, will do. Thanks for the patch, Peter. > > Just going to make a small edit: > s/LOCK_STAT_NOT_HELD/LOCK_STATE_NOT_HELD/ Bah, I knew I should've compile tested it :-), Thanks! _

Re: [Intel-gfx] [PATCH 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-29 Thread Desmond Cheong Zhi Xi
On 29/7/21 3:00 pm, Daniel Vetter wrote: On Tue, Jul 27, 2021 at 04:37:22PM +0200, Peter Zijlstra wrote: On Thu, Jul 22, 2021 at 12:38:10PM +0200, Daniel Vetter wrote: On Thu, Jul 22, 2021 at 05:29:27PM +0800, Desmond Cheong Zhi Xi wrote: Inside drm_is_current_master, using the outer drm_devic

Re: [Intel-gfx] [PATCH v3 23/30] drm/i915/dg2: Add MPLLB programming for SNPS PHY

2021-07-29 Thread Matt Atwood
On Fri, Jul 23, 2021 at 10:42:32AM -0700, Matt Roper wrote: > DG2's SNPS PHYs incorporate a dedicated port PLL called MPLLB which > takes the place of the shared DPLLs we've used on past platforms. Let's > add the MPLLB programming sequences; they'll be plugged into the rest of > the code in futur

Re: [Intel-gfx] [PATCH v3 21/30] drm/i915/dg2: Report INSTDONE_GEOM values in error state

2021-07-29 Thread Matt Atwood
On Fri, Jul 23, 2021 at 10:42:30AM -0700, Matt Roper wrote: > Xe_HPG adds some additional INSTDONE_GEOM debug registers; the Mesa team > has indicated that having these reported in the error state would be > useful for debugging GPU hangs. These registers are replicated per-DSS > with gslice steer

Re: [Intel-gfx] [PATCH v3 22/30] drm/i915/dg2: Define MOCS table for DG2

2021-07-29 Thread Matt Atwood
On Fri, Jul 23, 2021 at 10:42:31AM -0700, Matt Roper wrote: > Bspec: 45101, 45427 > Cc: Ramalingam C (v5) > Signed-off-by: Matt Roper Reviewed-by: Matt Atwood > --- > drivers/gpu/drm/i915/gt/intel_mocs.c | 35 +++- > 1 file changed, 34 insertions(+), 1 deletion(-) > > di

Re: [Intel-gfx] [PATCH v6 10/15] drm/i915/pxp: interfaces for using protected objects

2021-07-29 Thread Daniele Ceraolo Spurio
On 7/29/2021 4:10 AM, Rodrigo Vivi wrote: On Wed, Jul 28, 2021 at 07:01:01PM -0700, Daniele Ceraolo Spurio wrote: This api allow user mode to create protected buffers and to mark contexts as making use of such objects. Only when using contexts marked in such a way is the execution guaranteed

[Intel-gfx] [PATCH v2 3/6] drm/i915: Make shadow tables range-based

2021-07-29 Thread Matt Roper
Rather than defining our shadow tables as a list of individual registers, provide them as a list of register ranges; we'll have some ranges of multiple registers being added soon (and we already have a couple adjacent registers that we can squash into a single range now). This change also defines

Re: [Intel-gfx] [PATCH 01/14] drm/i915/guc/slpc: Initial definitions for SLPC

2021-07-29 Thread Michal Wajdeczko
On 28.07.2021 23:11, Vinay Belgaumkar wrote: > Add macros to check for SLPC support. This feature is currently supported > for Gen12+ and enabled whenever GuC submission is enabled/selected. > > Include templates for SLPC init/fini and enable. > > v2: Move SLPC helper functions to intel_guc_slp

Re: [Intel-gfx] [PATCH 03/14] drm/i915/guc/slpc: Adding SLPC communication interfaces

2021-07-29 Thread Michal Wajdeczko
On 28.07.2021 23:11, Vinay Belgaumkar wrote: > Add constants and params that are needed to configure SLPC. > > v2: Add a new abi header for SLPC. Replace bitfields with > genmasks. Address other comments from Michal W. > > v3: Add slpc H2G format in abi, other review commments (Michal W) > > v

Re: [Intel-gfx] [PATCH 05/14] drm/i915/guc/slpc: Enable SLPC and add related H2G events

2021-07-29 Thread Michal Wajdeczko
On 28.07.2021 23:11, Vinay Belgaumkar wrote: > Add methods for interacting with GuC for enabling SLPC. Enable > SLPC after GuC submission has been established. GuC load will > fail if SLPC cannot be successfully initialized. Add various > helper methods to set/unset the parameters for SLPC. They

Re: [Intel-gfx] [PATCH 11/14] drm/i915/guc/slpc: Cache platform frequency limits

2021-07-29 Thread Michal Wajdeczko
On 28.07.2021 23:11, Vinay Belgaumkar wrote: > Cache rp0, rp1 and rpn platform limits into SLPC structure > for range checking while setting min/max frequencies. > > Also add "soft" limits which keep track of frequency changes > made from userland. These are initially set to platform min > and

[Intel-gfx] [PATCH v1.1 14/25] drm/i915/display: remove CNL ddi buf translation tables

2021-07-29 Thread Lucas De Marchi
The only real platform with DISPLAY_VER == 10 is GLK. We don't need to handle CNL explicitly. Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi --- v1.1: rebase drivers/gpu/drm/i915/display/intel_ddi.c | 12 +- .../drm/i915/display/intel_ddi_buf_trans.c| 676 ++---

Re: [Intel-gfx] [PATCH 07/14] drm/i915/guc/slpc: Add methods to set min/max frequency

2021-07-29 Thread Michal Wajdeczko
On 28.07.2021 23:11, Vinay Belgaumkar wrote: > Add param set h2g helpers to set the min and max frequencies > for use by SLPC. > > v2: Address review comments (Michal W) > v3: Check for positive error code (Michal W) > v4: Print generic error in set_param (Michal W) > > Signed-off-by: Sundares

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: DPTX writes Swing/Pre-emphs(DPCD 0x103-0x106) requested during PHY Layer testing

2021-07-29 Thread Imre Deak
On Fri, Feb 26, 2021 at 12:15:54AM -0800, Khaled Almahallawy wrote: > Source needs to write DPCD 103-106 after receiving a PHY request to change > swing/pre-emphasis after reading DPCD 206-207. This is especially needed if > there is a retimer between source and sink and the retimer implements AUX_

[Intel-gfx] [PATCH v4 03/18] drm/i915/dg2: Add forcewake table

2021-07-29 Thread Matt Roper
The DG2 forcewake table is very similar to the one used by XeHP SDV (and both platforms are even presented as a single table in the bspec). For the most part DG2 starts using a few additional ranges that were 'reserved' on XeHP SDV and stops using some others. However there is a single range (0xd

[Intel-gfx] [PATCH v4 00/18] Begin enabling Xe_HP SDV and DG2 platforms

2021-07-29 Thread Matt Roper
This series provides some of the initial enablement patches for two upcoming discrete GPUs: * XeHP SDV: Xe_HP (version 12.50) graphics IP, no display IP * DG2: Xe_HPG (version 12.55) graphics IP, Xe_LPD (version 13) display IP Both platforms will need additional enablement patches beyond what'

[Intel-gfx] [PATCH v4 02/18] drm/i915/xehpsdv: Define steering tables

2021-07-29 Thread Matt Roper
Define and initialize the MMIO ranges for which XeHP SDV requires MSLICE and LNCF steering. Bspec: 66534 Cc: Tvrtko Ursulin Cc: Daniele Ceraolo Spurio Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_gt.c | 19 ++- drivers/gpu/drm/i915/gt/intel_workarounds.c

[Intel-gfx] [PATCH v4 05/18] drm/i915/dg2: Add SQIDI steering

2021-07-29 Thread Matt Roper
Although DG2_G10 platforms will always have all SQIDI's present and don't need steering for registers in a SQIDI MMIO range, this isn't true for DG2_G11 platforms; only SQIDI's 2 and 3 can be used on those. We handle SQIDI ranges a bit differently from other types of explicit steering. The SQIDI

[Intel-gfx] [PATCH v4 04/18] drm/i915/dg2: Update LNCF steering ranges

2021-07-29 Thread Matt Roper
DG2's replicated register ranges are almost the same at XeHP SDV with the exception of one LNCF sub-range that switches to gslice steering. We can re-use the XeHP SDV mslice steering table and just provide a DG2-specific LNCF steering table. Bspec: 66534 Cc: Daniele Ceraolo Spurio Signed-off-by:

[Intel-gfx] [PATCH v4 01/18] drm/i915/xehp: handle new steering options

2021-07-29 Thread Matt Roper
From: Daniele Ceraolo Spurio Xe_HP is more modular than its predecessors and as a consequence it has more types of replicated registers. As with l3bank regions on previous platforms, we may need to explicitly re-steer accesses to these new types of ranges at runtime if we can't find a single def

[Intel-gfx] [PATCH v4 08/18] drm/i915/xehp: Changes to ss/eu definitions

2021-07-29 Thread Matt Roper
From: Matthew Auld Xe_HP no longer has "slices" in the same way that old platforms did. There are new concepts (gslices, cslices, mslices) that apply in various contexts, but for the purposes of fusing slices no longer exist and we just have one large pool of dual-subslices (DSS) to work with. Fu

[Intel-gfx] [PATCH v4 07/18] drm/i915/dg2: Report INSTDONE_GEOM values in error state

2021-07-29 Thread Matt Roper
Xe_HPG adds some additional INSTDONE_GEOM debug registers; the Mesa team has indicated that having these reported in the error state would be useful for debugging GPU hangs. These registers are replicated per-DSS with gslice steering. Cc: Lionel Landwerlin Signed-off-by: Matt Roper Acked-by: Li

[Intel-gfx] [PATCH v4 09/18] drm/i915/xehpsdv: Add maximum sseu limits

2021-07-29 Thread Matt Roper
Due to the removal of legacy slices and the transition to a gslice/cslice/mslice/etc. design, we'll internally store all DSS under "slice0." Signed-off-by: Matt Roper Reviewed-by: Caz Yokoyama --- drivers/gpu/drm/i915/gt/intel_sseu.c | 5 - drivers/gpu/drm/i915/gt/intel_sseu.h

[Intel-gfx] [PATCH v4 06/18] drm/i915/xehp: Loop over all gslices for INSTDONE processing

2021-07-29 Thread Matt Roper
We no longer have traditional slices on Xe_HP platforms, but the INSTDONE registers are replicated according to gslice representation which is similar. We can mostly re-use the existing instdone code with just a few modifications: * Create an alternate instdone loop macro that will iterate over

[Intel-gfx] [PATCH v4 17/18] drm/i915/dg2: Maintain backward-compatible nested batch behavior

2021-07-29 Thread Matt Roper
For tgl+, the per-context setting of MI_MODE[12] determines whether the bits of a nested MI_BATCH_BUFFER_START instruction should be interpreted in the traditional manner or whether they should instead use a new tgl+ meaning that breaks backward compatibility, but allows nesting into 3rd-level batc

[Intel-gfx] [PATCH v4 12/18] drm/i915/xehpsdv: Define MOCS table for XeHP SDV

2021-07-29 Thread Matt Roper
From: Lucas De Marchi Like DG1, XeHP SDV doesn't have LLC/eDRAM control values due to being a dgfx card. XeHP SDV adds 2 more bits: L3_GLBGO to "push the Go point to memory for L3 destined transaction" and L3_LKP to "enable Lookup for uncacheable accesses". Bspec: 45101 Cc: Daniele Ceraolo Spuri

[Intel-gfx] [PATCH v4 16/18] drm/i915/dg2: Add new LRI reg offsets

2021-07-29 Thread Matt Roper
From: Akeem G Abodunrin New LRI register offsets were introduced for DG2, this patch adds those extra registers, and create new register table for setting offsets to compare with HW generated context image - especially for gt_lrc test. Also updates general purpose register with scratch offset for

[Intel-gfx] [PATCH v4 14/18] drm/i915/xehpsdv: factor out function to read RP_STATE_CAP

2021-07-29 Thread Matt Roper
From: Lucas De Marchi Instead of maintaining the same if ladder in 3 different places, add a function to read RP_STATE_CAP. Signed-off-by: Lucas De Marchi Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/debugfs_gt_pm.c | 8 +++- drivers/gpu/drm/i915/gt/intel_rps.c | 17

[Intel-gfx] [PATCH v4 18/18] drm/i915/dg2: Configure PCON in DP pre-enable path

2021-07-29 Thread Matt Roper
From: Ankit Nautiyal Add the functions to configure HDMI2.1 pcon for DG2, before DP link training. Signed-off-by: Ankit Nautiyal Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_ddi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi

[Intel-gfx] [PATCH v4 15/18] drm/i915/xehpsdv: Read correct RP_STATE_CAP register

2021-07-29 Thread Matt Roper
The RP_STATE_CAP register is no longer part of the MCHBAR on XEHPSDV; this register is now a per-tile register at GTTMMADDR offset 0x250014. Cc: Rodrigo Vivi Signed-off-by: Matt Roper Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_rps.c | 4 +++- dr

[Intel-gfx] [PATCH v4 13/18] drm/i915/dg2: Define MOCS table for DG2

2021-07-29 Thread Matt Roper
Bspec: 45101, 45427 Cc: Ramalingam C (v5) Signed-off-by: Matt Roper Reviewed-by: Matt Atwood --- drivers/gpu/drm/i915/gt/intel_mocs.c | 35 +++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/i

[Intel-gfx] [PATCH v4 10/18] drm/i915/xehpsdv: Add compute DSS type

2021-07-29 Thread Matt Roper
From: Stuart Summers Starting in XeHP, the concept of slice has been removed in favor of DSS (Dual-Subslice) masks for various workload types. These workloads have been divided into those enabled for geometry and those enabled for compute. i915 currently maintains a single set of S/SS/EU masks f

[Intel-gfx] [PATCH v4 11/18] drm/i915/dg2: DG2 uses the same sseu limits as XeHP SDV

2021-07-29 Thread Matt Roper
DG2 supports compute DSS and has the same maximum number of DSS and EU as XeHP SDV. Signed-off-by: Matt Roper Reviewed-by: Caz Yokoyama Reviewed-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_sseu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/dr

Re: [Intel-gfx] [PATCH 11/14] drm/i915/guc/slpc: Cache platform frequency limits

2021-07-29 Thread Belgaumkar, Vinay
On 7/29/2021 9:21 AM, Michal Wajdeczko wrote: On 28.07.2021 23:11, Vinay Belgaumkar wrote: Cache rp0, rp1 and rpn platform limits into SLPC structure for range checking while setting min/max frequencies. Also add "soft" limits which keep track of frequency changes made from userland. These

Re: [Intel-gfx] [PATCH v4 12/18] drm/i915/xehpsdv: Define MOCS table for XeHP SDV

2021-07-29 Thread Lucas De Marchi
On Thu, Jul 29, 2021 at 10:00:02AM -0700, Matt Roper wrote: From: Lucas De Marchi Like DG1, XeHP SDV doesn't have LLC/eDRAM control values due to being a dgfx card. XeHP SDV adds 2 more bits: L3_GLBGO to "push the Go point to memory for L3 destined transaction" and L3_LKP to "enable Lookup for

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: prefer the create_user helper (rev2)

2021-07-29 Thread Patchwork
== Series Details == Series: drm/i915/selftests: prefer the create_user helper (rev2) URL : https://patchwork.freedesktop.org/series/93131/ State : success == Summary == CI Bug Log - changes from CI_DRM_10418_full -> Patchwork_20738_full Su

Re: [Intel-gfx] [PATCH 12/14] drm/i915/guc/slpc: Sysfs hooks for SLPC

2021-07-29 Thread Michal Wajdeczko
On 28.07.2021 23:11, Vinay Belgaumkar wrote: > Update the get/set min/max freq hooks to work for > SLPC case as well. Consolidate helpers for requested/min/max > frequency get/set to intel_rps where the proper action can > be taken depending on whether SLPC is enabled. > > v2: Add wrappers for

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Forcewake and shadowed register updates (rev2)

2021-07-29 Thread Patchwork
== Series Details == Series: Forcewake and shadowed register updates (rev2) URL : https://patchwork.freedesktop.org/series/93158/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH v6 10/15] drm/i915/pxp: interfaces for using protected objects

2021-07-29 Thread Rodrigo Vivi
On Thu, Jul 29, 2021 at 08:17:44AM -0700, Daniele Ceraolo Spurio wrote: > > > On 7/29/2021 4:10 AM, Rodrigo Vivi wrote: > > On Wed, Jul 28, 2021 at 07:01:01PM -0700, Daniele Ceraolo Spurio wrote: > > > This api allow user mode to create protected buffers and to mark > > > contexts as making use o

Re: [Intel-gfx] [PATCH v6 02/15] mei: pxp: export pavp client to me client bus

2021-07-29 Thread Rodrigo Vivi
On Wed, Jul 28, 2021 at 07:00:53PM -0700, Daniele Ceraolo Spurio wrote: > From: Vitaly Lubart > > Export PAVP client to work with i915 driver, > for binding it uses kernel component framework. > > v2:drop debug prints, refactor match code to match mei_hdcp (Tomas) > > Signed-off-by: Vitaly Luba

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp

2021-07-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp URL : https://patchwork.freedesktop.org/series/93176/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10418_full -> Patchwork_20739_full =

[Intel-gfx] [PULL] drm-misc-next

2021-07-29 Thread Maarten Lankhorst
drm-misc-next-2021-07-29: drm-misc-next for v5.15: UAPI Changes: - Add modifiers for arm fixed rate compression. Cross-subsystem Changes: - Assorted dt binding fixes. - Convert ssd1307fb to json-schema. - Update a lot of irc channels to point to OFTC, as everyone moved there. - Fix the same divid

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Remove CNL - for drm-intel-next (rev2)

2021-07-29 Thread Patchwork
== Series Details == Series: Remove CNL - for drm-intel-next (rev2) URL : https://patchwork.freedesktop.org/series/93142/ State : failure == Summary == Applying: drm/i915/display: remove PORT_F workaround for CNL Applying: drm/i915/display: remove explicit CNL handling from intel_cdclk.c Apply

[Intel-gfx] ✓ Fi.CI.BAT: success for Forcewake and shadowed register updates (rev2)

2021-07-29 Thread Patchwork
== Series Details == Series: Forcewake and shadowed register updates (rev2) URL : https://patchwork.freedesktop.org/series/93158/ State : success == Summary == CI Bug Log - changes from CI_DRM_10420 -> Patchwork_20742 Summary --- **S

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Begin enabling Xe_HP SDV and DG2 platforms (rev8)

2021-07-29 Thread Patchwork
== Series Details == Series: Begin enabling Xe_HP SDV and DG2 platforms (rev8) URL : https://patchwork.freedesktop.org/series/92135/ State : failure == Summary == Applying: drm/i915/xehp: handle new steering options Applying: drm/i915/xehpsdv: Define steering tables Applying: drm/i915/dg2: Add

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Re-use gen11 forcewake read functions on gen12

2021-07-29 Thread Yokoyama, Caz
Reviewed-by: Caz Yokoyama -caz On Wed, 2021-07-28 at 22:41 -0700, Matt Roper wrote: > The forcewake read logic is identical between gen11 and gen12, only > the > forcewake table data (which is tracked separately) differs; there's > no > need to generate a separate set of gen12 read functions when

[Intel-gfx] [PATCH CI 03/10] drm/i915/bios: Enable parse of two integrated panels timing data

2021-07-29 Thread José Roberto de Souza
Continuing the conversion from single integrated VBT data to two. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_bios.c| 53 +--- drivers/gpu/drm/i915/display/intel_bios.h| 1 + dr

[Intel-gfx] [PATCH CI 04/10] drm/i915/bios: Enable parse of two integrated panels backlight data

2021-07-29 Thread José Roberto de Souza
Continuing the conversion from single integrated VBT data to two, now handling backlight data. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_bios.c | 59 +++ drivers/gpu/drm/i915/displ

[Intel-gfx] [PATCH CI 07/10] drm/i915/bios: Enable parse of two DSI panels data

2021-07-29 Thread José Roberto de Souza
Continuing the conversion from single integrated VBT data to two, now handling DSI data. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/icl_dsi.c | 12 +- drivers/gpu/drm/i915/display/intel_bios.c| 16

[Intel-gfx] [PATCH CI 05/10] drm/i915/bios: Enable parse of two integrated panels eDP data

2021-07-29 Thread José Roberto de Souza
Continuing the conversion from single integrated VBT data to two, now handling eDP data. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/g4x_dp.c | 9 ++- drivers/gpu/drm/i915/display/intel_bios.c |

[Intel-gfx] [PATCH CI 02/10] drm/i915/bios: Start to support two integrated panels

2021-07-29 Thread José Roberto de Souza
VBT has support for up two integrated panels but i915 only supports one. So here stating to add the basic support for two integrated panels and moving the DRRS to ddi_vbt_port_info instead of keeping a global one. Other VBT blocks will be converted in following patches. While at is also nucking l

[Intel-gfx] [PATCH CI 10/10] drm/i915/display/tgl+: Use PPS index from vbt

2021-07-29 Thread José Roberto de Souza
Tigerlake and newer has two instances of PPS, to support up to two eDP panels. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_pps.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dri

[Intel-gfx] [PATCH CI 06/10] drm/i915/bios: Enable parse of two integrated panels PSR data

2021-07-29 Thread José Roberto de Souza
Continuing the conversion from single integrated VBT data to two, now handling PSR data. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_bios.c | 73 +-- drivers/gpu/drm/i915/display/int

[Intel-gfx] [PATCH CI 01/10] drm/i915/bios: Allow DSI ports to be parsed by parse_ddi_port()

2021-07-29 Thread José Roberto de Souza
Allow MIPI DSI ports to be parsed like any other DDI port. This will be helpful to integrate into just one function the parse of information about integrated panels(eDP and DSI). Cc: Ville Syrjälä Cc: Jani Nikula Reviewed-by: Matt Atwood Signed-off-by: José Roberto de Souza --- drivers/gpu/dr

[Intel-gfx] [PATCH CI 08/10] drm/i915/bios: Nuke panel_type

2021-07-29 Thread José Roberto de Souza
All the users were converted, now we can drop it. Reviewed-by: Matt Atwood Cc: Jani Nikula Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_bios.c | 36 --- drivers/gpu/drm/i915/i915_drv.h | 1 - 2 files changed, 37 d

[Intel-gfx] [PATCH CI 09/10] drm/i915/bios: Only use opregion panel index for display ver 8 and older

2021-07-29 Thread José Roberto de Souza
On newer platform this opregion call always fails, also it do not support multiple panels so dropping it. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_bios.c | 19 +++ 1 file changed, 7 i

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915: Make shadow tables range-based

2021-07-29 Thread Yokoyama, Caz
On Thu, 2021-07-29 at 08:21 -0700, Matt Roper wrote: > Rather than defining our shadow tables as a list of individual > registers, provide them as a list of register ranges; we'll have some > ranges of multiple registers being added soon (and we already have a > couple adjacent registers that we ca

Re: [Intel-gfx] [PATCH 25/25] drm/i915: finish removal of CNL

2021-07-29 Thread Vivi, Rodrigo
On Wed, 2021-07-28 at 17:32 -0700, Lucas De Marchi wrote: > On Wed, Jul 28, 2021 at 02:59:46PM -0700, Lucas De Marchi wrote: > > With all the users removed, finish removing the CNL platform > > definitions. > > We will leave the PCI IDs around as those are exposed to userspace. > > Even if mesa doe

  1   2   >