Re: [Intel-gfx] [PATCH 6/6] drm/i915: Filter out modes that don't match the fixed mode vrefresh

2018-07-02 Thread Daniel Vetter
On Thu, Jun 28, 2018 at 10:43:01PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We only ever drive the panel with the fixed mode, hence we don't > want to advertize any modes that have a different vertical refresh rate. > > We tried to allow a second lower clocked mode to used for eDP b

[Intel-gfx] [PATCH] drm: Limite blob creation to drm master

2018-07-02 Thread Daniel Vetter
This interface allows pretty much unlimited kernel memory allocations, which isn't all that great. But we allow that anyway for any drm master client (through pinning display buffers and stuff, at least for UMA gpus), so just limiting it to the active master seems like a reasonable stopgap measure.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/psr: Prevent DC5/6 entry when reading pipe CRCs

2018-07-02 Thread Patchwork
== Series Details == Series: drm/i915/psr: Prevent DC5/6 entry when reading pipe CRCs URL : https://patchwork.freedesktop.org/series/45748/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4410_full -> Patchwork_9492_full = == Summary - FAILURE == Serious unknown changes co

Re: [Intel-gfx] [PATCH 05/20] drm/i915/icl: Define PORT_CL_DW_10 register

2018-07-02 Thread Chauhan, Madhav
> -Original Message- > From: Nikula, Jani > Sent: Friday, June 29, 2018 7:24 PM > To: Chauhan, Madhav ; intel- > g...@lists.freedesktop.org > Cc: Zanoni, Paulo R ; Shankar, Uma > ; Vivi, Rodrigo ; > Chauhan, Madhav > Subject: Re: [PATCH 05/20] drm/i915/icl: Define PORT_CL_DW_10 register >

Re: [Intel-gfx] [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-07-02 Thread Daniel Vetter
On Fri, May 04, 2018 at 03:47:59PM +0200, Daniel Vetter wrote: > On Fri, May 04, 2018 at 03:17:08PM +0200, Christian König wrote: > > Am 04.05.2018 um 11:25 schrieb Daniel Vetter: > > > On Fri, May 4, 2018 at 11:16 AM, Chris Wilson > > > wrote: > > > > Quoting Daniel Vetter (2018-05-04 09:57:59)

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Limite blob creation to drm master

2018-07-02 Thread Patchwork
== Series Details == Series: drm: Limite blob creation to drm master URL : https://patchwork.freedesktop.org/series/45753/ State : warning == Summary == $ dim checkpatch origin/drm-tip dea0d1f54e76 drm: Limite blob creation to drm master -:31: WARNING:LONG_LINE: line over 100 characters #31: F

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Limite blob creation to drm master

2018-07-02 Thread Patchwork
== Series Details == Series: drm: Limite blob creation to drm master URL : https://patchwork.freedesktop.org/series/45753/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4410 -> Patchwork_9493 = == Summary - WARNING == Minor unknown changes coming with Patchwork_9493 need

Re: [Intel-gfx] [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-07-02 Thread Christian König
Am 02.07.2018 um 10:23 schrieb Daniel Vetter: On Fri, May 04, 2018 at 03:47:59PM +0200, Daniel Vetter wrote: On Fri, May 04, 2018 at 03:17:08PM +0200, Christian König wrote: Am 04.05.2018 um 11:25 schrieb Daniel Vetter: On Fri, May 4, 2018 at 11:16 AM, Chris Wilson wrote: Quoting Daniel Vett

[Intel-gfx] [PATCH i-g-t 13/17] igt: Add gem_ctx_engines

2018-07-02 Thread Chris Wilson
To exercise the new I915_CONTEXT_PARAM_ENGINES and interactions with gem_execbuf(). Signed-off-by: Chris Wilson --- tests/Makefile.sources | 1 + tests/gem_ctx_engines.c | 236 tests/meson.build | 1 + 3 files changed, 238 insertions(+) create

[Intel-gfx] [PATCH i-g-t 14/17] igt: Add gem_exec_balancer

2018-07-02 Thread Chris Wilson
Exercise the in-kernel load balancer checking that we can distribute batches across the set of ctx->engines to avoid load. Signed-off-by: Chris Wilson --- tests/Makefile.am | 1 + tests/Makefile.sources| 1 + tests/gem_exec_balancer.c | 465 ++

[Intel-gfx] [PATCH i-g-t 08/17] igt/gem_sync: Show the baseline poll latency for wakeups

2018-07-02 Thread Chris Wilson
Distinguish between the latency required to switch away from the pollable spinner into the target nops from the client wakeup of synchronisation on the last nop. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- tests/gem_sync.c | 35 +++ 1 file change

[Intel-gfx] [PATCH i-g-t 02/17] igt/gem_tiled_partial_pwrite_pread: Check for known swizzling

2018-07-02 Thread Chris Wilson
As we want to compare a templated tiling pattern against the target_bo, we need to know that the swizzling is compatible. Or else the two tiling pattern may differ due to underlying page address that we cannot know, and so the test may sporadically fail. References: https://bugs.freedesktop.org/sh

[Intel-gfx] [PATCH i-g-t 05/17] lib: Spin fast, retire early

2018-07-02 Thread Chris Wilson
When using the pollable spinner, we often want to use it as a means of ensuring the task is running on the GPU before switching to something else. In which case we don't want to add extra delay inside the spinner, but the current 1000 NOPs add on order of 5us, which is often larger than the target

[Intel-gfx] [PATCH i-g-t 06/17] igt/gem_sync: Alternate stress for nop+sync

2018-07-02 Thread Chris Wilson
Apply a different sort of stress by timing how long it takes to sync a second nop batch in the pipeline. We first start a spinner on the engine, then when we know the GPU is active, we submit the second nop; start timing as we then release the spinner and wait for the nop to complete. As with ever

[Intel-gfx] [PATCH i-g-t 11/17] igt/gem_ctx_switch: Exercise queues

2018-07-02 Thread Chris Wilson
Queues are a form of contexts that share vm and enfore a single timeline across all engines. Test switching between them, just like ordinary contexts. Signed-off-by: Chris Wilson --- tests/gem_ctx_switch.c | 75 +++--- 1 file changed, 55 insertions(+), 20 dele

[Intel-gfx] [PATCH i-g-t 15/17] benchmarks/wsim: Simulate and interpret .wsim

2018-07-02 Thread Chris Wilson
A little tool I've been meaning to write for a while... Convert the .wsim into their dag and find the longest chains and evaluate them on an simulated machine. v2: Implement barriers to handle sync commands Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- benchmarks/Makefile.sources | 1 +

[Intel-gfx] [PATCH i-g-t 12/17] igt/gem_exec_whisper: Fork all-engine tests one-per-engine

2018-07-02 Thread Chris Wilson
Add a new mode for some more stress, submit the all-engines tests simultaneously, a stream per engine. Signed-off-by: Chris Wilson --- tests/gem_exec_whisper.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/tests/gem_exec_whisper.c b/tests/gem_ex

[Intel-gfx] [PATCH i-g-t 03/17] igt/gem_set_tiling_vs_pwrite: Show the erroneous value

2018-07-02 Thread Chris Wilson
Signed-off-by: Chris Wilson --- tests/gem_set_tiling_vs_pwrite.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/gem_set_tiling_vs_pwrite.c b/tests/gem_set_tiling_vs_pwrite.c index 006edfe4e..f0126b648 100644 --- a/tests/gem_set_tiling_vs_pwrite.c +++ b/tests/gem_set

[Intel-gfx] [PATCH i-g-t 16/17] tools: capture execution pathways

2018-07-02 Thread Chris Wilson
igt_kcov edges -o edges.yaml command-to-trace args ... igt_kcov sort -o sorted.yaml edges.yaml igt_kcov list --total=30 --single=0.5 sorted.yaml Requires CONFIG_KCOV Use LD_PRELOAD to wrap calls to DRM ioctls and capture the execution trace of all basic blocks invoked directly from the syscall. (

[Intel-gfx] [PATCH i-g-t 04/17] lib: Convert spin batch constructor to a factory

2018-07-02 Thread Chris Wilson
In order to make adding more options easier, expose the full set of options to the caller. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- lib/igt_dummyload.c| 147 + lib/igt_dummyload.h| 42 +- tests/drv_missed_irq.c |

[Intel-gfx] [PATCH i-g-t 17/17] igt/gem_exec_latency: Robustify measurements

2018-07-02 Thread Chris Wilson
Repeat the latency measurements and present the median over many so that the results are more reliable. Signed-off-by: Chris Wilson --- tests/gem_exec_latency.c | 165 ++- 1 file changed, 75 insertions(+), 90 deletions(-) diff --git a/tests/gem_exec_latency.c

[Intel-gfx] [PATCH i-g-t 01/17] lib: Report file cache as available system memory

2018-07-02 Thread Chris Wilson
sysinfo() doesn't include all reclaimable memory. In particular it excludes the majority of global_node_page_state(NR_FILE_PAGES), reclaimable pages that are a copy of on-disk files It seems the only way to obtain this counter is by parsing /proc/meminfo. For comparison, check vm_enough_memory() wh

[Intel-gfx] [PATCH i-g-t 09/17] igt/gem_userptr: Check read-only mappings

2018-07-02 Thread Chris Wilson
Setup a userptr object that only has a read-only mapping back to a file store (memfd). Then attempt to write into that mapping using the GPU and assert that those writes do not land (while also writing via a writable userptr mapping into the same memfd to verify that the GPU is working!) Signed-of

[Intel-gfx] [PATCH i-g-t 10/17] igt: Exercise creating context with shared GTT

2018-07-02 Thread Chris Wilson
v2: Test each shared context is its own timeline and allows request reordering between shared contexts. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Mika Kuoppala Cc: Michal Wajdeczko --- lib/i915/gem_context.c | 66 +++ lib/i915/gem_context.h | 13 + tests/Ma

[Intel-gfx] [PATCH i-g-t 07/17] igt/gem_sync: Double the wakeups, twice the pain

2018-07-02 Thread Chris Wilson
To further defeat any contemplated spin-optimisations to avoid the irq latency for synchronous wakeups, increase the queue length. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- tests/gem_sync.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/test

Re: [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Christian König
Am 27.06.2018 um 09:44 schrieb Michal Hocko: This is the v2 of RFC based on the feedback I've received so far. The code even compiles as a bonus ;) I haven't runtime tested it yet, mostly because I have no idea how. Any further feedback is highly appreciated of course. That sounds like it shou

Re: [Intel-gfx] [PATCH 17/37] drm/i915: Track vma activity per fence.context, not per engine

2018-07-02 Thread Tvrtko Ursulin
On 29/06/2018 16:39, Chris Wilson wrote: Quoting Chris Wilson (2018-06-29 16:36:22) Quoting Tvrtko Ursulin (2018-06-29 16:08:40) On 29/06/2018 15:54, Tvrtko Ursulin wrote: [snip] +int i915_vma_move_to_active(struct i915_vma *vma, +    struct i915_request *rq, +    u

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: Limite blob creation to drm master

2018-07-02 Thread Patchwork
== Series Details == Series: drm: Limite blob creation to drm master URL : https://patchwork.freedesktop.org/series/45753/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4410_full -> Patchwork_9493_full = == Summary - FAILURE == Serious unknown changes coming with Patchwo

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Filter out modes that don't match the fixed mode vrefresh

2018-07-02 Thread Ville Syrjälä
On Mon, Jul 02, 2018 at 09:46:23AM +0200, Daniel Vetter wrote: > On Thu, Jun 28, 2018 at 10:43:01PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We only ever drive the panel with the fixed mode, hence we don't > > want to advertize any modes that have a different vertical refresh r

Re: [Intel-gfx] [PATCH 04/20] drm/i915/icl: Enable DSI IO power

2018-07-02 Thread Jani Nikula
On Fri, 15 Jun 2018, Madhav Chauhan wrote: > This patch configures mode of operation for DSI > and enable DDI IO power by configuring power well. > > Signed-off-by: Madhav Chauhan > --- > drivers/gpu/drm/i915/intel_dsi_new.c | 22 ++ > 1 file changed, 22 insertions(+) > > dif

Re: [Intel-gfx] [PATCH 04/20] drm/i915/icl: Enable DSI IO power

2018-07-02 Thread Chauhan, Madhav
> -Original Message- > From: Nikula, Jani > Sent: Monday, July 2, 2018 3:27 PM > To: Chauhan, Madhav ; intel- > g...@lists.freedesktop.org > Cc: Zanoni, Paulo R ; Shankar, Uma > ; Vivi, Rodrigo ; > Chauhan, Madhav > Subject: Re: [PATCH 04/20] drm/i915/icl: Enable DSI IO power > > On Fri,

Re: [Intel-gfx] [PATCH 05/20] drm/i915/icl: Define PORT_CL_DW_10 register

2018-07-02 Thread Jani Nikula
On Mon, 02 Jul 2018, "Chauhan, Madhav" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Friday, June 29, 2018 7:24 PM >> To: Chauhan, Madhav ; intel- >> g...@lists.freedesktop.org >> Cc: Zanoni, Paulo R ; Shankar, Uma >> ; Vivi, Rodrigo ; >> Chauhan, Madhav >> Subject: Re: [PAT

Re: [Intel-gfx] [PATCH 05/20] drm/i915/icl: Define PORT_CL_DW_10 register

2018-07-02 Thread Chauhan, Madhav
> -Original Message- > From: Nikula, Jani > Sent: Monday, July 2, 2018 3:43 PM > To: Chauhan, Madhav ; intel- > g...@lists.freedesktop.org > Cc: Zanoni, Paulo R ; Shankar, Uma > ; Vivi, Rodrigo > Subject: RE: [PATCH 05/20] drm/i915/icl: Define PORT_CL_DW_10 register > > On Mon, 02 Jul 201

Re: [Intel-gfx] [PATCH 12/37] drm/i915: Priority boost for new clients

2018-07-02 Thread Tvrtko Ursulin
On 29/06/2018 12:10, Tvrtko Ursulin wrote: On 29/06/2018 11:51, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-06-29 11:36:50) On 29/06/2018 11:09, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-06-29 11:04:36) On 29/06/2018 08:53, Chris Wilson wrote: Taken from an idea used for FQ_C

Re: [Intel-gfx] [PATCH 04/20] drm/i915/icl: Enable DSI IO power

2018-07-02 Thread Jani Nikula
On Mon, 02 Jul 2018, "Chauhan, Madhav" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Monday, July 2, 2018 3:27 PM >> To: Chauhan, Madhav ; intel- >> g...@lists.freedesktop.org >> Cc: Zanoni, Paulo R ; Shankar, Uma >> ; Vivi, Rodrigo ; >> Chauhan, Madhav >> Subject: Re: [PATC

Re: [Intel-gfx] [PATCH] drm: Limite blob creation to drm master

2018-07-02 Thread Ville Syrjälä
On Mon, Jul 02, 2018 at 10:12:21AM +0200, Daniel Vetter wrote: > This interface allows pretty much unlimited kernel memory allocations, > which isn't all that great. But we allow that anyway for any drm > master client (through pinning display buffers and stuff, at least for > UMA gpus), At least

Re: [Intel-gfx] [PATCH 04/20] drm/i915/icl: Enable DSI IO power

2018-07-02 Thread Chauhan, Madhav
> -Original Message- > From: Nikula, Jani > Sent: Monday, July 2, 2018 3:53 PM > To: Chauhan, Madhav ; intel- > g...@lists.freedesktop.org > Cc: Zanoni, Paulo R ; Shankar, Uma > ; Vivi, Rodrigo > Subject: RE: [PATCH 04/20] drm/i915/icl: Enable DSI IO power > > On Mon, 02 Jul 2018, "Chauha

[Intel-gfx] [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-02 Thread Mahesh Kumar
This patch introduce a callback function "get_crc_sources" which will be called during read of control node. It is an optional callback function and if driver implements this callback, driver should print list of available CRC sources in seq_file privided as an input to the callback. Changes Since

[Intel-gfx] [PATCH 06/10] drm/i915/crc: implement verify_crc_source callback

2018-07-02 Thread Mahesh Kumar
This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/g

[Intel-gfx] [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-02 Thread Mahesh Kumar
This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node and while opening data node for crc reading. This will help in avoiding setting of wrong string for source. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org

[Intel-gfx] [PATCH 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

2018-07-02 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kumar Cc:

[Intel-gfx] [PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-02 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rcar drm driver. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 40 ++ 1 file changed, 40 insertions(+) d

[Intel-gfx] [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-02 Thread Mahesh Kumar
This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in the function before setting the source or memory allocation. Now set_crc_source takes only two variable inputs, values_cnt we already gets as part of verify_crc_source. Si

[Intel-gfx] [PATCH 10/10] drm: crc: Introduce pre_crc_read function

2018-07-02 Thread Mahesh Kumar
This patch implements a callback function "pre_crc_read" which will be called before crc read. In this function driver can implement and preparation work required for successfully reading CRC data. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/drm_debugfs_cr

[Intel-gfx] [PATCH 00/10] Improve crc-core driver interface

2018-07-02 Thread Mahesh Kumar
This series improves crc-core <-> driver interface. This series adds following functionality in the crc-core - Now control node will print all the available sources if implemented by driver along with current source. - Setting of sorce will fail if provided source is not supported - cleanup o

[Intel-gfx] [PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback

2018-07-02 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rockchip drm driver. Changes since V1: - simplify the verification (Jani N) Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 20 +

[Intel-gfx] [PATCH 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

2018-07-02 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

[Intel-gfx] [PATCH 07/10] drm/i915/crc: implement get_crc_sources callback

2018-07-02 Thread Mahesh Kumar
This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Changes since V1: - Return array of crc sources Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/g

[Intel-gfx] [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail

2018-07-02 Thread Mahesh Kumar
Now crc-core framework verifies the source string passed by the user. So setting bad-source will fail. Expect file write to fail in bad-source subtest of kms_pipe_crc_basic. Signed-off-by: Mahesh Kumar --- tests/kms_pipe_crc_basic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail

2018-07-02 Thread Maarten Lankhorst
Op 02-07-18 om 13:16 schreef Mahesh Kumar: > Now crc-core framework verifies the source string passed by the user. > So setting bad-source will fail. Expect file write to fail in bad-source > subtest of kms_pipe_crc_basic. > > Signed-off-by: Mahesh Kumar > --- > tests/kms_pipe_crc_basic.c | 3 +--

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Refactor export_fence() after i915_vma_move_to_active()

2018-07-02 Thread Tvrtko Ursulin
On 29/06/2018 23:54, Chris Wilson wrote: Currently all callers are responsible for adding the vma to the active timeline and then exporting its fence. Combine the two operations into i915_vma_move_to_active() to move all the extra handling from the callers to the single site. Signed-off-by: Chr

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Export i915_request_skip()

2018-07-02 Thread Tvrtko Ursulin
On 29/06/2018 23:54, Chris Wilson wrote: In the next patch, we will want to start skipping requests on failing to complete their payloads. So export the utility function current used to make requests inoperable following a failed gpu reset. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Start returning an error from i915_vma_move_to_active()

2018-07-02 Thread Tvrtko Ursulin
On 29/06/2018 23:54, Chris Wilson wrote: Handling such a late error in request construction is tricky, but to accommodate future patches which may allocate here, we potentially could err. To handle the error after already adjusting global state to track the new request, we must finish and submit

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Move i915_vma_move_to_active() to i915_vma.c

2018-07-02 Thread Tvrtko Ursulin
On 29/06/2018 23:54, Chris Wilson wrote: i915_vma_move_to_active() has grown beyond its execbuf origins, and should take its rightful place in i915_vma.c as a method for i915_vma! Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h| 3 -- drivers/gpu/drm/i915/i915_g

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Refactor export_fence() after i915_vma_move_to_active()

2018-07-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-07-02 12:34:51) > > @@ -1921,6 +1914,8 @@ void i915_vma_move_to_active(struct i915_vma *vma, > > > > if (flags & EXEC_OBJECT_NEEDS_FENCE) > > i915_gem_active_set(&vma->last_fence, rq); > > + > > + export_fence(vma, rq, flags); > > Don't care

[Intel-gfx] [PATCH] drm/i915: Show who pinned the pages when a leak is hit

2018-07-02 Thread Chris Wilson
Currently, we emit a warning when freeing an object if we do so with the pages still pinned (presumably as they are still in use somewhere). This only tells us that there is a problem, but doesn't tell us anything about the object or who might be pinning them and so provides no clue as to track dow

[Intel-gfx] ✗ Fi.CI.BAT: failure for Improve crc-core driver interface (rev4)

2018-07-02 Thread Patchwork
== Series Details == Series: Improve crc-core driver interface (rev4) URL : https://patchwork.freedesktop.org/series/45246/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4411 -> Patchwork_9494 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_9494 a

Re: [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 11:14:58, Christian König wrote: > Am 27.06.2018 um 09:44 schrieb Michal Hocko: > > This is the v2 of RFC based on the feedback I've received so far. The > > code even compiles as a bonus ;) I haven't runtime tested it yet, mostly > > because I have no idea how. > > > > Any further

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 01/17] lib: Report file cache as available system memory

2018-07-02 Thread Tvrtko Ursulin
On 02/07/2018 10:07, Chris Wilson wrote: sysinfo() doesn't include all reclaimable memory. In particular it excludes the majority of global_node_page_state(NR_FILE_PAGES), reclaimable pages that are a copy of on-disk files It seems the only way to obtain this counter is by parsing /proc/meminfo.

Re: [Intel-gfx] [PATCH] drm/i915: Show who pinned the pages when a leak is hit

2018-07-02 Thread Chris Wilson
Quoting Chris Wilson (2018-07-02 12:44:52) > @@ -451,6 +460,31 @@ i915_gem_object_get_tile_row_size(struct > drm_i915_gem_object *obj) > int i915_gem_object_set_tiling(struct drm_i915_gem_object *obj, >unsigned int tiling, unsigned int stride); > > +#if IS_ENABLE

[Intel-gfx] [PATCH v2] drm/i915: Show who pinned the pages when a leak is hit

2018-07-02 Thread Chris Wilson
Currently, we emit a warning when freeing an object if we do so with the pages still pinned (presumably as they are still in use somewhere). This only tells us that there is a problem, but doesn't tell us anything about the object or who might be pinning them and so provides no clue as to track dow

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 02/17] igt/gem_tiled_partial_pwrite_pread: Check for known swizzling

2018-07-02 Thread Tvrtko Ursulin
On 02/07/2018 10:07, Chris Wilson wrote: As we want to compare a templated tiling pattern against the target_bo, we need to know that the swizzling is compatible. Or else the two tiling pattern may differ due to underlying page address that we cannot know, and so the test may sporadically fail.

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 03/17] igt/gem_set_tiling_vs_pwrite: Show the erroneous value

2018-07-02 Thread Tvrtko Ursulin
On 02/07/2018 10:07, Chris Wilson wrote: Signed-off-by: Chris Wilson --- tests/gem_set_tiling_vs_pwrite.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/gem_set_tiling_vs_pwrite.c b/tests/gem_set_tiling_vs_pwrite.c index 006edfe4e..f0126b648 100644 --- a/tests/

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 01/17] lib: Report file cache as available system memory

2018-07-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-07-02 12:54:18) > > On 02/07/2018 10:07, Chris Wilson wrote: > > sysinfo() doesn't include all reclaimable memory. In particular it > > excludes the majority of global_node_page_state(NR_FILE_PAGES), > > reclaimable pages that are a copy of on-disk files It seems the o

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Show who pinned the pages when a leak is hit (rev2)

2018-07-02 Thread Patchwork
== Series Details == Series: drm/i915: Show who pinned the pages when a leak is hit (rev2) URL : https://patchwork.freedesktop.org/series/45770/ State : warning == Summary == $ dim checkpatch origin/drm-tip cd6455c5f8ad drm/i915: Show who pinned the pages when a leak is hit -:207: CHECK:UNCOMM

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Show who pinned the pages when a leak is hit (rev2)

2018-07-02 Thread Patchwork
== Series Details == Series: drm/i915: Show who pinned the pages when a leak is hit (rev2) URL : https://patchwork.freedesktop.org/series/45770/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Show who pinned the pages when a leak is hit -drivers/gpu/drm/i915/selfte

Re: [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Christian König
Am 02.07.2018 um 13:54 schrieb Michal Hocko: On Mon 02-07-18 11:14:58, Christian König wrote: Am 27.06.2018 um 09:44 schrieb Michal Hocko: This is the v2 of RFC based on the feedback I've received so far. The code even compiles as a bonus ;) I haven't runtime tested it yet, mostly because I hav

Re: [Intel-gfx] [PATCH 06/10] drm/i915/crc: implement verify_crc_source callback

2018-07-02 Thread Maarten Lankhorst
Op 02-07-18 om 13:07 schreef Mahesh Kumar: > This patch implements verify_crc_source callback function introduced > earlier in this series. > > Signed-off-by: Mahesh Kumar > Cc: dri-de...@lists.freedesktop.org > Reviewed-by: Maarten Lankhorst > --- Patch 6 and 7 were acked for inclusion through d

Re: [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 14:13:42, Christian König wrote: > Am 02.07.2018 um 13:54 schrieb Michal Hocko: > > On Mon 02-07-18 11:14:58, Christian König wrote: > > > Am 27.06.2018 um 09:44 schrieb Michal Hocko: > > > > This is the v2 of RFC based on the feedback I've received so far. The > > > > code even com

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Show who pinned the pages when a leak is hit (rev2)

2018-07-02 Thread Patchwork
== Series Details == Series: drm/i915: Show who pinned the pages when a leak is hit (rev2) URL : https://patchwork.freedesktop.org/series/45770/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4412 -> Patchwork_9495 = == Summary - SUCCESS == No regressions found. Extern

Re: [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Christian König
Am 02.07.2018 um 14:20 schrieb Michal Hocko: On Mon 02-07-18 14:13:42, Christian König wrote: Am 02.07.2018 um 13:54 schrieb Michal Hocko: On Mon 02-07-18 11:14:58, Christian König wrote: Am 27.06.2018 um 09:44 schrieb Michal Hocko: This is the v2 of RFC based on the feedback I've received so

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Refactor export_fence() after i915_vma_move_to_active()

2018-07-02 Thread Tvrtko Ursulin
On 02/07/2018 12:44, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-07-02 12:34:51) @@ -1921,6 +1914,8 @@ void i915_vma_move_to_active(struct i915_vma *vma, if (flags & EXEC_OBJECT_NEEDS_FENCE) i915_gem_active_set(&vma->last_fence, rq); + + export_fence(vma, rq,

Re: [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 14:24:29, Christian König wrote: > Am 02.07.2018 um 14:20 schrieb Michal Hocko: > > On Mon 02-07-18 14:13:42, Christian König wrote: > > > Am 02.07.2018 um 13:54 schrieb Michal Hocko: > > > > On Mon 02-07-18 11:14:58, Christian König wrote: > > > > > Am 27.06.2018 um 09:44 schrieb M

Re: [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Christian König
Am 02.07.2018 um 14:35 schrieb Michal Hocko: On Mon 02-07-18 14:24:29, Christian König wrote: Am 02.07.2018 um 14:20 schrieb Michal Hocko: On Mon 02-07-18 14:13:42, Christian König wrote: Am 02.07.2018 um 13:54 schrieb Michal Hocko: On Mon 02-07-18 11:14:58, Christian König wrote: Am 27.06.2

Re: [Intel-gfx] [PATCH 06/20] drm/i915/icl: Power down unused DSI lanes

2018-07-02 Thread Jani Nikula
On Fri, 15 Jun 2018, Madhav Chauhan wrote: > To save power, unused lanes should be powered > down using the bitfield of PORT_CL_DW10. > > Signed-off-by: Madhav Chauhan > --- > drivers/gpu/drm/i915/intel_dsi_new.c | 44 > > 1 file changed, 44 insertions(+) >

Re: [Intel-gfx] [PATCH 06/20] drm/i915/icl: Power down unused DSI lanes

2018-07-02 Thread Chauhan, Madhav
> -Original Message- > From: Nikula, Jani > Sent: Monday, July 2, 2018 6:12 PM > To: Chauhan, Madhav ; intel- > g...@lists.freedesktop.org > Cc: Zanoni, Paulo R ; Shankar, Uma > ; Vivi, Rodrigo ; > Chauhan, Madhav > Subject: Re: [PATCH 06/20] drm/i915/icl: Power down unused DSI lanes > >

Re: [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 14:39:50, Christian König wrote: [...] > Not wanting to block something as important as this, so feel free to add an > Acked-by: Christian König to the patch. Thanks a lot! > Let's rather face the next topic: Any idea how to runtime test this? This is a good question indeed. One

Re: [Intel-gfx] [PATCH v2 5/9] drm/nouveau: Use drm_connector_for_each_possible_encoder()

2018-07-02 Thread Ville Syrjälä
On Sat, Jun 30, 2018 at 10:12:21PM +0300, Dan Carpenter wrote: > Hi Ville, > > Thank you for the patch! Perhaps something to improve: > > url: > https://github.com/0day-ci/linux/commits/Ville-Syrjala/drm-Third-attempt-at-fixing-the-fb-helper-best_encoder-mess/20180629-014202 > base: git://p

[Intel-gfx] [PATCH v1] drm/i915: Adding YUV444 packed format(DRM_FORMAT_AYUV) support.

2018-07-02 Thread StanLis
From: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_display.c | 8 drivers/gpu/drm/i915/intel_sprite.c | 3 +++ 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 56818a45181c..4bc702193c88 100644 ---

[Intel-gfx] [PATCH v2] drm/i915: Adding YUV444 packed format(DRM_FORMAT_AYUV) support.

2018-07-02 Thread StanLis
From: Stanislav Lisovskiy PLANE_CTL_FORMAT_AYUV is already supported, according to hardware specification. v2: Edited commit message, removed redundant whitespaces. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_display.c | 7 +++ drivers/gpu/drm/i915/intel_sprite.c |

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Show who pinned the pages when a leak is hit (rev2)

2018-07-02 Thread Patchwork
== Series Details == Series: drm/i915: Show who pinned the pages when a leak is hit (rev2) URL : https://patchwork.freedesktop.org/series/45770/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4412_full -> Patchwork_9495_full = == Summary - FAILURE == Serious unknown chang

[Intel-gfx] [PATCH v4 2/9] drm/fb-helper: Add generic fbdev emulation .fb_probe function

2018-07-02 Thread Noralf Trønnes
This is the first step in getting generic fbdev emulation. A drm_fb_helper_funcs.fb_probe function is added which uses the DRM client API to get a framebuffer backed by a dumb buffer. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 192

[Intel-gfx] [PATCH v4 3/9] drm/pl111: Set .gem_prime_vmap and .gem_prime_mmap

2018-07-02 Thread Noralf Trønnes
These are needed for pl111 to use the generic fbdev emulation. Cc: Eric Anholt Signed-off-by: Noralf Trønnes Reviewed-by: Eric Anholt --- drivers/gpu/drm/pl111/pl111_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv

[Intel-gfx] [PATCH v4 5/9] drm/client: Add client callbacks

2018-07-02 Thread Noralf Trønnes
Add client callbacks and hook them up. Add a list of clients per drm_device. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c| 92 - drivers/gpu/drm/drm_drv.c | 7 +++ drivers/gpu/drm/drm_fb_cma_helper.c | 2 +- drivers/gpu/dr

[Intel-gfx] [PATCH v4 1/9] drm: Begin an API for in-kernel clients

2018-07-02 Thread Noralf Trønnes
This the beginning of an API for in-kernel clients. First out is a way to get a framebuffer backed by a dumb buffer. Only GEM drivers are supported. The original idea of using an exported dma-buf was dropped because it also creates an anonomous file descriptor which doesn't work when the buffer is

[Intel-gfx] [PATCH v4 0/9] drm: Add generic fbdev emulation

2018-07-02 Thread Noralf Trønnes
This patchset adds generic fbdev emulation for drivers that supports GEM based dumb buffers which support .gem_prime_vmap and gem_prime_mmap. An API is begun to support in-kernel clients in general. Change this version: Fix a bug in an error path that the kbuild test robot caught. Change previous

[Intel-gfx] [PATCH v4 8/9] drm/tinydrm: Use drm_fbdev_generic_setup()

2018-07-02 Thread Noralf Trønnes
Make full use of the generic fbdev client. Cc: David Lechner Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 3 +-- drivers/gpu/drm/tinydrm/ili9225.c | 1 - drivers/gpu/drm/tinydrm/ili9341.c | 1 - drivers/gpu/drm/tinydrm/mi0283qt.c |

[Intel-gfx] [PATCH v4 9/9] drm/cma-helper: Remove drm_fb_cma_fbdev_init_with_funcs()

2018-07-02 Thread Noralf Trønnes
Remove drm_fb_cma_fbdev_init_with_funcs(), its only user tinydrm has moved to drm_fbdev_generic_setup(). Cc: Laurent Pinchart Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_cma_helper.c | 21 - include/drm/drm_fb_cma_helper.h | 3 --- 2 files changed, 24 delet

[Intel-gfx] [PATCH v4 7/9] drm/fb-helper: Finish the generic fbdev emulation

2018-07-02 Thread Noralf Trønnes
This adds a drm_fbdev_generic_setup() function that sets up generic fbdev emulation with client callbacks for restore, hotplug and unregister. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 117 include/drm/drm_fb_helper.h | 7 +

[Intel-gfx] [PATCH v4 4/9] drm/cma-helper: Use the generic fbdev emulation

2018-07-02 Thread Noralf Trønnes
This switches the CMA helper drivers that use its fbdev emulation over to the generic fbdev emulation. It's the first phase of using generic fbdev. A later phase will use DRM client callbacks for the lastclose/hotplug/remove callbacks. There are currently 2 fbdev init/fini functions: - drm_fb_cma_

[Intel-gfx] [PATCH v4 6/9] drm/debugfs: Add internal client debugfs file

2018-07-02 Thread Noralf Trønnes
Print the names of the internal clients currently attached. Reviewed-by: Daniel Vetter Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c | 28 drivers/gpu/drm/drm_debugfs.c | 7 +++ include/drm/drm_client.h | 3 +++ 3 files changed, 38 inser

Re: [Intel-gfx] [PATCH v2] drm/i915: Try GGTT mmapping whole object as partial

2018-07-02 Thread Matthew Auld
On 30 June 2018 at 10:05, Chris Wilson wrote: > If the whole object is already pinned by HW for use as scanout, we will > fail to move it to the mappable region and so must resort to using a > partial VMA covering the whole object. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104513

[Intel-gfx] [PATCH] usb/icl: Work around ACPI boottime crash

2018-07-02 Thread Imre Deak
Work around the following boot time crash: [ 10.456056] CPU: 1 PID: 220 Comm: systemd-udevd Tainted: GW 4.17.0-rc7-CI-CI_DRM_4040+ #182 [ 10.465828] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP, BIOS +ICLSFWR1.R00.2204.A00.1805172221

Re: [Intel-gfx] [PATCH v2 5/9] drm/nouveau: Use drm_connector_for_each_possible_encoder()

2018-07-02 Thread Ville Syrjälä
On Mon, Jul 02, 2018 at 04:04:45PM +0300, Ville Syrjälä wrote: > On Sat, Jun 30, 2018 at 10:12:21PM +0300, Dan Carpenter wrote: > > Hi Ville, > > > > Thank you for the patch! Perhaps something to improve: > > > > url: > > https://github.com/0day-ci/linux/commits/Ville-Syrjala/drm-Third-attemp

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Adding YUV444 packed format(DRM_FORMAT_AYUV) support. (rev2)

2018-07-02 Thread Patchwork
== Series Details == Series: drm/i915: Adding YUV444 packed format(DRM_FORMAT_AYUV) support. (rev2) URL : https://patchwork.freedesktop.org/series/45774/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4412 -> Patchwork_9496 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Add generic fbdev emulation

2018-07-02 Thread Patchwork
== Series Details == Series: drm: Add generic fbdev emulation URL : https://patchwork.freedesktop.org/series/45777/ State : warning == Summary == $ dim checkpatch origin/drm-tip 44cb6f91d1db drm: Begin an API for in-kernel clients -:26: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s

[Intel-gfx] [PATCH v3] drm/i915: Adding YUV444 packed format(DRM_FORMAT_AYUV) support.

2018-07-02 Thread StanLis
From: Stanislav Lisovskiy PLANE_CTL_FORMAT_AYUV is already supported, according to hardware specification. v2: Edited commit message, removed redundant whitespaces. v3: Fixed fallthrough logic for the format switch cases. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_disp

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Add generic fbdev emulation

2018-07-02 Thread Patchwork
== Series Details == Series: drm: Add generic fbdev emulation URL : https://patchwork.freedesktop.org/series/45777/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm: Begin an API for in-kernel clients Okay! Commit: drm/fb-helper: Add generic fbdev emulation .fb_probe func

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Add generic fbdev emulation

2018-07-02 Thread Patchwork
== Series Details == Series: drm: Add generic fbdev emulation URL : https://patchwork.freedesktop.org/series/45777/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4412 -> Patchwork_9497 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.fr

Re: [Intel-gfx] [PATCH] drm/i915: abstract and document register picking macros

2018-07-02 Thread Jani Nikula
On Fri, 29 Jun 2018, Rodrigo Vivi wrote: > On Fri, Jun 29, 2018 at 01:20:39PM +0300, Jani Nikula wrote: >> Try to describe what the pick variants do, and which to prefer. No >> functional changes. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Rodrigo Vivi Thanks, pushed. BR, Jani. > >>

  1   2   >