Looking at the coordination of resets with the submission of execlists,
it will be useful to have a GEM_TRACE for when we issue the reset.
Whilst there tidy up the other GEM_TRACE to always include the engine
name, and be careful not to trust any pointers prior to asserts.
Signed-off-by: Chris Wil
== Series Details ==
Series: drm/i915: Tidy up GEM_TRACE around execlists
URL : https://patchwork.freedesktop.org/series/35611/
State : failure
== Summary ==
Applying: drm/i915: Tidy up GEM_TRACE around execlists
error: sha1 information is lacking or useless
(drivers/gpu/drm/i915/intel_lrc.c)
Looking at the coordination of resets with the submission of execlists,
it will be useful to have a GEM_TRACE for when we issue the reset.
Whilst there tidy up the other GEM_TRACE to always include the engine
name, and be careful not to trust any pointers prior to asserts.
Signed-off-by: Chris Wil
Quoting Dhinakaran Pandiyan (2017-12-20 04:35:20)
> Commit 77affa31722b ("drm/i915/psr: Fix compiler warnings for
> hsw_psr_disable()") swapped status and control registers while fixing
> indentation. The _ctl at the end of the status register name must have to
> led to this.
My bad. https://www.m
On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
> On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
[]
> > diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
[]
> > @@ -854,7 +854,7 @@ static ssize_t dma_op
On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote:
> On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
> > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> > > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
> []
> > > diff --git a/sound/soc/omap/mcbsp.c b/
Quoting Dhinakaran Pandiyan (2017-12-20 06:46:51)
> On Tuesday, December 19, 2017 8:35:20 PM PST Dhinakaran Pandiyan wrote:
> > Commit 77affa31722b ("drm/i915/psr: Fix compiler warnings for
> > hsw_psr_disable()") swapped status and control registers while fixing
> > indentation. The _ctl at the en
lock_all_ctx in setplane_internal may return -EINTR, and
__setplane_internal could return -EDEADLK. Making more
special cases for fb would make the code even harder to
read, so the easiest solution is not taking over the fb
refcount, and making callers responsible for dropping
the ref.
Bugzilla: h
This is is very useful to finding sources of leaked framebufers.
The fbcon fb is annotated with [fbcon], to give it a better name
than kworker.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/drm_fb_helper.c | 1 +
drivers/gpu/drm/drm_framebuffer.c | 2 ++
include/drm/drm_framebuffer.h
There's a small leak excerbated by interruptible waiting in setplane_internal,
which was triggered by kms_atomic. Another leak is in load detection, and easily
plugged by just removing the fb handling.
Maarten Lankhorst (2):
drm/plane: Make framebuffer refcounting the responsibility of
setpl
From: Ville Syrjälä
We don't need any active planes during load detection, so just disable
them all. This saves us from having to come up with a suitable
framebuffer. And we also avoid leaving sprite/cursor planes on and
potentially presenting them at a peculiar location during the load
detection
== Series Details ==
Series: drm/i915: Tidy up GEM_TRACE around execlists (rev2)
URL : https://patchwork.freedesktop.org/series/35611/
State : failure
== Summary ==
Series 35611v2 drm/i915: Tidy up GEM_TRACE around execlists
https://patchwork.freedesktop.org/api/1.0/series/35611/revisions/2/mb
From: Tvrtko Ursulin
Last refactoring introduced a copy and paste error, fix it.
Signed-off-by: Tvrtko Ursulin
Reported-by: John Harrison
Cc: John Harrison
---
scripts/trace.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/trace.pl b/scripts/trace.pl
index 98e4a
From: Tvrtko Ursulin
A couple of small optimizations which altogether bring around 30%
improvement in my testing.
1. Do less string processing on tracepoints names and push more of the
check into the if-ladder.
2. Pull out common db key and ctx processing and cache common values in
local
When reading CI failure reports seeing an "assertion false failed" is
confusing as you then have to look for the preceding explanation. Show
the actual condition that fails in the assert report. Note that this
give the system a chance at a reprieve and avoids conflicting
information such as:
(kms_
On 19/12/2017 22:42, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2017-12-19 15:45:41)
From: Tvrtko Ursulin
Support creating spin batches which return an output fence using new
__igt_spin_batch_new_fence / igt_spin_batch_new_fence API.
This will be used fromthe perf_pmu@interrupts test to ens
On 19/12/2017 21:45, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2017-12-19 15:45:42)
From: Tvrtko Ursulin
Rather than calibrate and emit nop batches, use a manually signalled chain
of spinners to generate the desired interrupts.
Signed-off-by: Tvrtko Ursulin
---
- /* Unplug the calib
Hi,
Joe Perches writes:
> drivers/usb/phy/phy-tahvo.c| 2 +-
Acked-by: Felipe Balbi
--
balbi
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 19/12/2017 22:45, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2017-12-19 15:45:43)
+static void debug_error(const char *str, double val, double ref)
+{
+ igt_debug("%s=%.2f%% (%.2f/%.2f)\n", str, __error(val, ref), val, ref);
+}
+
+static void log_error(const char *str, double val, dou
On Wed, 2017-12-20 at 10:32 +0100, Greg Kroah-Hartman wrote:
> On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote:
> > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
> > > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> > > > Convert DEVICE_ATTR uses to DEVICE_ATTR_
On 19/12/2017 16:23, John Harrison wrote:
On 12/19/2017 3:15 AM, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
A couple of small optimizations which altogether bring around 30%
improvement in my testing.
1. Do less string processing on tracepoints names and push more of the
check into the i
On Wed, Dec 20, 2017 at 01:54:41AM -0800, Joe Perches wrote:
> On Wed, 2017-12-20 at 10:32 +0100, Greg Kroah-Hartman wrote:
> > On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote:
> > > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
> > > > On Tue, Dec 19, 2017 at 10:15:07AM -0800
On Tue, Dec 19, 2017 at 03:27:31PM -0800, Dongwon Kim wrote:
> I forgot to include this brief information about this patch series.
>
> This patch series contains the implementation of a new device driver,
> hyper_dmabuf, which provides a method for DMA-BUF sharing across
> different OSes running o
On Tue, 2017-12-19 at 12:34 +, Chris Wilson wrote:
> Avoid having to test for spin[0] existing by starting the load-loop with
> it allocated.
>
> v2: Preallocate the spin[1] as well for high load.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=104060
> Signed-off-by: Chris Wilso
== Series Details ==
Series: drm: Plug framebuffer leaks.
URL : https://patchwork.freedesktop.org/series/35615/
State : success
== Summary ==
Series 35615v1 drm: Plug framebuffer leaks.
https://patchwork.freedesktop.org/api/1.0/series/35615/revisions/1/mbox/
Test debugfs_test:
Subgrou
From: Tvrtko Ursulin
Make the script survive preemption by simply forgetting the previous
request_in event happened.
Downside of the trivial approach is that the timeline will not show
the preemption event, but it will be as if the request only got
submitted to the hardware for the first time wh
On Wed, Dec 20, 2017 at 10:35:43AM +0100, Maarten Lankhorst wrote:
> lock_all_ctx in setplane_internal may return -EINTR, and
> __setplane_internal could return -EDEADLK. Making more
> special cases for fb would make the code even harder to
> read, so the easiest solution is not taking over the fb
On Wed, Dec 20, 2017 at 10:35:44AM +0100, Maarten Lankhorst wrote:
> This is is very useful to finding sources of leaked framebufers.
> The fbcon fb is annotated with [fbcon], to give it a better name
> than kworker.
>
> Signed-off-by: Maarten Lankhorst
I think we can polish this more later on,
On Wed, Dec 20, 2017 at 10:35:45AM +0100, Maarten Lankhorst wrote:
> From: Ville Syrjälä
>
> We don't need any active planes during load detection, so just disable
> them all. This saves us from having to come up with a suitable
> framebuffer. And we also avoid leaving sprite/cursor planes on and
== Series Details ==
Series: scripts/trace.pl: Fix context id recycling
URL : https://patchwork.freedesktop.org/series/35616/
State : failure
== Summary ==
IGT patchset tested on top of latest successful build
da0889bfacff106fb3ecb7049a7a21f78b4b301b igt/kms_frontbuffer_tracking: Access
via G
== Series Details ==
Series: scripts/trace.pl: Optimize event parsing and processing (rev2)
URL : https://patchwork.freedesktop.org/series/35569/
State : failure
== Summary ==
Applying: scripts/trace.pl: Optimize event parsing and processing
Using index info to reconstruct a base tree...
M
On Wed, Dec 20, 2017 at 10:08:53AM +0530, Sharma, Shashank wrote:
> Thanks for the review, David.
>
> My comments, inline.
>
>
> Regards
>
> Shashank
>
>
> On 12/19/2017 3:43 PM, David Weinehall wrote:
> > On Mon, Dec 18, 2017 at 08:15:30PM +0100, Maarten Lankhorst wrote:
> > > Op 14-11-17 om
Quoting Tvrtko Ursulin (2017-12-20 09:45:41)
>
> On 19/12/2017 21:45, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2017-12-19 15:45:42)
> >> From: Tvrtko Ursulin
> >>
> >> Rather than calibrate and emit nop batches, use a manually signalled chain
> >> of spinners to generate the desired interr
At least on the Chuwi Vi8 (non pro/plus) the LCD panel will show an image
shifted aprox. 20% to the left (with wraparound) and sometimes also wrong
colors, showing that the panel controller is starting with sampling the
datastream somewhere mid-line. This happens after the first blanking and
re-ini
== Series Details ==
Series: igt/kms_frontbuffer_tracking: Make assert(false) more informative
URL : https://patchwork.freedesktop.org/series/35617/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
da0889bfacff106fb3ecb7049a7a21f78b4b301b igt/kms_frontbuffer_
On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote:
> > > Why you didn't send that patch to the sysfs maintainer is a bit odd... :)
> >
> > So here's an opportunity for you:
> >
> > The sysfs maintainer hasn't added include/linux/sysfs.h to
> > the list of maintained files...
> >
> > D
Quoting Szwichtenberg, Radoslaw (2017-12-20 10:12:23)
> On Tue, 2017-12-19 at 12:34 +, Chris Wilson wrote:
> > Avoid having to test for spin[0] existing by starting the load-loop with
> > it allocated.
> >
> > v2: Preallocate the spin[1] as well for high load.
> >
> > References: https://bugs
> -Original Message-
> From: Chauhan, Madhav
> Sent: Monday, December 18, 2017 6:35 PM
> To: Nikula, Jani ; intel-gfx@lists.freedesktop.org
> Cc: Daniel Vetter
> Subject: RE: [Intel-gfx] [PATCH 4/4] drm/i915: push shared dpll enable to
> encoders on DDI platforms
>
> > -Original Messa
== Series Details ==
Series: drm/i915/vlv: Add cdclk workaround for DSI (rev2)
URL : https://patchwork.freedesktop.org/series/35598/
State : success
== Summary ==
Series 35598v2 drm/i915/vlv: Add cdclk workaround for DSI
https://patchwork.freedesktop.org/api/1.0/series/35598/revisions/2/mbox/
-Original Message-
> From: Lohith BS [mailto:lohith...@intel.com]
> Sent: Monday, December 11, 2017 3:13 PM
> To: intel-gfx@lists.freedesktop.org; rodrigo.v...@intel.com;
> jani.saari...@intel.com; daniel.vet...@ffwll.ch; ch...@chris-wilson.co.uk
> Cc: ankit.k.nauti...@intel.com; paulo.r.
== Series Details ==
Series: scripts/trace.pl: Rudimentary preemption support
URL : https://patchwork.freedesktop.org/series/35618/
State : failure
== Summary ==
Applying: scripts/trace.pl: Rudimentary preemption support
Using index info to reconstruct a base tree...
M scripts/trace.pl
F
== Series Details ==
Series: drm: Plug framebuffer leaks.
URL : https://patchwork.freedesktop.org/series/35615/
State : success
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-pri-indfb-multidraw:
fail -> PASS (shard-snb) fdo#103167
Subg
== Series Details ==
Series: igt/kms_frontbuffer_tracking: Make assert(false) more informative
URL : https://patchwork.freedesktop.org/series/35617/
State : success
== Summary ==
Warning: bzip IGTPW_712/shard-hsw4/results34.json.bz2 wasn't in correct JSON
format
Test kms_frontbuffer_tracking:
Hi Dave, seasons greetings, just a few small fixes.
BR,
Jani.
The following changes since commit 2cf654db8d7eafb973d28eb3cddf043d353e1345:
drm/i915/fence: Use rcu to defer freeing of irq_work (2017-12-14 10:58:59
+0200)
are available in the git repository at:
git://anongit.freedesktop.or
== Series Details ==
Series: drm/i915/vlv: Add cdclk workaround for DSI (rev2)
URL : https://patchwork.freedesktop.org/series/35598/
State : warning
== Summary ==
Test kms_flip:
Subgroup plain-flip-ts-check-interruptible:
pass -> FAIL (shard-hsw) fdo#100368
On 20/12/2017 10:49, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2017-12-20 09:45:41)
On 19/12/2017 21:45, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2017-12-19 15:45:42)
From: Tvrtko Ursulin
Rather than calibrate and emit nop batches, use a manually signalled chain
of spinners to generat
On 20/12/2017 09:06, Chris Wilson wrote:
Looking at the coordination of resets with the submission of execlists,
it will be useful to have a GEM_TRACE for when we issue the reset.
Whilst there tidy up the other GEM_TRACE to always include the engine
name, and be careful not to trust any pointers
Quoting Tvrtko Ursulin (2017-12-20 12:35:31)
>
> On 20/12/2017 10:49, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2017-12-20 09:45:41)
> >>
> >> On 19/12/2017 21:45, Chris Wilson wrote:
> >>> Quoting Tvrtko Ursulin (2017-12-19 15:45:42)
> From: Tvrtko Ursulin
>
> Rather than ca
Quoting Tvrtko Ursulin (2017-12-20 12:39:42)
>
> On 20/12/2017 09:06, Chris Wilson wrote:
> > Looking at the coordination of resets with the submission of execlists,
> > it will be useful to have a GEM_TRACE for when we issue the reset.
> > Whilst there tidy up the other GEM_TRACE to always includ
On 20/12/2017 12:43, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2017-12-20 12:39:42)
On 20/12/2017 09:06, Chris Wilson wrote:
Looking at the coordination of resets with the submission of execlists,
it will be useful to have a GEM_TRACE for when we issue the reset.
Whilst there tidy up the ot
Quoting Tvrtko Ursulin (2017-12-20 13:21:45)
>
> On 20/12/2017 12:43, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2017-12-20 12:39:42)
> >>
> >> On 20/12/2017 09:06, Chris Wilson wrote:
> >>> Looking at the coordination of resets with the submission of execlists,
> >>> it will be useful to hav
On Wed, 20 Dec 2017, Joe Perches wrote:
> On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote:
> > > > Why you didn't send that patch to the sysfs maintainer is a bit odd...
> > > > :)
> > >
> > > So here's an opportunity for you:
> > >
> > > The sysfs maintainer hasn't added include/l
On Wed, Dec 20, 2017 at 11:50:17AM +0100, Hans de Goede wrote:
> At least on the Chuwi Vi8 (non pro/plus) the LCD panel will show an image
> shifted aprox. 20% to the left (with wraparound) and sometimes also wrong
> colors, showing that the panel controller is starting with sampling the
> datastre
On 17-12-19 22:24:10, Gabriel Krisman Bertazi wrote:
Current code advertises (on the modifiers blob property) support for CCS
modifier for pipe C on GLK, only to reject it later when validating the
request before the atomic commit.
This fixes the tests igt@kms_ccs@pipe-c-*, which should skip on
On 17-12-17 22:45:13, Gabriel Krisman Bertazi wrote:
Hi Ben and list folks,
I've been investigating some CI failures with the kms_ccs testcase in
the GLK hardware. The original bug is linked below, but there are other
more basic tests failing when trying CCS on pipe C.
https://bugs.freedeskto
On 12/19/2017 6:59 PM, Daniel Vetter wrote:
On Mon, Dec 18, 2017 at 09:42:13AM -0800, Linus Torvalds wrote:
On Sun, Dec 17, 2017 at 11:11 PM, Daniel Vetter wrote:
This didn't seem to have made it into -rc4. Anything needed to get it
going?
Do you actually see the problem in -rc4?
Because w
On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
>
...
> diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
> index 7a54e3083203..79d4dc785e5c 100644
> --- a/sound/soc/omap/mcbsp.c
> +++ b/sound/soc/omap/mcbsp.c
On Wed, Dec 20, 2017 at 10:32:11AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote:
> > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
> > > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> > > > Convert DEVICE_ATTR uses to DEVIC
Does anyone know how to use Conexant CX20921 to develop our own application. I
cannot find anywhere to download the software and manuals.
Thanks to all
J.D
-Original Message-
From: alsa-devel-boun...@alsa-project.org
[mailto:alsa-devel-boun...@alsa-project.org] On Behalf Of Andy Shevch
On 12/19/2017 12:15 PM, Joe Perches wrote:
drivers/char/ipmi/ipmi_msghandler.c| 17 +++---
For ipmi:
Acked-by: Corey Minyard
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/
On Thu, Dec 07, 2017 at 12:36:34PM +, Mika Kahola wrote:
> Cannonlake port clock programming tests and verifies DPLL legal dividers
> P, Q, and K. This tests adds two reference clocks 19.2MHz and 24MHz to
> test algorithm's capability to find P, Q, and K dividers as well as DCO
> frequency for
On Fri, Dec 15, 2017 at 2:35 PM, Rodrigo Vivi wrote:
> In case we have multiple modesets for different connectors
> happening in parallel we could have a race on the RMW on these
> shared registers.
>
> This possibility was initially raised by Paulo when reviewing
> commit '555e38d27317 ("drm/i915
On Wed, Dec 20, 2017 at 09:42:57AM +, Chris Wilson wrote:
> When reading CI failure reports seeing an "assertion false failed" is
> confusing as you then have to look for the preceding explanation. Show
> the actual condition that fails in the assert report. Note that this
> give the system a c
BSD == BSD1 or BSD2. Since we already emit spinners to the explicit BSD
rins, skip the aliased ring.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104352
Signed-off-by: Chris Wilson
---
tests/gem_spin_batch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/gem_
Spec has been updated with more reserved IDs for existent SKUs.
Cc: Lucas De Marchi
Cc: Anusha Srivatsa
Cc: Dhinakaran Pandiyan
Cc: Anuj Phogat
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_pci.c | 2 ++
include/drm/i915_pciids.h | 28 ++--
2 files
Our main header is huge. Lets try to make some cleanup.
Cc: Chris Wilson
Cc: Rodrigo Vivi
Cc: Joonas Lahtinen
Michal Wajdeczko (8):
drm/i915: Move uint_fixed_16_16_t to i915_types.h
drm/i915: Move some utility functions to i915_util.h
drm/i915: Move display related definitions to dedicat
We already keep intel_device_info functions in dedicated file.
Add matching header file and move related definitions there.
Signed-off-by: Michal Wajdeczko
Cc: Chris Wilson
Cc: Rodrigo Vivi
Cc: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_drv.h | 139 +
drive
We already have dedicated file for opregion related code, dedicated
header will make our life easier.
Signed-off-by: Michal Wajdeczko
Cc: Chris Wilson
Cc: Rodrigo Vivi
Cc: Joonas Lahtinen
Cc: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_drv.h | 57 +---
drivers/gpu/drm
We already have separate files for display related code, there
is no reason to keep all display definitions in master header.
Signed-off-by: Michal Wajdeczko
Cc: Chris Wilson
Cc: Rodrigo Vivi
Cc: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_drv.h | 283 +--
d
During initialization of the runtime part of the intel_device_info
we are dumping that part using DRM_DEBUG_DRIVERE mechanism.
As we already have pretty printer for const part of the info,
make similar function for the runtime part and use it separately.
Signed-off-by: Michal Wajdeczko
Cc: Chris
We are dumping device info separately for sw_only and runtime part
but to simplify the code we can also do it from one place once
we complete driver load.
Signed-off-by: Michal Wajdeczko
Cc: Chris Wilson
Cc: Rodrigo Vivi
Cc: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_drv.c | 18 +++
Our uint_fixed_16_16_t definition and related helper functions
deserve dedicated header. While here cleanup types and indent.
Signed-off-by: Michal Wajdeczko
Cc: Chris Wilson
Cc: Rodrigo Vivi
Cc: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_drv.h | 139 +--
driv
We have dedicated header file for utility functions and macros.
Signed-off-by: Michal Wajdeczko
Cc: Chris Wilson
Cc: Rodrigo Vivi
Cc: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_drv.h | 15 ---
drivers/gpu/drm/i915/i915_utils.h | 15 +++
2 files changed, 15 inserti
As we try to follow object-verb pattern in our functions, update
intel_device_info_runtime_init() parameter from dev_priv to info.
Signed-off-by: Michal Wajdeczko
Cc: Chris Wilson
Cc: Rodrigo Vivi
Cc: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
drivers/gpu/drm/i915/i
Quoting Michal Wajdeczko (2017-12-20 18:36:09)
> During initialization of the runtime part of the intel_device_info
> we are dumping that part using DRM_DEBUG_DRIVERE mechanism.
> As we already have pretty printer for const part of the info,
> make similar function for the runtime part and use it s
== Series Details ==
Series: drm/i915/cfl: Adding more Coffee Lake PCI IDs.
URL : https://patchwork.freedesktop.org/series/35636/
State : success
== Summary ==
Series 35636v1 drm/i915/cfl: Adding more Coffee Lake PCI IDs.
https://patchwork.freedesktop.org/api/1.0/series/35636/revisions/1/mbox/
Quoting Michal Wajdeczko (2017-12-20 18:36:03)
> Our uint_fixed_16_16_t definition and related helper functions
> deserve dedicated header. While here cleanup types and indent.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Chris Wilson
> Cc: Rodrigo Vivi
> Cc: Joonas Lahtinen
> ---
> drivers/gpu/
Quoting Michal Wajdeczko (2017-12-20 18:36:04)
> We have dedicated header file for utility functions and macros.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Chris Wilson
> Cc: Rodrigo Vivi
> Cc: Joonas Lahtinen
Reviewed-by: Chris Wilson
-Chris
___
Int
Quoting Michal Wajdeczko (2017-12-20 18:36:05)
> We already have separate files for display related code, there
> is no reason to keep all display definitions in master header.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Chris Wilson
> Cc: Rodrigo Vivi
> Cc: Joonas Lahtinen
Looks a straight cop
Quoting Michal Wajdeczko (2017-12-20 18:36:06)
> We already have dedicated file for opregion related code, dedicated
> header will make our life easier.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Chris Wilson
> Cc: Rodrigo Vivi
> Cc: Joonas Lahtinen
> Cc: Ville Syrjälä
> ---
> drivers/gpu/d
Series:
Tested-by: Jordan Justen
Reviewed-by: Jordan Justen
On 2017-12-06 15:11:20, Scott D Phillips wrote:
> No functionality related to aub is provided by libdrm aside from
> intel_aub.h which somewhat defines the file format. Move the
> header into this project to ease aub-related developmen
Quoting Michal Wajdeczko (2017-12-20 18:36:07)
> We already keep intel_device_info functions in dedicated file.
> Add matching header file and move related definitions there.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Chris Wilson
> Cc: Rodrigo Vivi
> Cc: Joonas Lahtinen
> ---
> drivers/gpu/dr
On Tuesday, December 19, 2017 7:15:08 PM CET Joe Perches wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible.
>
> Done with perl script:
>
> $ git grep -w --name-only DEVICE_ATTR | \
> xargs perl -i -e 'local $/; while (<>) {
> s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IRUGO
== Series Details ==
Series: Misc i915_drv.h cleanups
URL : https://patchwork.freedesktop.org/series/35637/
State : failure
== Summary ==
Series 35637v1 Misc i915_drv.h cleanups
https://patchwork.freedesktop.org/api/1.0/series/35637/revisions/1/mbox/
Test debugfs_test:
Subgroup read_a
Quoting Michal Wajdeczko (2017-12-20 18:36:08)
> As we try to follow object-verb pattern in our functions, update
> intel_device_info_runtime_init() parameter from dev_priv to info.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Chris Wilson
> Cc: Rodrigo Vivi
> Cc: Joonas Lahtinen
The patch looks
On Wed, Dec 20, 2017 at 10:29:19AM -0800, Rodrigo Vivi wrote:
> Spec has been updated with more reserved IDs for existent SKUs.
>
> Cc: Lucas De Marchi
> Cc: Anusha Srivatsa
> Cc: Dhinakaran Pandiyan
> Cc: Anuj Phogat
> Signed-off-by: Rodrigo Vivi
The IDs match with Spec.
Reviewed-by: Anusha
Quoting Michal Wajdeczko (2017-12-20 18:36:10)
> We are dumping device info separately for sw_only and runtime part
> but to simplify the code we can also do it from one place once
> we complete driver load.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Chris Wilson
> Cc: Rodrigo Vivi
> Cc: Joonas
On Wed, Dec 20, 2017 at 07:15:47PM +, Anusha Srivatsa wrote:
> On Wed, Dec 20, 2017 at 10:29:19AM -0800, Rodrigo Vivi wrote:
> > Spec has been updated with more reserved IDs for existent SKUs.
> >
> > Cc: Lucas De Marchi
> > Cc: Anusha Srivatsa
> > Cc: Dhinakaran Pandiyan
> > Cc: Anuj Phoga
On Wed, 20 Dec 2017, Michal Wajdeczko wrote:
> Our main header is huge. Lets try to make some cleanup.
Overall seems fine, I think I agree with Chris' review. I do want
Rodrigo's ack wrt upcoming stuff that's bound to conflict with many of
the patches here. I don't want to cause unnecessary burde
== Series Details ==
Series: igt/gem_spin_batch: Skip overloading aliased BSD engines
URL : https://patchwork.freedesktop.org/series/35634/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
851c417b6b7a4ea28af67cfad116c8b7dc1d263e igt/kms_frontbuffer_tracking:
On Wed, Dec 20, 2017 at 07:24:52PM +, Jani Nikula wrote:
> On Wed, 20 Dec 2017, Michal Wajdeczko wrote:
> > Our main header is huge. Lets try to make some cleanup.
>
> Overall seems fine, I think I agree with Chris' review. I do want
> Rodrigo's ack wrt upcoming stuff that's bound to conflict
On Wed, 2017-12-20 at 09:24 +, Chris Wilson wrote:
> Quoting Dhinakaran Pandiyan (2017-12-20 04:35:20)
> > Commit 77affa31722b ("drm/i915/psr: Fix compiler warnings for
> > hsw_psr_disable()") swapped status and control registers while fixing
> > indentation. The _ctl at the end of the statu
On Tue, 2017-12-19 at 15:28 -0800, Rodrigo Vivi wrote:
> On Tue, Dec 19, 2017 at 10:07:30PM +, Chris Wilson wrote:
> > Quoting Rodrigo Vivi (2017-12-19 21:59:43)
> > > On Fri, Dec 08, 2017 at 10:06:46PM +, Lucas De Marchi wrote:
> > > > This copies include/drm/i915_pciids.h from kernel as o
Avoids some typo pitfalls.
Cc: Chris Wilson
Cc: Rodrigo Vivi
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
drivers/gpu/drm/i915/i915_reg.h | 6 +++---
drivers/gpu/drm/i915/intel_psr.c| 24
3 files changed, 17 insertions(
Quoting De Marchi, Lucas (2017-12-20 20:06:24)
> On Tue, 2017-12-19 at 15:28 -0800, Rodrigo Vivi wrote:
> > On Tue, Dec 19, 2017 at 10:07:30PM +, Chris Wilson wrote:
> > > Quoting Rodrigo Vivi (2017-12-19 21:59:43)
> > > > On Fri, Dec 08, 2017 at 10:06:46PM +, Lucas De Marchi wrote:
> > > >
== Series Details ==
Series: drm/i915/cfl: Adding more Coffee Lake PCI IDs.
URL : https://patchwork.freedesktop.org/series/35636/
State : success
== Summary ==
Test gem_eio:
Subgroup in-flight-contexts:
pass -> DMESG-WARN (shard-snb) fdo#104058
Test kms_frontbuffe
On Tue, 2017-12-19 at 13:59 -0800, Rodrigo Vivi wrote:
> On Fri, Dec 08, 2017 at 10:06:46PM +, Lucas De Marchi wrote:
> > This copies include/drm/i915_pciids.h from kernel as of drm-tip:
> > drm-tip: 2017y-12m-08d-21h-06m-35s UTC + patch adding INTEL_CFL_IDS that
> > was missing there[1].
>
>
== Series Details ==
Series: drm/i915/psr: Don't name status or debug registers like control
registers.
URL : https://patchwork.freedesktop.org/series/35644/
State : success
== Summary ==
Series 35644v1 drm/i915/psr: Don't name status or debug registers like control
registers.
https://patchw
== Series Details ==
Series: igt/gem_spin_batch: Skip overloading aliased BSD engines
URL : https://patchwork.freedesktop.org/series/35634/
State : success
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
fail -> PASS
Synchronize with kernel header as of
c99d7832dcd7 ("drm/i915/cfl: Adding more Coffee Lake PCI IDs.")
Signed-off-by: Lucas De Marchi
---
lib/i915_pciids.h | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
index
1 - 100 of 135 matches
Mail list logo
