Re: [Intel-gfx] [PATCH v8 5/6] drm/i915/guc : Updating GuC logs to remove enable_guc_submission parameter

2017-10-30 Thread Sagar Arun Kamble
On 10/24/2017 10:51 PM, Sujaritha Sundaresan wrote: Replacing conditions to remove dependance on enable_guc_submission Signed-off-by: Sujaritha Sundaresan Cc: Anusha Srivatsa Cc: Michal Wajdeczko Cc: Oscar Mateo Cc: Sagar Arun Kamble --- drivers/gpu/drm/i915/intel_guc_log.c | 8 +++-

[Intel-gfx] [PATCH] drm/i915: Fix DPLL warning when starting guest VM

2017-10-30 Thread Zhao, Xinda
The warning is occurred in guest VM when trying to get clock in encoder initialization. intel_modeset_init() ->intel_modeset_setup_hw_state() ->intel_ddi_get_config() ->intel_ddi_clock_get() ->skl_ddi_clock_get() ->intel_get_shared_dpll_id() ->WARN_ON(pll

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix DPLL warning when starting guest VM

2017-10-30 Thread Patchwork
== Series Details == Series: drm/i915: Fix DPLL warning when starting guest VM URL : https://patchwork.freedesktop.org/series/32820/ State : failure == Summary == Series 32820v1 drm/i915: Fix DPLL warning when starting guest VM https://patchwork.freedesktop.org/api/1.0/series/32820/revisions/1

Re: [Intel-gfx] [PATCH] drm/i915: Mention which driver is taking over the VGA console

2017-10-30 Thread Tvrtko Ursulin
On 27/10/2017 22:33, Chris Wilson wrote: Currently there is a rather bland, [4.987589] [drm] Replacing VGA console driver I had some patches which replaced this with [i915], but then Robert Bragg had some even better patches to improve the DRM logging in general. It might be best to res

[Intel-gfx] ✗ Fi.CI.BAT: failure for run-tests.sh: Use piglit names when listing available tests

2017-10-30 Thread Patchwork
== Series Details == Series: run-tests.sh: Use piglit names when listing available tests URL : https://patchwork.freedesktop.org/series/32527/ State : failure == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_latency: Wire

Re: [Intel-gfx] [PATCH v5 2/6] drm/i915: Stop frobbing with DDI encoder->type

2017-10-30 Thread Maarten Lankhorst
Op 27-10-17 om 21:31 schreef Ville Syrjala: > From: Ville Syrjälä > > Currently the DDI encoder->type will change at runtime depending on > what kind of hotplugs we've processed. That's quite bad since we can't > really trust that that current value of encoder->type actually matches > the type of

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Use intel_ddi_get_config() for MST

2017-10-30 Thread Maarten Lankhorst
Op 27-10-17 om 21:31 schreef Ville Syrjala: > From: Ville Syrjälä > > Eliminate the partially duplicated DDI readout code from MST, and > instead just call intel_ddi_get_config(). As a nice bonus we get > more cross checking as intel_ddi_get_config() will populate > output_types based on the actua

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915: Reject unknown syncobj flags (rev2)

2017-10-30 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Reject unknown syncobj flags (rev2) URL : https://patchwork.freedesktop.org/series/32755/ State : success == Summary == Series 32755v2 series starting with [v2,1/3] drm/i915: Reject unknown syncobj flags https://patchwork.f

Re: [Intel-gfx] [PATCH 02/15] drm: Add drm_device->drm_fb_helper_private pointer

2017-10-30 Thread Daniel Vetter
On Fri, Oct 20, 2017 at 07:11:18PM +0200, Noralf Trønnes wrote: > > Den 20.10.2017 18.00, skrev Ville Syrjälä: > > On Fri, Oct 20, 2017 at 05:44:15PM +0200, Noralf Trønnes wrote: > > > Den 20.10.2017 15.52, skrev Ville Syrjälä: > > > > On Fri, Oct 20, 2017 at 01:02:00AM +0200, Noralf Trønnes wrote

Re: [Intel-gfx] [PATCH v3 2/7] drm: Add panel orientation quirks

2017-10-30 Thread Daniel Vetter
On Mon, Oct 23, 2017 at 09:14:20AM +0200, Hans de Goede wrote: > Some x86 clamshell design devices use portrait tablet screens and a display > engine which cannot rotate in hardware, so the firmware just leaves things > as is and we cannot figure out that the display is oriented non upright > from

[Intel-gfx] ✓ Fi.CI.BAT: success for run-tests.sh: Use piglit names when listing available tests

2017-10-30 Thread Patchwork
== Series Details == Series: run-tests.sh: Use piglit names when listing available tests URL : https://patchwork.freedesktop.org/series/32527/ State : success == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_latency: Wire

Re: [Intel-gfx] [PATCH v3 3/7] drm: Add support for a panel-orientation connector property

2017-10-30 Thread Daniel Vetter
On Mon, Oct 23, 2017 at 09:14:21AM +0200, Hans de Goede wrote: > On some devices the LCD panel is mounted in the casing in such a way that > the up/top side of the panel does not match with the top side of the > device (e.g. it is mounted upside-down). > > This commit adds the necessary infra for

Re: [Intel-gfx] [PATCH v3 4/7] drm/fb-helper: Apply panel orientation connector prop to the primary plane

2017-10-30 Thread Daniel Vetter
On Mon, Oct 23, 2017 at 09:14:22AM +0200, Hans de Goede wrote: > Apply the "panel orientation" drm connector prop to the primary plane so > that fbcon and fbdev using userspace programs display the right way up. > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=94894 > Signed-off-by: Hans de

Re: [Intel-gfx] [PATCH v3 6/7] efifb: Set info->fbcon_rotate_hint based on drm_get_panel_orientation_quirk

2017-10-30 Thread Daniel Vetter
On Mon, Oct 23, 2017 at 09:14:24AM +0200, Hans de Goede wrote: > On some hardware the LCD panel is not mounted upright in the casing, > but rotated by 90 degrees. In this case we want the console to > automatically be rotated to compensate. > > The drm subsys has a quirk table for this, use the >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/edp: read edp display control registers unconditionally

2017-10-30 Thread Jani Nikula
On Thu, 26 Oct 2017, Manasi Navare wrote: > This is the second wierd eDP panel case/bug that I have seen recently > where it doesnt not behave as per the spec. It'll teach you to treat the displays as external devices that try to fuzz our driver... and there's a fine balance between being defensi

Re: [Intel-gfx] [PATCH v3 0/7] drm/fbdev: Panel orientation connector property support

2017-10-30 Thread Daniel Vetter
On Mon, Oct 23, 2017 at 09:14:18AM +0200, Hans de Goede wrote: > Hi All, > > Here is v3 of my series to add a "panel orientation" property to > the drm-connector for the LCD panel to let userspace know about LCD > panels which are not mounted upright, as well as detecting upside-down > panels with

[Intel-gfx] ✗ Fi.CI.BAT: failure for tests: add device information tests

2017-10-30 Thread Patchwork
== Series Details == Series: tests: add device information tests URL : https://patchwork.freedesktop.org/series/32764/ State : failure == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_latency: Wire up an interloper for p

Re: [Intel-gfx] [PATCH v2 2/2] Test case for drm_vblank_cleanup refcount validation patch

2017-10-30 Thread Daniel Vetter
On Wed, Oct 25, 2017 at 08:44:45PM +0530, PrasannaKumar Muralidharan wrote: > Hi All, > > On 24 October 2017 at 22:18, PrasannaKumar Muralidharan > wrote: > > In i915 driver unload drm_vblank_get is added to test whether > > drm_vblank_cleanup refcount validation patch is working. > > > > Signed-

[Intel-gfx] [PATCH i-g-t] tests/gem_eio: Nerf in-flight-suspend

2017-10-30 Thread Petri Latvala
Use TEST_NONE instead of TEST_DEVICES to prevent a machine death that happens on a particular model of SNB (2600 is affected, 2520m is not). Reset is unreliable, but the exact setup to trigger the death and how to work around it are not found at this time. References: https://intel-gfx-ci.01.org/

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Remove i915.semaphores modparam

2017-10-30 Thread Maarten Lankhorst
Op 28-10-17 om 13:27 schreef Chris Wilson: > Having disabled the broken semaphores on Sandybridge, there is no need > for a modparam any more, so remove it in favour of a simple > HAS_LEGACY_SEMAPHORES() guard. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > --- > drivers/gpu/drm/i915/i9

[Intel-gfx] ✓ Fi.CI.IGT: success for run-tests.sh: Use piglit names when listing available tests

2017-10-30 Thread Patchwork
== Series Details == Series: run-tests.sh: Use piglit names when listing available tests URL : https://patchwork.freedesktop.org/series/32527/ State : success == Summary == Test drv_suspend: Subgroup fence-restore-untiled: skip -> PASS (shard-hsw) Test perf:

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for run-tests.sh: Use piglit names when listing available tests

2017-10-30 Thread Arkadiusz Hiler
On Mon, Oct 30, 2017 at 09:40:14AM +, Patchwork wrote: > == Series Details == > > Series: run-tests.sh: Use piglit names when listing available tests > URL : https://patchwork.freedesktop.org/series/32527/ > State : success > > == Summary == > > IGT patchset tested on top of latest success

Re: [Intel-gfx] [PATCH igt] lib/i915: Query semaphore status using GETPARAM

2017-10-30 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 28/10/17 12:13, Chris Wilson wrote: Wherever possible we want to use existing ioctls rather than poking the volatile modparams, in this case we already provide I915_PARAM_HAS_SEMAPHORES so we have no excuse to peek i915.semaphores. Signed-off-by: Chris Wilson

[Intel-gfx] ✗ Fi.CI.BAT: failure for tests/gem_eio: Nerf in-flight-suspend

2017-10-30 Thread Patchwork
== Series Details == Series: tests/gem_eio: Nerf in-flight-suspend URL : https://patchwork.freedesktop.org/series/32825/ State : failure == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_latency: Wire up an interloper for

Re: [Intel-gfx] [i-g-t] assembler: Fix bashism in run-test.sh

2017-10-30 Thread Joonas Lahtinen
On Sat, 2017-10-28 at 20:20 -0400, Rhys Kidd wrote: > [[ a != b ]] is a bashism. As it's just comparing $1 to an empty string, > use -n with a normal [ ]. > > Noticed whilst testing meson builds. /bin/sh is apparently dash in Intel's CI. > > Also change the script to #!/bin/bash to avoid having t

Re: [Intel-gfx] [PATCH v3 2/7] drm: Add panel orientation quirks

2017-10-30 Thread Hans de Goede
Hi, On 30-10-17 10:39, Daniel Vetter wrote: On Mon, Oct 23, 2017 at 09:14:20AM +0200, Hans de Goede wrote: Some x86 clamshell design devices use portrait tablet screens and a display engine which cannot rotate in hardware, so the firmware just leaves things as is and we cannot figure out that t

Re: [Intel-gfx] [PATCH v3 3/7] drm: Add support for a panel-orientation connector property

2017-10-30 Thread Hans de Goede
Hi, On 30-10-17 10:43, Daniel Vetter wrote: On Mon, Oct 23, 2017 at 09:14:21AM +0200, Hans de Goede wrote: On some devices the LCD panel is mounted in the casing in such a way that the up/top side of the panel does not match with the top side of the device (e.g. it is mounted upside-down). Thi

Re: [Intel-gfx] [PATCH v3 4/7] drm/fb-helper: Apply panel orientation connector prop to the primary plane

2017-10-30 Thread Hans de Goede
Hi, On 30-10-17 10:52, Daniel Vetter wrote: On Mon, Oct 23, 2017 at 09:14:22AM +0200, Hans de Goede wrote: Apply the "panel orientation" drm connector prop to the primary plane so that fbcon and fbdev using userspace programs display the right way up. Fixes: https://bugs.freedesktop.org/show_b

Re: [Intel-gfx] [PATCH v3 6/7] efifb: Set info->fbcon_rotate_hint based on drm_get_panel_orientation_quirk

2017-10-30 Thread Hans de Goede
Hi, On 30-10-17 10:53, Daniel Vetter wrote: On Mon, Oct 23, 2017 at 09:14:24AM +0200, Hans de Goede wrote: On some hardware the LCD panel is not mounted upright in the casing, but rotated by 90 degrees. In this case we want the console to automatically be rotated to compensate. The drm subsys

[Intel-gfx] ✗ Fi.CI.BAT: failure for tests/gem_eio: Nerf in-flight-suspend

2017-10-30 Thread Patchwork
== Series Details == Series: tests/gem_eio: Nerf in-flight-suspend URL : https://patchwork.freedesktop.org/series/32825/ State : failure == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_latency: Wire up an interloper for

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add is-wedged flag to intel_engine_dump()

2017-10-30 Thread Mika Kuoppala
Chris Wilson writes: > Comparing the state tested by intel_engine_is_idle() and printed by > intel_engine_dump(), the only bit not shown is whether or not the device > is wedged. Add that little bit of information to the pretty printer so > that if the engine fails to idle we can see why. > > Sig

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Include the global reset count for intel_engine_dump()

2017-10-30 Thread Mika Kuoppala
Chris Wilson writes: > Since a global reset affects the engine, include that along side the > per-engine reset counter when pretty printing the engine state in > intel_engine_dump(). > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Disable sempahores on Sandybridge

2017-10-30 Thread Mika Kuoppala
Chris Wilson writes: > I should have admitted defeat long ago as there has been a rare but > persistent error on Sandybridge where semaphore signaling did not > propagate to the waiter, leading to a GPU hang. > > With the work on fence signaling for v4.9, the impact of using CPU driven > signalin

[Intel-gfx] [PATCH] drm/i915: Fallback to reserve forcewake if primary ack missing

2017-10-30 Thread Mika Kuoppala
There is a possibility on gen9 hardware to miss the forcewake ack message. The recommended workaround is to use another free bit and toggle it until original bit is successfully acknowledged. Some future gen9 revs might or might not fix the underlying issue but the fallback to reserve bit dance ca

Re: [Intel-gfx] [PATCH v2 2/2] Test case for drm_vblank_cleanup refcount validation patch

2017-10-30 Thread PrasannaKumar Muralidharan
Hi Daniel, On 30 October 2017 at 15:40, Daniel Vetter wrote: > On Wed, Oct 25, 2017 at 08:44:45PM +0530, PrasannaKumar Muralidharan wrote: >> Hi All, >> >> On 24 October 2017 at 22:18, PrasannaKumar Muralidharan >> wrote: >> > In i915 driver unload drm_vblank_get is added to test whether >> > dr

[Intel-gfx] ✓ Fi.CI.IGT: success for tests/gem_eio: Nerf in-flight-suspend

2017-10-30 Thread Patchwork
== Series Details == Series: tests/gem_eio: Nerf in-flight-suspend URL : https://patchwork.freedesktop.org/series/32825/ State : success == Summary == Test kms_flip: Subgroup basic-flip-vs-wf_vblank: fail -> PASS (shard-hsw) fdo#100368 Test kms_setmode:

Re: [Intel-gfx] [PATCH] drm/i915: Mention which driver is taking over the VGA console

2017-10-30 Thread Joonas Lahtinen
On Fri, 2017-10-27 at 22:33 +0100, Chris Wilson wrote: > Currently there is a rather bland, > > [4.987589] [drm] Replacing VGA console driver > > for when we take over the console. Let's put a (device) name on that. > If we opt for DRM_DEV_INFO we get > > [5.071879] i915 :00:02.0: [d

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Fallback to reserve forcewake if primary ack missing (rev3)

2017-10-30 Thread Patchwork
== Series Details == Series: drm/i915: Fallback to reserve forcewake if primary ack missing (rev3) URL : https://patchwork.freedesktop.org/series/32694/ State : warning == Summary == Series 32694v3 drm/i915: Fallback to reserve forcewake if primary ack missing https://patchwork.freedesktop.org

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove i915.enable_execlists module parameter

2017-10-30 Thread Joonas Lahtinen
On Thu, 2017-10-26 at 22:17 +0100, Chris Wilson wrote: > Execlists and legacy ringbuffer submission are no longer feature > comparable (execlists now offer greater functionality that should > overcome their performance hit) and obsoletes the unsafe module > parameter, i.e. comparing the two modes o

[Intel-gfx] [PATCH] drm/i915: Check incoming alignment for unfenced buffers (on i915gm)

2017-10-30 Thread Chris Wilson
In case the object has changed tiling between calls to execbuf, we need to check if the existing offset inside the GTT matches the new tiling constraint. We even need to do this for "unfenced" tiled objects, where the 3D commands use an implied fence and so the object still needs to match the physi

Re: [Intel-gfx] [PATCH v3] drm/i915: Remove unsafe i915.enable_rc6

2017-10-30 Thread David Weinehall
On Fri, Oct 27, 2017 at 01:57:09PM -0700, Daniele Ceraolo Spurio wrote: > > > On 26/10/17 03:32, Chris Wilson wrote: > > It has been many years since the last confirmed sighting (and fix) of an > > RC6 related bug (usually a system hang). Remove the parameter to stop > > users from setting danger

Re: [Intel-gfx] [PATCH] drm/i915: Fallback to reserve forcewake if primary ack missing

2017-10-30 Thread Chris Wilson
Quoting Mika Kuoppala (2017-10-30 12:27:07) > There is a possibility on gen9 hardware to miss the forcewake ack > message. The recommended workaround is to use another free > bit and toggle it until original bit is successfully acknowledged. > > Some future gen9 revs might or might not fix the und

[Intel-gfx] [i-g-t v2] assembler: Fix bashism in run-test.sh

2017-10-30 Thread Rhys Kidd
[[ a != b ]] is a bashism. As it's just comparing $1 to an empty string, use -n with a normal [ ]. Noticed whilst testing meson builds. /bin/sh is apparently dash in Intel's CI. v2: - keep this as a /bin/sh script (Joonas Lahtinen) Fixes: c3863e19 ("assembler/test: Prep work for meson") CC: Dan

Re: [Intel-gfx] [PATCH resend v3 0/3] drm/i915: Misc. PMIC bus access notifier fixes

2017-10-30 Thread Hans de Goede
Hi, On 19-10-17 10:34, Hans de Goede wrote: Hi All, Here is a resend of the first 3 of the 4 patches in my Misc. PMIC bus access notifier fixes series. I'm leaving out the 4th patch this time, because that includes some changes to the iosf_mbi code under arch/x86 and that has been blocking this

Re: [Intel-gfx] [PATCH v5 1/2] x86 / i915 iosf_mbi / PMIC bus access fixes

2017-10-30 Thread Hans de Goede
Thomas, Ingo, Ping? Can we please get an ack for taking this upstream through the drm subsys tree ? Regards, Hans On 19-10-17 13:16, Hans de Goede wrote: Hi All, Here is a split-up version of my "drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()" patch, this time with the

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Fix SSEU Device Status.

2017-10-30 Thread David Weinehall
On Fri, Oct 27, 2017 at 03:05:58PM -0700, Oscar Mateo wrote: > > > On 10/25/2017 05:15 PM, Rodrigo Vivi wrote: > > CNL adds an extra register for slice/subslice information. > > Although no SKU is planed with an extra slice let's already > > handle this extra piece of information so we don't have

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Check incoming alignment for unfenced buffers (on i915gm)

2017-10-30 Thread Patchwork
== Series Details == Series: drm/i915: Check incoming alignment for unfenced buffers (on i915gm) URL : https://patchwork.freedesktop.org/series/32828/ State : failure == Summary == Series 32828v1 drm/i915: Check incoming alignment for unfenced buffers (on i915gm) https://patchwork.freedesktop

[Intel-gfx] ✓ Fi.CI.BAT: success for tests: add device information tests

2017-10-30 Thread Patchwork
== Series Details == Series: tests: add device information tests URL : https://patchwork.freedesktop.org/series/32764/ State : success == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_latency: Wire up an interloper for p

Re: [Intel-gfx] [PATCH] drm/i915: Fix DPLL warning when starting guest VM

2017-10-30 Thread Ville Syrjälä
On Mon, Oct 30, 2017 at 04:17:06PM +0800, Zhao, Xinda wrote: > The warning is occurred in guest VM when trying to get clock in encoder > initialization. > > intel_modeset_init() > ->intel_modeset_setup_hw_state() > ->intel_ddi_get_config() > ->intel_ddi_clock_get() > ->skl_ddi_

[Intel-gfx] ✗ Fi.CI.BAT: failure for assembler: Fix bashism in run-test.sh (rev2)

2017-10-30 Thread Patchwork
== Series Details == Series: assembler: Fix bashism in run-test.sh (rev2) URL : https://patchwork.freedesktop.org/series/32810/ State : failure == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_latency: Wire up an interlo

Re: [Intel-gfx] [PATCH] drm/i915/guc: Split GuC firmware xfer function into clear steps

2017-10-30 Thread Sagar Arun Kamble
On 10/27/2017 10:45 PM, Michal Wajdeczko wrote: Transfer of GuC firmware requires few steps that currently are implemented in two large functions. Split this code into smaller functions to make these steps small and clear. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Joonas Lahtinen

[Intel-gfx] ✓ Fi.CI.IGT: success for tests: add device information tests

2017-10-30 Thread Patchwork
== Series Details == Series: tests: add device information tests URL : https://patchwork.freedesktop.org/series/32764/ State : success == Summary == Test kms_flip: Subgroup basic-flip-vs-wf_vblank: fail -> PASS (shard-hsw) fdo#100368 Subgroup wf_vbla

[Intel-gfx] ✓ Fi.CI.BAT: success for tools/intel_vbt_decode: Fix HDMI level shifter and max data rate bitfield sizes

2017-10-30 Thread Patchwork
== Series Details == Series: tools/intel_vbt_decode: Fix HDMI level shifter and max data rate bitfield sizes URL : https://patchwork.freedesktop.org/series/32786/ State : success == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/g

[Intel-gfx] [PATCH v2 2/2] drm/i915: Parse max HDMI TMDS clock from VBT

2017-10-30 Thread Ville Syrjala
From: Ville Syrjälä Starting from version 204 VBT can specify the max TMDS clock we are allowed to use with HDMI ports. Parse that information and take it into account when filtering modes and computing a crtc state. Also take the opportunity to sort the platform check if ladder from new to old.

[Intel-gfx] [PATCH i-g-t 1/2] tools/intel_vbt_defs: Sync up intel_vbt_defs.h with enum vbt_gmbus_ddi from the kernel

2017-10-30 Thread Ville Syrjala
From: Ville Syrjälä Bring over enum vbt_gmbus_ddi from intel_vbt_defs.h in the kernel. Cc: Rodrigo Vivi Cc: Jani Nikula Signed-off-by: Ville Syrjälä --- tools/intel_vbt_defs.h | 8 1 file changed, 8 insertions(+) diff --git a/tools/intel_vbt_defs.h b/tools/intel_vbt_defs.h index 27

[Intel-gfx] [PATCH i-g-t 2/2] tools/intel_vbt_decode: Decode HDMI max data rate

2017-10-30 Thread Ville Syrjala
From: Ville Syrjälä Decode the HDMI max data rate from the VBT. Cc: Jani Nikula Signed-off-by: Ville Syrjälä --- tools/intel_vbt_decode.c | 22 +- tools/intel_vbt_defs.h | 4 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/tools/intel_vbt_decode.c b/

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Parse max HDMI TMDS clock from VBT

2017-10-30 Thread Jani Nikula
On Mon, 30 Oct 2017, Ville Syrjala wrote: > From: Ville Syrjälä > > Starting from version 204 VBT can specify the max TMDS clock we are > allowed to use with HDMI ports. Parse that information and take it > into account when filtering modes and computing a crtc state. > > Also take the opportunit

Re: [Intel-gfx] [PATCH i-g-t 1/2] tools/intel_vbt_defs: Sync up intel_vbt_defs.h with enum vbt_gmbus_ddi from the kernel

2017-10-30 Thread Jani Nikula
On Mon, 30 Oct 2017, Ville Syrjala wrote: > From: Ville Syrjälä > > Bring over enum vbt_gmbus_ddi from intel_vbt_defs.h in the kernel. Both patches Reviewed-by: Jani Nikula > > Cc: Rodrigo Vivi > Cc: Jani Nikula > Signed-off-by: Ville Syrjälä > --- > tools/intel_vbt_defs.h | 8 >

Re: [Intel-gfx] [PATCH] drm/i915: Fix DPLL warning when starting guest VM

2017-10-30 Thread Ville Syrjälä
On Mon, Oct 30, 2017 at 03:49:28PM +0200, Ville Syrjälä wrote: > On Mon, Oct 30, 2017 at 04:17:06PM +0800, Zhao, Xinda wrote: > > The warning is occurred in guest VM when trying to get clock in encoder > > initialization. What does guest VM mean here? gvt? If so, why do you claim to have an enable

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/vbt: Fix HDMI level shifter and max data rate bitfield sizes

2017-10-30 Thread Patchwork
== Series Details == Series: drm/i915/vbt: Fix HDMI level shifter and max data rate bitfield sizes URL : https://patchwork.freedesktop.org/series/32785/ State : failure == Summary == Series 32785v1 drm/i915/vbt: Fix HDMI level shifter and max data rate bitfield sizes https://patchwork.freedes

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/edp: read edp display control registers unconditionally

2017-10-30 Thread Jani Nikula
On Fri, 27 Oct 2017, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/i915/edp: read edp display control > registers unconditionally > URL : https://patchwork.freedesktop.org/series/32695/ > State : failure So I've made a mistake and pushed the patches without

Re: [Intel-gfx] [PATCH v2 1/2] drm/dp: Bit definition for D3 power state that keeps AUX fully powered

2017-10-30 Thread Jani Nikula
On Fri, 27 Oct 2017, Ville Syrjälä wrote: > On Fri, Oct 27, 2017 at 01:25:01PM +0300, Jani Nikula wrote: >> On Mon, 14 Aug 2017, Harry Wentland wrote: >> > On 2017-08-11 02:10 PM, Dhinakaran Pandiyan wrote: >> >> DPCD 600h - SET_POWER & SET_DP_PWR_VOLTAGE defines power state >> >> >> >> 101 = Se

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible() (rev2)

2017-10-30 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible() (rev2) URL : https://patchwork.freedesktop.org/series/32698/ State : success == Summary == Series 32698v2 series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_

[Intel-gfx] [PATCH v2 01/15] drm/fb-helper: Handle function NULL argument

2017-10-30 Thread Noralf Trønnes
Make functions tolerate that the drm_fb_helper argument is NULL. This is useful for drivers that continue probing when fbdev emulation fails and not having to do this check themselves. Update docs for functions that already handles this. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter -

[Intel-gfx] [PATCH v2 00/15] drm/fb-helper: Add .last_close and .output_poll_changed helpers

2017-10-30 Thread Noralf Trønnes
This patchset adds fbdev .last_close and .output_poll_changed helpers to reduce fbdev emulation footprint in drivers. I don't know which drivers have their own tree or not, so if you want me to apply your patch to drm-misc, please let me know. I will do a separate patchset for the cma helper driv

[Intel-gfx] [PATCH v2 04/15] drm/amdgpu: Use drm_fb_helper_lastclose() and _poll_changed()

2017-10-30 Thread Noralf Trønnes
This driver can use drm_fb_helper_lastclose() in its .lastclose function. It can also use drm_fb_helper_output_poll_changed() as its .output_poll_changed callback. Cc: Alex Deucher Cc: "Christian König" Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 9 ++--

[Intel-gfx] [PATCH v2 08/15] drm/i915: Use drm_fb_helper_output_poll_changed()

2017-10-30 Thread Noralf Trønnes
This driver can use drm_fb_helper_output_poll_changed() as its .output_poll_changed callback. Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/i915/intel_display.c | 2 +- drivers/gpu/drm/i915/intel_drv.h | 5 - drivers/gpu/drm/i91

[Intel-gfx] [PATCH v2 03/15] drm/fb-helper: Add .last_close and .output_poll_changed helpers

2017-10-30 Thread Noralf Trønnes
This adds helpers for the drm_driver->last_close and the drm_mode_config_funcs->output_poll_changed callbacks. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 28 include/drm/drm_fb_helper.h | 11 +++ 2 file

[Intel-gfx] [PATCH v2 06/15] drm/exynos: Use drm_fb_helper_lastclose() and _poll_changed()

2017-10-30 Thread Noralf Trønnes
This driver can use drm_fb_helper_lastclose() as its .lastclose callback. It can also use drm_fb_helper_output_poll_changed() as its .output_poll_changed callback. Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/exynos/exy

[Intel-gfx] [PATCH v2 09/15] drm/msm: Use drm_fb_helper_lastclose() and _poll_changed()

2017-10-30 Thread Noralf Trønnes
This driver can use drm_fb_helper_lastclose() as its .lastclose callback. It can also use drm_fb_helper_output_poll_changed() as its .output_poll_changed callback. Cc: Rob Clark Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/msm/msm_drv.c | 18 ++ 1 file changed, 2 insertions

[Intel-gfx] [PATCH v2 05/15] drm/armada: Use drm_fb_helper_lastclose() and _poll_changed()

2017-10-30 Thread Noralf Trønnes
This driver can use drm_fb_helper_lastclose() as its .lastclose callback. It can also use drm_fb_helper_output_poll_changed() as its .output_poll_changed callback. Cc: Russell King Signed-off-by: Noralf Trønnes Acked-by: Russell King --- drivers/gpu/drm/armada/armada_drm.h | 1 - drivers/gp

[Intel-gfx] [PATCH v2 02/15] drm: Add drm_device->fb_helper pointer

2017-10-30 Thread Noralf Trønnes
drm_fb_helper is *the* way of doing fbdev emulation so add a pointer to struct drm_device. This makes it possible to add callback helpers for .last_close and .output_poll_changed further reducing fbdev emulation footprint in drivers. The pointer is set by drm_fb_helper_init() and cleared by drm_fb_

[Intel-gfx] [PATCH v2 07/15] drm/gma500: Use drm_fb_helper_lastclose() and _poll_changed()

2017-10-30 Thread Noralf Trønnes
This driver can use drm_fb_helper_lastclose() as its .lastclose callback. It can also use drm_fb_helper_output_poll_changed() as its .output_poll_changed callback. Cc: Patrik Jakobsson Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/gma500/framebuffer.c | 9 + drivers/gpu/drm/gma500/

Re: [Intel-gfx] [PATCH 1/2] drm/i915/fbc: intel_fbc.crtc and intel_fbc.enabled are synonymous

2017-10-30 Thread Jani Nikula
On Fri, 27 Oct 2017, Chris Wilson wrote: > Slightly reduce the chance for confusion by only having one variable > instead of two to tell us when intel_fbc is enabled on a crtc. Would be great to have a simple comment within struct intel_fbc stating this. BR, Jani. > > Signed-off-by: Chris Wilso

[Intel-gfx] [PATCH v2 10/15] drm/nouveau: Use drm_fb_helper_output_poll_changed()

2017-10-30 Thread Noralf Trønnes
This driver can use drm_fb_helper_output_poll_changed() instead of its own nouveau_fbcon_output_poll_changed(). Cc: Ben Skeggs Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/nouveau/nouveau_display.c | 3 ++- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 8 drivers/gpu/drm/nouveau/nou

[Intel-gfx] [PATCH v2 11/15] drm/omap: Use drm_fb_helper_lastclose() and _poll_changed()

2017-10-30 Thread Noralf Trønnes
This driver can use drm_fb_helper_lastclose() as its .lastclose callback. It can also use drm_fb_helper_output_poll_changed() as its .output_poll_changed callback. Cc: Tomi Valkeinen Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/omapdrm/omap_drv.c | 34 ++ 1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Last part of DDI encoder->type cleanup (rev2)

2017-10-30 Thread Patchwork
== Series Details == Series: drm/i915: Last part of DDI encoder->type cleanup (rev2) URL : https://patchwork.freedesktop.org/series/32298/ State : success == Summary == Series 32298v2 drm/i915: Last part of DDI encoder->type cleanup https://patchwork.freedesktop.org/api/1.0/series/32298/revisi

[Intel-gfx] [PATCH v2 14/15] drm/tegra: Use drm_fb_helper_lastclose() and _poll_changed()

2017-10-30 Thread Noralf Trønnes
This driver can use drm_fb_helper_lastclose() as its .lastclose callback. It can also use drm_fb_helper_output_poll_changed() as its .output_poll_changed callback. Cc: Thierry Reding Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tegra/drm.c | 13 ++--- drivers/gpu/drm/tegra/drm.h |

[Intel-gfx] [PATCH v2 15/15] staging: vboxvideo: Use drm_fb_helper_lastclose()

2017-10-30 Thread Noralf Trønnes
This driver can use drm_fb_helper_lastclose() as its .lastclose callback. Cc: Hans de Goede Signed-off-by: Noralf Trønnes Reviewed-by: Hans de Goede --- drivers/staging/vboxvideo/vbox_drv.c | 2 +- drivers/staging/vboxvideo/vbox_drv.h | 1 - drivers/staging/vboxvideo/vbox_main.c | 12 -

Re: [Intel-gfx] [PATCH i-g-t v4 6/6] tests/kms_ccs: Test case for wrong aux buffer stride size

2017-10-30 Thread Ville Syrjälä
On Tue, Oct 03, 2017 at 01:57:13PM +0300, Arkadiusz Hiler wrote: > On Wed, Sep 27, 2017 at 03:34:19PM -0300, Gabriel Krisman Bertazi wrote: > > Two scenarios tested: > > - unaligned stride > > - Stride too small > > > > Signed-off-by: Gabriel Krisman Bertazi > > Fails on APL > https://intel-

Re: [Intel-gfx] [PATCH i-g-t v4 4/6] tests/kms_ccs: Test case where the CCS buffer was not provided

2017-10-30 Thread Ville Syrjälä
On Tue, Oct 03, 2017 at 09:35:33AM -0700, Ben Widawsky wrote: > On 17-09-27 15:34:17, Gabriel Krisman Bertazi wrote: > >Signed-off-by: Gabriel Krisman Bertazi > >--- > > tests/kms_ccs.c | 37 +++-- > > 1 file changed, 27 insertions(+), 10 deletions(-) > > > >diff --g

Re: [Intel-gfx] [PATCH i-g-t v4 6/6] tests/kms_ccs: Test case for wrong aux buffer stride size

2017-10-30 Thread Ville Syrjälä
On Tue, Oct 03, 2017 at 09:40:59AM -0700, Ben Widawsky wrote: > On 17-09-27 15:34:19, Gabriel Krisman Bertazi wrote: > >Two scenarios tested: > > - unaligned stride > > - Stride too small > > > >Signed-off-by: Gabriel Krisman Bertazi > > Jason, could you provide your opinion on this? I've alway

[Intel-gfx] [PATCH v2 13/15] drm/rockchip: Use drm_fb_helper_lastclose() and _poll_changed()

2017-10-30 Thread Noralf Trønnes
This driver can use drm_fb_helper_lastclose() as its .lastclose callback. It can also use drm_fb_helper_output_poll_changed() as its .output_poll_changed callback. Cc: Mark Yao Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 9 + drivers/gpu/drm/rockchip/

Re: [Intel-gfx] [PATCH v5 2/6] drm/i915: Stop frobbing with DDI encoder->type

2017-10-30 Thread Ville Syrjälä
On Mon, Oct 30, 2017 at 09:59:29AM +0100, Maarten Lankhorst wrote: > Op 27-10-17 om 21:31 schreef Ville Syrjala: > > From: Ville Syrjälä > > > > Currently the DDI encoder->type will change at runtime depending on > > what kind of hotplugs we've processed. That's quite bad since we can't > > really

[Intel-gfx] [PATCH v2 12/15] drm/radeon: Use drm_fb_helper_lastclose() and _poll_changed()

2017-10-30 Thread Noralf Trønnes
This driver can use drm_fb_helper_lastclose() in its .lastclose function. It can also use drm_fb_helper_output_poll_changed() as its .output_poll_changed callback. Cc: Alex Deucher Cc: "Christian König" Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/radeon/radeon_display.c | 9 ++--- d

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] tools/intel_vbt_defs: Sync up intel_vbt_defs.h with enum vbt_gmbus_ddi from the kernel

2017-10-30 Thread Patchwork
== Series Details == Series: series starting with [1/2] tools/intel_vbt_defs: Sync up intel_vbt_defs.h with enum vbt_gmbus_ddi from the kernel URL : https://patchwork.freedesktop.org/series/32841/ State : failure == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390

Re: [Intel-gfx] [PATCH v5 2/6] drm/i915: Stop frobbing with DDI encoder->type

2017-10-30 Thread Maarten Lankhorst
Op 30-10-17 om 17:07 schreef Ville Syrjälä: > On Mon, Oct 30, 2017 at 09:59:29AM +0100, Maarten Lankhorst wrote: >> Op 27-10-17 om 21:31 schreef Ville Syrjala: >>> From: Ville Syrjälä >>> >>> Currently the DDI encoder->type will change at runtime depending on >>> what kind of hotplugs we've proces

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/fb-helper: Add .last_close and .output_poll_changed helpers (rev2)

2017-10-30 Thread Patchwork
== Series Details == Series: drm/fb-helper: Add .last_close and .output_poll_changed helpers (rev2) URL : https://patchwork.freedesktop.org/series/32332/ State : failure == Summary == Series 32332v2 drm/fb-helper: Add .last_close and .output_poll_changed helpers https://patchwork.freedesktop.o

[Intel-gfx] ✗ Fi.CI.IGT: warning for tools/intel_vbt_decode: Fix HDMI level shifter and max data rate bitfield sizes

2017-10-30 Thread Patchwork
== Series Details == Series: tools/intel_vbt_decode: Fix HDMI level shifter and max data rate bitfield sizes URL : https://patchwork.freedesktop.org/series/32786/ State : warning == Summary == Test kms_flip: Subgroup wf_vblank-vs-dpms: dmesg-warn -> PASS (shard-h

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible() (rev2)

2017-10-30 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible() (rev2) URL : https://patchwork.freedesktop.org/series/32698/ State : success == Summary == Test kms_flip: Subgroup wf_vblank-vs-dpms: dmesg-warn -> PASS

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Last part of DDI encoder->type cleanup (rev2)

2017-10-30 Thread Patchwork
== Series Details == Series: drm/i915: Last part of DDI encoder->type cleanup (rev2) URL : https://patchwork.freedesktop.org/series/32298/ State : success == Summary == Test gem_tiled_swapping: Subgroup non-threaded: incomplete -> PASS (shard-hsw) Test kms_flip:

[Intel-gfx] [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"

2017-10-30 Thread Chris Wilson
To quote kbuild/makefiles.txt: cc-disable-warning checks if gcc supports a given warning and returns the commandline switch to disable it. This special function is needed, because gcc 4.4 and later accept any unknown -Wno-* option and only warn about it if there is another warning

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat

2017-10-30 Thread Daniele Ceraolo Spurio
On 27/10/17 15:32, Michel Thierry wrote: There is no need check if PPGTT is disabled because that not possible in CNL. Execlists and GuC submission modes rely on at least aliasing PPGTT and even intel_sanitize_enable_ppgtt says: "We don't allow disabling PPGTT for gen9+ as it's a requirement fo

Re: [Intel-gfx] [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"

2017-10-30 Thread Ville Syrjälä
On Mon, Oct 30, 2017 at 05:29:27PM +, Chris Wilson wrote: > To quote kbuild/makefiles.txt: > > cc-disable-warning checks if gcc supports a given warning and returns > the commandline switch to disable it. This special function is needed, > because gcc 4.4 and later accept any unkno

Re: [Intel-gfx] [PATCH v3] drm/i915: Remove unsafe i915.enable_rc6

2017-10-30 Thread Rodrigo Vivi
On Mon, Oct 30, 2017 at 01:00:51PM +, David Weinehall wrote: > On Fri, Oct 27, 2017 at 01:57:09PM -0700, Daniele Ceraolo Spurio wrote: > > > > > > On 26/10/17 03:32, Chris Wilson wrote: > > > It has been many years since the last confirmed sighting (and fix) of an > > > RC6 related bug (usually

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"

2017-10-30 Thread Patchwork
== Series Details == Series: drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo" URL : https://patchwork.freedesktop.org/series/32852/ State : success == Summary == Series 32852v1 drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo" https://patchwork.freedeskt

[Intel-gfx] [PATCH i-g-t v2 RESEND] tests/kms_fbcon_fbt: Report fbc_status on error

2017-10-30 Thread Gabriel Krisman Bertazi
knowing the assertion triggered on wait_until_enabled() is not that useful without knowing what exactly caused the failure. It might be an user error, like too little stolen memory by the bios, or an actual issue in the kernel. So, let's make life easier, particularly for the CI, by printing the

Re: [Intel-gfx] [i-g-t v2] assembler: Fix bashism in run-test.sh

2017-10-30 Thread Arkadiusz Hiler
On Mon, Oct 30, 2017 at 09:09:41AM -0400, Rhys Kidd wrote: > [[ a != b ]] is a bashism. As it's just comparing $1 to an empty string, > use -n with a normal [ ]. > > Noticed whilst testing meson builds. /bin/sh is apparently dash in Intel's CI. > > v2: > - keep this as a /bin/sh script (Joonas L

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/kms_fbcon_fbt: Report fbc_status on error (rev3)

2017-10-30 Thread Patchwork
== Series Details == Series: tests/kms_fbcon_fbt: Report fbc_status on error (rev3) URL : https://patchwork.freedesktop.org/series/32256/ State : success == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_latency: Wire up a

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Parse max HDMI TMDS clock from VBT

2017-10-30 Thread Ville Syrjälä
On Mon, Oct 30, 2017 at 05:05:09PM +0200, Jani Nikula wrote: > On Mon, 30 Oct 2017, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Starting from version 204 VBT can specify the max TMDS clock we are > > allowed to use with HDMI ports. Parse that information and take it > > into account when

  1   2   >