On Sat, 2017-10-28 at 20:20 -0400, Rhys Kidd wrote:
> [[ a != b ]] is a bashism. As it's just comparing $1 to an empty string,
> use -n with a normal [ ].
> 
> Noticed whilst testing meson builds. /bin/sh is apparently dash in Intel's CI.
> 
> Also change the script to #!/bin/bash to avoid having to babysit bashism 
> later.

Just leave the shebang as it is, then this is;

Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to