Re: [Intel-gfx] [maintainer-tools PATCH 30/30] qf: Use .dimrc to config and extend qf.

2017-08-22 Thread Daniel Vetter
On Mon, Aug 21, 2017 at 01:11:20PM -0700, Rodrigo Vivi wrote: > Soon we will need to extend qf for very specific > usages of our internal maintenance and rebase bot. > > So instead of creating yet another config file > let's use the existent one. > > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: Jo

Re: [Intel-gfx] [maintainer-tools PATCH] dim.rst: Document aliases extension on dimrc.

2017-08-22 Thread Jani Nikula
On Mon, 21 Aug 2017, Rodrigo Vivi wrote: > On Mon, Aug 21, 2017 at 1:39 AM, Jani Nikula wrote: >> On Fri, 18 Aug 2017, Rodrigo Vivi wrote: >>> On my own workflow I was missing a way to download mboxes >>> directly from patchwork with the patchwork id. So my first >>> reflex was to modify dim to

Re: [Intel-gfx] [PATCH] dim: Properly handle series on apply_branch

2017-08-22 Thread Jani Nikula
On Mon, 21 Aug 2017, Rodrigo Vivi wrote: > So far we could use *dim* to apply a whole series > in a mbox, but only the very last patch was receiving > all the checks and patchwork link. > > So this patch remove this limitation by using git mailsplit > to split the mbox and than use git am and chec

Re: [Intel-gfx] [maintainer-tools PATCH 30/30] qf: Use .dimrc to config and extend qf.

2017-08-22 Thread Jani Nikula
On Mon, 21 Aug 2017, Rodrigo Vivi wrote: > Soon we will need to extend qf for very specific > usages of our internal maintenance and rebase bot. > > So instead of creating yet another config file > let's use the existent one. I think I'd prefer a separate config file for qf. BR, Jani. > > Cc: D

Re: [Intel-gfx] [maintainer-tools PATCH 01/30] qf: Deprecate the use of qf without any subcommand.

2017-08-22 Thread Jani Nikula
On Mon, 21 Aug 2017, Rodrigo Vivi wrote: > These sequences here are already covered by `qf git` subcommand. > I double checked and confirmed that our continuously rebasing > bot does not use this qf directly here and I'm not aware > of anyone else using it. So let's remove it so we can start > han

Re: [Intel-gfx] [maintainer-tools PATCH 01/30] qf: Deprecate the use of qf without any subcommand.

2017-08-22 Thread Daniel Vetter
On Tue, Aug 22, 2017 at 08:55:33AM +0200, Daniel Vetter wrote: > On Mon, Aug 21, 2017 at 01:10:51PM -0700, Rodrigo Vivi wrote: > > These sequences here are already covered by `qf git` subcommand. > > I double checked and confirmed that our continuously rebasing > > bot does not use this qf directly

Re: [Intel-gfx] [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-22 Thread Gerd Hoffmann
Hi, > These are both from Gerd.  Gerd, do you have any objection to using a > union to provide either the dmabuf fd or region index? No. > > It's like we want to propose a general interface used to share > > guest's buffer with host. And the > > general interface, so far, has two choice: regio

[Intel-gfx] [PATCH i-g-t] tests/Makefile.am: Wrap audio test with dedicated conditional

2017-08-22 Thread Paul Kocialkowski
This uses the dedicated HAVE_AUDIO conditional, that depends on both ALSA and GSL, for wrapping the audio test. This makes the wrapping consistent with what is done for the chamelium test. Signed-off-by: Paul Kocialkowski --- tests/Makefile.am | 4 +--- 1 file changed, 1 insertion(+), 3 deletion

Re: [Intel-gfx] [PATCH v14 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-22 Thread Gerd Hoffmann
On Fri, 2017-08-18 at 18:21 +0800, Tina Zhang wrote: > +/** > + * VFIO_DEVICE_QUERY_GFX_PLANE - _IOW(VFIO_TYPE, VFIO_BASE + 14, > struct vfio_device_query_gfx_plane) > + * > + * Set the drm_plane_type and flags, then retrieve information about > the gfx plane. > + * > + * flags: > + * VFIO_GFX_

Re: [Intel-gfx] [RFC] mm, drm/i915: Mark pinned shmemfs pages as unevictable

2017-08-22 Thread Christopher Lameter
On Mon, 21 Aug 2017, Peter Zijlstra wrote: > > Peter, is that the latest version? > > Probably, I ran into the Infiniband code and couldn't convince anybody > to help me out :/ Its been stale for a few years now I'm afraid. What help do you need? CCing linux-rdma ___

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/Makefile.am: Wrap audio test with dedicated conditional

2017-08-22 Thread Patchwork
== Series Details == Series: tests/Makefile.am: Wrap audio test with dedicated conditional URL : https://patchwork.freedesktop.org/series/29128/ State : success == Summary == IGT patchset tested on top of latest successful build 4524a8951348a31ae5dabfc4c69f2a835034ec3e tests: Introduce audio t

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()

2017-08-22 Thread Imre Deak
On Sun, Aug 20, 2017 at 02:59:20PM +0200, Hans de Goede wrote: > intel_uncore_forcewake_reset() does forcewake puts and gets as such > we need to make sure that no-one tries to access the PUNIT->PMIC bus > (on systems where this bus is shared) while it runs, otherwise bad > things happen. > > Norm

Re: [Intel-gfx] [PATCH v2 1/2] drm: Add retries for lspcon status check

2017-08-22 Thread Imre Deak
On Mon, Aug 21, 2017 at 06:55:47PM +0530, Shashank Sharma wrote: > It's an observation during some CI tests that few LSPCON chips > respond slow while system is under load, and need some delay > while reading current mode status using i2c-over-aux channel. > > This patch: > - Adds few retries and

[Intel-gfx] [PATCH] drm/i915: Make own struct for execlist items

2017-08-22 Thread Mika Kuoppala
Engine's execlist related items have been increasing to a point where a separate struct is warranted. Carve execlist specific items to a dedicated struct to add clarity. Suggested-by: Chris Wilson Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_debugfs.c| 6 +-- drivers/gpu/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make own struct for execlist items

2017-08-22 Thread Patchwork
== Series Details == Series: drm/i915: Make own struct for execlist items URL : https://patchwork.freedesktop.org/series/29129/ State : success == Summary == Series 29129v1 drm/i915: Make own struct for execlist items https://patchwork.freedesktop.org/api/1.0/series/29129/revisions/1/mbox/ Te

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()

2017-08-22 Thread Hans de Goede
Hi, On 22-08-17 11:00, Imre Deak wrote: On Sun, Aug 20, 2017 at 02:59:20PM +0200, Hans de Goede wrote: diff --git a/arch/x86/platform/intel/iosf_mbi.c b/arch/x86/platform/intel/iosf_mbi.c index a952ac199741..a5361fd11e6e 100644 --- a/arch/x86/platform/intel/iosf_mbi.c +++ b/arch/x86/platfo

[Intel-gfx] [PATCH igt] igt: Add gem_close

2017-08-22 Thread Chris Wilson
What transpired recently was that we allow a single process to create multiple handles to the same VMA (which I broke). Make sure we test! References: https://bugs.freedesktop.org/show_bug.cgi?id=102355 Signed-off-by: Chris Wilson --- tests/Makefile.sources | 1 + tests/gem_close.c | 90 ++

Re: [Intel-gfx] [PATCH] drm/i915: Make own struct for execlist items

2017-08-22 Thread Chris Wilson
Quoting Mika Kuoppala (2017-08-22 10:37:16) > Engine's execlist related items have been increasing to > a point where a separate struct is warranted. Carve execlist > specific items to a dedicated struct to add clarity. > > Suggested-by: Chris Wilson > Signed-off-by: Mika Kuoppala Looks ok, I q

[Intel-gfx] [PATCH] drm/i915: Add more latency to avoid display flicker

2017-08-22 Thread Lee, Shawn C
From: "Lee, Shawn C" LFP flicker with latest drm-nightly on customer board. After increase latency value and this symptom can't be reproduced. TEST=Reboot DUT and no flicking on LFP. Cc: Kumar, Mahesh Cc: Gary C Wang Signed-off-by: Shawn Lee --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 fi

[Intel-gfx] [PATCH 1/3] drm/i915: Assert the context is not closed on object-close

2017-08-22 Thread Chris Wilson
During the context-close, we should be decoupling all the vma from the object so that upon object-closing we shouldn't see any vma from the already closed contexts. So include a check upon closing the object that the context is still open. v2: Eek, the fpriv check is required for shared objects. D

[Intel-gfx] [PATCH 2/3] drm/i915: Assert that the handle->vma lut is empty on object close

2017-08-22 Thread Chris Wilson
Make sure that we are not leaking an entry in the ctx->handles_lut by asserting that the object was removed prior to being freed. This should be enforced by all such handles being removed by i915_gem_close_object. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 1 + 1 file chan

[Intel-gfx] [PATCH 3/3] drm/i915: Ignore duplicate VMA stored within the per-object handle LUT

2017-08-22 Thread Chris Wilson
By using drm_gem_flink/drm_gem_open on an object using the same fd, it is possible for a client to create multiple handles pointing to the same object (tied to the same contexts and VMA), as exemplified by igt::gem_handle_to_libdrm_bo(). Since this duplication has been possible since forever, we ca

[Intel-gfx] [PATCH igt v2] igt: Add gem_close

2017-08-22 Thread Chris Wilson
What transpired recently was that we allow a single process to create multiple handles to the same VMA (which I broke). Make sure we test! References: https://bugs.freedesktop.org/show_bug.cgi?id=102355 Signed-off-by: Chris Wilson --- tests/Makefile.sources | 1 + tests/gem_close.c | 97 ++

[Intel-gfx] ✓ Fi.CI.BAT: success for igt: Add gem_close

2017-08-22 Thread Patchwork
== Series Details == Series: igt: Add gem_close URL : https://patchwork.freedesktop.org/series/29135/ State : success == Summary == IGT patchset tested on top of latest successful build 4524a8951348a31ae5dabfc4c69f2a835034ec3e tests: Introduce audio tests, starting with HDMI signal integrity

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Re-enable per-engine reset for Broxton

2017-08-22 Thread Chris Wilson
Quoting Patchwork (2017-08-18 18:57:52) > == Series Details == > > Series: drm/i915: Re-enable per-engine reset for Broxton > URL : https://patchwork.freedesktop.org/series/29011/ > State : success > > == Summary == > > Series 29011v1 drm/i915: Re-enable per-engine reset for Broxton > https://

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add more latency to avoid display flicker

2017-08-22 Thread Patchwork
== Series Details == Series: drm/i915: Add more latency to avoid display flicker URL : https://patchwork.freedesktop.org/series/29136/ State : success == Summary == Series 29136v1 drm/i915: Add more latency to avoid display flicker https://patchwork.freedesktop.org/api/1.0/series/29136/revisio

Re: [Intel-gfx] [PATCH i-g-t 02/11] tests/perf: add per context filtering test for gen8+

2017-08-22 Thread Lionel Landwerlin
On 08/08/17 15:21, Matthew Auld wrote: On 4 August 2017 at 12:20, Lionel Landwerlin wrote: From: Robert Bragg Signed-off-by: Robert Bragg Signed-off-by: Lionel Landwerlin --- tests/perf.c | 806 --- 1 file changed, 768 insertions(+)

Re: [Intel-gfx] [PATCH i-g-t] pm_rps: Extended testcases with checking PMINTRMSK register value

2017-08-22 Thread Szwichtenberg, Radoslaw
On Tue, 2017-08-22 at 01:31 +0300, Arkadiusz Hiler wrote: > On Mon, Aug 21, 2017 at 09:39:24PM +0200, Daniel Vetter wrote: > > On Mon, Aug 21, 2017 at 11:21:49AM +0100, Chris Wilson wrote: > > > Quoting Chris Wilson (2017-08-21 10:53:36) > > > > Quoting Arkadiusz Hiler (2017-08-21 10:42:25) > > > >

Re: [Intel-gfx] [PATCH i-g-t 02/11] tests/perf: add per context filtering test for gen8+

2017-08-22 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-08-22 12:45:47) > On 08/08/17 15:21, Matthew Auld wrote: > > On 4 August 2017 at 12:20, Lionel Landwerlin > > wrote: > >> static void > >> @@ -1336,6 +1504,66 @@ print_reports(uint32_t *oa_report0, uint32_t > >> *oa_report1, int fmt) > >> } > >> > >> static v

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Assert the context is not closed on object-close

2017-08-22 Thread Lofstedt, Marta
Thanks Chris, With this series the test pin-pointed in the bug now pass. Tested-by: Marta Lofstedt > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Chris Wilson > Sent: Tuesday, August 22, 2017 2:05 PM > To: intel-gfx@lists.freedeskto

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Assert the context is not closed on object-close

2017-08-22 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Assert the context is not closed on object-close URL : https://patchwork.freedesktop.org/series/29137/ State : success == Summary == Series 29137v1 series starting with [1/3] drm/i915: Assert the context is not closed on objec

[Intel-gfx] [PATCH i-g-t] intel-ci: Remove generic.testlist

2017-08-22 Thread Petri Latvala
The list has been unmaintained and unused. The set of tests is a subset of what CI runs in sharded runs so we are running all of them already. Signed-off-by: Petri Latvala --- tests/intel-ci/Makefile.am | 1 - tests/intel-ci/README | 6 -- tests/intel-ci/generic.testlist | 125

Re: [Intel-gfx] [PATCH] drm/i915: Make own struct for execlist items

2017-08-22 Thread Joonas Lahtinen
On Tue, 2017-08-22 at 12:37 +0300, Mika Kuoppala wrote: > Engine's execlist related items have been increasing to > a point where a separate struct is warranted. Carve execlist > specific items to a dedicated struct to add clarity. > > Suggested-by: Chris Wilson > Signed-off-by: Mika Kuoppala

[Intel-gfx] ✓ Fi.CI.BAT: success for igt: Add gem_close (rev2)

2017-08-22 Thread Patchwork
== Series Details == Series: igt: Add gem_close (rev2) URL : https://patchwork.freedesktop.org/series/29135/ State : success == Summary == IGT patchset tested on top of latest successful build 4524a8951348a31ae5dabfc4c69f2a835034ec3e tests: Introduce audio tests, starting with HDMI signal int

Re: [Intel-gfx] [PATCH i-g-t] pm_rps: Extended testcases with checking PMINTRMSK register value

2017-08-22 Thread Chris Wilson
Quoting Szwichtenberg, Radoslaw (2017-08-22 12:56:00) > On Tue, 2017-08-22 at 01:31 +0300, Arkadiusz Hiler wrote: > > On Mon, Aug 21, 2017 at 09:39:24PM +0200, Daniel Vetter wrote: > > > On Mon, Aug 21, 2017 at 11:21:49AM +0100, Chris Wilson wrote: > > > > Quoting Chris Wilson (2017-08-21 10:53:36)

[Intel-gfx] ✓ Fi.CI.BAT: success for intel-ci: Remove generic.testlist

2017-08-22 Thread Patchwork
== Series Details == Series: intel-ci: Remove generic.testlist URL : https://patchwork.freedesktop.org/series/29139/ State : success == Summary == IGT patchset tested on top of latest successful build 4524a8951348a31ae5dabfc4c69f2a835034ec3e tests: Introduce audio tests, starting with HDMI si

[Intel-gfx] [PATCH i-g-t v3] pm_rps: Changes in waitboost scenario

2017-08-22 Thread Katarzyna Dec
CI is observing sporadical failures in pm_rps subtests. There are a couple of reasons. One of them is the fact that on gen6, gen7 and gen7.5, max frequency (as in the HW limit) is not set to RP0, but the value obtaind from PCODE (which may be different from RP0). Thus the test is operating under wr

Re: [Intel-gfx] [PATCH i-g-t] intel-ci: Remove generic.testlist

2017-08-22 Thread Arkadiusz Hiler
On Tue, Aug 22, 2017 at 03:08:49PM +0300, Petri Latvala wrote: > The list has been unmaintained and unused. The set of tests is a > subset of what CI runs in sharded runs so we are running all of them > already. > > Signed-off-by: Petri Latvala Acked-by: Arkadiusz Hiler _

Re: [Intel-gfx] [maintainer-tools PATCH 30/30] qf: Use .dimrc to config and extend qf.

2017-08-22 Thread Daniel Vetter
On Tue, Aug 22, 2017 at 09:06:36AM +0200, Daniel Vetter wrote: > On Mon, Aug 21, 2017 at 01:11:20PM -0700, Rodrigo Vivi wrote: > > Soon we will need to extend qf for very specific > > usages of our internal maintenance and rebase bot. > > > > So instead of creating yet another config file > > let'

Re: [Intel-gfx] [maintainer-tools PATCH 30/30] qf: Use .dimrc to config and extend qf.

2017-08-22 Thread Jani Nikula
On Tue, 22 Aug 2017, Daniel Vetter wrote: > On Tue, Aug 22, 2017 at 09:06:36AM +0200, Daniel Vetter wrote: >> On Mon, Aug 21, 2017 at 01:11:20PM -0700, Rodrigo Vivi wrote: >> > Soon we will need to extend qf for very specific >> > usages of our internal maintenance and rebase bot. >> > >> > So in

[Intel-gfx] [PATCH igt] igt/pm_rpm: Use libc 'ftw' rather than opencoding our own filetree walk

2017-08-22 Thread Chris Wilson
By using ftw, we avoid the issue of having to handle directory recursion ourselves and can focus on the test of checking the reading a sysfs/debugfs does not break runtime suspend. In the process, disregard errors when opening the individual files as they may fail for other reasons. Signed-off-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for pm_rps: Changes in waitboost scenario (rev4)

2017-08-22 Thread Patchwork
== Series Details == Series: pm_rps: Changes in waitboost scenario (rev4) URL : https://patchwork.freedesktop.org/series/28966/ State : success == Summary == IGT patchset tested on top of latest successful build 4524a8951348a31ae5dabfc4c69f2a835034ec3e tests: Introduce audio tests, starting w

Re: [Intel-gfx] [PATCH i-g-t 02/11] tests/perf: add per context filtering test for gen8+

2017-08-22 Thread Lionel Landwerlin
On 22/08/17 12:59, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-08-22 12:45:47) On 08/08/17 15:21, Matthew Auld wrote: On 4 August 2017 at 12:20, Lionel Landwerlin wrote: static void @@ -1336,6 +1504,66 @@ print_reports(uint32_t *oa_report0, uint32_t *oa_report1, int fmt) }

Re: [Intel-gfx] [PATCH i-g-t] pm_rps: Extended testcases with checking PMINTRMSK register value

2017-08-22 Thread Szwichtenberg, Radoslaw
On Tue, 2017-08-22 at 13:33 +0100, Chris Wilson wrote: > Quoting Szwichtenberg, Radoslaw (2017-08-22 12:56:00) > > On Tue, 2017-08-22 at 01:31 +0300, Arkadiusz Hiler wrote: > > > On Mon, Aug 21, 2017 at 09:39:24PM +0200, Daniel Vetter wrote: > > > > On Mon, Aug 21, 2017 at 11:21:49AM +0100, Chris W

Re: [Intel-gfx] [PATCH] drm: Release driver tracking before making the object available again

2017-08-22 Thread Joonas Lahtinen
+ Sean On Mon, 2017-08-21 at 18:16 +0200, Daniel Vetter wrote: > On Sat, Aug 19, 2017 at 01:05:58PM +0100, Chris Wilson wrote: > > This is the same bug as we fixed in commit f6cd7daecff5 ("drm: Release > > driver references to handle before making it available again"), but now > > the exposure is

Re: [Intel-gfx] [PATCH i-g-t 02/11] tests/perf: add per context filtering test for gen8+

2017-08-22 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-08-22 14:11:07) > On 22/08/17 12:59, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2017-08-22 12:45:47) > >> On 08/08/17 15:21, Matthew Auld wrote: > >>> On 4 August 2017 at 12:20, Lionel Landwerlin > >>> wrote: > static void > @@ -1336,6 +1504,66

Re: [Intel-gfx] [PATCH i-g-t 01/11] tests/perf: make stream_fd a global variable

2017-08-22 Thread Lionel Landwerlin
On 04/08/17 12:39, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-08-04 12:20:30) When debugging unstable tests on new platforms we currently we don't cleanup everything well in between different tests. Since only a single OA stream fd can be opened at a time, having the stream_fd as a glob

Re: [Intel-gfx] [PATCH i-g-t 02/11] tests/perf: add per context filtering test for gen8+

2017-08-22 Thread Lionel Landwerlin
On 22/08/17 14:28, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-08-22 14:11:07) On 22/08/17 12:59, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-08-22 12:45:47) On 08/08/17 15:21, Matthew Auld wrote: On 4 August 2017 at 12:20, Lionel Landwerlin wrote: static void @@ -1336,6

[Intel-gfx] [PATCH 2/2] drm/i915: Wire up shrinkctl->nr_scanned

2017-08-22 Thread Chris Wilson
shrink_slab() allows us to report back the number of objects we successfully scanned (out of the target shrinkctl->nr_to_scan). As report the number of pages owned by each GEM object as a separate item to the shrinker, we cannot precisely control the number of shrinker objects we scan on each pass;

[Intel-gfx] [PATCH 1/2] mm: Track actual nr_scanned during shrink_slab()

2017-08-22 Thread Chris Wilson
Some shrinkers may only be able to free a bunch of objects at a time, and so free more than the requested nr_to_scan in one pass. Whilst other shrinkers may find themselves even unable to scan as many objects as they counted, and so underreport. Account for the extra freed/scanned objects against t

Re: [Intel-gfx] [PATCH i-g-t 02/11] tests/perf: add per context filtering test for gen8+

2017-08-22 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-08-22 14:48:12) > On 22/08/17 14:28, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2017-08-22 14:11:07) > >> On 22/08/17 12:59, Chris Wilson wrote: > >>> Quoting Lionel Landwerlin (2017-08-22 12:45:47) > On 08/08/17 15:21, Matthew Auld wrote: > > On 4 A

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/pm_rpm: Use libc 'ftw' rather than opencoding our own filetree walk

2017-08-22 Thread Patchwork
== Series Details == Series: igt/pm_rpm: Use libc 'ftw' rather than opencoding our own filetree walk URL : https://patchwork.freedesktop.org/series/29141/ State : success == Summary == IGT patchset tested on top of latest successful build 4524a8951348a31ae5dabfc4c69f2a835034ec3e tests: Introdu

[Intel-gfx] [PATCH v2 3/8] drm/i915: Disable infoframes when shutting down DDI HDMI

2017-08-22 Thread ville . syrjala
From: Ville Syrjälä Disabling the video DIP when shutting the port down seems like a good idea. Bspec says: "When disabling both the DIP port and DIP transmission, first disable the port and then disable DIP." and "Restriction : GCP is only supported with HDMI when the bits per color is not eq

Re: [Intel-gfx] [PATCH 00/23] huge gtt pages

2017-08-22 Thread Chris Wilson
Quoting Matthew Auld (2017-08-21 19:34:40) > Some more improvements as per Chris' comments. > > Matthew Auld (23): > mm/shmem: introduce shmem_file_setup_with_mnt > drm/i915: introduce simple gemfs > drm/i915/gemfs: enable THP > drm/i915: introduce page_size_mask to dev_info > drm/i915:

Re: [Intel-gfx] [PATCH 00/23] huge gtt pages

2017-08-22 Thread Chris Wilson
Quoting Chris Wilson (2017-08-22 15:21:10) > Quoting Matthew Auld (2017-08-21 19:34:40) > > Some more improvements as per Chris' comments. > > > > Matthew Auld (23): > > mm/shmem: introduce shmem_file_setup_with_mnt > > drm/i915: introduce simple gemfs > > drm/i915/gemfs: enable THP > > dr

Re: [Intel-gfx] [PATCH 1/2] drm/i915/cnl: simplify cnl_procmon_values handling

2017-08-22 Thread Ville Syrjälä
On Mon, Aug 21, 2017 at 05:03:55PM -0700, Rodrigo Vivi wrote: > From: Paulo Zanoni > > Make it a little less magical and a little simpler and more hardcoded > so we don't end up with an array that's composed mostly of empty > entries. > > v2: Add an enum for the voltage+register values (Ville).

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make infoframe code available to (e)DP ports (rev4)

2017-08-22 Thread Patchwork
== Series Details == Series: drm/i915: Make infoframe code available to (e)DP ports (rev4) URL : https://patchwork.freedesktop.org/series/8183/ State : success == Summary == Series 8183v4 drm/i915: Make infoframe code available to (e)DP ports https://patchwork.freedesktop.org/api/1.0/series/81

[Intel-gfx] [PATCH 3/3] drm: Add retries for dp dual mode read

2017-08-22 Thread Shashank Sharma
From the CI builds, its been observed that during a driver reload/insert, dp dual mode read function sometimes fails to read from dual mode devices (like LSPCON) over i2c-over-aux channel. This patch adds some delay and few retries, allowing a scope for these devices to settle down. V3: Introduced

[Intel-gfx] [PATCH 1/3] drm: Add retries for lspcon status check

2017-08-22 Thread Shashank Sharma
It's an observation during some CI tests that few LSPCON chips respond slow while system is under load, and need some delay while reading current mode status using i2c-over-aux channel. This patch: - Adds few retries and delays before declaring a read failure from LSPCON hardware. - Changes the

[Intel-gfx] [PATCH 0/3] Add retries for DP dual mode devices

2017-08-22 Thread Shashank Sharma
Some of the DP dual mode devices (like LSPCON) need some time to settle down, on specific platfomrs. Its been observed during IGT CI runs that some of the KBL boards show some i2c-over-aux failures when driver module is re-inserted or re-loaded. This patch series adds some retries at various dp_du

[Intel-gfx] [PATCH 2/3] drm/i915: Don't give up waiting on INVALID_MODE

2017-08-22 Thread Shashank Sharma
Our current logic to read LSPCON's current mode, stops retries and breaks wait-loop, if it gets LSPCON_MODE_INVALID as return from the core function. This doesn't allow us to try reading the mode again. This patch removes this condition and allows retries reading the currnt mode until timeout. Th

Re: [Intel-gfx] [PATCH 1/3] drm: Add retries for lspcon status check

2017-08-22 Thread Imre Deak
On Tue, Aug 22, 2017 at 08:23:49PM +0530, Shashank Sharma wrote: > It's an observation during some CI tests that few LSPCON chips > respond slow while system is under load, and need some delay > while reading current mode status using i2c-over-aux channel. > > This patch: > - Adds few retries and

Re: [Intel-gfx] [PATCH i-g-t 05/11] tests/perf: rework oa-exponent test

2017-08-22 Thread Lionel Landwerlin
On 10/08/17 14:15, Matthew Auld wrote: On 4 August 2017 at 12:20, Lionel Landwerlin wrote: New issues that were discovered while making the tests work on Gen8+ : - we need to measure timings between periodic reports and discard all other kind of reports - it seems periodicity of the

Re: [Intel-gfx] [PATCH 1/3] drm: Add retries for lspcon status check

2017-08-22 Thread Sharma, Shashank
Regards Shashank On 8/22/2017 8:24 PM, Imre Deak wrote: On Tue, Aug 22, 2017 at 08:23:49PM +0530, Shashank Sharma wrote: It's an observation during some CI tests that few LSPCON chips respond slow while system is under load, and need some delay while reading current mode status using i2c-over

Re: [Intel-gfx] [PATCH v3 0/8] drm/i915: Make infoframe code available to (e)DP ports

2017-08-22 Thread Ville Syrjälä
On Fri, Aug 18, 2017 at 04:49:50PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > A rebased reposting of the dig_port infoframe series. > > Notable changes since last time: > * Dealt with the new intel_sdvo_connector_state > * Annotated the SDP types with the DP spec versi

[Intel-gfx] ✓ Fi.CI.BAT: success for Add retries for DP dual mode devices

2017-08-22 Thread Patchwork
== Series Details == Series: Add retries for DP dual mode devices URL : https://patchwork.freedesktop.org/series/29146/ State : success == Summary == Series 29146v1 Add retries for DP dual mode devices https://patchwork.freedesktop.org/api/1.0/series/29146/revisions/1/mbox/ Test gem_exec_flus

Re: [Intel-gfx] [PATCH 00/23] huge gtt pages

2017-08-22 Thread Matthew Auld
On 22 August 2017 at 15:23, Chris Wilson wrote: > Quoting Chris Wilson (2017-08-22 15:21:10) >> Quoting Matthew Auld (2017-08-21 19:34:40) >> > Some more improvements as per Chris' comments. >> > >> > Matthew Auld (23): >> > mm/shmem: introduce shmem_file_setup_with_mnt >> > drm/i915: introduc

Re: [Intel-gfx] [PATCH 1/3] drm: Add retries for lspcon status check

2017-08-22 Thread Jani Nikula
On Tue, 22 Aug 2017, Shashank Sharma wrote: > It's an observation during some CI tests that few LSPCON chips > respond slow while system is under load, and need some delay > while reading current mode status using i2c-over-aux channel. > > This patch: > - Adds few retries and delays before declari

[Intel-gfx] [CI] drm/i915: Boost GPU clocks if we miss the pageflip's vblank

2017-08-22 Thread Chris Wilson
If we miss the current vblank because the gpu was busy, that may cause a jitter as the frame rate temporarily drops. We try to limit the impact of this by then boosting the GPU clock to deliver the frame as quickly as possible. Originally done in commit 6ad790c0f5ac ("drm/i915: Boost GPU frequency

Re: [Intel-gfx] [PATCH 1/3] drm: Add retries for lspcon status check

2017-08-22 Thread Sharma, Shashank
Regards Shashank On 8/22/2017 8:57 PM, Jani Nikula wrote: On Tue, 22 Aug 2017, Shashank Sharma wrote: It's an observation during some CI tests that few LSPCON chips respond slow while system is under load, and need some delay while reading current mode status using i2c-over-aux channel. Thi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Boost GPU clocks if we miss the pageflip's vblank (rev2)

2017-08-22 Thread Patchwork
== Series Details == Series: drm/i915: Boost GPU clocks if we miss the pageflip's vblank (rev2) URL : https://patchwork.freedesktop.org/series/28921/ State : success == Summary == Series 28921v2 drm/i915: Boost GPU clocks if we miss the pageflip's vblank https://patchwork.freedesktop.org/api/1

[Intel-gfx] [PATCH 0/2] Add retries for dp dual mode reads

2017-08-22 Thread Shashank Sharma
Some of the DP dual mode devices (like LSPCON) need some time to settle down, on specific platfomrs. Its been observed during IGT CI runs that some of the KBL boards show some i2c-over-aux failures when driver module is re-inserted or re-loaded. This patch series adds some retries at various dp_du

[Intel-gfx] [PATCH 2/2] drm/i915: Don't give up waiting on INVALID_MODE

2017-08-22 Thread Shashank Sharma
Our current logic to read LSPCON's current mode, stops retries and breaks wait-loop, if it gets LSPCON_MODE_INVALID as return from the core function. This doesn't allow us to try reading the mode again. This patch removes this condition and allows retries reading the currnt mode until timeout. Th

[Intel-gfx] [PATCH 1/2] drm: Add retries for dp dual mode read

2017-08-22 Thread Shashank Sharma
From the CI builds, its been observed that during a driver reload/insert, dp dual mode read function sometimes fails to read from dual mode devices (like LSPCON) over i2c-over-aux channel. This patch: - adds some delay and few retries, allowing a scope for these devices to settle down and respon

Re: [Intel-gfx] [PATCH] drm/i915: Boost GPU clocks if we miss the pageflip's vblank

2017-08-22 Thread Chris Wilson
Quoting Szwichtenberg, Radoslaw (2017-08-18 09:50:35) > On Fri, 2017-08-18 at 08:54 +0100, Chris Wilson wrote: > > Quoting Chris Wilson (2017-08-17 13:37:06) > > > If we miss the current vblank because the gpu was busy, that may cause a > > > jitter as the frame rate temporarily drops. We try to li

Re: [Intel-gfx] [PATCH i-g-t 05/11] tests/perf: rework oa-exponent test

2017-08-22 Thread Matthew Auld
On 22 August 2017 at 15:56, Lionel Landwerlin wrote: > On 10/08/17 14:15, Matthew Auld wrote: > > On 4 August 2017 at 12:20, Lionel Landwerlin > wrote: > > New issues that were discovered while making the tests work on Gen8+ : > > - we need to measure timings between periodic reports and discard

Re: [Intel-gfx] [PATCH 1/2] drm/i915/cnl: simplify cnl_procmon_values handling

2017-08-22 Thread Rodrigo Vivi
merged to dinq. thanks for the patches and review On Tue, Aug 22, 2017 at 7:44 AM, Ville Syrjälä wrote: > On Mon, Aug 21, 2017 at 05:03:55PM -0700, Rodrigo Vivi wrote: >> From: Paulo Zanoni >> >> Make it a little less magical and a little simpler and more hardcoded >> so we don't end up with an

[Intel-gfx] [maintainer-tools PATCH] dim.rst: Document aliases extension on dimrc.

2017-08-22 Thread Rodrigo Vivi
On my own workflow I was missing a way to download mboxes directly from patchwork with the patchwork id. So my first reflex was to modify dim to fulfil my needs. However that was increasing dim in complexity and dependencies and leaving that messy. That was when Jani suggested me the dimrc extensi

Re: [Intel-gfx] [PATCH v6] drm/i915/edp: Be less aggressive about changing link config on eDP

2017-08-22 Thread Jim Bride
On Mon, Aug 21, 2017 at 11:27:37PM +, Vivi, Rodrigo wrote: > On Mon, 2017-08-21 at 14:03 -0700, Jim Bride wrote: > > This set of changes has some history to them. There were several attempts > > to add what was called "fast link training" to i915, which actually wasn't > > fast link training a

[Intel-gfx] [PATCH v7] drm/i915/edp: Be less aggressive about changing link config on eDP

2017-08-22 Thread Jim Bride
This set of changes has some history to them. There were several attempts to add what was called "fast link training" to i915, which actually wasn't fast link training as per the DP spec. These changes were: commit 5fa836a9d859 ("drm/i915: DP link training optimization") commit 4e96c97742f4 ("dr

[Intel-gfx] [PATCH v3 0/1] drm/i915: Deal with upside-down mounted LCD panels

2017-08-22 Thread Hans de Goede
Hi All, When I last send this patch not everyone was enthusiastic about this patch. As already mentioned in the v2 discussion, solving this in userspace is not really feasible since there is no single place to fix it there, it will need fixing in at least 6 different places from the top of my head

[Intel-gfx] [PATCH v3] drm/i915: Deal with upside-down mounted LCD panels

2017-08-22 Thread Hans de Goede
On some (Bay Trail) devices the LCD panel is mounted upside-down. This commit uses the code to read back the initial rotation of the primary plane in get_initial_plane_config from Ville Syrjala's "drm/fb-helper: Inherit rotation wip" patch and when re-using the initial fb it stores that in intel_c

[Intel-gfx] [maintainer-tools PATCH] dim: Properly handle series on apply_branch

2017-08-22 Thread Rodrigo Vivi
So far we could use *dim* to apply a whole series in a mbox, but only the very last patch was receiving all the checks and patchwork link. So this patch remove this limitation by using git mailsplit to split the mbox and than use git am and checks individually on each patch. v2: a. Don't loop wit

Re: [Intel-gfx] [PATCH] dim: Properly handle series on apply_branch

2017-08-22 Thread Rodrigo Vivi
On Tue, Aug 22, 2017 at 12:22 AM, Jani Nikula wrote: > On Mon, 21 Aug 2017, Rodrigo Vivi wrote: >> So far we could use *dim* to apply a whole series >> in a mbox, but only the very last patch was receiving >> all the checks and patchwork link. >> >> So this patch remove this limitation by using g

Re: [Intel-gfx] [PATCH] drm/i915: Boost GPU clocks if we miss the pageflip's vblank

2017-08-22 Thread Ville Syrjälä
On Mon, Aug 21, 2017 at 04:54:21PM +0100, Chris Wilson wrote: > Quoting Chris Wilson (2017-08-17 13:37:06) > > If we miss the current vblank because the gpu was busy, that may cause a > > jitter as the frame rate temporarily drops. We try to limit the impact > > of this by then boosting the GPU clo

Re: [Intel-gfx] [PATCH] drm/i915: Boost GPU clocks if we miss the pageflip's vblank

2017-08-22 Thread Chris Wilson
Quoting Ville Syrjälä (2017-08-22 18:02:04) > On Mon, Aug 21, 2017 at 04:54:21PM +0100, Chris Wilson wrote: > > Quoting Chris Wilson (2017-08-17 13:37:06) > > > If we miss the current vblank because the gpu was busy, that may cause a > > > jitter as the frame rate temporarily drops. We try to limit

[Intel-gfx] ✓ Fi.CI.BAT: success for Add retries for dp dual mode reads

2017-08-22 Thread Patchwork
== Series Details == Series: Add retries for dp dual mode reads URL : https://patchwork.freedesktop.org/series/29155/ State : success == Summary == Series 29155v1 Add retries for dp dual mode reads https://patchwork.freedesktop.org/api/1.0/series/29155/revisions/1/mbox/ Test gem_exec_suspend:

[Intel-gfx] [PATCH 1/6] drm/i915/lrc: Clarify the format of the context image

2017-08-22 Thread Chris Wilson
From: Michel Thierry Not only the context image consist of two parts (the PPHWSP, and the logical context state), but we also allocate a header at the start of for sharing data with GuC. Thus every lrc looks like this: | [guc] | [hwsp] [logical state] | |<- our header ->|<- context

[Intel-gfx] HWSP execlists for kbl-shards

2017-08-22 Thread Chris Wilson
Just sending so I can see if the farm's kbl (or other execlist boxes) have any of the same symptoms as Mika. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 5/6] drm/i915/execlists: Read the context-status buffer from the HWSP

2017-08-22 Thread Chris Wilson
The engine provides a mirror of the CSB in the HWSP. If we use the cacheable reads from the HWSP, we can shave off a few mmio reads per context-switch interrupt (which are quite frequent!). Just removing a couple of mmio is not enough to actually reduce any latency, but a small reduction in overall

[Intel-gfx] [PATCH 4/6] drm/i915: Allow HW status page to be bound high

2017-08-22 Thread Chris Wilson
At the time of commit 1f767e02d69f ("drm/i915: HWS must be in the mappable region for g33"), drm_mm insertion would often default to placing a new object high in the zone forcing us to specify that certain HWSP must be bound within the low mappable region. Since then, drm_mm has gained more finesse

[Intel-gfx] [PATCH 3/6] drm/i915/lrc: allocate separate page for HWSP

2017-08-22 Thread Chris Wilson
From: Daniele Ceraolo Spurio On gen8+ we're currently using the PPHWSP of the kernel ctx as the global HWSP. However, when the kernel ctx gets submitted (e.g. from __intel_autoenable_gt_powersave) the HW will use that page as both HWSP and PPHWSP. This causes a conflict in the register arena of t

[Intel-gfx] [PATCH 2/6] drm/i915/guc: Don't make assumptions while getting the lrca offset

2017-08-22 Thread Chris Wilson
From: Michel Thierry Using the HWSP ggtt_offset to get the lrca offset is only correct if the HWSP happens to be before it (when we reuse the PPHWSP of the kernel context as the engine HWSP). Instead of making this assumption, get the lrca offset from the kernel_context engine state. And while l

[Intel-gfx] [PATCH 6/6] drm/i915/execlists: Read the context-status HEAD from the HWSP

2017-08-22 Thread Chris Wilson
The engine also provides a mirror of the CSB write pointer in the HWSP, but not of our read pointer. To take advantage of this we need to remember where we read up to on the last interrupt and continue off from there. This poses a problem following a reset, as we don't know where the hw will start

Re: [Intel-gfx] [PATCH i-g-t] tests/Makefile.am: Wrap audio test with dedicated conditional

2017-08-22 Thread Lyude Paul
r-b'd and pushed, thanks! On Tue, 2017-08-22 at 11:26 +0300, Paul Kocialkowski wrote: > This uses the dedicated HAVE_AUDIO conditional, that depends on both > ALSA and GSL, for wrapping the audio test. This makes the wrapping > consistent with what is done for the chamelium test. > > Signed-off-b

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Be less aggressive about changing link config on eDP (rev3)

2017-08-22 Thread Patchwork
== Series Details == Series: drm/i915/edp: Be less aggressive about changing link config on eDP (rev3) URL : https://patchwork.freedesktop.org/series/28588/ State : success == Summary == Series 28588v3 drm/i915/edp: Be less aggressive about changing link config on eDP https://patchwork.freed

[Intel-gfx] [CI 1/2] drm-tip: 2017y-08m-22d-16h-09m-30s UTC integration manifest

2017-08-22 Thread Chris Wilson
--- integration-manifest | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 integration-manifest diff --git a/integration-manifest b/integration-manifest new file mode 100644 index ..7bc477a0f3da --- /dev/null +++ b/integration-manifest @@ -0,0 +1,22 @@

[Intel-gfx] [CI 2/2] drm/i915: Keep a small stash of preallocated WC pages

2017-08-22 Thread Chris Wilson
We use WC pages for coherent writes into the ppGTT on !llc architectures. However, to create a WC page requires a stop_machine(), i.e. is very slow. To compensate we currently keep a per-vm cache of recently freed pages, but we still see the slow startup of new contexts. We can amoritize that cost

[Intel-gfx] [CI] drm/i915: Keep a small stash of preallocated WC pages

2017-08-22 Thread Chris Wilson
We use WC pages for coherent writes into the ppGTT on !llc architectures. However, to create a WC page requires a stop_machine(), i.e. is very slow. To compensate we currently keep a per-vm cache of recently freed pages, but we still see the slow startup of new contexts. We can amoritize that cost

[Intel-gfx] [RFCv3 3/3] drm/i915: Introduce per-platform PPAT configurations

2017-08-22 Thread Zhi Wang
The previous static PPAT configuration for each platform is kept unchanged and now configured through intel_ppat_reserve(). Also the PPAT feature of each platform is described in intel PPAT instance during the initialization and related callbacks which supports the PPAT management framework will be

  1   2   >