On Fri, 13 May 2016, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> DRM_DEBUG_ATOMIC generates a lot of noise that no one normally cares
> about. However error paths everyone cares about, so hiding the error
> debugs under DRM_DEBUG_ATOMIC is a bad idea. Let's use DRM_DEBUG_KMS
> f
On Sat, 14 May 2016, Marius Vlad wrote:
> Introduced by 633ad03c6 (tests: Separate tests with lots of subtests).
fatal: ambiguous argument '633ad03c6': unknown revision or path not in the
working tree.
>
> Signed-off-by: Marius Vlad
> ---
> tests/Makefile.am | 1 +
> 1 file changed, 1 insert
On 13 May 2016 at 03:34, Jani Nikula wrote:
>
> I don't have any FreeBSD experience and I don't know what kind of team
> of developers you have, but it is my educated guess that you'll have
> plenty of more productive things to do than trying to maintain a
> significant amount of delta with upstre
Load specific firmware versions for the DMC instead of using symbolic
links. The currently recommended versions are: SKL 1.26, KBL 1.01 and
BXT 1.07.
Certain DMC versions need workarounds in the driver which forces us to
have a tight dependency between firmware and driver. In order to be able
to p
== Series Details ==
Series: drm/i915/dmc: Step away from symbolic links (rev2)
URL : https://patchwork.freedesktop.org/series/6966/
State : success
== Summary ==
Series 6966v2 drm/i915/dmc: Step away from symbolic links
http://patchwork.freedesktop.org/api/1.0/series/6966/revisions/2/mbox
Te
Introduced by a633ad03c6 (tests: Separate tests with lots of subtests).
v2: Fix commit typo (Jani Nikula).
Signed-off-by: Marius Vlad
---
tests/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 32b9115..c2c2025 100644
--- a/tests/Makefil
Signed-off-by: Marius Vlad
---
assembler/gram.y | 74
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/assembler/gram.y b/assembler/gram.y
index 23e1a57..15b8b64 100644
--- a/assembler/gram.y
+++ b/assembler/gram.y
@@ -509,15
On 13/05/16 16:05, Tvrtko Ursulin wrote:
On 13/05/16 15:47, Jani Nikula wrote:
On Fri, 13 May 2016, Chris Wilson wrote:
On Fri, May 13, 2016 at 03:25:05PM +0100, Tvrtko Ursulin wrote:
On 13/05/16 15:04, Jani Nikula wrote:
This is more robust for assignments and comparisons.
Signed-off-by:
Hi,
On 15/05/16 18:32, Zhi Wang wrote:
Fold vGPU related active check into the inner functions. (Kevin)
Signed-off-by: Zhi Wang
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 11 ---
drivers/gpu/drm/i915/i915_vgpu.c| 10 --
drivers/gpu/drm/i915/i915_vgpu.h| 2 +-
3 fi
Hi,
Just a few comments from a non-assigned reviewer.
On 15/05/16 18:32, Zhi Wang wrote:
This patch introduces the very basic framework of GVT-g device model,
includes basic prototypes, definitions, initialization.
v3:
Take Joonas' comments:
- Change file name i915_gvt.* to intel_gvt.*
- Move
On Mon, 16 May 2016, Patrik Jakobsson wrote:
> Load specific firmware versions for the DMC instead of using symbolic
> links. The currently recommended versions are: SKL 1.26, KBL 1.01 and
> BXT 1.07.
>
> Certain DMC versions need workarounds in the driver which forces us to
> have a tight depende
This fixes invalid path handling under piglit.
/opt/igt/tests/drv_missed_irq_hang: line 14:
/opt/igt/piglit//opt/igt/tests/../benchmarks/gem_blt: No such file or
directory
Signed-off-by: Marius Vlad
---
tests/drv_missed_irq_hang | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff
Prep work for DP branch device handling
This series of patches reads DPCD register 0x80h for receiver
capabilities for DP branch devices. The branch device types are
converters for the following standards
- DP to VGA
- DP to DVI
- DP to HDMI
- DP++ dual mode
- Wireless WiGig
DPCD register
Add missing DisplayPort downstream port types. The introduced
new port types are DP++ and Wireless.
Signed-off-by: Mika Kahola
---
include/drm/drm_dp_helper.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 92d9a52..4049af9 10
Read from DPCD receiver capability field for the
DP to Wireless converter. The only supported wireless
technology on DP1.3 spec is WiGig display extension. If WiGig
display extension is present, then read out the
- number of wde tx on device
- the number of wde txs that can be concurrently activ
Read from DPCD receiver capability field the max allowed
pixel clock and bits per component for DP to VGA converter.
Signed-off-by: Mika Kahola
---
drivers/gpu/drm/drm_dp_helper.c | 46
drivers/gpu/drm/i915/intel_drv.h | 2 ++
include/drm/drm_dp_helper.
Read from DPCD receiver capability field for DP to HDMI
converter. The features for DP to HDMI converter are
- max TMDS characther clock rate
- max bits per component
- support for conversion from 3D frame sequential to frame pack
- support for YCBCR422 pass through
- support for YCBCR420 pas
Prep work to improve DP branch device handling.
Filter out a mode that exceeds the max pixel rate setting
for DP to VGA dongle. This is defined in DPCD register 0x81
if detailed cap info i.e. info field is 4 bytes long and
it is available for DP downstream port.
The register defines the pixel rat
Read from DPCD receiver capability field for the following
features:
- max TMDS clock rate
- max bits per component
- single or dual link support
- high color depth support
Signed-off-by: Mika Kahola
---
drivers/gpu/drm/drm_dp_helper.c | 5 +
include/drm/drm_dp_helper.h | 14 +++
Read from DPCD receiver capability field for the
DP++ devices. The features are
- max TMDS charachter clock
- max bits per component
- support for conversion from 3D frame sequential to
frame pack
Signed-off-by: Mika Kahola
---
drivers/gpu/drm/drm_dp_helper.c | 4
include/drm/drm_dp
On 15/05/16 18:32, Zhi Wang wrote:
Currently ctx->ppgtt would only be initialized when full PPGTT is used.
For aliasing PPGTT mode, ctx->ppgtt will be set when LRC context is
populated.
This patch moves the assignment into i915_gem_create_context() for better
code structure.
Hm, it doesn't mo
From: Robert Foss
Fix issue where the plane counting fails due to the number and
configuration of planes being unlike the intel configuration.
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
in
From: Robert Foss
Added function pipe_id_to_vbl_flag() to igt_kms.
This function formats a pipe_id into the format
expected by DRM while processing DRM_IOCTL_WAIT_VBLANK.
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 16
lib/igt_kms.h | 1 +
2 files changed, 17 insertions(+)
From: Robert Foss
In addition to the changes made in v4, danvet suggested that the argument for
the (newly renamed) helper function kmstest_get_vbl_flag should be changed.
I investigated it and found that all of the places where the helper function
currently is used, would require more of a rewo
From: Robert Foss
Previously crtc0 was statically used for VBLANK tests, but
that assumption is not valid for the VC4 platform.
Instead we're now explicitly setting the mode.
Also add support for testing all connected connectors during
the same test.
Signed-off-by: Robert Foss
---
tests/kms_v
From: Robert Foss
Increase the number of planes supported to 10.
kmstest_plane_name only previously supported 4 planes,
this patch adds support for up to 10 planes.
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 6 ++
lib/igt_kms.h | 8 +++-
2 files changed, 13 insertions(+), 1 deleti
From: Robert Foss
Change __wait_for_vblank() to use kmstest_get_vbl_flag() helper function.
Signed-off-by: Robert Foss
---
tests/kms_flip.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index eda2fcc..0ecca07 100644
--- a/tests/
== Series Details ==
Series: drm/i915: DP branch devices (rev2)
URL : https://patchwork.freedesktop.org/series/6658/
State : failure
== Summary ==
Series 6658v2 drm/i915: DP branch devices
http://patchwork.freedesktop.org/api/1.0/series/6658/revisions/2/mbox
Test drv_module_reload_basic:
From: Robert Foss
Change igt_wait_for_vblank() to use kmstest_get_vbl_flag() helper function.
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 5ef73c8..bc022c8 100644
--- a/lib/igt_kms.c
+
On 15/05/16 18:32, Zhi Wang wrote:
Previously the addressing mode bit in context descriptor is generated from
context PPGTT. As we allow context could be used without PPGTT, and we
still need to know the addressing mode during context submission, a flag
is introduced.
And the addressing mode bi
From: Robert Foss
Switch igt_assert to igt_assert_lte to provide more diagnostic
information.
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 876f65c..9af9603 100644
--- a/lib/igt_kms.c
+++ b/l
Thanks for the comments. :)
-Original Message-
From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com]
Sent: Monday, May 16, 2016 3:50 AM
To: Wang, Zhi A ; intel-gfx@lists.freedesktop.org;
Gordon, David S ; joonas.lahti...@linux.intel.com;
Tian, Kevin ; Lv, Zhiyuan
Subject: Re: [I
From: Ville Syrjälä
Like with cdclk, the DMC is supposed to manage dbuf enabling/disabling.
Let's make sure it has correctly restored the dbuf state to enabled
when we disable the DC states.
Cc: Imre Deak
Suggested-by: Imre Deak
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_run
On 15/05/16 18:32, Zhi Wang wrote:
This patch introduces an approach to track the execlist context status
change.
GVT-g uses GVT context as the "shadow context". The content inside GVT
context will be copied back to guest after the context is idle. So GVT-g
has to know the status of the execlis
On 06/05/2016 13:18, Gordon, David S wrote:
On 06/05/16 10:37, Nick Hoath wrote:
On 05/05/2016 16:04, Dave Gordon wrote:
On 05/05/2016 15:02, Antoine, Peter wrote:
The attached version still does not explain that the WOPCM_TOP is to
tell the GuC not to use that space.
That's NOT what WOPCM_T
Looks like I can drop this patch without harm. As I will load the root pointer
myself. And there is patch to check if ppgtt == something then populate PDPs,
so under FULL_PPGTT && !NO_PPGTT_CTX it won't load anything. Under !FULL_PPGTT
&& !NO_PPGTT_CTX, it will load aliasing_ppgtt_mm, but then I
-Original Message-
From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com]
Sent: Monday, May 16, 2016 7:00 AM
To: Wang, Zhi A ; intel-gfx@lists.freedesktop.org;
Gordon, David S ; joonas.lahti...@linux.intel.com;
Tian, Kevin ; Lv, Zhiyuan
Subject: Re: [Intel-gfx] [PATCH 11/15] drm
I understand what you say. Let me think about other approach. My requirement is
to do nothing if a context doesn't have a ppgtt, but ctx->ppgtt == NULL means
context is using aliasing ppgtt, so I need to find another way to achieve this.
-Original Message-
From: Tvrtko Ursulin [mailto:t
On Mon, May 16, 2016 at 01:32:52AM +0800, Zhi Wang wrote:
> Factor out and expose fence stealing functionality for GVT-g. GVT-g
> will use i915_find_fence_reg() to find a free/unpin fence register
> and use i915_steal_fence() to steal it.
No. This code cannot be exported as is (the code makes pres
Trivial. Pushed.
On Mon, May 16, 2016 at 01:36:48PM +0300, Marius Vlad wrote:
> Introduced by a633ad03c6 (tests: Separate tests with lots of subtests).
>
> v2: Fix commit typo (Jani Nikula).
>
> Signed-off-by: Marius Vlad
> ---
> tests/Makefile.am | 1 +
> 1 file changed, 1 insertion(+)
>
> d
In sequence block v3 these are gracefully skipped anyway, but add the
functions so we can have some debug breadcrumbs.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dsi_pa
This is not interesting. They are not "missing", they are just not part
of the VBT sequences for the panel.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
Run the power/backlight on/off sequences, log about not running tear
on/off sequences, add a consistency check, and improve the debug
logging.
BR,
Jani.
Jani Nikula (7):
drm/i915/dsi: don't debug log "missing" sequences
drm/i915/dsi: add debug logging to element execution
drm/i915/dsi: add
Just simple breadcrumbs for now. While at it, rename the i2c skip
function.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
b/drivers/gpu/drm/i9
Based on the documentation alone, it's anyone's guess when exactly we
should be running these sequences. Add them where it feels logical. The
drm panel hooks don't currently offer us more granularity anyway.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 ++
1 file
Leave behind some debugging clues in case some panels don't work
properly.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_bios.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_bios.c
b/drivers/gpu/drm/i915/intel_bios.c
index 8b68c4882fba..8cab24bb5
Be a little paranoid in case the specs change or something.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
index d078c57
I see. How about merging this function into i915_find_fence_reg()?
-Original Message-
From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
Sent: Monday, May 16, 2016 7:58 AM
To: Wang, Zhi A
Cc: intel-gfx@lists.freedesktop.org; Gordon, David S
; joonas.lahti...@linux.intel.com; Tian, Kev
On Mon, May 16, 2016 at 01:32:44AM +0800, Zhi Wang wrote:
> GVT context will use its own shadow PPGTT, and it doesn't need a
> i915_hw_ppgtt.
>
> This patch adds a "has_ppgtt" param to i915_gem_context(), which
> allows the caller to create a context without PPGTT
>
> Signed-off-by: Zhi Wang
> -
Based on the documentation alone, it's anyone's guess when exactly we
should be running these sequences. Add them where it feels logical. The
drm panel hooks don't currently offer us more granularity anyway.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 ++
1 file
Yes. Thanks! Seems there is an assumption if ctx->ppgtt == NULL then go back to
use aliasing ppgtt. I see. I will drop that patch, without that patch we could
also work
-Original Message-
From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
Sent: Monday, May 16, 2016 8:13 AM
To: Wang, Z
The recently-added i915_gem_object_pin_map() can be further optimised
for "small" objects. To facilitate this, and simplify the error paths
before adding the new code, this patch pulls out the "mapping" part of
the operation (involving local allocations which must be undone before
return) into its
We're using this function for ringbuffers and other "small" objects, so
it's worth avoiding an extra malloc()/free() cycle if the page array is
small enough to put on the stack. Here we've chosen an arbitrary cutoff
of 32 (4k) pages, which is big enough for a ringbuffer (4 pages) or a
context image
The existing for_each_sg_page() iterator is somewhat heavyweight, and is
limiting i915 driver performance in a few benchmarks. So here we
introduce somewhat lighter weight iterators, primarily for use with GEM
objects or other case where we need only deal with whole aligned pages.
Unlike the old i
On Mon, 16 May 2016, Dave Gordon wrote:
> On 13/05/16 16:05, Tvrtko Ursulin wrote:
>>
>> On 13/05/16 15:47, Jani Nikula wrote:
>>> On Fri, 13 May 2016, Chris Wilson wrote:
On Fri, May 13, 2016 at 03:25:05PM +0100, Tvrtko Ursulin wrote:
>
> On 13/05/16 15:04, Jani Nikula wrote:
>>
== Series Details ==
Series: drm/i915/dsi: sequence execution tweaks
URL : https://patchwork.freedesktop.org/series/7234/
State : failure
== Summary ==
Series 7234v1 drm/i915/dsi: sequence execution tweaks
http://patchwork.freedesktop.org/api/1.0/series/7234/revisions/1/mbox
Test kms_flip:
== Series Details ==
Series: series starting with [1/3] drm/i915: refactor i915_gem_object_pin_map()
URL : https://patchwork.freedesktop.org/series/7237/
State : failure
== Summary ==
Series 7237v1 Series without cover letter
http://patchwork.freedesktop.org/api/1.0/series/7237/revisions/1/mbo
On 13/05/16 16:31, Tvrtko Ursulin wrote:
On 13/05/16 15:36, Dave Gordon wrote:
Split the function of "enable_guc_submission" into two separate
options. The new one ("enable_guc_loading") controls only the
*fetching and loading* of the GuC firmware image. The existing
one is redefined to contro
Split the function of "enable_guc_submission" into two separate
options. The new one ("enable_guc_loading") controls only the
*fetching and loading* of the GuC firmware image. The existing
one is redefined to control only the *use* of the GuC for batch
submission once the firmware is loaded.
In a
Hi Chris,
On 9 May 2016 at 11:04, Chris Wilson wrote:
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -607,12 +606,8 @@ drm_gem_object_lookup(struct drm_device *dev, struct
> drm_file *filp,
>
> /* Check if we currently have a reference on the object */
>
These patches from Mahesh address places where our SKL-style watermark
programming does not match the current bspec rules, either because the bspec
was updated after the original code was written, or because new display
features (e.g., plane scaling) were added without corresponding updates to the
From: "Kumar, Mahesh"
don't always use 8 ddb as minimum, instead calculate using proper
algorithm.
v2: optimizations as per Matt's comments.
v3 (by Matt):
- Fix boolean logic for !fb test in skl_ddb_min_alloc()
- Adjust negative tiling format comparisons in skl_ddb_min_alloc() to
improve r
From: "Kumar, Mahesh"
Don't use pipe pixel rate for plane pixel rate. Calculate plane pixel according
to formula
adjusted plane_pixel_rate = adjusted pipe_pixel_rate * downscale ammount
downscale amount = max[1, src_h/dst_h] * max[1, src_w/dst_w]
if 90/270 rotation use rotated width & height
v
We don't actually read out full plane state during driver startup (only
whether the primary plane is enabled/disabled), so all of the src/dest
rectangles are invalid at this point. However this calculation was
needless anyway since we re-calculate them from scratch on the very
first atomic transac
From: "Kumar, Mahesh"
if downscaling is enabled plane data rate increases according to scaling
amount. take scaling amount under consideration while calculating plane
data rate
v2: Address Matt's comments, where data rate was overridden because of
missing else.
v3 (by Matt):
- Add braces to 'e
This is the userspace component of the Displayport Compliance
testing software required for compliance testing of the I915
Display Port driver. This must be running in order to successfully
complete Display Port compliance testing. This app and the kernel
code that accompanies it has been written t
-Original Message-
From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com]
Sent: Monday, May 16, 2016 5:03 AM
To: Wang, Zhi A ; intel-gfx@lists.freedesktop.org;
Gordon, David S ; joonas.lahti...@linux.intel.com;
Tian, Kevin ; Lv, Zhiyuan
Subject: Re: [Intel-gfx] [PATCH 03/15] drm
== Series Details ==
Series: Enable GuC submission (rev2)
URL : https://patchwork.freedesktop.org/series/7153/
State : failure
== Summary ==
Series 7153v2 Enable GuC submission
http://patchwork.freedesktop.org/api/1.0/series/7153/revisions/2/mbox
Test drv_module_reload_basic:
== Series Details ==
Series: SKL watermark algorithm updates
URL : https://patchwork.freedesktop.org/series/7262/
State : warning
== Summary ==
Series 7262v1 SKL watermark algorithm updates
http://patchwork.freedesktop.org/api/1.0/series/7262/revisions/1/mbox
Test drv_hangman:
Subgrou
On Mon, May 16, 2016 at 04:19:33PM +0300, Mika Kahola wrote:
> Prep work to improve DP branch device handling.
>
> Filter out a mode that exceeds the max pixel rate setting
> for DP to VGA dongle. This is defined in DPCD register 0x81
> if detailed cap info i.e. info field is 4 bytes long and
> it
On Mon, May 16, 2016 at 11:15:09PM +0100, Emil Velikov wrote:
> Hi Chris,
>
> On 9 May 2016 at 11:04, Chris Wilson wrote:
>
> > --- a/drivers/gpu/drm/drm_gem.c
> > +++ b/drivers/gpu/drm/drm_gem.c
>
> > @@ -607,12 +606,8 @@ drm_gem_object_lookup(struct drm_device *dev, struct
> > drm_file *filp
71 matches
Mail list logo
