Re: [Intel-gfx] [PATCH] drm/i915: HWSTAM is not a thing on SKL+

2015-12-18 Thread Mika Kuoppala
Ben Widawsky writes: > Compile tested only. > > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/intel_lrc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_lrc.c > b/drivers/gpu/drm/i915/intel_lrc.c > index 42a7be1..a9bc207 100644

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add helpers to reduce (repetitive) noise

2015-12-18 Thread Joonas Lahtinen
On to, 2015-12-17 at 21:10 +, Chris Wilson wrote: > On Thu, Dec 17, 2015 at 09:25:50PM +0200, Joonas Lahtinen wrote: > > Add helpers to reduce the amount of noise. Use the i915.debug > > parameter > > introduced in the previous patch to decide on whether to display > > all > > debug messages or

[Intel-gfx] ✗ warning: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == Built on ac2305b6c91b9a84cc12566016ece257c3ebcba3 drm-intel-nightly: 2015y-12m-17d-16h-19m-23s UTC integration manifest Test igt@kms_flip@basic-flip-vs-wf_vblank on bsw-nuc-2 pass -> dmesg-warn Test igt@kms_flip@basic-flip-vs-wf_vblank on skl-i7k-2 dmesg-fail -> dmesg-warn Test igt

[Intel-gfx] ✗ failure: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == HEAD is now at ac2305b drm-intel-nightly: 2015y-12m-17d-16h-19m-23s UTC integration manifest Applying: drm/i915: HWSTAM is not a thing on SKL+ Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 drm/i915: HWSTAM is

Re: [Intel-gfx] [PATCH v4] drm/i915: Disable fast link training if DP config changes

2015-12-18 Thread Mika Kahola
On Thu, 2015-12-17 at 15:16 +0200, Ville Syrjälä wrote: > On Thu, Dec 17, 2015 at 02:46:03PM +0200, Mika Kahola wrote: > > Disable DP fast link training if DP link configuration > > changes. If one of the DP link parameters i.e. link > > bandwidth, lane count, rate selection, port clock or bpp > >

[Intel-gfx] [PATCH] drm/i915/backlight: prefer dev_priv over dev pointer

2015-12-18 Thread Jani Nikula
Use dev_priv rather than dev pointer where applicable. Remove plenty of unnecessary temp variables. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_panel.c | 156 ++--- 1 file changed, 58 insertions(+), 98 deletions(-) diff --git

[Intel-gfx] ✗ failure: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == HEAD is now at ac2305b drm-intel-nightly: 2015y-12m-17d-16h-19m-23s UTC integration manifest Applying: drm/i915: edp resume/On time optimization. Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 drm/i915: edp res

Re: [Intel-gfx] [PATCH] drm/i915/backlight: prefer dev_priv over dev pointer

2015-12-18 Thread Mika Kuoppala
Jani Nikula writes: > Use dev_priv rather than dev pointer where applicable. Remove plenty of > unnecessary temp variables. No functional changes. > > Signed-off-by: Jani Nikula Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/intel_panel.c | 156 > ++-

Re: [Intel-gfx] [PATCH] drm/i915/backlight: prefer dev_priv over dev pointer

2015-12-18 Thread Chris Wilson
On Fri, Dec 18, 2015 at 10:51:35AM +0200, Jani Nikula wrote: > Use dev_priv rather than dev pointer where applicable. Remove plenty of > unnecessary temp variables. No functional changes. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_panel.c | 156 > ++---

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Decouple struct i915_params i915 into i915_params.h

2015-12-18 Thread Chris Wilson
On Thu, Dec 17, 2015 at 08:59:42PM +, Chris Wilson wrote: > On Thu, Dec 17, 2015 at 09:25:47PM +0200, Joonas Lahtinen wrote: > > +#ifndef _I915_PARAMS_H_ > > +#define _I915_PARAMS_H_ > > + > Is it worth saying > > #include /* for __read_mostly */ > > or am I alone in not knowing that? Anywa

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Compile time concatenate WARN_ON macro strings

2015-12-18 Thread Chris Wilson
On Thu, Dec 17, 2015 at 09:25:46PM +0200, Joonas Lahtinen wrote: > Using __stringify(x) instead of #x adds support for macros as > a parameter and reduces runtime overhead. > > Slightly increases the .text size but should not matter. > > Cc: Rob Clark > Acked-by: Daniel Vetter > Signed-off-by:

[Intel-gfx] [PATCH i-g-t] tests/kms_color:Color i-g-t

2015-12-18 Thread Dhanya Pillai
From: Dhanya This patch will verify color correction capability of a display driver. Gamma/CSC/De-gamma for SKL/BXT supported. Signed-off-by: Dhanya --- tests/.gitignore | 1 + tests/Makefile.sources | 1 + tests/kms_color.c | 999

Re: [Intel-gfx] [PATCH] drm/i915/backlight: prefer dev_priv over dev pointer

2015-12-18 Thread Jani Nikula
On Fri, 18 Dec 2015, Mika Kuoppala wrote: > Jani Nikula writes: > >> Use dev_priv rather than dev pointer where applicable. Remove plenty of >> unnecessary temp variables. No functional changes. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Mika Kuoppala Pushed to drm-intel-next-queued, th

[Intel-gfx] ✗ warning: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == Built on ac2305b6c91b9a84cc12566016ece257c3ebcba3 drm-intel-nightly: 2015y-12m-17d-16h-19m-23s UTC integration manifest Test igt@kms_flip@basic-flip-vs-wf_vblank on byt-nuc dmesg-warn -> skip Test igt@kms_flip@basic-flip-vs-wf_vblank on skl-i7k-2 dmesg-fail -> dmesg-warn Test igt@k

Re: [Intel-gfx] [PATCH] drm/i915/backlight: prefer dev_priv over dev pointer

2015-12-18 Thread Jani Nikula
On Fri, 18 Dec 2015, Chris Wilson wrote: > On Fri, Dec 18, 2015 at 10:51:35AM +0200, Jani Nikula wrote: >> Use dev_priv rather than dev pointer where applicable. Remove plenty of >> unnecessary temp variables. No functional changes. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i91

[Intel-gfx] [PATCH i-g-t] tests/kms_color:Color i-g-t

2015-12-18 Thread Dhanya Pillai
From: Dhanya This patch will verify color correction capability of a display driver. Gamma/CSC/De-gamma for SKL/BXT supported. Signed-off-by: Dhanya --- tests/.gitignore | 1 + tests/Makefile.sources | 1 + tests/kms_color.c | 997

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix a warning message problem during driver unload

2015-12-18 Thread Jani Nikula
On Thu, 17 Dec 2015, yu@intel.com wrote: > From: Alex Dai > > The device struct_mutex needs to be held before releasing any GEM > objects allocated by GuC. This is indeed so, but your patch subject needs to say it fixes an actual bug rather than a "warning message problem" which makes one thi

Re: [Intel-gfx] [PATCH] [v2] drm/i915: Limit VF cache invalidate workaround usage to gen9

2015-12-18 Thread Jani Nikula
On Thu, 17 Dec 2015, Imre Deak wrote: > On Thu, 2015-12-17 at 09:49 -0800, Ben Widawsky wrote: >> +> if (IS_GEN9(ring->dev)) > > Nitpick: INTEL_INFO()->gen == 9 is the preferred way. Oh? Since when and says who? BR, Jani. -- Jani Nikula, Intel Open Source Technology Center ___

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Add i915.debug parameter

2015-12-18 Thread Joonas Lahtinen
On to, 2015-12-17 at 21:02 +, Chris Wilson wrote: > On Thu, Dec 17, 2015 at 09:25:49PM +0200, Joonas Lahtinen wrote: > > Add i915.debug parameter to control output in cases where the debug > > output > > amount will be massive and as such is unsuitable for everyday use, > > but still > > signif

Re: [Intel-gfx] [PATCH] drm/i915/skl: Increase ddb blocks to support large cursor sizes

2015-12-18 Thread Jani Nikula
On Thu, 17 Dec 2015, Radhakrishna Sripada wrote: > Original value of 32 blocks is not sufficient when using cursor size of > 256x256 causing FIFO underruns when the reworked wm > caluclations in > > commit 024c9045221fe45482863c47c4b4c47d37f97cbf > Author: Matt Roper > Date: Thu Sep 24 15:53:1

[Intel-gfx] [PATCH] drm/i915: Slaughter the thundering i915_wait_request herd

2015-12-18 Thread Chris Wilson
One particularly stressful scenario consists of many independent tasks all competing for GPU time and waiting upon the results (e.g. realtime transcoding of many, many streams). One bottleneck in particular is that each client waits on its own results, but every client is woken up after every batch

Re: [Intel-gfx] [PATCH] dim: Add support for native git worktrees

2015-12-18 Thread Jani Nikula
On Thu, 17 Dec 2015, Daniel Vetter wrote: > git 2.5 gained native support for worktrees, so let's use them. > > Since this is fairly new I don't think we should switch the general > dim setup over to using it (for e.g. the maintainer-tools and other > auxiliary branches) since 2.5 was only release

[Intel-gfx] [PATCH] drm/i915/vlv: Modifying RC6 Promotion timer for Media workloads.

2015-12-18 Thread Namrta Salonie
In normal cases, RC6 promotion timer is 1700us. This will result in more time spent in C1 state. For more residency in C6 in case of media workloads, this is changed to 250us. Not doing this for 3D workloads as too many C6-C0 transition delays can result in performance impact. Tracking the media wo

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Modifying RC6 Promotion timer for Media workloads.

2015-12-18 Thread Chris Wilson
On Fri, Dec 18, 2015 at 03:44:36PM +0530, Namrta Salonie wrote: > In normal cases, RC6 promotion timer is 1700us. This will result in more > time spent in C1 state. For more residency in C6 in case of media workloads, > this is changed to 250us. Not doing this for 3D workloads as too many C6-C0 > t

[Intel-gfx] ✗ failure: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == HEAD is now at 3c71db8 drm-intel-nightly: 2015y-12m-18d-09h-42m-49s UTC integration manifest Applying: drm/i915/vlv: Modifying RC6 Promotion timer for Media workloads. Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at

Re: [Intel-gfx] [PATCH] drm/i915: don't enable autosuspend on platforms without RPM support

2015-12-18 Thread David Weinehall
On Thu, Dec 17, 2015 at 07:04:33PM +0200, Imre Deak wrote: > Since > > commit 357597e51dd1aa3cf764d322abf89217e3dcd7bb > Author: Imre Deak > Date: Tue Nov 10 06:12:22 2015 +0200 > > drm/i915: remove HAS_RUNTIME_PM check from RPM get/put/assert helpers > > this file is writeable also on pl

Re: [Intel-gfx] [PATCH] [v2] drm/i915: Limit VF cache invalidate workaround usage to gen9

2015-12-18 Thread Imre Deak
On pe, 2015-12-18 at 11:59 +0200, Jani Nikula wrote: > On Thu, 17 Dec 2015, Imre Deak wrote: > > On Thu, 2015-12-17 at 09:49 -0800, Ben Widawsky wrote: > > > +>  if (IS_GEN9(ring->dev)) > > > > Nitpick: INTEL_INFO()->gen == 9 is the preferred way. > > Oh? Since when and says who?

Re: [Intel-gfx] [PATCH] drm/i915/skl: Increase ddb blocks to support large cursor sizes

2015-12-18 Thread Ville Syrjälä
On Wed, Dec 16, 2015 at 07:06:20PM -0800, Radhakrishna Sripada wrote: > Original value of 32 blocks is not sufficient when using cursor size of > 256x256 causing FIFO underruns when the reworked wm > caluclations in > > commit 024c9045221fe45482863c47c4b4c47d37f97cbf > Author: Matt Roper > Date:

[Intel-gfx] [PATCH 2/2] drm/i915: Compile time concatenate WARN_ON macro strings

2015-12-18 Thread Joonas Lahtinen
Using __stringify(x) instead of #x adds support for macros as a parameter and reduces runtime overhead. Slightly increases the .text size but should not matter. v2: - Define I915_STATE_WARN_ON though I915_STATE_WARN (Bikeshed inspiration by Chris) Cc: Rob Clark Cc: Chris Wilson Acked-by: Dan

[Intel-gfx] [PATCH 1/2] drm/i915: Simplify _STATE_ debug macros

2015-12-18 Thread Joonas Lahtinen
Take advantage of WARN return value to simplify the flow. Cc: Rob Clark Cc: Chris Wilson Reported-by: Chris Wilson Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_

[Intel-gfx] [PATCH 0/2] Optimize WARN_ON macros

2015-12-18 Thread Joonas Lahtinen
Joonas Lahtinen (2): drm/i915: Simplify _STATE_ debug macros drm/i915: Compile time concatenate WARN_ON macro strings drivers/gpu/drm/i915/i915_drv.h | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) -- 2.4.3 ___ Inte

[Intel-gfx] [PATCH] drm/i915/bdw+: Replace list_del+list_add_tail with list_move_tail

2015-12-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Same effect for slightly less source code and resulting binary. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_lrc.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) Compile tested only! diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/d

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Compile time concatenate WARN_ON macro strings

2015-12-18 Thread Chris Wilson
On Fri, Dec 18, 2015 at 12:39:17PM +0200, Joonas Lahtinen wrote: > Using __stringify(x) instead of #x adds support for macros as > a parameter and reduces runtime overhead. > > Slightly increases the .text size but should not matter. > > v2: > - Define I915_STATE_WARN_ON though I915_STATE_WARN >

[Intel-gfx] [PATCH v2 4/4] drm/i915: Use WARN_RECUR for recurring warning messages

2015-12-18 Thread Joonas Lahtinen
Avoid flooding end users kernel log with warnings and mark recurring warnings as such. This is a case when multiple code paths trigger a warning and only displaying it once masks multiple errors in CI but displaying it each time would make end user system log overflow easily. v2: - Rebase for new

[Intel-gfx] [PATCH v2 0/4] Optionally display recurring warning messages

2015-12-18 Thread Joonas Lahtinen
Wakeref series introduced multiple WARN_ONCE clauses which might be triggered from several sources (hangcheck or cache flusing for example), this series adds an i915.recur_warnings option and WARN_RECUR macro. The WARN_ONCE calls are converted into WARN_RECUR which always WARNs if recur_warnings o

[Intel-gfx] [PATCH v2 3/4] drm/i915: Add WARN_RECUR and i915.recur_warnings

2015-12-18 Thread Joonas Lahtinen
Add i915.recur_warnings parameter to control output in cases where the warning is of recurring type and is potentially called from multiple paths. Using just WARN_ONCE would mask out other calling paths but one, this is not desireable on developer machine or CI system, but is a compromise to be mad

[Intel-gfx] [PATCH v2 1/4] drm/i915: Decouple struct i915_params i915 into i915_params.h

2015-12-18 Thread Joonas Lahtinen
Otherwise usage in the i915 debug macros yields problems due to i915_drv.h <-> i915_trace.h <-> intel_drv.h include loops. v2: - Document not-so-obvious need for linux/cache.h (Chris) Reviewed-by: Chris Wilson Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h| 40 ++---

[Intel-gfx] [PATCH v2 2/4] drm/i915: Reorder i915_params struct.

2015-12-18 Thread Joonas Lahtinen
Move all the bool variables to the end as per the comment. Reviewed-by: Chris Wilson Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_params.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_

[Intel-gfx] [PATCH v2 2/2] drm/i915: Compile-time concatenate WARN_ON macro strings

2015-12-18 Thread Joonas Lahtinen
Using __stringify(x) instead of #x adds support for macros as a parameter and compile-time concatenation reduces the runtime overhead. Slightly increases the .text size but should not matter. v2: - Define I915_STATE_WARN_ON though I915_STATE_WARN (Bikeshed inspiration by Chris) v3: - More spec

[Intel-gfx] [PATCH v2 0/2] Optimize WARN_ON macros

2015-12-18 Thread Joonas Lahtinen
Joonas Lahtinen (2): drm/i915: Simplify _STATE_ debug macros drm/i915: Compile-time concatenate WARN_ON macro strings drivers/gpu/drm/i915/i915_drv.h | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) -- 2.4.3 ___ Inte

[Intel-gfx] [PATCH v2 1/2] drm/i915: Simplify _STATE_ debug macros

2015-12-18 Thread Joonas Lahtinen
Take advantage of WARN return value to simplify the flow. Cc: Rob Clark Reviewed-by: Chris Wilson Reported-by: Chris Wilson Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i

[Intel-gfx] ✗ warning: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == Built on 3c71db89fc37b6061ce6b070ce73f89155da5f20 drm-intel-nightly: 2015y-12m-18d-09h-42m-49s UTC integration manifest Test igt@kms_flip@basic-flip-vs-wf_vblank on ivb-t430s pass -> dmesg-warn Test igt@kms_flip@basic-flip-vs-wf_vblank on byt-nuc dmesg-warn -> skip Test igt@kms_fli

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Add WARN_RECUR and i915.recur_warnings

2015-12-18 Thread Chris Wilson
On Fri, Dec 18, 2015 at 01:08:17PM +0200, Joonas Lahtinen wrote: > Add i915.recur_warnings parameter to control output in cases where the warning > is of recurring type and is potentially called from multiple paths. Using just > WARN_ONCE would mask out other calling paths but one, this is not desi

[Intel-gfx] ✗ failure: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == Built on 3c71db89fc37b6061ce6b070ce73f89155da5f20 drm-intel-nightly: 2015y-12m-18d-09h-42m-49s UTC integration manifest Test igt@kms_flip@basic-flip-vs-wf_vblank on ivb-t430s pass -> dmesg-warn Test igt@kms_flip@basic-flip-vs-wf_vblank on byt-nuc dmesg-warn -> pass Test igt@kms_pip

[Intel-gfx] [RFC] drm/i915/bdw+: Do not emit user interrupts when not needed

2015-12-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We can rely on context complete interrupt to wake up the waiters apart in the case where requests are merged into a single ELSP submission. In this case we inject MI_USER_INTERRUPTS in the ring buffer to ensure prompt wake-ups. This optimization has the effect on for example

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Compile time concatenate WARN_ON macro strings

2015-12-18 Thread Dave Gordon
On 18/12/15 10:39, Joonas Lahtinen wrote: Using __stringify(x) instead of #x adds support for macros as a parameter and reduces runtime overhead. Slightly increases the .text size but should not matter. v2: - Define I915_STATE_WARN_ON though I915_STATE_WARN (Bikeshed inspiration by Chris) C

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Compile time concatenate WARN_ON macro strings

2015-12-18 Thread Joonas Lahtinen
On pe, 2015-12-18 at 12:03 +, Dave Gordon wrote: > On 18/12/15 10:39, Joonas Lahtinen wrote: > > Using __stringify(x) instead of #x adds support for macros as > > a parameter and reduces runtime overhead. > > > > Slightly increases the .text size but should not matter. > > > > v2: > > - Defin

[Intel-gfx] ✗ warning: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == Built on 3c71db89fc37b6061ce6b070ce73f89155da5f20 drm-intel-nightly: 2015y-12m-18d-09h-42m-49s UTC integration manifest Test igt@kms_flip@basic-flip-vs-wf_vblank on ivb-t430s pass -> dmesg-warn Test igt@kms_flip@basic-flip-vs-wf_vblank on bsw-nuc-2 pass -> dmesg-warn Test igt@kms_p

[Intel-gfx] [PATCH v3 0/2] Optimize WARN_ON macros

2015-12-18 Thread Joonas Lahtinen
v3: - Fixed potential OOPS scenario with modulo in condition (Dave Gordon) Joonas Lahtinen (2): drm/i915: Simplify _STATE_ debug macros drm/i915: Compile-time concatenate WARN_ON macro strings drivers/gpu/drm/i915/i915_drv.h | 23 ++- 1 file changed, 6 insertions(+), 17

[Intel-gfx] [PATCH v3 1/2] drm/i915: Simplify _STATE_ debug macros

2015-12-18 Thread Joonas Lahtinen
Take advantage of WARN return value to simplify the flow. Cc: Rob Clark Reviewed-by: Chris Wilson Reported-by: Chris Wilson Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i

[Intel-gfx] [PATCH v3 2/2] drm/i915: Compile-time concatenate WARN_ON macro strings

2015-12-18 Thread Joonas Lahtinen
Using __stringify(x) instead of #x adds support for macros as a parameter and compile-time concatenation reduces the runtime overhead. Slightly increases the .text size but should not matter. v2: - Define I915_STATE_WARN_ON though I915_STATE_WARN (Bikeshed inspiration by Chris) v3: - More spec

Re: [Intel-gfx] [RFC] drm/i915/bdw+: Do not emit user interrupts when not needed

2015-12-18 Thread Chris Wilson
On Fri, Dec 18, 2015 at 11:59:41AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > We can rely on context complete interrupt to wake up the waiters > apart in the case where requests are merged into a single ELSP > submission. In this case we inject MI_USER_INTERRUPTS in the > ring buffer

[Intel-gfx] ✗ failure: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == HEAD is now at 3c71db8 drm-intel-nightly: 2015y-12m-18d-09h-42m-49s UTC integration manifest Applying: drm/i915/bdw+: Do not emit user interrupts when not needed Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/intel_lrc.c Falling back to patching base and

Re: [Intel-gfx] [RFC] drm/i915/bdw+: Do not emit user interrupts when not needed

2015-12-18 Thread Chris Wilson
On Fri, Dec 18, 2015 at 11:59:41AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > We can rely on context complete interrupt to wake up the waiters > apart in the case where requests are merged into a single ELSP > submission. In this case we inject MI_USER_INTERRUPTS in the > ring buffer

[Intel-gfx] ✗ warning: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == Built on 3c71db89fc37b6061ce6b070ce73f89155da5f20 drm-intel-nightly: 2015y-12m-18d-09h-42m-49s UTC integration manifest Test igt@kms_flip@basic-flip-vs-wf_vblank on ivb-t430s pass -> dmesg-warn Test igt@kms_flip@basic-flip-vs-wf_vblank on bsw-nuc-2 pass -> dmesg-warn Test igt@gem_s

Re: [Intel-gfx] [RFC] drm/i915/bdw+: Do not emit user interrupts when not needed

2015-12-18 Thread Tvrtko Ursulin
On 18/12/15 12:28, Chris Wilson wrote: On Fri, Dec 18, 2015 at 11:59:41AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We can rely on context complete interrupt to wake up the waiters apart in the case where requests are merged into a single ELSP submission. In this case we inject MI_USE

Re: [Intel-gfx] [PATCH] drm/i915: don't enable autosuspend on platforms without RPM support

2015-12-18 Thread Imre Deak
On pe, 2015-12-18 at 12:32 +0200, David Weinehall wrote: > On Thu, Dec 17, 2015 at 07:04:33PM +0200, Imre Deak wrote: > > Since > > > > commit 357597e51dd1aa3cf764d322abf89217e3dcd7bb > > Author: Imre Deak > > Date:   Tue Nov 10 06:12:22 2015 +0200 > > > > drm/i915: remove HAS_RUNTIME_PM che

[Intel-gfx] ✗ warning: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == Built on 3c71db89fc37b6061ce6b070ce73f89155da5f20 drm-intel-nightly: 2015y-12m-18d-09h-42m-49s UTC integration manifest Test gem_mmap: Subgroup basic: dmesg-warn -> PASS (byt-nuc) Test gem_mmap_gtt: Subgroup basic-write: dmesg-w

[Intel-gfx] ✗ warning: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == Built on 3c71db89fc37b6061ce6b070ce73f89155da5f20 drm-intel-nightly: 2015y-12m-18d-09h-42m-49s UTC integration manifest Test gem_mmap: Subgroup basic: dmesg-warn -> PASS (byt-nuc) Test gem_mmap_gtt: Subgroup basic-write: dmesg-w

[Intel-gfx] [PATCH] drm/i915/skl: Default to noncoherent access up to F0

2015-12-18 Thread Mika Kuoppala
The workarounds for disabling hdc invalidation and also forcing context to be non coherent, are advised to be used up until rev D0. However as it was found that rev F0, without the WaForceEnableNonCoherent might system hang if the mesa tried to use coherent mode. As these two workarounds are abou

Re: [Intel-gfx] Xorg[9132]: segfault at 0 ip 00007fbc84d6fb0d sp 00007ffca3765610 error 4 in intel_drv.so[7fbc84d4d000+18b000]

2015-12-18 Thread Marc MERLIN
> Looking at dmesg I don't see the stuck pageflip anymore. It looks like the > DDX is simply falling over itself, with now blame to the kernel here. Or > if there is it's a new/different bug. So we need to restart triage and > check whether this was introduced by a ddx or kernel upgrade. > -Daniel

Re: [Intel-gfx] [RFC] drm/i915/bdw+: Do not emit user interrupts when not needed

2015-12-18 Thread Chris Wilson
On Fri, Dec 18, 2015 at 01:51:38PM +, Tvrtko Ursulin wrote: > > On 18/12/15 12:28, Chris Wilson wrote: > >On Fri, Dec 18, 2015 at 11:59:41AM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>We can rely on context complete interrupt to wake up the waiters > >>apart in the case wh

[Intel-gfx] [PATCH v4] drm/i915: Fix context/engine cleanup order

2015-12-18 Thread Nick Hoath
Swap the order of context & engine cleanup, so that it is now contexts, then engines. This allows the context clean up code to do things like confirm that ring->dev->struct_mutex is locked without a NULL pointer dereference. This came about as a result of the 'intel_ring_initialized() must be simpl

Re: [Intel-gfx] [PATCH] drm/i915/skl: Default to noncoherent access up to F0

2015-12-18 Thread Francisco Jerez
Mika Kuoppala writes: > The workarounds for disabling hdc invalidation and also forcing > context to be non coherent, are advised to be used up until rev D0. > > However as it was found that rev F0, without the > WaForceEnableNonCoherent might system hang if the mesa > tried to use coherent mode.

[Intel-gfx] [PATCH v9] drm/i915: Extend LRC pinning to cover GPU context writeback

2015-12-18 Thread Nick Hoath
Use the first retired request on a new context to unpin the old context. This ensures that the hw context remains bound until it has been written back to by the GPU. Now that the context is pinned until later in the request/context lifecycle, it no longer needs to be pinned from context_queue to re

[Intel-gfx] ✗ warning: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == Built on da33ddbb03875d7e1e5f06ac445368f97dcc3488 drm-intel-nightly: 2015y-12m-18d-13h-53m-06s UTC integration manifest Test gem_mmap_gtt: Subgroup basic-write-no-prefault: pass -> DMESG-WARN (bsw-nuc-2) Test kms_flip: Subgroup basic-flip-vs-mo

Re: [Intel-gfx] [PATCH] drm/i915/skl: Increase ddb blocks to support large cursor sizes

2015-12-18 Thread Matt Roper
On Fri, Dec 18, 2015 at 12:35:47PM +0200, Ville Syrjälä wrote: > On Wed, Dec 16, 2015 at 07:06:20PM -0800, Radhakrishna Sripada wrote: > > Original value of 32 blocks is not sufficient when using cursor size of > > 256x256 causing FIFO underruns when the reworked wm > > caluclations in > > > > com

[Intel-gfx] ✗ failure: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == HEAD is now at da33ddb drm-intel-nightly: 2015y-12m-18d-13h-53m-06s UTC integration manifest Applying: drm/i915: Extend LRC pinning to cover GPU context writeback Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001

Re: [Intel-gfx] [PATCH] drm/i915/skl: Increase ddb blocks to support large cursor sizes

2015-12-18 Thread Ville Syrjälä
On Fri, Dec 18, 2015 at 06:58:58AM -0800, Matt Roper wrote: > On Fri, Dec 18, 2015 at 12:35:47PM +0200, Ville Syrjälä wrote: > > On Wed, Dec 16, 2015 at 07:06:20PM -0800, Radhakrishna Sripada wrote: > > > Original value of 32 blocks is not sufficient when using cursor size of > > > 256x256 causing

Re: [Intel-gfx] [PATCH] drm/i915/skl: Increase ddb blocks to support large cursor sizes

2015-12-18 Thread Matt Roper
On Fri, Dec 18, 2015 at 05:10:12PM +0200, Ville Syrjälä wrote: > On Fri, Dec 18, 2015 at 06:58:58AM -0800, Matt Roper wrote: > > On Fri, Dec 18, 2015 at 12:35:47PM +0200, Ville Syrjälä wrote: > > > On Wed, Dec 16, 2015 at 07:06:20PM -0800, Radhakrishna Sripada wrote: > > > > Original value of 32 bl

[Intel-gfx] [PATCH] Allow userspace to set NULL blob on properties

2015-12-18 Thread Lionel Landwerlin
Hi, A couple of people told me I should be able to set a blob property to NULL from user space using a blob id 0. I couldn't get that to work (probably nobody's doing this at the moment). Here is a patch to make that work. Cheers, - Lionel Lionel Landwerlin (1): drm/atomic: allow setting a bl

[Intel-gfx] [PATCH] drm/atomic: allow setting a blob to NULL using id = 0

2015-12-18 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/drm_atomic.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 65f007a..b8c90a4 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm

Re: [Intel-gfx] [PATCH] drm/i915/skl: Increase ddb blocks to support large cursor sizes

2015-12-18 Thread Matt Roper
On Fri, Dec 18, 2015 at 07:14:17AM -0800, Matt Roper wrote: > On Fri, Dec 18, 2015 at 05:10:12PM +0200, Ville Syrjälä wrote: > > On Fri, Dec 18, 2015 at 06:58:58AM -0800, Matt Roper wrote: > > > On Fri, Dec 18, 2015 at 12:35:47PM +0200, Ville Syrjälä wrote: > > > > On Wed, Dec 16, 2015 at 07:06:20P

[Intel-gfx] ✗ failure: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == HEAD is now at da33ddb drm-intel-nightly: 2015y-12m-18d-13h-53m-06s UTC integration manifest Applying: drm/atomic: allow setting a blob to NULL using id = 0 Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 drm/at

Re: [Intel-gfx] [PATCH] drm/i915/skl: Increase ddb blocks to support large cursor sizes

2015-12-18 Thread Ville Syrjälä
On Fri, Dec 18, 2015 at 07:14:17AM -0800, Matt Roper wrote: > On Fri, Dec 18, 2015 at 05:10:12PM +0200, Ville Syrjälä wrote: > > On Fri, Dec 18, 2015 at 06:58:58AM -0800, Matt Roper wrote: > > > On Fri, Dec 18, 2015 at 12:35:47PM +0200, Ville Syrjälä wrote: > > > > On Wed, Dec 16, 2015 at 07:06:20P

Re: [Intel-gfx] [PATCH v4] drm/i915: Disable fast link training if DP config changes

2015-12-18 Thread Ville Syrjälä
On Fri, Dec 18, 2015 at 10:37:26AM +0200, Mika Kahola wrote: > On Thu, 2015-12-17 at 15:16 +0200, Ville Syrjälä wrote: > > On Thu, Dec 17, 2015 at 02:46:03PM +0200, Mika Kahola wrote: > > > Disable DP fast link training if DP link configuration > > > changes. If one of the DP link parameters i.e. l

Re: [Intel-gfx] [PATCH 2/4] drm/i915: mark the global default (intel_)context as such

2015-12-18 Thread Dave Gordon
On 17/12/15 19:00, Dave Gordon wrote: On 17/12/15 12:27, Chris Wilson wrote: On Thu, Dec 17, 2015 at 11:09:54AM +, Nick Hoath wrote: [snip!] If you want to make such a big change, eliminate the default_ctx from execlists. -Chris No, we need the default (or global) context for idling the

[Intel-gfx] i915 Sky Lake graphics problem: screen blank after grub boot

2015-12-18 Thread James Bottomley
With kernel 4.3.x (tested x=2,3) the screen goes blank as soon as the system boots (both for VGA console and graphics). The only way to get it to turn on is to suspend and resume the system. The system is a Dell XPS 13 (latest rev) running OpenSuse Leap 42.1 and this is the lspci output: 00:00.0

Re: [Intel-gfx] [PATCH 03/32] drm/i915: Only spin whilst waiting on the current request

2015-12-18 Thread Daniel Vetter
On Fri, Dec 11, 2015 at 11:32:59AM +, Chris Wilson wrote: > Limit busywaiting only to the request currently being processed by the > GPU. If the request is not currently being processed by the GPU, there > is a very low likelihood of it being completed within the 2 microsecond > spin timeout an

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Simplify _STATE_ debug macros

2015-12-18 Thread Dave Gordon
On 18/12/15 12:27, Joonas Lahtinen wrote: Take advantage of WARN return value to simplify the flow. Cc: Rob Clark Reviewed-by: Chris Wilson Reported-by: Chris Wilson Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h | 15 +-- 1 file changed, 5 insertions(+), 1

Re: [Intel-gfx] [PATCH v3] drm/i915: Avoid writing relocs with addresses in non-canonical form

2015-12-18 Thread Chris Wilson
On Fri, Dec 11, 2015 at 03:13:37PM +0100, Michał Winiarski wrote: > According to bspec, some parts of HW require the addresses to be in > a canonical form, where bits [63:48] == [47]. Let's convert addresses to > canonical form prior to relocating and return converted offsets to > userspace. We als

[Intel-gfx] [PULL] topic/drm-misc

2015-12-18 Thread Daniel Vetter
Hi Dave, Seems I lied in my last drm-misc pull request and suddenly there's a big pile of random stuff. Boris dug out Thierry's drm-trivial branch and resubmitted everything since that branch didn't really work out. On top of that Nicolas' changes to drm_dev_set_unique - this might conflict with

Re: [Intel-gfx] [PATCH 1/6] drm: Create Color Management DRM properties

2015-12-18 Thread Daniel Stone
[Paging danvet to the bottom paragraphs re client-cap ...] Hi Lionel, I've still got quite a few concerns about the implementation as it stands. Some are minor quibbles (e.g. can't unset blob IDs), some are larger design issues, some are rehashed comments from previous series, and some are new now

Re: [Intel-gfx] [PATCH 5/6] drm/i915/bdw+: Implement color management

2015-12-18 Thread Daniel Stone
Hi, On 17 December 2015 at 18:57, Lionel Landwerlin wrote: > @@ -289,22 +289,30 @@ static const struct intel_device_info > intel_haswell_m_info = { > static const struct intel_device_info intel_broadwell_d_info = { > HSW_FEATURES, > .gen = 8, > + .num_samples_after_ctm = B

Re: [Intel-gfx] [PATCH 4/6] drm/i915/chv: Implement color management

2015-12-18 Thread Daniel Stone
Hi, On 17 December 2015 at 18:57, Lionel Landwerlin wrote: > @@ -311,7 +312,9 @@ static const struct intel_device_info > intel_cherryview_info = { > .gen = 8, .num_pipes = 3, > .need_gfx_hws = 1, .has_hotplug = 1, > .ring_mask = RENDER_RING | BSD_RING | BLT_RING | VEBOX_R

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Register color correction capabilities

2015-12-18 Thread Daniel Stone
Hi, On 17 December 2015 at 18:57, Lionel Landwerlin wrote: > void intel_crtc_attach_color_properties(struct drm_crtc *crtc) > { > + struct drm_device *dev = crtc->dev; > + struct drm_mode_config *config = &dev->mode_config; > + struct drm_mode_object *mode_obj = &crtc->base; >

Re: [Intel-gfx] [PATCH] drm/atomic: allow setting a blob to NULL using id = 0

2015-12-18 Thread Daniel Stone
On 18 December 2015 at 15:17, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > drivers/gpu/drm/drm_atomic.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index 65f007a..b8c90a

Re: [Intel-gfx] [PATCH] Allow userspace to set NULL blob on properties

2015-12-18 Thread Daniel Stone
Hi, On 18 December 2015 at 15:17, Lionel Landwerlin wrote: > A couple of people told me I should be able to set a blob property to > NULL from user space using a blob id 0. I couldn't get that to work > (probably nobody's doing this at the moment). Here is a patch to make > that work. You can't

Re: [Intel-gfx] [PATCH] drm/i915/backlight: prefer dev_priv over dev pointer

2015-12-18 Thread Dave Gordon
On 18/12/15 09:49, Jani Nikula wrote: On Fri, 18 Dec 2015, Chris Wilson wrote: On Fri, Dec 18, 2015 at 10:51:35AM +0200, Jani Nikula wrote: Use dev_priv rather than dev pointer where applicable. Remove plenty of unnecessary temp variables. No functional changes. Signed-off-by: Jani Nikula --

[Intel-gfx] [PATCH] drm/i915: Workaround CHV pipe C cursor fail

2015-12-18 Thread ville . syrjala
From: Ville Syrjälä Turns out CHV pipe C was glued on somewhat poorly, and there's something wrong with the cursor. If the cursor straddles the left screen edge, and is then moved away from the edge or disabled, the pipe will often underrun. If enough underruns are triggered quickly enough the pi

[Intel-gfx] [PATCH i-g-t 1/6] lib: Make 'extra_long_opts' const

2015-12-18 Thread ville . syrjala
From: Ville Syrjälä The extra_long_opts passed to igt_*_parse_opts() isn't modified, so let's make it const. Signed-off-by: Ville Syrjälä --- lib/igt_core.c | 6 +++--- lib/igt_core.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index

[Intel-gfx] [PATCH i-g-t 3/6] lib: Use igt_assert_eq() to check for crc component count

2015-12-18 Thread ville . syrjala
From: Ville Syrjälä It's nice to see just how many components the crc claims to have when the count don't match what we expect. Signed-off-by: Ville Syrjälä --- lib/igt_debugfs.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c

[Intel-gfx] [PATCH i-g-t 4/6] lib: Add igt_pipe_crc_new_nonblock()

2015-12-18 Thread ville . syrjala
From: Ville Syrjälä Add support for reading the CRC in non-blocking mode. Useful for tests that want to start the CRC capture, then do a bunch of operations, then collect however many CRCs that got generated. The current igt_pipe_crc_new() + igt_pipe_crc_get_crcs() method would block until it get

[Intel-gfx] [PATCH i-g-t 5/6] tests/kms_pipe_crc_basic: Add tests for O_NONBLOCK CRC reads

2015-12-18 Thread ville . syrjala
From: Ville Syrjälä Signed-off-by: Ville Syrjälä --- tests/kms_pipe_crc_basic.c | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index a3292c225203..eb8e15e7f413 100644 --- a/tests/kms_

[Intel-gfx] [PATCH i-g-t 2/6] lib: Extract ssme common fb create+fill methods into helpers

2015-12-18 Thread ville . syrjala
From: Ville Syrjälä Several tests do one or more of the followin: * igt_create_fb() + igt_paint_test_pattern() * igt_create_color_fb() + igt_paint_test_pattern() * igt_create_fb() + igt_paint_image() Extract them into new helpes: igt_create_pattern_fb(), igt_create_color_pattern_fb(), igt_create

[Intel-gfx] [PATCH i-g-t 6/6] tests/kms_chv_cursor_fail: Add a test to exercise CHV pipe C cursor fail

2015-12-18 Thread ville . syrjala
From: Ville Syrjälä The test tries to anger CHV pipe C cursor by walking the edges of the screen while moving the cursor across the screen edge. The actual hw issue only occurs on pipe C, and only on the left screen edge. The testcase can walk all the edges though, and on all pipes, just so I co

Re: [Intel-gfx] [PATCH] drm/i915: HWSTAM is not a thing on SKL+

2015-12-18 Thread Ben Widawsky
On Fri, Dec 18, 2015 at 10:17:49AM +0200, Mika Kuoppala wrote: > Ben Widawsky writes: > > > Compile tested only. > > > > Signed-off-by: Ben Widawsky > > --- > > drivers/gpu/drm/i915/intel_lrc.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915

[Intel-gfx] ✗ failure: Fi.CI.BAT

2015-12-18 Thread Patchwork
== Summary == Built on deb496ede4fc5e7affe15640a113ea9b5f1189e0 drm-intel-nightly: 2015y-12m-18d-16h-12m-24s UTC integration manifest Test gem_storedw_loop: Subgroup basic-render: dmesg-warn -> PASS (skl-i5k-2) Test kms_flip: Subgroup basic-flip-vs-modeset:

[Intel-gfx] vsync + vaapi question

2015-12-18 Thread Lukas Hejtmanek
Hello, is it possible to switch vsync from internal LCD (laptop) to external monitor when playing movie via VA-API? I can drop vsync with internal LCD and keep vsync only with external monitor. I tried to use --primary for excernal monitor when enabling output but no luck. Is there any way to sy

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_pm: Lib for power management

2015-12-18 Thread Thomas Wood
On 15 December 2015 at 09:14, David Weinehall wrote: > Move power management related code to a separate library. > Initially this is done only for workarounds that apply to external > components. Modify the users of such workarounds accordingly. > This currently involves HD audio and SATA link po

  1   2   >