On pe, 2015-12-18 at 11:59 +0200, Jani Nikula wrote: > On Thu, 17 Dec 2015, Imre Deak <imre.d...@intel.com> wrote: > > On Thu, 2015-12-17 at 09:49 -0800, Ben Widawsky wrote: > > > +> if (IS_GEN9(ring->dev)) > > > > Nitpick: INTEL_INFO()->gen == 9 is the preferred way. > > Oh? Since when and says who?
Haven't found it after some digging, but I do remember someone having this comment earlier. My opinion is that we should only use one form, and since INTEL_INFO()- gen can be used in a more generic manner I would prefer that. Currently we have it both ways in the code. --Imre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
