Re: [Intel-gfx] [PATCH] drm/i915: Check for driver readyness before handling an underrun interrupt

2015-02-27 Thread Jani Nikula
On Fri, 27 Feb 2015, Jani Nikula wrote: > On Thu, 26 Feb 2015, Chris Wilson wrote: >> When we takeover from the BIOS and install our interrupt handler, the >> BIOS may have left us a few surprises in the form of spontaneous >> interrupts. (This is especially likely on hardware like 965gm where >>

Re: [Intel-gfx] [PATCH] drm/i915: Check DVO reads for errors

2015-02-27 Thread Quentin Casasnovas
On Thu, Feb 26, 2015 at 10:09:49PM +, Chris Wilson wrote: > On Thu, Feb 26, 2015 at 06:47:14PM +0100, Quentin Casasnovas wrote: > > On Thu, Feb 26, 2015 at 05:10:17PM +, Chris Wilson wrote: > > > Not all of the DVO functions were checking the return value from their > > > i2c routines when

[Intel-gfx] Suspend/resume problems on Broadwell

2015-02-27 Thread phoebe
Hi, I'm having a few problems with i915 on my Broadwell Thinkpad (T450s, i7-5600U), apparently suspend/resume related. During every suspend/resume cycle, I see this in my kernel log after wakeup: Freezing user space processes ... (elapsed 0.001 seconds) done. Freezing remaining freezable tasks .

Re: [Intel-gfx] [PATCH] drm/i915: Check DVO reads for errors

2015-02-27 Thread Quentin Casasnovas
On Thu, Feb 26, 2015 at 05:10:17PM +, Chris Wilson wrote: > Not all of the DVO functions were checking the return value from their > i2c routines when reading registers. This could lead to us feeding > garbage values back into the hardware, possible causing further > failures. In some cases the

Re: [Intel-gfx] [PATCH] drm/i915: Check for driver readyness before handling an underrun interrupt

2015-02-27 Thread Chris Wilson
On Fri, Feb 27, 2015 at 10:20:05AM +0200, Jani Nikula wrote: > On Fri, 27 Feb 2015, Jani Nikula wrote: > > On Thu, 26 Feb 2015, Chris Wilson wrote: > >> When we takeover from the BIOS and install our interrupt handler, the > >> BIOS may have left us a few surprises in the form of spontaneous > >>

Re: [Intel-gfx] [PATCH 6/8] drm/i915/skl: Updated watermark programming

2015-02-27 Thread Tvrtko Ursulin
On 02/26/2015 04:45 PM, Damien Lespiau wrote: On Wed, Feb 25, 2015 at 04:47:22PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Recent BSpect updates have changed the watermark calculation to avoid display flickering in some cases. Signed-off-by: Tvrtko Ursulin --- There are really sev

Re: [Intel-gfx] [PATCH 7/8] drm/i915/skl: Update watermarks for Y tiling

2015-02-27 Thread Tvrtko Ursulin
On 02/26/2015 04:59 PM, Damien Lespiau wrote: On Wed, Feb 25, 2015 at 04:47:23PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Display watermarks need different programming for different tiling modes. Set the relevant flag so this happens during the plane commit and add relevant data int

Re: [Intel-gfx] [PATCH 8/8] drm/i915/skl: Allow Y (and Yf) frame buffer creation

2015-02-27 Thread Tvrtko Ursulin
On 02/26/2015 04:44 PM, Daniel Vetter wrote: On Wed, Feb 25, 2015 at 04:47:24PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin By this patch all underlying bits have been implemented and this patch actually enables the feature. v2: Validate passed in fb modifiers to reject garbage. (Danie

Re: [Intel-gfx] [PATCH i-g-t] kms_universal_plane: Check for cursor fb leaks

2015-02-27 Thread Chris Wilson
On Thu, Feb 26, 2015 at 07:00:19PM -0800, Matt Roper wrote: > We've been leaking the framebuffers that get created inside the > legacy -> universal cursor compatibility layer and nobody noticed. Add > an i-g-t test to check debugfs and ensure we end up the same number of > framebuffers we started

Re: [Intel-gfx] [PATCH] drm/i915: Check for driver readyness before handling an underrun interrupt

2015-02-27 Thread Jani Nikula
On Fri, 27 Feb 2015, Chris Wilson wrote: > On Fri, Feb 27, 2015 at 10:20:05AM +0200, Jani Nikula wrote: >> On Fri, 27 Feb 2015, Jani Nikula wrote: >> > On Thu, 26 Feb 2015, Chris Wilson wrote: >> >> When we takeover from the BIOS and install our interrupt handler, the >> >> BIOS may have left us

Re: [Intel-gfx] [PATCH] drm/i915: DP link training optimization

2015-02-27 Thread Sivakumar Thulasimani
On 2/27/2015 1:14 PM, Jani Nikula wrote: On Fri, 27 Feb 2015, Todd Previte wrote: Hi Mika, On 2/26/2015 2:26 AM, Mika Kahola wrote: In a case when DP link has been once trained we can reuse the existing link training parameters i.e. voltage swing and pre-emphasis levels from cache when there

[Intel-gfx] [PATCH v2] drm/dp: add DPCD definitions from DP 1.1 and 1.2a

2015-02-27 Thread Jani Nikula
Add a number of DPCD definitions from DP 1.1 and 1.2a. v2: drop wrong DP version reference, rename DP training set macros (Sonika). Reviewed-by: Sonika Jindal Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 93 ++--- 1 file changed, 88 inser

[Intel-gfx] [PATCH v2] drm/dp: add DPCD definitions from eDP 1.4

2015-02-27 Thread Jani Nikula
Add a number of DPCD definitions from eDP 1.4. v2: s/DP_ALPM_LOCK_TIMEOUT_ERROR_STATUS/DP_ALPM_LOCK_TIMEOUT_ERROR/ (Sonika) Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 37 + 1 file changed, 37 insertions(+) diff --git a/include/drm/drm_dp

Re: [Intel-gfx] [PATCH v2] drm/dp: add DPCD definitions from DP 1.1 and 1.2a

2015-02-27 Thread Jani Nikula
Apologies, this was supposed to be in reply to http://mid.gmane.org/54eeecc9.4010...@intel.com On Fri, 27 Feb 2015, Jani Nikula wrote: > Add a number of DPCD definitions from DP 1.1 and 1.2a. > > v2: drop wrong DP version reference, rename DP training set macros > (Sonika). > > Reviewed-by: Son

[Intel-gfx] [PATCH 3/8] drm/i915/skl: Adjust intel_fb_align_height() for Yb/Yf tiling

2015-02-27 Thread Tvrtko Ursulin
From: Damien Lespiau We now need the bpp of the fb as Yf tiling has different tile widths depending on it. v2: Rebased for the new addfb2 interface. (Tvrtko Ursulin) v3: Rebased for fb modifier changes. (Tvrtko Ursulin) v4: Added missing case and 128-bit pixel warning. (Damien Lespiau) Signed-o

[Intel-gfx] [PATCH 1/8] drm/i915/skl: Add new displayable tiling formats

2015-02-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Starting with SKL display engine can scan out Y, and newly introduced Yf tiling formats so add the latter to the frame buffer modifier space. v2: Definitions moved to drm_fourcc.h. v3: Try to document the format better. Signed-off-by: Tvrtko Ursulin Reviewed-by: Damien Les

[Intel-gfx] [PATCH 2/8] drm/i915/skl: Allow scanning out Y and Yf fbs

2015-02-27 Thread Tvrtko Ursulin
From: Damien Lespiau Skylake is able to scannout those tiling formats. We need to allow them in the ADDFB ioctl and tell the harware about it. v2: Rebased for addfb2 interface. (Tvrtko Ursulin) v3: Rebased for fb modifier changes. (Tvrtko Ursulin) v4: Don't allow Y tiled fbs just yet. (Tvrtko Ur

[Intel-gfx] [PATCH 6/8] drm/i915/skl: Updated watermark programming

2015-02-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Recent BSpect updates have changed the watermark calculation to avoid display flickering in some cases. v2: Fix check against DDB allocation and tidy the code a bit. (Damien Lespiau) Signed-off-by: Tvrtko Ursulin Reviewed-by: Damien Lespiau --- drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH 8/8] drm/i915/skl: Allow Y (and Yf) frame buffer creation

2015-02-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin By this patch all underlying bits have been implemented and this patch actually enables the feature. v2: Validate passed in fb modifiers to reject garbage. (Daniel Vetter) v3: Rearrange validation checks per code review comments. (Daniel Vetter) Signed-off-by: Tvrtko Ursuli

[Intel-gfx] [PATCH 7/8] drm/i915/skl: Update watermarks for Y tiling

2015-02-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Display watermarks need different programming for different tiling modes. Set the relevant flag so this happens during the plane commit and add relevant data into a structure made available to the watermark computation code. v2: Pass in tiling info to sprite plane updates a

[Intel-gfx] [PATCH 4/8] drm/i915/skl: Teach pin_and_fence_fb_obj() about Y tiling constraints

2015-02-27 Thread Tvrtko Ursulin
From: Damien Lespiau 1Mb! v2: Rebased for addfb2 interface. (Tvrtko Ursulin) v3: Rebased for fb modifier changes. (Tvrtko Ursulin) Signed-off-by: Damien Lespiau Signed-off-by: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 8 ++-- 1 file changed, 6

[Intel-gfx] [PATCH 5/8] drm/i915/skl: Adjust get_plane_config() to support Yb/Yf tiling

2015-02-27 Thread Tvrtko Ursulin
From: Damien Lespiau v2: Rebased for addfb2 interface and consolidated a bit. (Tvrtko Ursulin) v3: Rebased for fb modifier changes. (Tvrtko Ursulin) v4: Use intel_fb_stride_alignment instead of open coding. (Damien Lespiau) Signed-off-by: Damien Lespiau Signed-off-by: Tvrtko Ursulin Reviewed-b

[Intel-gfx] [PATCH v5 0/8] Skylake Y tiled scanout

2015-02-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Starting with Skylake the display engine can scan out Y tiled objects. (Both legacy Y tiled, and the new Yf format.) This series takes the original work by Damien Lespiau and converts it to use the new frame buffer modifiers instead of object set/get tiling. Some patches nee

Re: [Intel-gfx] [PATCH v6 06/32] drm/i915: Extract context switch skip and pd load logic

2015-02-27 Thread Mika Kuoppala
Michel Thierry writes: > From: Ben Widawsky > > We have some fanciness coming up. This patch just breaks out the logic > of context switch skip, pd load pre, and pd load post. > > v2: Use new functions to replace the logic right away (Daniel) > > Cc: Daniel Vetter > Signed-off-by: Ben Widawsky

[Intel-gfx] [PATCH] drm: Fixup racy refcounting in plane_force_disable

2015-02-27 Thread Daniel Vetter
Originally it was impossible to be dropping the last refcount in this function since there was always one around still from the idr. But in commit 83f45fc360c8e16a330474860ebda872d1384c8c Author: Daniel Vetter Date: Wed Aug 6 09:10:18 2014 +0200 drm: Don't grab an fb reference for the idr

Re: [Intel-gfx] [PATCH 01/51] drm/i915: Rename 'flags' to 'dispatch_flags' for better code reading

2015-02-27 Thread John Harrison
On 25/02/2015 21:34, Daniel Vetter wrote: On Fri, Feb 13, 2015 at 11:48:10AM +, john.c.harri...@intel.com wrote: From: John Harrison There is a flags word that is passed through the execbuffer code path all the way from initial decoding of the user parameters down to the very final dispatc

Re: [Intel-gfx] [PATCH] drm/i915: fix failure to power off after hibernate

2015-02-27 Thread David Weinehall
On Thu, Feb 26, 2015 at 09:01:27PM +0100, Daniel Vetter wrote: > On Thu, Feb 26, 2015 at 08:50:48PM +0200, Imre Deak wrote: [snip] > > > > The problem seems to be that after the kernel puts the device into D3 > > the BIOS still tries to access it, or otherwise assumes that it's in D0. > > This is

Re: [Intel-gfx] [PATCH 04/51] drm/i915: Merged the many do_execbuf() parameters into a structure

2015-02-27 Thread John Harrison
On 25/02/2015 21:52, Daniel Vetter wrote: On Fri, Feb 13, 2015 at 11:48:13AM +, john.c.harri...@intel.com wrote: From: John Harrison The do_execbuf() function takes quite a few parameters. The actual set of parameters is going to change with the conversion to passing requests around. Furth

Re: [Intel-gfx] [PATCH 07/51] drm/i915: Early alloc request in execbuff

2015-02-27 Thread John Harrison
On 25/02/2015 22:22, Daniel Vetter wrote: On Fri, Feb 13, 2015 at 11:48:16AM +, john.c.harri...@intel.com wrote: From: John Harrison Start of explicit request management in the execbuffer code path. This patch adds a call to allocate a request structure before all the actual hardware work

Re: [Intel-gfx] [PATCH 08/51] drm/i915: Update alloc_request to return the allocated request

2015-02-27 Thread John Harrison
On 25/02/2015 21:08, Daniel Vetter wrote: On Fri, Feb 13, 2015 at 12:21:29PM +, Chris Wilson wrote: On Fri, Feb 13, 2015 at 11:48:17AM +, john.c.harri...@intel.com wrote: From: John Harrison The alloc_request() function does not actually return the newly allocated request. Instead, it

Re: [Intel-gfx] [PATCH 24/51] drm/i915: Update deferred context creation to do explicit request management

2015-02-27 Thread John Harrison
On 25/02/2015 21:15, Daniel Vetter wrote: On Wed, Feb 18, 2015 at 03:27:38PM +, John Harrison wrote: On 13/02/2015 12:15, Chris Wilson wrote: On Fri, Feb 13, 2015 at 11:48:33AM +, john.c.harri...@intel.com wrote: From: John Harrison In execlist mode, context initialisation is deferre

Re: [Intel-gfx] [PATCH 47/51] drm/i915: Update ironlake_enable_rc6() to do explicit request management

2015-02-27 Thread John Harrison
On 25/02/2015 21:31, Daniel Vetter wrote: On Wed, Feb 18, 2015 at 02:28:16PM +, John Harrison wrote: On 13/02/2015 17:03, Chris Wilson wrote: On Fri, Feb 13, 2015 at 04:58:24PM +, John Harrison wrote: On 13/02/2015 12:19, Chris Wilson wrote: On Fri, Feb 13, 2015 at 11:48:56AM +, j

Re: [Intel-gfx] [PATCH 47/51] drm/i915: Update ironlake_enable_rc6() to do explicit request management

2015-02-27 Thread Ville Syrjälä
On Wed, Feb 25, 2015 at 10:31:13PM +0100, Daniel Vetter wrote: > On Wed, Feb 18, 2015 at 02:28:16PM +, John Harrison wrote: > > On 13/02/2015 17:03, Chris Wilson wrote: > > >On Fri, Feb 13, 2015 at 04:58:24PM +, John Harrison wrote: > > >>On 13/02/2015 12:19, Chris Wilson wrote: > > >>>On F

Re: [Intel-gfx] [PATCH v2] drm/dp: add DPCD definitions from DP 1.1 and 1.2a

2015-02-27 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 01:12:46PM +0200, Jani Nikula wrote: > > Apologies, this was supposed to be in reply to > http://mid.gmane.org/54eeecc9.4010...@intel.com > > > On Fri, 27 Feb 2015, Jani Nikula wrote: > > Add a number of DPCD definitions from DP 1.1 and 1.2a. > > > > v2: drop wrong DP ve

Re: [Intel-gfx] [PATCH 01/51] drm/i915: Rename 'flags' to 'dispatch_flags' for better code reading

2015-02-27 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 12:14:06PM +, John Harrison wrote: > On 25/02/2015 21:34, Daniel Vetter wrote: > >On Fri, Feb 13, 2015 at 11:48:10AM +, john.c.harri...@intel.com wrote: > >>From: John Harrison > >> > >>There is a flags word that is passed through the execbuffer code path all > >>t

Re: [Intel-gfx] [PATCH 04/51] drm/i915: Merged the many do_execbuf() parameters into a structure

2015-02-27 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 12:22:42PM +, John Harrison wrote: > On 25/02/2015 21:52, Daniel Vetter wrote: > >On Fri, Feb 13, 2015 at 11:48:13AM +, john.c.harri...@intel.com wrote: > >>From: John Harrison > >> > >>The do_execbuf() function takes quite a few parameters. The actual set of > >>pa

[Intel-gfx] [PATCH] drm/i915: Extract context switch skip and add pd load logic

2015-02-27 Thread Michel Thierry
From: Ben Widawsky This patch just breaks out the logic of context switch skip. It also adds pd load pre, and pd load post logic (for GEN8). v2: Use new functions to replace the logic right away (Daniel) v3: Add missing pd load logic. Cc: Daniel Vetter Signed-off-by: Ben Widawsky Signed-off-

Re: [Intel-gfx] [PATCH 07/51] drm/i915: Early alloc request in execbuff

2015-02-27 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 12:27:15PM +, John Harrison wrote: > On 25/02/2015 22:22, Daniel Vetter wrote: > >On Fri, Feb 13, 2015 at 11:48:16AM +, john.c.harri...@intel.com wrote: > >>From: John Harrison > >> > >>Start of explicit request management in the execbuffer code path. This patch > >

[Intel-gfx] [PATCH] drm/i915: Initialize all contexts

2015-02-27 Thread Michel Thierry
From: Ben Widawsky The problem is we're going to switch to a new context, which could be the default context. The plan was to use restore inhibit, which would be fine, except if we are using dynamic page tables (which we will). If we use dynamic page tables and we don't load new page tables, the

Re: [Intel-gfx] [PATCH 08/51] drm/i915: Update alloc_request to return the allocated request

2015-02-27 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 12:34:29PM +, John Harrison wrote: > On 25/02/2015 21:08, Daniel Vetter wrote: > >On Fri, Feb 13, 2015 at 12:21:29PM +, Chris Wilson wrote: > >>On Fri, Feb 13, 2015 at 11:48:17AM +, john.c.harri...@intel.com wrote: > >>>From: John Harrison > >>> > >>>The alloc_r

Re: [Intel-gfx] [PATCH v2] drm/dp: add DPCD definitions from eDP 1.4

2015-02-27 Thread Jindal, Sonika
Reviewed-by: Sonika Jindal On 2/27/2015 4:41 PM, Jani Nikula wrote: Add a number of DPCD definitions from eDP 1.4. v2: s/DP_ALPM_LOCK_TIMEOUT_ERROR_STATUS/DP_ALPM_LOCK_TIMEOUT_ERROR/ (Sonika) Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 37 +

Re: [Intel-gfx] [PATCH 24/51] drm/i915: Update deferred context creation to do explicit request management

2015-02-27 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 12:45:19PM +, John Harrison wrote: > On 25/02/2015 21:15, Daniel Vetter wrote: > >On Wed, Feb 18, 2015 at 03:27:38PM +, John Harrison wrote: > >>On 13/02/2015 12:15, Chris Wilson wrote: > >>>On Fri, Feb 13, 2015 at 11:48:33AM +, john.c.harri...@intel.com wrote: >

Re: [Intel-gfx] [PATCH 47/51] drm/i915: Update ironlake_enable_rc6() to do explicit request management

2015-02-27 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 03:03:22PM +0200, Ville Syrjälä wrote: > On Wed, Feb 25, 2015 at 10:31:13PM +0100, Daniel Vetter wrote: > > On Wed, Feb 18, 2015 at 02:28:16PM +, John Harrison wrote: > > > On 13/02/2015 17:03, Chris Wilson wrote: > > > >On Fri, Feb 13, 2015 at 04:58:24PM +, John Har

Re: [Intel-gfx] [PATCH 47/51] drm/i915: Update ironlake_enable_rc6() to do explicit request management

2015-02-27 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 12:49:11PM +, John Harrison wrote: > On 25/02/2015 21:31, Daniel Vetter wrote: > >On Wed, Feb 18, 2015 at 02:28:16PM +, John Harrison wrote: > >>On 13/02/2015 17:03, Chris Wilson wrote: > >>>On Fri, Feb 13, 2015 at 04:58:24PM +, John Harrison wrote: > On 13/0

[Intel-gfx] [PATCH] drm/i915: Tighten obj->map_and_fenceable

2015-02-27 Thread Chris Wilson
For an object right on the boundary of mappable space, as the fenceable size is stricly greater than the actual size, its fence region may extend out of mappable space. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Remove irq-related FIXME in reset code

2015-02-27 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 05:11:16PM -0800, Rodrigo Vivi wrote: > I believe this patch is on the wrong series, right? It's in here since I've spotted the FIXME while removing ums crap. > I'm afraid I don't know what was this race neither the two-step reset > to be able to review this comment remove

Re: [Intel-gfx] [PATCH] drm/i915: Add debugfs entry for DRRS

2015-02-27 Thread Ramalingam C
On Tuesday 24 February 2015 06:09 AM, Daniel Vetter wrote: On Mon, Feb 23, 2015 at 05:35:54PM +0530, Ramalingam C wrote: From: Vandana Kannan Adding a debugfs entry to determine if DRRS is supported or not V2: [By Ram]: Following details about the active crtc will be filled in seq-fi

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Remove DRIVER_MODESET checks from modeset code

2015-02-27 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 05:17:36PM -0800, Rodrigo Vivi wrote: > Reviewed-by: Rodrigo Vivi All merged to dinq, thanks for your review. -Daniel > > On Mon, Feb 23, 2015 at 3:03 AM, Daniel Vetter wrote: > > Mostly just checks in i915-private modeset ioctls. > > > > Signed-off-by: Daniel Vetter >

Re: [Intel-gfx] [PATCH 8/8] drm/i915/skl: Allow Y (and Yf) frame buffer creation

2015-02-27 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 09:45:27AM +, Tvrtko Ursulin wrote: > > On 02/26/2015 04:44 PM, Daniel Vetter wrote: > >On Wed, Feb 25, 2015 at 04:47:24PM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>By this patch all underlying bits have been implemented and this > >>patch actually

Re: [Intel-gfx] [PATCH] drm/i915: Check for driver readyness before handling an underrun interrupt

2015-02-27 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 09:27:04AM +, Chris Wilson wrote: > On Fri, Feb 27, 2015 at 10:20:05AM +0200, Jani Nikula wrote: > > On Fri, 27 Feb 2015, Jani Nikula wrote: > > > On Thu, 26 Feb 2015, Chris Wilson wrote: > > >> When we takeover from the BIOS and install our interrupt handler, the > >

Re: [Intel-gfx] [PATCH 7/8] drm/i915/skl: Update watermarks for Y tiling

2015-02-27 Thread Damien Lespiau
On Fri, Feb 27, 2015 at 09:39:47AM +, Tvrtko Ursulin wrote: > >Hum, does this compile? I'm seeing an extra argument to skl_wm_method2() > >but no update at the calling site? > > Not only that, but it even works! :) (Extra argument is there, you must have > missed it!) Ooops, I see it now: Re

Re: [Intel-gfx] [PATCH 0/6] eDP DRRS based on frontbuffer tracking

2015-02-27 Thread Ramalingam C
On Tuesday 24 February 2015 06:21 AM, Daniel Vetter wrote: On Fri, Feb 13, 2015 at 03:32:58PM +0530, Ramalingam C wrote: This series includes a preparation patch for drrs support across differnt platforms in intel_dp_set_m_n along with last 5 pending patches of V3 eDP DRRS patch series. New se

Re: [Intel-gfx] [PATCH] drm/i915: Redo WMs when cursor size changes

2015-02-27 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 05:47:35PM -0800, Matt Roper wrote: > On Thu, Feb 26, 2015 at 02:48:44PM -0800, Joe Konno wrote: > > From: Joe Konno > > > > In instances where cursor sizes change, as in Chromium Ozone/Freon, > > watermarks should be recomputed. There should be no hard-coded > > assumptio

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_kms.c: igt_require -> igt_require_f("two displays required\n")

2015-02-27 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 06:43:43PM -0800, Marc Herbert wrote: > The bare "Test requirement: modes" message is too cryptic, I had to go and > read the source code to understand the missing requirement. > > Signed-off-by: Marc Herbert Nice one, applied. Thanks, Daniel > --- > > If there is a dif

Re: [Intel-gfx] [PATCH] drm: Fixup racy refcounting in plane_force_disable

2015-02-27 Thread Matt Roper
On Fri, Feb 27, 2015 at 01:03:37PM +0100, Daniel Vetter wrote: > Originally it was impossible to be dropping the last refcount in this > function since there was always one around still from the idr. But in > > commit 83f45fc360c8e16a330474860ebda872d1384c8c > Author: Daniel Vetter > Date: Wed

[Intel-gfx] [PATCH 7/8] drm/i915/skl: Update watermarks for Y tiling

2015-02-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Display watermarks need different programming for different tiling modes. Set the relevant flag so this happens during the plane commit and add relevant data into a structure made available to the watermark computation code. v2: Pass in tiling info to sprite plane updates a

[Intel-gfx] [PATCH i-g-t] tests/kms_universal_planes: Inline igt_assert(ret == 0) checks

2015-02-27 Thread Daniel Vetter
This way the debug output in case of failures is nicer since we dump the entire test condition. Also replace one open-coded igt_assert_eq. Signed-off-by: Daniel Vetter --- tests/kms_universal_plane.c | 112 1 file changed, 50 insertions(+), 62 deleti

Re: [Intel-gfx] [PATCH i-g-t] kms_universal_plane: Check for cursor fb leaks

2015-02-27 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 07:00:19PM -0800, Matt Roper wrote: > We've been leaking the framebuffers that get created inside the > legacy -> universal cursor compatibility layer and nobody noticed. Add > an i-g-t test to check debugfs and ensure we end up the same number of > framebuffers we started

[Intel-gfx] [PATCH i-g-t] lib: add igt_assert_lt

2015-02-27 Thread Daniel Vetter
Found one user in gem_wait.c Signed-off-by: Daniel Vetter --- lib/igt_core.h | 13 + tests/gem_wait.c | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/lib/igt_core.h b/lib/igt_core.h index cc73a712bb7b..c2c820d14c9f 100644 --- a/lib/igt_core.h +++ b/lib/igt_c

Re: [Intel-gfx] [PATCH v5 0/8] Skylake Y tiled scanout

2015-02-27 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 11:15:16AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Starting with Skylake the display engine can scan out Y tiled objects. (Both > legacy Y tiled, and the new Yf format.) > > This series takes the original work by Damien Lespiau and converts it to use > th

Re: [Intel-gfx] [PATCH] drm/i915: add i915 specific connector debugfs file for DPCD

2015-02-27 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5824 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 282/282

Re: [Intel-gfx] [PATCH] drm/i915: Tighten obj->map_and_fenceable

2015-02-27 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 01:58:43PM +, Chris Wilson wrote: > For an object right on the boundary of mappable space, as the fenceable > size is stricly greater than the actual size, its fence region may extend > out of mappable space. > > Signed-off-by: Chris Wilson Do you have a scenario wher

Re: [Intel-gfx] [PATCH 0/6] eDP DRRS based on frontbuffer tracking

2015-02-27 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 07:59:43PM +0530, Ramalingam C wrote: > > On Tuesday 24 February 2015 06:21 AM, Daniel Vetter wrote: > >On Fri, Feb 13, 2015 at 03:32:58PM +0530, Ramalingam C wrote: > >>This series includes a preparation patch for drrs support across differnt > >>platforms in intel_dp_set_

[Intel-gfx] [PATCH] drm/i915: Do both mt and gen6 style forcewake reset on ivb probe

2015-02-27 Thread Mika Kuoppala
commit 05a2fb157e44 ("drm/i915: Consolidate forcewake code") failed to take into account that we have used to reset both the gen6 style and the multithreaded style forcewake registers. This is due to fact that ivb can use either, depending on how the bios has set up the machine. Mimic the old sema

Re: [Intel-gfx] [PATCH] drm/i915: Redo WMs when cursor size changes

2015-02-27 Thread Joe Konno
On 02/27/2015 06:53 AM, Daniel Vetter wrote: > On Thu, Feb 26, 2015 at 05:47:35PM -0800, Matt Roper wrote: >> So your patch below could result in sleeps happening while vblanks are >> disabled, which is bad (IIRC, most of those sleeps are in the SKL >> codepath right now, but I think there's a work

Re: [Intel-gfx] [PATCH] drm/i915: Redo WMs when cursor size changes

2015-02-27 Thread Matt Roper
On Fri, Feb 27, 2015 at 08:21:34AM -0800, Joe Konno wrote: > On 02/27/2015 06:53 AM, Daniel Vetter wrote: > > On Thu, Feb 26, 2015 at 05:47:35PM -0800, Matt Roper wrote: > >> So your patch below could result in sleeps happening while vblanks are > >> disabled, which is bad (IIRC, most of those slee

Re: [Intel-gfx] [PATCH] drm/i915: Tighten obj->map_and_fenceable

2015-02-27 Thread Chris Wilson
On Fri, Feb 27, 2015 at 04:32:26PM +0100, Daniel Vetter wrote: > On Fri, Feb 27, 2015 at 01:58:43PM +, Chris Wilson wrote: > > For an object right on the boundary of mappable space, as the fenceable > > size is stricly greater than the actual size, its fence region may extend > > out of mappabl

Re: [Intel-gfx] [PATCH] drm/i915: Do both mt and gen6 style forcewake reset on ivb probe

2015-02-27 Thread Chris Wilson
On Fri, Feb 27, 2015 at 06:11:09PM +0200, Mika Kuoppala wrote: > commit 05a2fb157e44 ("drm/i915: Consolidate forcewake code") > failed to take into account that we have used to reset both > the gen6 style and the multithreaded style forcewake registers. > This is due to fact that ivb can use either

[Intel-gfx] [PATCH 0/3] Watermark atomic fixes

2015-02-27 Thread Matt Roper
I'm in the process of reworking watermarks to play more nicely with atomic driver design. It sounds like a few people are already running into watermark-related problems caused by the atomic changes, so I've extracted a few early patches here that might solve those immediate issues. Note that the

[Intel-gfx] [PATCH 2/3] drm/i915: Kill intel_crtc->cursor_{width, height}

2015-02-27 Thread Matt Roper
The cursor size fields in intel_crtc just duplicate the data from cursor->state.crtc_{w,h} so we don't need them any more. Worse, their use in the watermark code actually introduces a subtle bug since they don't get updated to mirror the state values until the plane commit stage, which is *after*

[Intel-gfx] [PATCH 3/3] drm/i915: Use plane->state->fb in watermark code

2015-02-27 Thread Matt Roper
plane->fb is a legacy pointer that not always be up-to-date (or updated early enough). Make sure the watermark code uses plane->state->fb so that we're always doing our calculations based on the correct framebuffers. This patch was generated by Coccinelle with the following semantic patch:

Re: [Intel-gfx] Suspend/resume problems on Broadwell

2015-02-27 Thread phoebe
On Fri, 27 Feb 2015 00:07:41 +0100, pho...@quasiparticle.net wrote: > Hi, > > I'm having a few problems with i915 on my Broadwell Thinkpad > (T450s, i7-5600U) with kernel 3.19, apparently suspend/resume related. […] > Also, it seems that running or having run a GL application has some > impact on

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen8: The WA BB framework is enabled.

2015-02-27 Thread Michel Thierry
On 25/02/15 17:54, Arun Siluvery wrote: From: Namrta This can be used to enable WA BB infrastructure for features like RC6, SSEU and in between context save/restore etc. The patch which would need WA BB will have to declare the wa_bb obj utilizing the function here. Update the WA BB with requ

Re: [Intel-gfx] [PATCH] drm/i915: Look at staged config when fixing pipe_src_w for LVDS

2015-02-27 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5831 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 282/282

Re: [Intel-gfx] [PATCH 01/12] drm/i915: Reduce CHV DDL multiplier to 16/8

2015-02-27 Thread Jesse Barnes
On 02/10/2015 05:28 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Apparently we must yet halve the DDL drain latency from what we're > using currently. This little nugget is not in any spec, but came > down through the grapevine. > > This makes the displays a bit more stable

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Kill DRAIN_LATENCY_PRECISION_* defines

2015-02-27 Thread Jesse Barnes
On 02/10/2015 05:28 AM, ville.syrj...@linux.intel.com wrote: > @@ -957,8 +954,7 @@ static void valleyview_update_sprite_wm(struct drm_plane *plane, > int plane_prec; > int sprite_dl; > int prec_mult; > - const int high_precision = IS_CHERRYVIEW(dev) ? > - DRAIN_LAT

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Simplify VLV drain latency computation

2015-02-27 Thread Jesse Barnes
On 02/10/2015 05:28 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The current drain lantency computation relies on hardcoded limits to > determine when the to use the low vs. high precision multiplier. > Rewrite the code to use a more straightforward approach. > > Signed-off

Re: [Intel-gfx] [PATCH 04/12] drm/i915: Hide VLV DDL precision handling

2015-02-27 Thread Jesse Barnes
On 02/10/2015 05:28 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Move the DDL precision handling into vlv_compute_drain_latency() so the > callers don't have to duplicate the same code to deal with it. A little painful due to the addition of the #define changes, but I think

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Reorganize VLV DDL setup

2015-02-27 Thread Jesse Barnes
On 02/10/2015 05:28 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Introduce struct vlv_wm_values to house VLV watermark/drain latency > values. We start by using it when computing the drain latency values. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/i915_

Re: [Intel-gfx] Suspend/resume problems on Broadwell

2015-02-27 Thread Daniel Vetter
Smells like something is wrong in bdw-land. Can you please retest with latest drm-intel-nightly from http://cgit.freedesktop.org/drm-intel or alternatively 4.0-rc kernels? Starting with 4.0 we're using the execlist cmd submission support, which might help. Thanks, Daniel On Fri, Feb 27, 2015 at

Re: [Intel-gfx] [PATCH] drm/i915: Tighten obj->map_and_fenceable

2015-02-27 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 04:37:29PM +, Chris Wilson wrote: > On Fri, Feb 27, 2015 at 04:32:26PM +0100, Daniel Vetter wrote: > > On Fri, Feb 27, 2015 at 01:58:43PM +, Chris Wilson wrote: > > > For an object right on the boundary of mappable space, as the fenceable > > > size is stricly greate

[Intel-gfx] [PULL] drm-intel-next

2015-02-27 Thread Daniel Vetter
Hi Dave, -rc1 is out, time for the first i915 pull request ;-) drm-intel-next-2015-02-14: - use the atomic helpers for plane_upate/disable hooks (Matt Roper) - refactor the initial plane config code (Damien) - ppgtt prep patches for dynamic pagetable alloc (Ben Widawsky, reworked and rebased by

Re: [Intel-gfx] [PATCH 01/12] drm/i915: Reduce CHV DDL multiplier to 16/8

2015-02-27 Thread Ville Syrjälä
On Fri, Feb 27, 2015 at 09:36:58AM -0800, Jesse Barnes wrote: > On 02/10/2015 05:28 AM, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Apparently we must yet halve the DDL drain latency from what we're > > using currently. This little nugget is not in any spec, but came > >

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Pass plane to vlv_compute_drain_latency()

2015-02-27 Thread Jesse Barnes
On 02/10/2015 05:28 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Now that we have drm_planes for the cursor and primary we can move the > pixel_size handling into vlv_compute_drain_latency() and just pass the > appropriate plane to it. > > Signed-off-by: Ville Syrjälä > --

[Intel-gfx] [PATCH 1/2] drm/i915/chv: Determine CHV slice/subslice/EU info

2015-02-27 Thread jeff . mcgee
From: Jeff McGee Total EU was already being detected on CHV, so we just add the additional info parameters. The detection method is changed to be more robust in the case of subslice fusing - we don't want to trust the EU fuse bits corresponding to subslices which are fused-off. Signed-off-by: Je

[Intel-gfx] [PATCH 2/2] drm/i915/chv: Add CHV HW status to SSEU status

2015-02-27 Thread jeff . mcgee
From: Jeff McGee Collect the currently enabled counts of slice, subslice, and execution units using the power gate control ack message registers specific to Cherryview. Slice/subslice/EU info and hardware status can now be determined for CHV, so allow the debugfs SSEU status dump to proceed for

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen8: The WA BB framework is enabled.

2015-02-27 Thread Michel Thierry
On 27/02/15 17:32, Michel Thierry wrote: On 25/02/15 17:54, Arun Siluvery wrote: From: Namrta This can be used to enable WA BB infrastructure for features like RC6, SSEU and in between context save/restore etc. The patch which would need WA BB will have to declare the wa_bb obj utilizing t

[Intel-gfx] [PATCH 0/2] SSEU detection for CHV

2015-02-27 Thread jeff . mcgee
From: Jeff McGee These two patches add detection of available and enabled slice/subslice/EU on CHV following the implementation recently merged for SKL. They have been requested to help CHV users determine their configuration through the debugfs interface. Jeff McGee (2): drm/i915/chv: Determi

Re: [Intel-gfx] [PATCH v2 07/12] drm/i915: Read out display FIFO size on VLV/CHV

2015-02-27 Thread Jesse Barnes
On 02/12/2015 10:59 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > VLV/CHV have similar DSPARB registers as older platforms, just more of > them due to more planes. Add a bit of code to read out the current FIFO > split from the registers. Will be useful later when we improve

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Kill DRAIN_LATENCY_PRECISION_* defines

2015-02-27 Thread Ville Syrjälä
On Fri, Feb 27, 2015 at 09:38:10AM -0800, Jesse Barnes wrote: > On 02/10/2015 05:28 AM, ville.syrj...@linux.intel.com wrote: > > @@ -957,8 +954,7 @@ static void valleyview_update_sprite_wm(struct > drm_plane *plane, > > int plane_prec; > > int sprite_dl; > > int prec_mult; > > - const

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Pass plane to vlv_compute_drain_latency()

2015-02-27 Thread Ville Syrjälä
On Fri, Feb 27, 2015 at 09:57:20AM -0800, Jesse Barnes wrote: > On 02/10/2015 05:28 AM, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Now that we have drm_planes for the cursor and primary we can move the > > pixel_size handling into vlv_compute_drain_latency() and just pas

[Intel-gfx] [PATCH 2/3] drm/i915: Kill intel_crtc->cursor_{width, height} (v2)

2015-02-27 Thread Matt Roper
The cursor size fields in intel_crtc just duplicate the data from cursor->state.crtc_{w,h} so we don't need them any more. Worse, their use in the watermark code actually introduces a subtle bug since they don't get updated to mirror the state values until the plane commit stage, which is *after*

[Intel-gfx] [PATCH 3/3] drm/i915: Use plane->state->fb in watermark code (v2)

2015-02-27 Thread Matt Roper
plane->fb is a legacy pointer that not always be up-to-date (or updated early enough). Make sure the watermark code uses plane->state->fb so that we're always doing our calculations based on the correct framebuffers. This patch was generated by Coccinelle with the following semantic patch:

[Intel-gfx] [PATCH 0/3] Watermark atomic fixes (v2)

2015-02-27 Thread Matt Roper
I'm in the process of reworking watermarks to play more nicely with atomic driver design. It sounds like a few people are already running into watermark-related problems caused by the atomic changes, so I've extracted a few early patches here that might solve those immediate issues. Note that the

[Intel-gfx] Updated drm-intel-testing

2015-02-27 Thread Daniel Vetter
Hi all, New -testing cycle with cool stuff: - Y tiling support for scanout from Tvrtko&Damien - Remove more UMS support - some small prep patches for OLR removal from John Harrison - first few patches for dynamic pagetable allocation from Ben Widawsky, rebased by tons of other people - DRRS supp

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Move watermark handling to intel_wm.c

2015-02-27 Thread Ville Syrjälä
On Fri, Feb 27, 2015 at 08:54:19AM -0800, Matt Roper wrote: > Move watermark handling from intel_pm.c to intel_wm.c and add a little > bit of kerneldoc to exported functions. We also add a new > intel_init_wm() function to setup memory timing information and > initialize the relevant watermark vfu

Re: [Intel-gfx] [PATCH 04/51] drm/i915: Merged the many do_execbuf() parameters into a structure

2015-02-27 Thread John Harrison
On 27/02/2015 13:35, Daniel Vetter wrote: On Fri, Feb 27, 2015 at 12:22:42PM +, John Harrison wrote: On 25/02/2015 21:52, Daniel Vetter wrote: On Fri, Feb 13, 2015 at 11:48:13AM +, john.c.harri...@intel.com wrote: From: John Harrison The do_execbuf() function takes quite a few parame

Re: [Intel-gfx] [PATCH] drm/i915: fix failure to power off after hibernate

2015-02-27 Thread Imre Deak
On Fri, 2015-02-27 at 14:15 +0200, David Weinehall wrote: > On Thu, Feb 26, 2015 at 09:01:27PM +0100, Daniel Vetter wrote: > > On Thu, Feb 26, 2015 at 08:50:48PM +0200, Imre Deak wrote: > > [snip] > > > > > > The problem seems to be that after the kernel puts the device into D3 > > > the BIOS sti

Re: [Intel-gfx] [PATCH 1/2] drm/i915/chv: Determine CHV slice/subslice/EU info

2015-02-27 Thread Ville Syrjälä
On Fri, Feb 27, 2015 at 10:22:31AM -0800, jeff.mc...@intel.com wrote: > From: Jeff McGee > > Total EU was already being detected on CHV, so we just add the > additional info parameters. The detection method is changed to > be more robust in the case of subslice fusing - we don't want > to trust t

Re: [Intel-gfx] Suspend/resume problems on Broadwell

2015-02-27 Thread phoebe
On Fri, 27 Feb 2015 18:59:07 +0100, Daniel Vetter wrote: > Smells like something is wrong in bdw-land. > > Can you please retest with latest drm-intel-nightly from > http://cgit.freedesktop.org/drm-intel or alternatively 4.0-rc kernels? > Starting with 4.0 we're using the execlist cmd submission s

  1   2   >