Re: [Intel-gfx] [PATCH 1/2] drm/i915: HSW PSR fix inverted sink DP_PSR_CFG link setup.

On Fri, Feb 07, 2014 at 04:09:47PM -0200, Rodrigo Vivi wrote: > As pointed out by Ville we were using inverted logic here. > According to spec: > For link standby mode set 170h[1] = 1. > For full link disabling set 170h[1] = 0. > > Cc: Ville Syrjälä > Signed-off-by: Rodrigo Vivi > --- > drivers

Re: [Intel-gfx] [PATCH 2/2] drm/i915: PSR HSW: update after enabling sprite.

On Fri, Feb 7, 2014 at 5:17 PM, Ville Syrjälä wrote: > On Fri, Feb 07, 2014 at 04:09:48PM -0200, Rodrigo Vivi wrote: >> On the current structure HSW doesn't support PSR with sprites enabled >> but sprites can be enabled after PSR was enabled what would cause >> user to miss screen updates. >> >> C

[Intel-gfx] [PATCH igt 10/28] lib/display: Add support for the cursor plane

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 148 ++ lib/igt_kms.h | 13 +- 2 files changed, 150 insertions(+), 11 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 64fb39a..3b75478 100644 --- a/lib/igt_kms.c +++ b/lib

Re: [Intel-gfx] [PATCH] drm/i915: Fix correct FIFO size for Baytrail

On Fri, Feb 07, 2014 at 09:56:29PM +0530, Vijay Purushothaman wrote: > On 2/7/2014 9:28 PM, Ville Syrjälä wrote: > > On Fri, Feb 07, 2014 at 08:43:12PM +0530, Vijay Purushothaman wrote: > >> B-spec says the FIFO total size is 512. So fix this to 512. > >> > >> Signed-off-by: Vijay Purushothaman >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: HSW PSR fix inverted sink DP_PSR_CFG link setup.

On Fri, Feb 7, 2014 at 5:14 PM, Ville Syrjälä wrote: > On Fri, Feb 07, 2014 at 04:09:47PM -0200, Rodrigo Vivi wrote: >> As pointed out by Ville we were using inverted logic here. >> According to spec: >> For link standby mode set 170h[1] = 1. >> For full link disabling set 170h[1] = 0. >> >> Cc: V

[Intel-gfx] [PATCH 2/6] drm/i915: get_plane_config for i9xx v10

Read out the current plane configuration at init time into a new plane_config structure. This allows us to track any existing framebuffers attached to the plane and potentially re-use them in our fbdev code for a smooth handoff. v2: update for new pitch_for_width function (Jesse) comment how

[Intel-gfx] [PATCH 6/6] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v10

Retrieve current framebuffer config info from the regs and create an fb object for the buffer the BIOS or boot loader left us. This should allow for smooth transitions to userspace apps once we finish the initial configuration construction. v2: check for non-native modes and adjust (Jesse) fi

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Disable SF pipelined attribute fetch for SNB

On 02/04/2014 11:59 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > According to Bspec we need to disable SF pipelined attribute fetch > whenever SF outputs exceed 16 and normal clip mode is used. A quick > glance at Mesa suggests that these conditions could happen. So let's >

[Intel-gfx] [PATCH 4/6] drm/i915: alloc intel_fb in the intel_fbdev struct

Allocate this struct instead, so we can re-use another allocated elsewhere if needed. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c |4 ++-- drivers/gpu/drm/i915/intel_drv.h |2 +- drivers/gpu/drm/i915/intel_fbdev.c | 27 +++ 3 files

[Intel-gfx] [PATCH 5/6] drm/i915: allow re-use BIOS connector config for initial fbdev config

The BIOS or boot loader will generally create an initial display configuration for us that includes some set of active pipes and displays. This routine tries to figure out which pipes and connectors are active and stuffs them into the crtcs and modes array given to us by the drm_fb_helper code. S

[Intel-gfx] [PATCH 1/6] drm/i915: split aligned height calculation out v2

For use by get_plane_config. v2: cleanup tile_height bits (Chris) Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_displa

[Intel-gfx] [PATCH 3/6] drm/i915: get_plane_config support for ILK+

This should allow BIOS fb inheritance to work on ILK+ machines too. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c | 92 ++ 1 file changed, 92 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_di

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add Baytrail PSR Support.

On Fri, Feb 07, 2014 at 04:05:26PM -0200, Rodrigo Vivi wrote: > On Fri, Feb 7, 2014 at 3:24 PM, Ville Syrjälä > wrote: > > On Wed, Feb 05, 2014 at 05:04:31PM -0200, Rodrigo Vivi wrote: > >> This patch adds PSR Support to Baytrail. > >> > >> Baytrail cannot easily detect screen updates and force PS

Re: [Intel-gfx] intel_sdvo_init: trying to register non-static key

On Fri, 2014-02-07 at 15:51 +0100, Daniel Vetter wrote: > On Fri, Feb 07, 2014 at 12:28:09PM +0100, Borislav Petkov wrote: > > On Fri, Feb 07, 2014 at 01:12:22PM +0200, Imre Deak wrote: > > > On Fri, 2014-02-07 at 13:04 +0200, Jani Nikula wrote: > > > > Imre, is this the same i2c_del_adapter issue

[Intel-gfx] [PATCH v4 11/11] drm/i915: Calling rotate and inverse rotate transformations after clipping

From: Sagar Kamble With clipped sprites these transformations are not working. these functions transform complete sprite irrespective of clipping present. This leads to invisible portion of sprite show up when rotate 180 if it was out of visible area before. v4: Moved rotate transform for source

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add Baytrail PSR Support.

On Fri, Feb 7, 2014 at 3:24 PM, Ville Syrjälä wrote: > On Wed, Feb 05, 2014 at 05:04:31PM -0200, Rodrigo Vivi wrote: >> This patch adds PSR Support to Baytrail. >> >> Baytrail cannot easily detect screen updates and force PSR exit. >> So we inactivate it on {busy_ioctl, set_domain, sw_finish and m

Re: [Intel-gfx] [PATCH 0/5] Add power feature debugfs disabling

On Thu, Feb 06, 2014 at 05:37:29PM +0100, Daniel Vetter wrote: > On Thu, Feb 6, 2014 at 4:44 PM, Jeff McGee wrote: > > Our Android system validation tests are expecting these interfaces. That's > > not igt, I know, but is supporting downstream test suites a priority? I can > > get our val guys on

[Intel-gfx] [PATCH igt 04/28] lib: Introduce a for_each_connected_output() macro

So we can easily cycle through them in tests without knowing too many internal details about how igt_display_t organize its data. Signed-off-by: Damien Lespiau --- lib/igt_kms.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/igt_kms.h b/lib/igt_kms.h index 80cdfb6..1d06767 100644 --

[Intel-gfx] [PATCH igt 05/28] kms_pipe_crc_basic: Use for_each_connected_output()

Signed-off-by: Damien Lespiau --- tests/kms_pipe_crc_basic.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index fdec077..7d48ca6 100644 --- a/tests/kms_pipe_crc_basic.c +++ b/tests/kms_pipe_crc_basic.c @@ -81,

[Intel-gfx] [PATCH igt 16/28] lib/crc: Add a helper to read a single CRC value

In this case, we also take care of starting/stopping the CRC collection. Signed-off-by: Damien Lespiau --- lib/igt_debugfs.c | 14 ++ lib/igt_debugfs.h | 1 + 2 files changed, 15 insertions(+) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index a0d84bf..4a4a4dd 100644 --- a/li

Re: [Intel-gfx] [PATCH 1/2] tests/pm_rps: Round requested freq correctly

On Fri, Feb 07, 2014 at 11:15:15AM +0100, Daniel Vetter wrote: > On Fri, Feb 7, 2014 at 10:33 AM, Chris Wilson > wrote: > > On Fri, Feb 07, 2014 at 10:03:33AM +0100, Daniel Vetter wrote: > >> The kernel will round it, so if we don't we'll have a spurious > >> mismatch. Happens on my machine here

Re: [Intel-gfx] [PATCH 1/2] tests/pm_rps: Round requested freq correctly

On Fri, Feb 07, 2014 at 08:44:14AM -0600, Jeff McGee wrote: > On Fri, Feb 07, 2014 at 11:15:15AM +0100, Daniel Vetter wrote: > > On Fri, Feb 7, 2014 at 10:33 AM, Chris Wilson > > wrote: > > > On Fri, Feb 07, 2014 at 10:03:33AM +0100, Daniel Vetter wrote: > > >> The kernel will round it, so if we

Re: [Intel-gfx] [PATCH] drm/i915: Disable dp aux irq on g4x

On Fri, Feb 07, 2014 at 03:14:01PM +0100, Daniel Vetter wrote: > Apparently it's broken in the exact same way as the gmbus irq. For > reference of the full story see > > commit c12aba5aa0e60b7947bc8b6ea25ef55c4acf81a4 > Author: Jiri Kosina > Date: Tue Mar 19 09:56:57 2013 +0100 > > drm/i91

[Intel-gfx] [PATCH 4/9] drm/i915: Propagate PCI read/write errors during vga_set_state()

From: Chris Wilson This has very little effect other than log the errors in case of failure, and we then hope for the best. Signed-off-by: Chris Wilson Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_display.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) di

[Intel-gfx] [PATCH 1/9] drm/i915: Propagate errors on failed PPGTT

From: Ben Widawsky Clean up the return values/error handling so it's obvious what is going on. This was tripped over in the PPGTT branch where code was added to do a ret = foo() near the top, and this ended up bypassing some error cases later. These errors shouldn't exist with today's code, but

[Intel-gfx] [PATCH 9/9] drm/i915: PF CRC may not work on HSW

From: Ville Syrjälä When using pipe A and transcoder EDP w/o panel fitter on HSW, the PF CRC isn't available as the panel fitter is entirely bypassed. Check for this and refuse to give out CRCs. Signed-off-by: Ville Syrjälä Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_debugfs.c |

[Intel-gfx] [PATCH 0/9] drm-intel-collector - update

This is another drm-intel-collector updated notice: http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector Here goes the update list in order for better reviewers assignment: Patch drm/i915: Propagate errors on failed PPGTT - Reviewer: Patch drm/i915: wrap crtc enable/

[Intel-gfx] [PATCH 8/9] drm/i915: Flush GPU rendering with a lockless wait during a pagefault

From: Chris Wilson Arjan van de Ven reported that on his test machine that he was seeing stalls of greater than 1 frame greatly impacting the user experience. He tracked this down to being the locked flush during a pagefault as being the culprit hogging the struct_mutex and so blocking any other

[Intel-gfx] [PATCH 6/9] drm/i915: Verify address field of PCBR register.

From: Deepak S RC6 should be enabled only if the PCBR register is programmed properly either BIOS or Gfx. This patches address the case where PCBR allocation fails due buggy BIOS or due to stolen memory allocation failed. v2: Add #define for magic numbers (Daniel) v3: Use VLV_PCBR_ADDR_SHIFT in

[Intel-gfx] [PATCH 3/9] drm/i915: make crtc enable/disable asynchronous

From: Jesse Barnes The intent is to get back to userspace as quickly as possible so it can start doing drawing or whatever. It should also allow our suspend/resume/init time to improve a lot. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_irq.c | 10 +- drivers/gpu/drm

[Intel-gfx] [PATCH 7/9] drm/i915: Bring UP Power Wells before disabling RC6.

From: Deepak S We need do forcewake before Disabling RC6, This is what the BIOS expects while going into suspend. v2: updated commit message. (Daniel) Signed-off-by: Deepak S Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_pm.c | 6 ++ 1 file changed, 6 insertions(+) diff --g

[Intel-gfx] [PATCH 2/9] drm/i915: wrap crtc enable/disable

From: Jesse Barnes This allows us to hide queuing of enable/disable later. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 4 +- drivers/gpu/drm/i915/intel_display.c | 83 +--- drivers/gpu/drm

[Intel-gfx] [PATCH 5/9] drm/i915: Short-circuit no-op vga_set_state()

From: Chris Wilson Touching the VGA registers risks a hard machine hang, at least on this ivb machine after removing a conflicting efifb. This is more than likely related to the discovery that VGA IO decode on the more recent PCH platforms is terminally broken. Signed-off-by: Chris Wilson Cc: V

[Intel-gfx] [PATCH 2/2] drm/i915: add a display info file to debugfs v2

Can be expanded up on to include all sorts of things (HDMI infoframe data, more DP status, etc). Should be useful for bug reports to get a baseline on the display config and info. v2: use seq_putc (Rodrigo) describe mode field names (Rodrigo) Reviewed-by: Rodrigo Vivi Signed-off-by: Jesse B

[Intel-gfx] [PATCH 1/2] drm: expose subpixel order name routine v2

Just like we have for connector type etc. v2: drop static array (Chris) Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc.c | 16 include/drm/drm_crtc.h |1 + 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.

[Intel-gfx] [PATCH 1/3] drm/i915: dp: fix order of dp aux i2c device cleanup

Atm we set the parent of the dp i2c device to be the correspondig connector device. During driver cleanup we first remove the connector device through intel_modeset_cleanup()->drm_sysfs_connector_remove() and only after that the i2c device through the encoder's destroy callback. This order is not s

[Intel-gfx] [PATCH 2/3] drm/i915: sdvo: fix error path in sdvo_connector_init

Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/intel_sdvo.c | 49 +++ 1 file changed, 39 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index 95bdfb3..e9a2680 100644 --- a/drivers/gpu/drm/i

[Intel-gfx] [PATCH 3/3] drm/i915: sdvo: add i2c sysfs symlink to the connector's directory

This is the same what we do for DP connectors, so make things more consistent. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/intel_sdvo.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index e

Re: [Intel-gfx] Request for feedback - Sprite flip notification support

On Fri, Feb 7, 2014 at 7:36 AM, Vijay Purushothaman wrote: > Ping.. Could you please suggest whether this is okay? If you think this is > not worth or if nuclear page flip is on the horizon i will focus on display > self refresh patches.. Since we need to keep userspace ABIs working essentially f

Re: [Intel-gfx] 3.13.1 - WARNING at drivers/gpu/drm/i915/i915_irq.c:1240

On Thu, Feb 06, 2014 at 11:29:34PM +0100, Thomas Meyer wrote: > Am Dienstag, den 04.02.2014, 21:17 +0100 schrieb Daniel Vetter: > > On Tue, Feb 04, 2014 at 08:37:02PM +0100, Thomas Meyer wrote: > > > > > > Hi, > > > > > > I see a *lot* of these warning in 3.13.1. > > > 3.12.x never showed this pr

[Intel-gfx] [PATCH 2/2] tests/pm_rps: remove setfreq

It's unused. Cc: Jeff McGee Signed-off-by: Daniel Vetter --- tests/pm_rps.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/tests/pm_rps.c b/tests/pm_rps.c index 27e758755e3f..3d374f92f82d 100644 --- a/tests/pm_rps.c +++ b/tests/pm_rps.c @@ -110,17 +110,6 @@ static int do_writev

[Intel-gfx] [PATCH 1/2] tests/pm_rps: Round requested freq correctly

The kernel will round it, so if we don't we'll have a spurious mismatch. Happens on my machine here with 650-1300MHz range, where the midpoint is 975. Cc: Jeff McGee Signed-off-by: Daniel Vetter --- tests/pm_rps.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/pm_rps.c b/tests/pm_

Re: [Intel-gfx] [PATCH v2] drm/i915: Restore rps/rc6 on reset

On Tue, Feb 04, 2014 at 11:32:31AM -0600, jeff.mc...@intel.com wrote: > From: Jeff McGee > > A check of rps/rc6 state after i915_reset determined that the ring > MAX_IDLE registers were returned to their hardware defaults and that > the GEN6_PMIMR register was set to mask all interrupts. This cha

Re: [Intel-gfx] [PATCH v3] drm/i915: Update rps interrupt limits

On Tue, Feb 04, 2014 at 11:37:01AM -0600, jeff.mc...@intel.com wrote: > From: Jeff McGee > > sysfs changes to rps min and max delay were only triggering an update > of the rps interrupt limits if the active delay required an update. > This change ensures that interrupt limits are always updated.

Re: [Intel-gfx] [PATCH 1/2] tests/pm_rps: Round requested freq correctly

On Fri, Feb 07, 2014 at 10:03:33AM +0100, Daniel Vetter wrote: > The kernel will round it, so if we don't we'll have a spurious > mismatch. Happens on my machine here with 650-1300MHz range, where the > midpoint is 975. > > Cc: Jeff McGee > Signed-off-by: Daniel Vetter > --- > tests/pm_rps.c |

[Intel-gfx] intel_sdvo_init: trying to register non-static key

Hi guys, so I'm seeing this on rc1 + tip during boot: [0.558106] Linux agpgart interface v0.103 [0.558283] [drm] Initialized drm 1.1.0 20060810 [0.562280] [drm] Memory usable by graphics device = 2048M [0.632301] i915 :00:02.0: irq 42 for MSI/MSI-X [0.632401] [drm] Support

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Added write-enable pte bit support

>> What happens when we GTT-mapped write a batchbuffer that had previously been >> silently made RO by the kernel? Does the CPU take a fault? We tested this particular case, doing the relocation inside the Batch buffer, which is mapped to GTT as read-only, from the exec-buffer path. On doing so,

Re: [Intel-gfx] [PATCH] tests/gem_gtt_hog: Fix for BDW

On Thu, Feb 06, 2014 at 07:46:38PM -0200, Rodrigo Vivi wrote: > Update XY_COLOR_BLT command for Broadwell. > > v2: stash devid and remove ugly double allocation. (by Chris). > v3: fix inverted blt command size and stash fd, devid and intel_gen. > > Cc: Chris Wilson ch...@chris-wilson.co.uk> > Sig

Re: [Intel-gfx] [PATCH 1/2] tests/pm_rps: Round requested freq correctly

On Fri, Feb 7, 2014 at 10:33 AM, Chris Wilson wrote: > On Fri, Feb 07, 2014 at 10:03:33AM +0100, Daniel Vetter wrote: >> The kernel will round it, so if we don't we'll have a spurious >> mismatch. Happens on my machine here with 650-1300MHz range, where the >> midpoint is 975. >> >> Cc: Jeff McGee

Re: [Intel-gfx] intel_sdvo_init: trying to register non-static key

Imre, is this the same i2c_del_adapter issue you're looking at? Any patches to try yet? BR, Jani. On Fri, 07 Feb 2014, Borislav Petkov wrote: > Hi guys, > > so I'm seeing this on rc1 + tip during boot: > > [0.558106] Linux agpgart interface v0.103 > [0.558283] [drm] Initialized drm 1.1

Re: [Intel-gfx] intel_sdvo_init: trying to register non-static key

On Fri, 2014-02-07 at 13:04 +0200, Jani Nikula wrote: > Imre, is this the same i2c_del_adapter issue you're looking at? Any > patches to try yet? It looks like the same issue yes. The following patch fixed it for me: http://patchwork.freedesktop.org/patch/18698/ I'm working on an improved versio

Re: [Intel-gfx] intel_sdvo_init: trying to register non-static key

On Fri, Feb 07, 2014 at 01:12:22PM +0200, Imre Deak wrote: > On Fri, 2014-02-07 at 13:04 +0200, Jani Nikula wrote: > > Imre, is this the same i2c_del_adapter issue you're looking at? Any > > patches to try yet? > > It looks like the same issue yes. The following patch fixed it for me: > > http://

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv: Replaced Blitter ring based flips with MMIO Flips for VLV.

Please could you kindly elaborate here, it will help us to proceed further with this patch. Best Regards Akash -Original Message- From: Goel, Akash Sent: Monday, January 13, 2014 3:17 PM To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org Subject: RE: [Intel-gfx] [PATCH 2/2] drm/i915/v

[Intel-gfx] [PATCH v2 0/3] Rendering specific Hw workarounds for VLV

From: Akash Goel The following patches leads to stable behavior on VLV, especially when playing 3D Apps, benchmarks. Addressed review comments from Ville. Akash Goel (3): drm/i915/vlv: Added a rendering specific Hw WA 'WaTlbInvalidateStoreDataBefore' drm/i915/vlv: Added a rendering speci

[Intel-gfx] [PATCH v2 1/3] drm/i915/vlv: Added a rendering specific Hw WA 'WaTlbInvalidateStoreDataBefore'

From: Akash Goel Added a new rendering specific Workaround 'WaTlbInvalidateStoreDataBefore'. In this WA, before pipecontrol with TLB invalidate set, need to add 2 MI Store data commands. v2: Modified the WA comment. (Ville) Signed-off-by: Akash Goel --- drivers/gpu/drm/i915/intel_ringbuffer.c

[Intel-gfx] [PATCH v2 3/3] drm/i915/vlv: Modified the programming of 2 regs in Ring initialisation

From: Akash Goel Modified programming of following 2 regs in Render ring initialisation fn. 1. GFX_MODE_GEN7 (Enabling TLB invalidate) 2. MI_MODE (Enabling MI Flush) v2: Removed the enabling of MI_FLUSH (Ville) Added new comments (Ville). Signed-off-by: Akash Goel --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2 2/3] drm/i915/vlv: Added a rendering specific Hw WA 'WaReadAfterWriteHazard'

From: Akash Goel Added a new rendering specific Workaround 'WaReadAfterWriteHazard'. In this WA, need to add 12 MI Store Dword commands to ensure proper flush of h/w pipeline. v2: Modified the WA comment (Ville) Signed-off-by: Akash Goel --- drivers/gpu/drm/i915/intel_ringbuffer.c | 26 ++

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/vlv: Modified the programming of 2 regs in Ring initialisation

On Fri, Feb 07, 2014 at 05:52:12PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > Modified programming of following 2 regs in Render ring initialisation fn. > 1. GFX_MODE_GEN7 (Enabling TLB invalidate) The changelog needs to explain why. According to the spec this is a pessimisation.

[Intel-gfx] [PATCH v4 00/11] Enabling 180 degree rotation for sprite and crtc planes

From: Sagar Kamble These patches will enable 180 degree rotation for CRTC and Sprite planes. Changelog: 1. drm/i915: Add 180 degree primary plane rotation support Addressed review comments for CRTC rotation from FBC, page flip, CRTC active/ inactive perspective. 2. drm/i915: Calling rotate and in

[Intel-gfx] [PATCH v4 02/11] drm: Add support_bits parameter to drm_property_create_bitmask()

From: Ville Syrjälä Make drm_property_create_bitmask() a bit more generic by allowing the caller to specify which bits are in fact supported. This allows multiple callers to use the same enum list, but still create different versions of the same property with different list of supported bits. Si

[Intel-gfx] [PATCH v4 03/11] drm: Add drm_mode_create_rotation_property()

From: Ville Syrjälä Add a function to create a standards compliant rotation property. v4: For creating rotation bitmask property send number of values as only number of set rotations Signed-off-by: Ville Syrjälä Signed-off-by: Sagar Kamble Tested-by: Sagar Kamble --- drivers/gpu/drm/drm_crt

[Intel-gfx] [PATCH v4 01/11] drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h

From: Ville Syrjälä The rotation property stuff should be standardized among all drivers. Move the bits to drm_crtc.h from omap_drv.h. Signed-off-by: Ville Syrjälä Tested-by: Sagar Kamble --- drivers/gpu/drm/omapdrm/omap_drv.h | 7 --- include/drm/drm_crtc.h | 8 2 fi

[Intel-gfx] [PATCH v4 05/11] drm: Add drm_rect rotation functions

From: Ville Syrjälä Add some helper functions to move drm_rects between different rotated coordinate spaces. One function does the forward transform and another does the inverse. Signed-off-by: Ville Syrjälä Tested-by: Sagar Kamble --- drivers/gpu/drm/drm_rect.c | 140

[Intel-gfx] [PATCH v4 04/11] drm/omap: Switch omapdrm over to drm_mode_create_rotation_property()

From: Ville Syrjälä Use the new drm_mode_create_rotation_property() in omapdrm. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/omapdrm/omap_plane.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/o

[Intel-gfx] [PATCH v4 06/11] drm: Add drm_rotation_simplify()

From: Ville Syrjälä drm_rotation_simplify() can be used to eliminate unsupported rotation flags. It will check if any unsupported flags are present, and if so it will modify the rotation to an alternate form by adding 180 degrees to rotation angle, and flipping the reflect x and y bits. The hope

[Intel-gfx] [PATCH v4 10/11] drm/i915: Add 180 degree primary plane rotation support

From: Sagar Kamble Primary planes support 180 degree rotation. Expose the feature through rotation drm property. v2: Calculating linear/tiled offsets based on pipe source width and height. Added 180 degree rotation support in ironlake_update_plane. v3: Checking if CRTC is active before issueing

[Intel-gfx] [PATCH v4 07/11] drm/i915: Add 180 degree sprite rotation support

From: Ville Syrjälä The sprite planes (in fact all display planes starting from gen4) support 180 degree rotation. Add the relevant low level bits to the sprite code to make use of that feature. The upper layers are not yet plugged in. v2: HSW handles the rotated buffer offset automagically Si

[Intel-gfx] [PATCH v4 09/11] drm/i915: Add rotation property for sprites

From: Ville Syrjälä Sprite planes support 180 degree rotation. The lower layers are now in place, so hook in the standard rotation property to expose the feature to the users. Signed-off-by: Ville Syrjälä Tested-by: Sagar Kamble --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/

[Intel-gfx] [PATCH v4 08/11] drm/i915: Make intel_plane_restore() return an error

From: Ville Syrjälä Propagate the error from intel_update_plane() up through intel_plane_restore() to the caller. This will be used for rollback purposes when setting properties fails. Signed-off-by: Ville Syrjälä Tested-by: Sagar Kamble --- drivers/gpu/drm/i915/intel_drv.h| 2 +- driver

[Intel-gfx] [PATCH v2 1/1] tests/kms_rotate_crc: Test to verify rotation of planes through CRC

From: Sagar Kamble This test will verify 180 degree rotation of CRTC and sprite planes by grabbing CRC for already rotated image and comparing with CRC calculated after triggering rotation through DRM property. v2: Using cairo_rotate to created reference rotated version of CRTC and Sprite Image.

Re: [Intel-gfx] [PATCH 02/13] drm/i915: Implement command buffer parsing logic

On Wed, 29 Jan 2014, bradley.d.vol...@intel.com wrote: > +static int valid_reg(const u32 *table, int count, u32 addr) > +{ > + if (table && count != 0) { > + int i; > + > + for (i = 0; i < count; i++) { > + if (table[i] == addr) > +

[Intel-gfx] [PATCH] drm/i915: Disable dp aux irq on g4x

Apparently it's broken in the exact same way as the gmbus irq. For reference of the full story see commit c12aba5aa0e60b7947bc8b6ea25ef55c4acf81a4 Author: Jiri Kosina Date: Tue Mar 19 09:56:57 2013 +0100 drm/i915: stop using GMBUS IRQs on Gen4 chips The effect is that we have a storm of u

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/vlv: Modified the programming of 2 regs in Ring initialisation

> 1. GFX_MODE_GEN7 (Enabling TLB invalidate) >> The changelog needs to explain why. According to the spec this is a >> pessimisation. Ok, Will look into this. > 2. MI_MODE (Enabling MI Flush) >> And this is out-of-date. Doesn't describe the actual change nor why. Sorry I did not update the comm

Re: [Intel-gfx] [PATCH] Fix LIBDRM_PATH for top android build

Sorry for late reply, I still have trouble keeping track my patches with this email-patching-way-of-doing-things. Yes, that is correct, the tools should also benefit from the same fix. Joao -Original Message- From: Lespiau, Damien Sent: Friday, January 31, 2014 10:20 AM To: Barbalho

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/vlv: Modified the programming of 2 regs in Ring initialisation

On Fri, Feb 07, 2014 at 05:52:12PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > Modified programming of following 2 regs in Render ring initialisation fn. > 1. GFX_MODE_GEN7 (Enabling TLB invalidate) > 2. MI_MODE (Enabling MI Flush) > > v2: Removed the enabling of MI_FLUSH (Ville) >

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv: Replaced Blitter ring based flips with MMIO Flips for VLV.

On Fri, Feb 07, 2014 at 11:59:29AM +, Goel, Akash wrote: > Please could you kindly elaborate here, it will help us to proceed further > with this patch. As Chris said, instead of rolling your own code to track when flips are emitted to the ring, simply add a real request (with the add_request

[Intel-gfx] [PATCH igt 21/28] lib: Include drm_fourcc.h from igt_kms.h

This include is needed for the DRM_FORMAT* defines used in the fb creation helpers. Signed-off-by: Damien Lespiau --- lib/igt_kms.h | 1 + tests/kms_cursor_crc.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/igt_kms.h b/lib/igt_kms.h index 8110dad..96dd9e4 10

[Intel-gfx] [PATCH igt 15/28] lib/crc: Factor out reading a single CRC value

Signed-off-by: Damien Lespiau --- lib/igt_debugfs.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index 4b96521..a0d84bf 100644 --- a/lib/igt_debugfs.c +++ b/lib/igt_debugfs.c @@ -301,6 +301,21 @@ static bool pip

[Intel-gfx] [PATCH igt 24/28] lib/display: Add a way to wait at every commit for inspection

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 74e52b6..fbbf6aa 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1368,6 +1368,9 @@ int igt_display_commit(igt_display_t *display) LOG_UNINDENT(di

[Intel-gfx] [PATCH igt 08/28] tests/kms_cursor_crc: Move the array of cursor fb_ids to the stack

This array is not used outside ouf create_cursor_fb(). A stack allocated array is enough. Signed-off-by: Damien Lespiau --- tests/kms_cursor_crc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index 38aa1ab..9ddee06

[Intel-gfx] [PATCH igt 12/28] kms_cursor_crc: Port the test to the new modeset API

Signed-off-by: Damien Lespiau --- tests/kms_cursor_crc.c | 201 ++--- 1 file changed, 106 insertions(+), 95 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index 9ddee06..76e2845 100644 --- a/tests/kms_cursor_crc.c +++ b/tests

[Intel-gfx] [PATCH igt 18/28] lib/display: Add support for DRM planes

We can now extend our plane support beyond primary and cursor planes. Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 116 +- lib/igt_kms.h | 6 +++ 2 files changed, 120 insertions(+), 2 deletions(-) diff --git a/lib/igt_kms.c b/lib/ig

[Intel-gfx] [PATCH igt 20/28] kms_cursor_crc: Use kmstest_create_color_fb()

Signed-off-by: Damien Lespiau --- tests/kms_cursor_crc.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index a386ad9..6cdb785 100644 --- a/tests/kms_cursor_crc.c +++ b/tests/kms_cursor_crc.c @@ -61,25

[Intel-gfx] [PATCH igt 14/28] lib/display: Check if we're trying to use the same pipe on 2 outputs

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index c503ebb..1933fa6 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -977,10 +977,34 @@ void igt_display_fini(igt_displa

[Intel-gfx] [PATCH igt 03/28] lib: Introduce symbolic names for display planes

It'd be nice to have symbolic names for planes instead of using an index in igt_output_get_plane(). We also namespace the enum to not conflict with anyone. Signed-off-by: Damien Lespiau --- lib/igt_display.h | 18 +- lib/igt_kms.c | 18 -- lib/igt_kms.h |

[Intel-gfx] [PATCH igt 28/28] kms_plane: Start a basic display plane test

We test the sprite plane positionning in there, for now. Signed-off-by: Damien Lespiau --- tests/.gitignore | 1 + tests/Makefile.sources | 1 + tests/kms_plane.c | 247 + 3 files changed, 249 insertions(+) create mode 100644 tests/

[Intel-gfx] [PATCH igt 02/28] kms_pipe_crc_basic: Port to the new modeset API

Signed-off-by: Damien Lespiau --- tests/kms_pipe_crc_basic.c | 126 +++-- 1 file changed, 29 insertions(+), 97 deletions(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index f4a97eb..fdec077 100644 --- a/tests/kms_pipe_crc_basic.c

[Intel-gfx] [PATCH igt 13/28] lib/display: Allow to override the display verbosity with an env variale

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index e2413e5..c503ebb 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -863,6 +863,7 @@ void igt_display_init(igt_display_t *display, int drm_fd) { dr

[Intel-gfx] [PATCH igt 01/28] lib: Introduce a modeset API

The goals here are: - Reduce duplicated code in each KMS test - Provide an API that looks more like what we want for atomic modesets. The hope is then that it'll be easy to switch, at run-time, between the "legacy" path and atomic modesets, keeping the same API for tests. Signed-of

[Intel-gfx] [PATCH igt 06/28] lib/display: Add an accessor to retrieve the number of pipes

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 5 + lib/igt_kms.h | 1 + 2 files changed, 6 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index e3e902a..38ee82b 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -934,6 +934,11 @@ void igt_display_set_verbose(igt_display_t *displ

[Intel-gfx] [PATCH igt 19/28] lib: Introduce a new helper kmstest_create_color_fb()

We need to create fbs of a single color in a few places. Time to abstract that out to a helper function. Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 19 +++ lib/igt_kms.h | 4 2 files changed, 23 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 23a7318.

[Intel-gfx] [PATCH igt 11/28] lib/display: Add a way to specify we don't care about the pipe to use

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 12 lib/igt_kms.h | 6 ++ 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 3b75478..e2413e5 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1226,10 +1226,14 @@ void igt_output

[Intel-gfx] [PATCH igt 09/28] lib/display: Fix the SetCrtc disabling log message

We were displaying the value of fb_id (0), when the actual interesting thing about this call it that it'll just down the pipe. Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 38ee82b..64f

[Intel-gfx] [PATCH igt 25/28] lib/display: Print the fb id, not its pointer in the set_fb() log message

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index fbbf6aa..7d74bf8 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1411,8 +1411,8 @@ void igt_plane_set_fb(igt_plane_t *plane, struct kmste

[Intel-gfx] [PATCH igt 17/28] tests/kms_cursor_crc: Use igt_pipe_crc_collect_crc()

Signed-off-by: Damien Lespiau --- tests/kms_cursor_crc.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index 76e2845..a386ad9 100644 --- a/tests/kms_cursor_crc.c +++ b/tests/kms_cursor_crc.c @@ -94,7 +94,7 @

[Intel-gfx] [PATCH igt 26/28] lib/display: Wait for a vblank after SetPlane()

Let's be testing friendly and gently wait for the next vblank before returning from commit() when needed. After igt_display_commit() one can safely look at the CRC. Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 8 lib/igt_kms.h | 5 +++-- 2 files changed, 11 insertions(+), 2 deleti

[Intel-gfx] [PATCH igt 22/28] kms_pipe_crc_basic: Use kmstest_create_color_fb()

Reducing again the per-test number of lines. Signed-off-by: Damien Lespiau --- tests/kms_pipe_crc_basic.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index f4de64f..8a45c5b 100644 --- a/te

[Intel-gfx] [PATCH igt 07/28] kms_pipe_crc_basic: Use igt_display_get_n_pipes() instead of hardcoding 3

Signed-off-by: Damien Lespiau --- tests/kms_pipe_crc_basic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index 7d48ca6..f4de64f 100644 --- a/tests/kms_pipe_crc_basic.c +++ b/tests/kms_pipe_crc_basic.c @@ -169,7 +169,7

[Intel-gfx] [PATCH igt 23/28] lib: Add a helper to wait for a keypress

Signed-off-by: Damien Lespiau --- lib/drmtest.c | 13 + lib/drmtest.h | 2 ++ 2 files changed, 15 insertions(+) diff --git a/lib/drmtest.c b/lib/drmtest.c index f7262d7..f0635d3 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -46,6 +46,7 @@ #include #include #include +#inclu

Re: [Intel-gfx] intel_sdvo_init: trying to register non-static key

On Fri, Feb 07, 2014 at 12:28:09PM +0100, Borislav Petkov wrote: > On Fri, Feb 07, 2014 at 01:12:22PM +0200, Imre Deak wrote: > > On Fri, 2014-02-07 at 13:04 +0200, Jani Nikula wrote: > > > Imre, is this the same i2c_del_adapter issue you're looking at? Any > > > patches to try yet? > > > > It loo

  1   2   >