[Intel-gfx] [pull] last drm-intel-next pull for 3.7

2012-09-26 Thread Daniel Vetter
Hi Dave, Last pile of stuff for 3.7, essentially just a bunch of bigger fixes and a few less intrusive features: - cpu freq interface in sysfs from Ben - cpu edp fixes and some related cleanups - write-combining ptes for pre-gen6 (Chris) - basic CADL support (Peter Wu), this fixes quite a few iss

Re: [Intel-gfx] [PATCH] drm/i915: Wrap external callers to IPS state with appropriate locks

2012-09-26 Thread Daniel Vetter
On Tue, Sep 25, 2012 at 10:16:12AM +0100, Chris Wilson wrote: > Finishes commit 02d719562ef40483648b2cc46899d4a2ff5953bb > Author: Daniel Vetter > Date: Thu Aug 9 16:44:54 2012 +0200 > > drm/i915: properly guard ilk ips state > > The core functions were annotated with their locking require

Re: [Intel-gfx] [PATCH 1/2] drm/i915: s/cacheing/caching/

2012-09-26 Thread Daniel Vetter
On Tue, Sep 25, 2012 at 09:55:35AM -0700, Ben Widawsky wrote: > On Tue, 25 Sep 2012 10:43:55 +0100 > Chris Wilson wrote: > > > On Tue, 25 Sep 2012 10:32:17 +0200, Daniel Vetter wrote: > > > On Sat, Sep 22, 2012 at 2:01 AM, Ben Widawsky wrote: > > > > From: Ben Widawsky > > > > > > > > Signed-o

Re: [Intel-gfx] [RFC] [PATCH] quick_dump: A dump utility different than reg_dumper

2012-09-26 Thread Daniel Vetter
On Sat, Sep 22, 2012 at 01:58:37PM -0700, Ben Widawsky wrote: > On 2012-09-22 11:05, Daniel Vetter wrote: > >And a quick comment on your approach here: I'm not too sure > >whether the > >file-base register block approach scales, respectively why exactly > >this is > >better than frobbing the reg_du

Re: [Intel-gfx] [PATCH] drm/i915: Valleyview doesn't have rc6+ or rc6++

2012-09-26 Thread Daniel Vetter
On Mon, Sep 17, 2012 at 05:10:15PM -0700, Ben Widawsky wrote: > I do not currently have a VLV to test this on, but hopefully it only > removes information from debugfs, sysfs, and prevents enabling an > unsupported mode. > > CC: Jesse Barnes > Signed-off-by: Ben Widawsky Haswell seems to have a

Re: [Intel-gfx] [PATCH 3/4] drm/i915/dp: Fetch downstream port info if needed during DPCD fetch

2012-09-26 Thread Daniel Vetter
On Thu, Sep 20, 2012 at 03:28:45PM +0300, Jani Nikula wrote: > On Tue, 18 Sep 2012, Adam Jackson wrote: > > v2: Fix parenthesis mismatch, spotted by Jani Nikula > > > > Tested-by: Takashi Iwai > > Signed-off-by: Adam Jackson > > --- > > drivers/gpu/drm/i915/intel_dp.c | 25 +++

[Intel-gfx] [PATCH] drm/i915: Disallow preallocation of requests

2012-09-26 Thread Chris Wilson
The intention was to allow the caller to avoid a failure to queue a request having already written commands to the ring. However, this is a moot point as the i915_add_request() can fail for other reasons than a mere allocation failure and those failure cases are more likely than ENOMEM. So the over

Re: [Intel-gfx] [PATCH] drm/i915: Disallow preallocation of requests

2012-09-26 Thread Chris Wilson
On Wed, 26 Sep 2012 13:35:33 +0100, Chris Wilson wrote: > The intention was to allow the caller to avoid a failure to queue a > request having already written commands to the ring. However, this is a > moot point as the i915_add_request() can fail for other reasons than a > mere allocation failur

Re: [Intel-gfx] [PATCH 2/2] drm/dp: Make sink count DP 1.2 aware

2012-09-26 Thread Daniel Vetter
On Thu, Sep 20, 2012 at 06:45:29PM -0300, Paulo Zanoni wrote: > 2012/9/20 Adam Jackson : > > Signed-off-by: Adam Jackson > > Reviewed-by: Paulo Zanoni Both patches merged to dinq (again with Dave's irc-ack for the common stuff). Thanks, Daniel > > > --- > > drivers/gpu/drm/i915/intel_dp.c |

[Intel-gfx] [PATCH] drm/i915: Disallow preallocation of requests

2012-09-26 Thread Chris Wilson
The intention was to allow the caller to avoid a failure to queue a request having already written commands to the ring. However, this is a moot point as the i915_add_request() can fail for other reasons than a mere allocation failure and those failure cases are more likely than ENOMEM. So the over

[Intel-gfx] [PATCH] drm/i915: Disallow preallocation of requests

2012-09-26 Thread Chris Wilson
The intention was to allow the caller to avoid a failure to queue a request having already written commands to the ring. However, this is a moot point as the i915_add_request() can fail for other reasons than a mere allocation failure and those failure cases are more likely than ENOMEM. So the over

Re: [Intel-gfx] [PATCH] Add option -o , which can test only one specified mode.

2012-09-26 Thread Daniel Vetter
On Tue, Sep 25, 2012 at 05:13:17PM +0800, Yi Sun wrote: > Each mode line has a number just like '[i]'. So we can only test the > specified mode with giving the number of mode to '-o' parameter. > > Signed-off-by: Yi Sun Merged, thanks for the patch. -Daniel > > diff --git a/tests/testdisplay.c

[Intel-gfx] [PATCH] drm/i915: Disallow preallocation of requests

2012-09-26 Thread Chris Wilson
The intention was to allow the caller to avoid a failure to queue a request having already written commands to the ring. However, this is a moot point as the i915_add_request() can fail for other reasons than a mere allocation failure and those failure cases are more likely than ENOMEM. So the over

[Intel-gfx] [PATCH 0/9] Enable all display interfaces in Valleyview

2012-09-26 Thread Vijay Purushothaman
This patch set enables all supported display interfaces like HDMI, DisplayPort and eDP for Valleyview. This also enables support for multi-display configurations. Jesse, Ben : Since this patch set was reviewed in internal mailing lists, could you please add your reviewed-by & tested-by tags? B

[Intel-gfx] [PATCH 2/9] drm/i915: Fix SDVO IER and status bits for Valleyview

2012-09-26 Thread Vijay Purushothaman
Fixed SDVOB and SDVOC bit definitions for Valleyview. Signed-off-by: Vijay Purushothaman Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_irq.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c

[Intel-gfx] [PATCH 1/9] drm/i915: Set aux clk to 100MHz for Valleyview

2012-09-26 Thread Vijay Purushothaman
Set hrawclk to 200 MHz and aux divider clock to 100 MHz for Valleyview. This enables the aux transactions in Valleyview. Signed-off-by: Vijay Purushothaman Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/intel_dp.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH 3/9] drm/i915: Add Valleyview lane control definitions

2012-09-26 Thread Vijay Purushothaman
Added DPIO data lane register definitions for Valleyview Signed-off-by: Vijay Purushothaman Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_reg.h |8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index a828

[Intel-gfx] [PATCH 5/9] drm/i915: Fix lanecontrol, vswing, preemp for Valleyview DisplayPort

2012-09-26 Thread Vijay Purushothaman
In Valleyview voltage swing, pre-emphasis and lane control registers can be programmed only through the h/w side band fabric. Also use i9xx_update_pll to program the correct DPLL sequence. Signed-off-by: Vijay Purushothaman Signed-off-by: Gajanan Bhat Signed-off-by: Ben Widawsky --- drivers/gp

[Intel-gfx] [PATCH 4/9] drm/i915: Program correct m n tu register for Valleyview

2012-09-26 Thread Vijay Purushothaman
m n tu register offset has changed in Valleyview. Also fixed DP limit frequencies. Signed-off-by: Vijay Purushothaman Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/intel_display.c |6 +++--- drivers/gpu/drm/i915/intel_dp.c |5 + 2 files changed, 8 insertions(+), 3 deleti

[Intel-gfx] [PATCH 7/9] drm/i915: panel power sequencing for VLV eDP

2012-09-26 Thread Vijay Purushothaman
PPS register offsets have changed in Valleyview. Signed-off-by: Gajanan Bhat Signed-off-by: Vijay Purushothaman Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_reg.h |9 +++ drivers/gpu/drm/i915/intel_dp.c | 122 +++ 2 files changed, 93 insert

[Intel-gfx] [PATCH 6/9] drm/i915: Add eDP support for Valleyview

2012-09-26 Thread Vijay Purushothaman
Eventhough Valleyview display block is derived from Cantiga, VLV supports eDP. So, added eDP checks in i9xx_crtc_mode_set path. v2: use different DPIO_DIVISOR values for VGA, DP and eDP v3: fix DPIO value calculation to use same values for all display interfaces Signed-off-by: Gajanan Bha

[Intel-gfx] [PATCH 8/9] drm/i915: Reverse min, max vco limits for VLV HDMI

2012-09-26 Thread Vijay Purushothaman
Fixed min, max vco limits for VLV HDMI. Also fixed correct register offset for VLV_VIDEO_DIP_CTL_A Signed-off-by: Vijay Purushothaman Signed-off-by: Gajanan Bhat Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_reg.h |2 +- drivers/gpu/drm/i915/intel_display.c |2 +- 2 fi

[Intel-gfx] [PATCH 9/9] drm/i915: Enable multi display support in VLV

2012-09-26 Thread Vijay Purushothaman
From: "Bhat, Gajanan" Clened up DPLL calculations for Valleyview. Moved DPLL register and DPIO programming to vlv_update_pll function. With all the changes multi display (clone, extended desktop) should work for VLV. Signed-off-by: Gajanan Bhat --- drivers/gpu/drm/i915/i915_reg.h |8 +

[Intel-gfx] Question regarding libva encoding

2012-09-26 Thread Charlie Good
Hello my name is Charlie Good and I am the CTO of Wowza Media System. We are the authors of Wowza Media Server. Our product includes a transcoder for transcoding incoming streams to adaptive bitrate stream sets. We are only using the AVC/H.264 encoder at this time. We are looking to use libva fo

Re: [Intel-gfx] [PATCH 7/9] drm/i915: limit VLV IRQ enables to those we use

2012-09-26 Thread Daniel Vetter
On Wed, Sep 19, 2012 at 01:29:01PM -0700, Jesse Barnes wrote: > To match IVB. > > Signed-off-by: Jesse Barnes Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Fix lanecontrol, vswing, preemp for Valleyview DisplayPort

2012-09-26 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 07:07:34PM +0530, Vijay Purushothaman wrote: > In Valleyview voltage swing, pre-emphasis and lane control registers can > be programmed only through the h/w side band fabric. Also use > i9xx_update_pll to program the correct DPLL sequence. > > Signed-off-by: Vijay Purushoth

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Add eDP support for Valleyview

2012-09-26 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 07:07:35PM +0530, Vijay Purushothaman wrote: > Eventhough Valleyview display block is derived from Cantiga, VLV > supports eDP. So, added eDP checks in i9xx_crtc_mode_set path. > > v2: use different DPIO_DIVISOR values for VGA, DP and eDP > v3: fix DPIO value calculation to

Re: [Intel-gfx] [PATCH 7/9] drm/i915: panel power sequencing for VLV eDP

2012-09-26 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 07:07:36PM +0530, Vijay Purushothaman wrote: > PPS register offsets have changed in Valleyview. > > Signed-off-by: Gajanan Bhat > Signed-off-by: Vijay Purushothaman > Signed-off-by: Ben Widawsky I have a feeling that we need to add some panel power sequencer abstraction

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Reverse min, max vco limits for VLV HDMI

2012-09-26 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 07:07:37PM +0530, Vijay Purushothaman wrote: > Fixed min, max vco limits for VLV HDMI. Also fixed correct register > offset for VLV_VIDEO_DIP_CTL_A > > Signed-off-by: Vijay Purushothaman > Signed-off-by: Gajanan Bhat > Signed-off-by: Ben Widawsky Patch splitup bikeshed:

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Enable multi display support in VLV

2012-09-26 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 07:07:38PM +0530, Vijay Purushothaman wrote: > From: "Bhat, Gajanan" > > Clened up DPLL calculations for Valleyview. Moved DPLL register and DPIO > programming to vlv_update_pll function. With all the changes multi > display (clone, extended desktop) should work for VLV. >

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Add eDP support for Valleyview

2012-09-26 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 04:31:46PM +0200, Daniel Vetter wrote: > On Wed, Sep 26, 2012 at 07:07:35PM +0530, Vijay Purushothaman wrote: > > Eventhough Valleyview display block is derived from Cantiga, VLV > > supports eDP. So, added eDP checks in i9xx_crtc_mode_set path. > > > > v2: use different DP

[Intel-gfx] [PATCH] drm/i915: pass adjusted_mode instead of mode to intel_choose_pipe_bpp_dither

2012-09-26 Thread Jani Nikula
The dithering introduced in commit 3b5c78a35cf7511c15e09a9b0ffab290a42d9bcf Author: Adam Jackson Date: Tue Dec 13 15:41:00 2011 -0800 drm/i915/dp: Dither down to 6bpc if it makes the mode fit stores the INTEL_MODE_DP_FORCE_6BPC flag in the private_flags of the adjusted mode, while intel_c

Re: [Intel-gfx] [PATCH] drm/i915: pass adjusted_mode instead of mode to intel_choose_pipe_bpp_dither

2012-09-26 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 06:27:51PM +0300, Jani Nikula wrote: > The dithering introduced in > > commit 3b5c78a35cf7511c15e09a9b0ffab290a42d9bcf > Author: Adam Jackson > Date: Tue Dec 13 15:41:00 2011 -0800 > > drm/i915/dp: Dither down to 6bpc if it makes the mode fit > > stores the INTEL_M

[Intel-gfx] [PATCH] drm/i915: use adjusted_mode instead of mode for checking the 6bpc force flag

2012-09-26 Thread Jani Nikula
The dithering introduced in commit 3b5c78a35cf7511c15e09a9b0ffab290a42d9bcf Author: Adam Jackson Date: Tue Dec 13 15:41:00 2011 -0800 drm/i915/dp: Dither down to 6bpc if it makes the mode fit stores the INTEL_MODE_DP_FORCE_6BPC flag in the private_flags of the adjusted mode, while i9xx_cr

Re: [Intel-gfx] [PATCH] drm/i915: use adjusted_mode instead of mode for checking the 6bpc force flag

2012-09-26 Thread Adam Jackson
On Wed, 2012-09-26 at 18:43 +0300, Jani Nikula wrote: > The dithering introduced in > > commit 3b5c78a35cf7511c15e09a9b0ffab290a42d9bcf > Author: Adam Jackson > Date: Tue Dec 13 15:41:00 2011 -0800 > > drm/i915/dp: Dither down to 6bpc if it makes the mode fit > > stores the INTEL_MODE_DP_

[Intel-gfx] [PATCH] drm/i915: Try harder to complete DP training pattern 1

2012-09-26 Thread Chris Wilson
In commit cdb0e95bf571dccc1f75fef9bdad21b167ef0b37 Author: Keith Packard Date: Tue Nov 1 20:00:06 2011 -0700 drm/i915: Try harder during dp pattern 1 link training extra passes were made to retry the same voltage and then retry a full clock reset. However, as coverity pointed out, we never

[Intel-gfx] triple-buffering on Arrandale?

2012-09-26 Thread Charles G Waldman
Hi. I've got a Thinkpad X201 with Integrated Graphics Controller (rev 02), Intel(R) Arrandale running Gentoo Linux. The documentation mentions Option "TripleBuffer" "boolean" but when I try to use this to control triple-buffering, the Xorg.0.log shows (WW) intel(0): Option "TripleBuffe

[Intel-gfx] [PATCH] intel_infoframes: Dump HDMI vendor infoframes

2012-09-26 Thread Damien Lespiau
From: Damien Lespiau Those infoframes are programmed when using stereo 3D modes. Signed-off-by: Damien Lespiau --- tools/intel_infoframes.c | 63 +- 1 files changed, 62 insertions(+), 1 deletions(-) diff --git a/tools/intel_infoframes.c b/tools/in

[Intel-gfx] [PATCH 1/3] drm/i915: Extract PCU communication

2012-09-26 Thread Ben Widawsky
There is a special mechanism for communicating with the PCU already being used for the ring frequency stuff. As we'll be needing this for other commands, extract it now to make future code less error prone and the current code more reusable. I'm not entirely sure if this code matches 1:1 with the

[Intel-gfx] [PATCH 2/3] drm/i915: Workaround to bump rc6 voltage to 450

2012-09-26 Thread Ben Widawsky
BIOS should be setting the minimum voltage for rc6 to be 450mV. Old or buggy BIOSen may not be doing this, so we correct it for them. Ideally customers should update the BIOS as only it would know the optimal values for the platform, so we leave that fact as a DRM_ERROR for the user to see. Unfort

[Intel-gfx] [PATCH 3/3] drm/i915: Add rc6vids to debugfs

2012-09-26 Thread Ben Widawsky
CC: Jesse Barnes Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_debugfs.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 6647585..3c5710f 100644 --- a/drivers/gpu/drm/i915/i91

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Workaround to bump rc6 voltage to 450

2012-09-26 Thread Matt Turner
On Wed, Sep 26, 2012 at 10:34 AM, Ben Widawsky wrote: > BIOS should be setting the minimum voltage for rc6 to be 450mV. Old or > buggy BIOSen may not be doing this, so we correct it for them. Ideally > customers should update the BIOS as only it would know the optimal > values for the platform, so

Re: [Intel-gfx] [RFC] [PATCH] quick_dump: A dump utility different than reg_dumper

2012-09-26 Thread Ben Widawsky
On Wed, 26 Sep 2012 13:51:01 +0200 Daniel Vetter wrote: > On Sat, Sep 22, 2012 at 01:58:37PM -0700, Ben Widawsky wrote: > > On 2012-09-22 11:05, Daniel Vetter wrote: > > >And a quick comment on your approach here: I'm not too sure > > >whether the > > >file-base register block approach scales, re

Re: [Intel-gfx] [PATCH] intel_infoframes: Dump HDMI vendor infoframes

2012-09-26 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Wed, Sep 26, 2012 at 2:17 PM, Damien Lespiau wrote: > From: Damien Lespiau > > Those infoframes are programmed when using stereo 3D modes. > > Signed-off-by: Damien Lespiau > --- > tools/intel_infoframes.c | 63 > +- >

[Intel-gfx] [PATCH] drm/i915: Fix set_caching locking

2012-09-26 Thread Ben Widawsky
On the EINVAL case we don't release struct_mutex. It should be safe to grab the lock after checking the parameters, which also resolves the issues. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_gem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/

Re: [Intel-gfx] Question regarding libva encoding

2012-09-26 Thread Xiang, Haihao
The support for Main/High profile has been done in the staging branch. We will merge the interfaces for Main/High profile back into the master branch. Thanks Haihao > Hello my name is Charlie Good and I am the CTO of Wowza Media System. > We are the authors of Wowza Media Server. Our product in

Re: [Intel-gfx] assertion on intel_disable_transcoder

2012-09-26 Thread Wang, Xingchao
Hi Ben, I have no idea about the resolution, maybe Paulo and Daniel know more details? Thanks --xingchao From: ben.gut...@gmail.com [mailto:ben.gut...@gmail.com] On Behalf Of Ben Guthro Sent: Wednesday, September 26, 2012 4:43 AM To: Wang, Xingchao Cc: intel-gfx@lists.freedesktop.org; Zanoni, Pa

Re: [Intel-gfx] assertion on intel_disable_transcoder

2012-09-26 Thread Daniel Vetter
On Thu, Sep 27, 2012 at 06:32:06AM +, Wang, Xingchao wrote: > Hi Ben, > > I have no idea about the resolution, maybe Paulo and Daniel know more details? Oh, it's just an older assert for pre-hsw that we haven't properly disabled yet. Since this code will change quite a bit with Paulo's new wa

Re: [Intel-gfx] [PATCH] drm/i915: use adjusted_mode instead of mode for checking the 6bpc force flag

2012-09-26 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 11:50:36AM -0400, Adam Jackson wrote: > On Wed, 2012-09-26 at 18:43 +0300, Jani Nikula wrote: > > The dithering introduced in > > > > commit 3b5c78a35cf7511c15e09a9b0ffab290a42d9bcf > > Author: Adam Jackson > > Date: Tue Dec 13 15:41:00 2011 -0800 > > > > drm/i915/d

Re: [Intel-gfx] [PATCH] intel_infoframes: Dump HDMI vendor infoframes

2012-09-26 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 08:01:09PM -0300, Rodrigo Vivi wrote: > Reviewed-by: Rodrigo Vivi > > On Wed, Sep 26, 2012 at 2:17 PM, Damien Lespiau > wrote: > > From: Damien Lespiau > > > > Those infoframes are programmed when using stereo 3D modes. > > > > Signed-off-by: Damien Lespiau Applied, tha

Re: [Intel-gfx] [PATCH] drm/i915: Fix set_caching locking

2012-09-26 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 04:15:20PM -0700, Ben Widawsky wrote: > On the EINVAL case we don't release struct_mutex. It should be safe to > grab the lock after checking the parameters, which also resolves the > issues. > > Signed-off-by: Ben Widawsky Nice catch, thanks for the patch, applied to fix