Re: [Intel-gfx] [PATCH 1/2] drm: Add Panel Self Refresh DP addresses

2011-10-03 Thread Ben Widawsky
On Mon, Oct 03, 2011 at 04:31:22PM -0700, Keith Packard wrote: > On Mon, 3 Oct 2011 15:14:14 -0700, Ben Widawsky wrote: > > > +# define DP_PSR_SUPPORTED 1 > > That's PSR version 1, not just a simple boolean Ok. > > > +# define DP_PSR_SETUP_TIME_330 (0 << 1) > >

Re: [Intel-gfx] [PATCH 1/2] drm: Add Panel Self Refresh DP addresses

2011-10-03 Thread Keith Packard
On Mon, 3 Oct 2011 15:14:14 -0700, Ben Widawsky wrote: > +# define DP_PSR_SUPPORTED 1 That's PSR version 1, not just a simple boolean > +# define DP_PSR_SETUP_TIME_330 (0 << 1) > +# define DP_PSR_SETUP_TIME_275 (1 << 1) > +# define DP_PSR_SETUP_TIME_2

Re: [Intel-gfx] [PATCH 1/2] drm: Add Panel Self Refresh DP addresses

2011-10-03 Thread Ben Widawsky
On Mon, Oct 03, 2011 at 02:25:39PM -0700, Keith Packard wrote: > On Tue, 20 Sep 2011 15:29:47 -0700, Ben Widawsky wrote: > > > Add the addresses and definitions I care about for Panel Self Refresh, as > > documented in the eDP spec. > > I generally review the addresses and bit definitions for an

Re: [Intel-gfx] [PATCH 1/2] drm: Add Panel Self Refresh DP addresses

2011-10-03 Thread Keith Packard
On Tue, 20 Sep 2011 15:29:47 -0700, Ben Widawsky wrote: > Add the addresses and definitions I care about for Panel Self Refresh, as > documented in the eDP spec. I generally review the addresses and bit definitions for any new registers -- getting them wrong makes debugging the code really hard.

[Intel-gfx] [PATCH 1/2] drm: Add Panel Self Refresh DP addresses

2011-09-20 Thread Ben Widawsky
Add the addresses and definitions I care about for Panel Self Refresh, as documented in the eDP spec. I'm sending these out before some other patches because this should be a fairly simple one to get upstream and not require too much fuss (where the others may have some fuss). This file is a mess