On Mon, Oct 03, 2011 at 04:31:22PM -0700, Keith Packard wrote: > On Mon, 3 Oct 2011 15:14:14 -0700, Ben Widawsky <b...@bwidawsk.net> wrote: > > > +# define DP_PSR_SUPPORTED 1 > > That's PSR version 1, not just a simple boolean
Ok. > > > +# define DP_PSR_SETUP_TIME_330 (0 << 1) > > +# define DP_PSR_SETUP_TIME_275 (1 << 1) > > +# define DP_PSR_SETUP_TIME_220 (2 << 1) > > +# define DP_PSR_SETUP_TIME_165 (3 << 1) > > +# define DP_PSR_SETUP_TIME_110 (4 << 1) > > +# define DP_PSR_SETUP_TIME_55 (5 << 1) > > +# define DP_PSR_SETUP_TIME_0 (6 << 1) > > Need a DP_PSR_SETUP_TIME_MASK to indicate which bits are relevant here Ok. > > > +# define DP_PSR_MAIN_LIKE_ACTIVE (1 << 1) > > LINK, I assume Yes > > > > +# define DP_PSR_SINK_INACTIVE (1 << 0) > > +# define DP_PSR_SINK_ACTIVE_SRC_SYNCED (1 << 1) > > +# define DP_PSR_SINK_ACTIVE_RFB (1 << 2) > > +# define DP_PSR_SINK_ACTIVE_SINK_SYNCED (1 << 3) > > +# define DP_PSR_SINK_ACTIVE_RESYNC (1 << 4) > > +# define DP_PSR_SINK_INTERNAL_ERROR (1 << 7) > > These are all wrong. Bits 2:0 are a 3 bit field. That's really odd. Not sure how I screwed that up so badly. Good catch. I guess you'll want a mask here too then. Ben
pgpNfduNPwmk3.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
