Re: [Intel-gfx] [PATCH] drm/i915: Fix KMS regression on Sandybridge/CPT

2010-11-04 Thread Chris Wilson
On Thu, 4 Nov 2010 13:50:24 +0800, Zhenyu Wang wrote: > Chris, I try to retest your changed version on drm-intel-staging. > It looks things work fine now with that. ;) > > Sorry that I'm not quite sure why my last test failed...please pick that > one to -fixes, so QA team could pick it up for val

Re: [Intel-gfx] [PATCH] drm/i915: Fix KMS regression on Sandybridge/CPT

2010-11-03 Thread Zhenyu Wang
On 2010.11.04 13:50:24 +0800, Zhenyu Wang wrote: > On 2010.11.04 02:23:46 +, Chris Wilson wrote: > > On Tue, 2 Nov 2010 14:24:22 +0800, Zhenyu Wang > > wrote: > > > I don't think transcoder bpc setting should matter, but sorry that I'm > > > short > > > of time to track down which one extra

Re: [Intel-gfx] [PATCH] drm/i915: Fix KMS regression on Sandybridge/CPT

2010-11-03 Thread Chris Wilson
On Tue, 2 Nov 2010 14:24:22 +0800, Zhenyu Wang wrote: > I don't think transcoder bpc setting should matter, but sorry that I'm short > of time to track down which one extra read made the difference, my sandybridge > laptop normally refuse to boot on first time.. ;) > > The code operation is same

Re: [Intel-gfx] [PATCH] drm/i915: Fix KMS regression on Sandybridge/CPT

2010-11-01 Thread Zhenyu Wang
On 2010.10.29 09:52:31 +0100, Chris Wilson wrote: > On Fri, 29 Oct 2010 10:34:51 +0800, Zhenyu Wang > wrote: > > On 2010.10.28 10:50:04 +0100, Chris Wilson wrote: > > > I've shrunk the patch to just the FDI portion, pushed to staging for > > > review. > > > > Current drm-intel-staging still fai

Re: [Intel-gfx] [PATCH] drm/i915: Fix KMS regression on Sandybridge/CPT

2010-10-29 Thread Chris Wilson
On Fri, 29 Oct 2010 10:34:51 +0800, Zhenyu Wang wrote: > On 2010.10.28 10:50:04 +0100, Chris Wilson wrote: > > I've shrunk the patch to just the FDI portion, pushed to staging for > > review. > > Current drm-intel-staging still fails unfortunately.. I'm very interested to know which was the mag

Re: [Intel-gfx] [PATCH] drm/i915: Fix KMS regression on Sandybridge/CPT

2010-10-28 Thread Zhenyu Wang
On 2010.10.28 10:50:04 +0100, Chris Wilson wrote: > > The POSTING_READs you added are no-ops since they are all followed by a > read. The transconf should have the bpc in the register at this point or > else we should have bugged much earlier. The break-exec-wait condition is > still documented fo

Re: [Intel-gfx] [PATCH] drm/i915: Fix KMS regression on Sandybridge/CPT

2010-10-28 Thread Chris Wilson
On Thu, 28 Oct 2010 16:38:08 +0800, Zhenyu Wang wrote: > We should enable FDI normal training on Sandybridge/CPT system > as well. Also restore back some original register posting read > that got removed. LVDS/VGA/HDMI seems back to life but DP still > fails. The POSTING_READs you added are no-op

[Intel-gfx] [PATCH] drm/i915: Fix KMS regression on Sandybridge/CPT

2010-10-28 Thread Zhenyu Wang
We should enable FDI normal training on Sandybridge/CPT system as well. Also restore back some original register posting read that got removed. LVDS/VGA/HDMI seems back to life but DP still fails. Signed-off-by: Zhenyu Wang --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915/