Re: [Intel-gfx] [PATCH] drm/i915/vlv: reset DPIO on load and resume v2

2013-10-04 Thread Daniel Vetter
On Thu, Oct 03, 2013 at 10:18:56PM +0300, Ville Syrjälä wrote: > On Thu, Oct 03, 2013 at 11:35:46AM -0700, Jesse Barnes wrote: > > DPIO needs to have common reset de-asserted on soft resets like boot and > > S3. In some cases, the BIOS will have done this for us, but it should > > be safe to do at

Re: [Intel-gfx] [PATCH] drm/i915/vlv: reset DPIO on load and resume v2

2013-10-03 Thread Ville Syrjälä
On Thu, Oct 03, 2013 at 11:35:46AM -0700, Jesse Barnes wrote: > DPIO needs to have common reset de-asserted on soft resets like boot and > S3. In some cases, the BIOS will have done this for us, but it should > be safe to do at runtime as well, as long as we do it when the pipes are > otherwise of

[Intel-gfx] [PATCH] drm/i915/vlv: reset DPIO on load and resume v2

2013-10-03 Thread Jesse Barnes
DPIO needs to have common reset de-asserted on soft resets like boot and S3. In some cases, the BIOS will have done this for us, but it should be safe to do at runtime as well, as long as we do it when the pipes are otherwise off. v2: update bit name to match docs better (Ville) reset after C

Re: [Intel-gfx] [PATCH] drm/i915/vlv: reset DPIO on load and resume

2013-10-03 Thread Jesse Barnes
On Thu, 3 Oct 2013 19:38:26 +0300 Ville Syrjälä wrote: > On Fri, Sep 27, 2013 at 12:34:31PM +0300, Ville Syrjälä wrote: > > On Thu, Sep 26, 2013 at 02:39:14PM -0700, Jesse Barnes wrote: > > > This fixes resume on my test platform, since I think some DPIO bits need > > > recalibration. > > > > >

Re: [Intel-gfx] [PATCH] drm/i915/vlv: reset DPIO on load and resume

2013-10-03 Thread Ville Syrjälä
On Fri, Sep 27, 2013 at 12:34:31PM +0300, Ville Syrjälä wrote: > On Thu, Sep 26, 2013 at 02:39:14PM -0700, Jesse Barnes wrote: > > This fixes resume on my test platform, since I think some DPIO bits need > > recalibration. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=69166 > >

Re: [Intel-gfx] [PATCH] drm/i915/vlv: reset DPIO on load and resume

2013-09-27 Thread Ville Syrjälä
On Thu, Sep 26, 2013 at 02:39:14PM -0700, Jesse Barnes wrote: > This fixes resume on my test platform, since I think some DPIO bits need > recalibration. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=69166 > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_display.c

Re: [Intel-gfx] [PATCH] drm/i915/vlv: reset DPIO on load and resume

2013-09-26 Thread Lee, Chon Ming
On 09/26 14:58, Jesse Barnes wrote: > On Thu, 26 Sep 2013 23:51:52 +0200 > Daniel Vetter wrote: > > > On Thu, Sep 26, 2013 at 02:39:14PM -0700, Jesse Barnes wrote: > > > This fixes resume on my test platform, since I think some DPIO bits need > > > recalibration. > > > > > > References: https://

Re: [Intel-gfx] [PATCH] drm/i915/vlv: reset DPIO on load and resume

2013-09-26 Thread Jesse Barnes
On Thu, 26 Sep 2013 23:51:52 +0200 Daniel Vetter wrote: > On Thu, Sep 26, 2013 at 02:39:14PM -0700, Jesse Barnes wrote: > > This fixes resume on my test platform, since I think some DPIO bits need > > recalibration. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=69166 > > Signe

Re: [Intel-gfx] [PATCH] drm/i915/vlv: reset DPIO on load and resume

2013-09-26 Thread Daniel Vetter
On Thu, Sep 26, 2013 at 02:39:14PM -0700, Jesse Barnes wrote: > This fixes resume on my test platform, since I think some DPIO bits need > recalibration. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=69166 > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH] drm/i915/vlv: reset DPIO on load and resume

2013-09-26 Thread Jesse Barnes
This fixes resume on my test platform, since I think some DPIO bits need recalibration. References: https://bugs.freedesktop.org/show_bug.cgi?id=69166 Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/g