Re: [PATCH] drm/i915: Increase I915_PARAM_MMAP_GTT_VERSION version to indicate support for partial mmaps

2025-03-07 Thread Nirmoy Das
On 3/6/2025 10:08 PM, José Roberto de Souza wrote: > Commit 255fc1703e42 ("drm/i915/gem: Calculate object page offset for partial > memory mapping") > was the last patch of several patches fixing multiple partial mmaps. > But without a bump in I915_PARAM_MMAP_GTT_VERSION there is no clean > way

✗ i915.CI.BAT: failure for drm/i915: Increase I915_PARAM_MMAP_GTT_VERSION version to indicate support for partial mmaps (rev4)

2025-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Increase I915_PARAM_MMAP_GTT_VERSION version to indicate support for partial mmaps (rev4) URL : https://patchwork.freedesktop.org/series/145945/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16246 -> Patchwork_145945v4 ==

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Increase I915_PARAM_MMAP_GTT_VERSION version to indicate support for partial mmaps (rev4)

2025-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Increase I915_PARAM_MMAP_GTT_VERSION version to indicate support for partial mmaps (rev4) URL : https://patchwork.freedesktop.org/series/145945/ State : warning == Summary == Error: dim checkpatch failed e4a5570cfc5d drm/i915: Increase I915_PARAM_MMAP_GT

✗ i915.CI.BAT: failure for drm/i915: Increase I915_PARAM_MMAP_GTT_VERSION version to indicate support for partial mmaps (rev3)

2025-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Increase I915_PARAM_MMAP_GTT_VERSION version to indicate support for partial mmaps (rev3) URL : https://patchwork.freedesktop.org/series/145945/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16246 -> Patchwork_145945v3 ==

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Increase I915_PARAM_MMAP_GTT_VERSION version to indicate support for partial mmaps (rev3)

2025-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Increase I915_PARAM_MMAP_GTT_VERSION version to indicate support for partial mmaps (rev3) URL : https://patchwork.freedesktop.org/series/145945/ State : warning == Summary == Error: dim checkpatch failed c832f4990539 drm/i915: Increase I915_PARAM_MMAP_GT

Re: [PATCH v6 2/7] bits: introduce fixed-type genmasks

2025-03-07 Thread Andy Shevchenko
On Sat, Mar 08, 2025 at 01:48:49AM +0900, Vincent Mailhol via B4 Relay wrote: > From: Yury Norov > > Add GENMASK_TYPE() which generalizes __GENMASK() to support different > types, and implement fixed-types versions of GENMASK() based on it. > The fixed-type version allows more strict checks to th

Re: [PATCH RFC v3 4/7] drm/display: dp-aux-dev: use new DCPD access helpers

2025-03-07 Thread Dmitry Baryshkov
On Fri, Mar 07, 2025 at 05:53:38PM -0500, Lyude Paul wrote: > I thought we had agreed that drm_dp_aux_dev.c was one of the few places where > we wanted to keep using the old functions here? Hmm, I thought I dropped it. > > On Fri, 2025-03-07 at 06:34 +0200, Dmitry Baryshkov wrote: > > From: Dmit

Re: [PATCH RFC v3 4/7] drm/display: dp-aux-dev: use new DCPD access helpers

2025-03-07 Thread Lyude Paul
I thought we had agreed that drm_dp_aux_dev.c was one of the few places where we wanted to keep using the old functions here? On Fri, 2025-03-07 at 06:34 +0200, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > Switch drm_dp_aux_dev.c to use new set of DPCD read / write helpers. > > Acked-by

✓ i915.CI.BAT: success for drm/i915: sagv/bw cleanup (rev2)

2025-03-07 Thread Patchwork
== Series Details == Series: drm/i915: sagv/bw cleanup (rev2) URL : https://patchwork.freedesktop.org/series/146014/ State : success == Summary == CI Bug Log - changes from CI_DRM_16246 -> Patchwork_146014v2 Summary --- **SUCCESS**

Re: [PATCH v6 0/7] bits: Fixed-type GENMASK_U*() and BIT_U*()

2025-03-07 Thread Yury Norov
On Fri, Mar 07, 2025 at 07:43:57PM +0200, Andy Shevchenko wrote: > On Fri, Mar 07, 2025 at 12:18:02PM -0500, Yury Norov wrote: > > No rush, please allow your reviewers a week or two before submitting > > a new iteration unless you want to disregard the previous version for > > some reason, of cours

✗ Fi.CI.CHECKPATCH: warning for drm/i915: sagv/bw cleanup (rev2)

2025-03-07 Thread Patchwork
== Series Details == Series: drm/i915: sagv/bw cleanup (rev2) URL : https://patchwork.freedesktop.org/series/146014/ State : warning == Summary == Error: dim checkpatch failed c73c696466a4 drm/i915: Drop the cached per-pipe min_cdclk[] from bw state 4d25dd1d8209 drm/i915: s/intel_crtc_bw/intel

Re: ✗ i915.CI.Full: failure for drm/i915: Fix harmfull driver register/unregister assymetry (rev4)

2025-03-07 Thread Janusz Krzysztofik
Hi i915-ci-in...@lists.freedesktop.org, On Thursday, 6 March 2025 03:08:57 CET Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix harmfull driver register/unregister assymetry (rev4) > URL : https://patchwork.freedesktop.org/series/144436/ > State : failure > > == Summary == >

Re: [PATCH RFC v3 2/7] drm/display: dp: change drm_dp_dpcd_read_link_status() return value

2025-03-07 Thread Lyude Paul
Reviewed-by: Lyude Paul On Fri, 2025-03-07 at 06:34 +0200, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > drm_dp_dpcd_read_link_status() follows the "return error code or number > of bytes read" protocol, with the code returning less bytes than > requested in case of some errors. However

Re: [PATCH RFC v3 1/7] drm/display: dp: implement new access helpers

2025-03-07 Thread Lyude Paul
A few tiny nitpicks below, but with those addressed: Reviewed-by: Lyude Paul On Fri, 2025-03-07 at 06:34 +0200, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > Existing DPCD access functions return an error code or the number of > bytes being read / write in case of partial access. Howeve

[PATCH 05/14] drm/i915: Avoid triggering unwanted cdclk changes due to dbuf bandwidth changes

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä Currently intel_bw_calc_min_cdclk() always adds the bw_state to the atomic state. Not only does it result in potentially redundant work later, it's also currently causing unwanted cdclk changes during driver load. Check if the dbuf bw is actually changing before we decide to

Re: [PATCH v6 3/7] bits: introduce fixed-type BIT_U*()

2025-03-07 Thread Andy Shevchenko
On Fri, Mar 07, 2025 at 07:48:01PM +0200, Andy Shevchenko wrote: > On Sat, Mar 08, 2025 at 01:48:50AM +0900, Vincent Mailhol via B4 Relay wrote: ... > > /* > > * Missing asm support > > * > > - * GENMASK_U*() depends on BITS_PER_TYPE() which relies on sizeof(), > > - * something not availabl

✗ i915.CI.BAT: failure for drm/i915/xe3lpd: Update bandwidth parameters (rev3)

2025-03-07 Thread Patchwork
== Series Details == Series: drm/i915/xe3lpd: Update bandwidth parameters (rev3) URL : https://patchwork.freedesktop.org/series/11/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16246 -> Patchwork_11v3 Summary -

✗ Fi.CI.SPARSE: warning for drm/i915/xe3lpd: Update bandwidth parameters (rev3)

2025-03-07 Thread Patchwork
== Series Details == Series: drm/i915/xe3lpd: Update bandwidth parameters (rev3) URL : https://patchwork.freedesktop.org/series/11/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm

✓ i915.CI.BAT: success for drm/dp_mst: Fix locking when skipping CSN before topology probing

2025-03-07 Thread Patchwork
== Series Details == Series: drm/dp_mst: Fix locking when skipping CSN before topology probing URL : https://patchwork.freedesktop.org/series/146019/ State : success == Summary == CI Bug Log - changes from CI_DRM_16246 -> Patchwork_146019v1

✗ i915.CI.BAT: failure for drm/i915: sagv/bw cleanup

2025-03-07 Thread Patchwork
== Series Details == Series: drm/i915: sagv/bw cleanup URL : https://patchwork.freedesktop.org/series/146014/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16246 -> Patchwork_146014v1 Summary --- **FAILURE** Serio

Re: [PATCH v6 3/7] bits: introduce fixed-type BIT_U*()

2025-03-07 Thread Andy Shevchenko
On Sat, Mar 08, 2025 at 01:48:50AM +0900, Vincent Mailhol via B4 Relay wrote: > From: Lucas De Marchi > > Implement fixed-type BIT_U*() to help drivers add stricter checks, > like it was done for GENMASK_U*(). ... > /* > * Missing asm support > * > - * GENMASK_U*() depends on BITS_PER_TYPE

[PATCH v3 3/3] drm/i915/xe3lpd: Update bandwidth parameters

2025-03-07 Thread Gustavo Sousa
Bandwidth parameters for Xe3_LPD have been updated with respect to previous display releases. Encode them into xe3lpd_sa_info and use that new struct. Bspec: 68859 Reviewed-by: Matt Roper Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/display/intel_bw.c | 11 ++- 1 file changed,

[PATCH v3 2/3] drm/i915/display: Convert intel_bw.c externally to intel_display

2025-03-07 Thread Gustavo Sousa
We already have internal interface for intel_bw.c converted to use intel_display. Now convert the external interface as well. Cc: Ville Syrjälä Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/display/intel_bw.c| 25 +- drivers/gpu/drm/i915/display/intel_bw.

[PATCH v3 1/3] drm/i915/display: Convert intel_bw.c internally to intel_display

2025-03-07 Thread Gustavo Sousa
Update intel_bw.c internally use intel_display. Conversion of the public interface will come as a follow-up. Cc: Ville Syrjälä Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/display/intel_bw.c | 416 +--- 1 file changed, 217 insertions(+), 199 deletions(-) di

[PATCH v3 0/3] drm/i915/xe3lpd: Update bandwidth parameters

2025-03-07 Thread Gustavo Sousa
Bandwidth parameters for Xe3_LPD have been updated with respect to previous display releases. Encode them into xe3lpd_sa_info and use that new struct. Since we are touching intel_bw.c, also take the opportunity convert it to intel_display. Changes in v2: - Fix typo in patch #2. Changes in v3:

✗ Fi.CI.CHECKPATCH: warning for drm/i915: sagv/bw cleanup

2025-03-07 Thread Patchwork
== Series Details == Series: drm/i915: sagv/bw cleanup URL : https://patchwork.freedesktop.org/series/146014/ State : warning == Summary == Error: dim checkpatch failed a5fb29a33b44 drm/i915: Drop the cached per-pipe min_cdclk[] from bw state 57ad45e27d59 drm/i915: s/intel_crtc_bw/intel_dbuf_b

Re: [PULL] drm-xe-next

2025-03-07 Thread Lucas De Marchi
On Fri, Mar 07, 2025 at 08:51:03AM -0600, Lucas De Marchi wrote: On Fri, Mar 07, 2025 at 02:02:15AM -0600, Lucas De Marchi wrote: Hi Dave and Sima, Last drm-xe-next pull request for 6.15. It comes with some big features that we have been working on for some time: EU stall sampling and SVM. The

Re: [PATCH v6 0/7] bits: Fixed-type GENMASK_U*() and BIT_U*()

2025-03-07 Thread Andy Shevchenko
On Fri, Mar 07, 2025 at 12:18:02PM -0500, Yury Norov wrote: > No rush, please allow your reviewers a week or two before submitting > a new iteration unless you want to disregard the previous version for > some reason, of course. This will not get into the upcoming merge > window, anyways. > > So,

[PATCH 10/14] drm/i915: Extract intel_bw_check_sagv_mask()

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä Move the bw_state->pipe_sagv_reject computation into intel_bw.c where it belongs. Previously we had a complicated dance between watermarks and sagv which required this to be computed earlier, but that was changed in commit 5e8146251f7b ("extract intel_bw_check_sagv_mask()") w

[PATCH 11/14] drm/i915: Make intel_bw_check_sagv_mask() internal to intel_bw.c

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä The only thing between the current intel_bw_check_sagv_mask() call site and intel_bw_atomic_check() is skl_wm_add_affected_planes() which no longer depends on the sagv mask, so we can make life a lot less confusing by calling intel_bw_check_sagv_mask() from intel_bw_atomic_che

[PATCH 02/14] drm/i915: s/intel_crtc_bw/intel_dbuf_bw/

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä Rename the intel_crtc_bw struct to intel_dbuf_bw to better reflect what it does. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bw.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/disp

[PATCH] drm/dp_mst: Fix locking when skipping CSN before topology probing

2025-03-07 Thread Imre Deak
The handling of the MST Connection Status Notify message is skipped if the probing of the topology is still pending. Acquiring the drm_dp_mst_topology_mgr::probe_lock for this in drm_dp_mst_handle_up_req() is problematic: the task/work this function is called from is also responsible for handling M

[PATCH 14/14] drm/i915: Eliminate intel_compute_sagv_mask()

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä intel_compute_sagv_mask() has become pointless. Just inline its contents into the existing loop in skl_compute_wm(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/skl_watermark.c | 64 1 file changed, 24 insertions(+), 40 deletions(-) d

[PATCH 09/14] drm/i915: Extract intel_bw_modeset_checks()

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä Pull the new_bw_state->active_pipes computation out from intel_compute_sagv_mask() and move it into the intel_bw.c (which is arguably the correct place for it). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bw.c | 29 drivers/

[PATCH 13/14] drm/i915: Skip bw stuff if per-crtc sagv state doesn't change

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä If there are no changes to intel_crtc_can_enable_sagv() there is no need to do all the sagv bw_state recomputation. The only slight caveat here is hw state takeover where we initially disable SAGV, and want it to get re-enabled once we've determined that it's safe to do so.

[PATCH 12/14] drm/i915: Make intel_bw_modeset_checks() internal to intel_bw_atomic_check()

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä Now that all the sagv computation has been moved from the skl+ watermark code into intel_bw_atomic_check() there is no point in calling intel_bw_modeset_checks() before the wm computation. Hide it within intel_bw_atomic_check(). Signed-off-by: Ville Syrjälä --- drivers/gpu/

[PATCH 06/14] drm/i915: Do more bw readout

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä Update a bunch of bw related stuff during readout: - bw_state->dbuf_bw possible now that the wm readout has given us access to the plane ddb data - cdclk_state->bw_min_cdclk Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bw.c| 3 +++ drivers/gpu/d

[PATCH 07/14] drm/i915: Flag even inactive crtcs as "inherited"

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä I want to use the crtc_state->inherited flag to clean up some of the early SAGV handling. To make that work nicely I need to flag even the inactive crtcs as "inherited". Since we can't expect user space to perform any real commits on inactive crtcs we'll clear the flag alread

[PATCH 08/14] drm/i915: Drop force_check_qgv

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä Remove the force_check_qgv flag and just fill the pipe_sagv_reject bitmask properly during readout. This will cause the initial commit to re-enable SAGV if possible. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bw.c | 12 ++-- drivers/gpu/drm/

[PATCH 03/14] drm/i915: Extract intel_dbuf_bw_changed()

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä Extract the struct intel_dbuf_bw comparison into a small helper. We'll get more users later. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bw.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 04/14] drm/i915: Pass intel_dbuf_bw to skl_*_calc_dbuf_bw() explicitly

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä Make skl_*_calc_dbuf_bw() a bit lower level passing in the to be mutated dbuf_bw struct in explicitly. This will allow more reuse later. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bw.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions

[PATCH 01/14] drm/i915: Drop the cached per-pipe min_cdclk[] from bw state

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä intel_bw_crtc_min_cdclk() only depends on the pipe data rate, which we already have stashed in bw_state->data_rate[]. So stashing the resulting min_cdclk[] as well is redundant. Get rid of it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bw.c | 17 +++

[PATCH 00/14] drm/i915: sagv/bw cleanup

2025-03-07 Thread Ville Syrjala
From: Ville Syrjälä Continue improving the code around sagv/bw vs. watermarks. A lot of the details get better encapsulated within intel_bw.c and the complicated interactions between different parts of the code are somewhat reduced. Ville Syrjälä (14): drm/i915: Drop the cached per-pipe min_c

Re: [PATCH v6 4/7] drm/i915: Convert REG_GENMASK*() to fixed-width GENMASK_U*()

2025-03-07 Thread Andy Shevchenko
On Sat, Mar 08, 2025 at 01:48:51AM +0900, Vincent Mailhol via B4 Relay wrote: > From: Lucas De Marchi > > Now that include/linux/bits.h implements fixed-width GENMASK_U*(), use > them to implement the i915/xe specific macros. Converting each driver > to use the generic macros are left for later,

Re: [PATCH v6 0/7] bits: Fixed-type GENMASK_U*() and BIT_U*()

2025-03-07 Thread Andy Shevchenko
On Fri, Mar 07, 2025 at 12:48:36PM -0500, Yury Norov wrote: > On Fri, Mar 07, 2025 at 07:43:57PM +0200, Andy Shevchenko wrote: > > On Fri, Mar 07, 2025 at 12:18:02PM -0500, Yury Norov wrote: > > > No rush, please allow your reviewers a week or two before submitting > > > a new iteration unless you

✗ i915.CI.BAT: failure for drm/i915: Increase I915_PARAM_MMAP_GTT_VERSION version to indicate support for partial mmaps (rev2)

2025-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Increase I915_PARAM_MMAP_GTT_VERSION version to indicate support for partial mmaps (rev2) URL : https://patchwork.freedesktop.org/series/145945/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16245 -> Patchwork_145945v2 ==

Re: [PATCH v6 1/7] bits: split the definition of the asm and non-asm GENMASK()

2025-03-07 Thread Andy Shevchenko
On Sat, Mar 08, 2025 at 01:48:48AM +0900, Vincent Mailhol via B4 Relay wrote: > From: Vincent Mailhol > > In an upcoming change, GENMASK() and its friends will indirectly > depend on sizeof() which is not available in asm. > > Instead of adding further complexity to __GENMASK() to make it work >

Re: [PATCH v6 0/7] bits: Fixed-type GENMASK_U*() and BIT_U*()

2025-03-07 Thread Yury Norov
No rush, please allow your reviewers a week or two before submitting a new iteration unless you want to disregard the previous version for some reason, of course. This will not get into the upcoming merge window, anyways. So, what should I do? Go through the v5 and all discussions in there, or jus

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Increase I915_PARAM_MMAP_GTT_VERSION version to indicate support for partial mmaps (rev2)

2025-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Increase I915_PARAM_MMAP_GTT_VERSION version to indicate support for partial mmaps (rev2) URL : https://patchwork.freedesktop.org/series/145945/ State : warning == Summary == Error: dim checkpatch failed 9631f5af88ec drm/i915: Increase I915_PARAM_MMAP_GT

✓ i915.CI.BAT: success for drm/display: dp: add new DPCD access functions

2025-03-07 Thread Patchwork
== Series Details == Series: drm/display: dp: add new DPCD access functions URL : https://patchwork.freedesktop.org/series/145998/ State : success == Summary == CI Bug Log - changes from CI_DRM_16245 -> Patchwork_145998v1 Summary ---

Re: [PATCH v5 1/7] bits: split the definition of the asm and non-asm GENMASK()

2025-03-07 Thread David Laight
On Fri, 7 Mar 2025 18:58:08 +0900 Vincent Mailhol wrote: > On 07/03/2025 at 04:23, David Laight wrote: > > On Thu, 06 Mar 2025 20:29:52 +0900 > > Vincent Mailhol via B4 Relay > > wrote: > > > >> From: Vincent Mailhol > >> > >> In an upcoming change, GENMASK() and its friends will indirectly

Re: [PATCH v4 1/8] bits: fix typo 'unsigned __init128' -> 'unsigned __int128'

2025-03-07 Thread Yury Norov
On Wed, Mar 05, 2025 at 04:36:12PM +0200, Andy Shevchenko wrote: > On Wed, Mar 05, 2025 at 09:30:20AM -0500, Yury Norov wrote: > > On Wed, Mar 05, 2025 at 10:00:13PM +0900, Vincent Mailhol via B4 Relay > > wrote: > > > From: Vincent Mailhol > > > > > > "int" was misspelled as "init" in GENMASK_U

Re: [PATCH v5 7/7] test_bits: add tests for BIT_U*()

2025-03-07 Thread Vincent Mailhol
On 08/03/2025 at 01:07, Andy Shevchenko wrote: > On Fri, Mar 07, 2025 at 07:11:42PM +0900, Vincent Mailhol wrote: >> On 07/03/2025 at 02:55, Andy Shevchenko wrote: >>> On Fri, Mar 07, 2025 at 01:08:15AM +0900, Vincent Mailhol wrote: On 06/03/2025 at 22:11, Andy Shevchenko wrote: > On Thu,

✗ Fi.CI.SPARSE: warning for drm/display: dp: add new DPCD access functions

2025-03-07 Thread Patchwork
== Series Details == Series: drm/display: dp: add new DPCD access functions URL : https://patchwork.freedesktop.org/series/145998/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ i915.CI.BAT: success for bits: Fixed-type GENMASK()/BIT() (rev2)

2025-03-07 Thread Patchwork
== Series Details == Series: bits: Fixed-type GENMASK()/BIT() (rev2) URL : https://patchwork.freedesktop.org/series/145997/ State : success == Summary == CI Bug Log - changes from CI_DRM_16245 -> Patchwork_145997v2 Summary --- **SUCC

✗ Fi.CI.SPARSE: warning for bits: Fixed-type GENMASK()/BIT() (rev2)

2025-03-07 Thread Patchwork
== Series Details == Series: bits: Fixed-type GENMASK()/BIT() (rev2) URL : https://patchwork.freedesktop.org/series/145997/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for bits: Fixed-type GENMASK()/BIT() (rev2)

2025-03-07 Thread Patchwork
== Series Details == Series: bits: Fixed-type GENMASK()/BIT() (rev2) URL : https://patchwork.freedesktop.org/series/145997/ State : warning == Summary == Error: dim checkpatch failed f96fba907aff bits: fix typo 'unsigned __init128' -> 'unsigned __int128' fdc85516eb83 bits: split the definition

Re: [PATCH v5 7/7] test_bits: add tests for BIT_U*()

2025-03-07 Thread Andy Shevchenko
On Fri, Mar 07, 2025 at 07:11:42PM +0900, Vincent Mailhol wrote: > On 07/03/2025 at 02:55, Andy Shevchenko wrote: > > On Fri, Mar 07, 2025 at 01:08:15AM +0900, Vincent Mailhol wrote: > >> On 06/03/2025 at 22:11, Andy Shevchenko wrote: > >>> On Thu, Mar 06, 2025 at 08:29:58PM +0900, Vincent Mailhol

✗ i915.CI.BAT: failure for drm/i915/selftests: Re-enable power gating after live_selftest (rev3)

2025-03-07 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Re-enable power gating after live_selftest (rev3) URL : https://patchwork.freedesktop.org/series/145144/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16245 -> Patchwork_145144v3 =

Re: [PATCH v5 1/7] bits: split the definition of the asm and non-asm GENMASK()

2025-03-07 Thread Vincent Mailhol
On 07/03/2025 at 22:27, David Laight wrote: > On Fri, 7 Mar 2025 18:58:08 +0900 > Vincent Mailhol wrote: > >> On 07/03/2025 at 04:23, David Laight wrote: >>> On Thu, 06 Mar 2025 20:29:52 +0900 >>> Vincent Mailhol via B4 Relay >>> wrote: >>> From: Vincent Mailhol (...) +#define G

✗ Fi.CI.BUILD: failure for Remove aops->writepage

2025-03-07 Thread Patchwork
== Series Details == Series: Remove aops->writepage URL : https://patchwork.freedesktop.org/series/145995/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/145995/revisions/1/mbox/ not applied Applying: f2fs: Remove check for ->writepage Applying: f

✗ i915.CI.BAT: failure for i915/gt/selftest_lrc: Disable timestamp test

2025-03-07 Thread Patchwork
== Series Details == Series: i915/gt/selftest_lrc: Disable timestamp test URL : https://patchwork.freedesktop.org/series/145991/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16245 -> Patchwork_145991v1 Summary --- *

[RFC PATCH 09/11] drm/i915/psr: Apply underrun on PSR idle workaround

2025-03-07 Thread Jouni Högander
This patch is applying workaround for underrun on idle PSR HW issue (Wa_16025596647) when PSR is getting enabled. It uses vblank enable/disable status, DC5/6 enabled disabled and enabled pipes count information made available. This patch is also adding calls to dc5/dc6, vblank enable/disable and p

Re: [PULL] drm-xe-next

2025-03-07 Thread Lucas De Marchi
On Fri, Mar 07, 2025 at 02:02:15AM -0600, Lucas De Marchi wrote: Hi Dave and Sima, Last drm-xe-next pull request for 6.15. It comes with some big features that we have been working on for some time: EU stall sampling and SVM. The latter also touches other subsystems and provides the common parts

✓ i915.CI.BAT: success for drm/i915/psr: Check transcoder Selective Update support for PR as well

2025-03-07 Thread Patchwork
== Series Details == Series: drm/i915/psr: Check transcoder Selective Update support for PR as well URL : https://patchwork.freedesktop.org/series/145989/ State : success == Summary == CI Bug Log - changes from CI_DRM_16245 -> Patchwork_145989v1

[PATCH v4 1/8] bits: fix typo 'unsigned __init128' -> 'unsigned __int128'

2025-03-07 Thread Vincent Mailhol via B4 Relay
From: Vincent Mailhol "int" was misspelled as "init" in GENMASK_U128() comments. Fix the typo. Signed-off-by: Vincent Mailhol --- include/linux/bits.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/bits.h b/include/linux/bits.h index 61a75d3f294bfa96267383b5

[PATCH 11/11] fs: Remove aops->writepage

2025-03-07 Thread Matthew Wilcox (Oracle)
All callers and implementations are now removed, so remove the operation and update the documentation to match. Signed-off-by: Matthew Wilcox (Oracle) --- Documentation/admin-guide/cgroup-v2.rst | 2 +- Documentation/filesystems/fscrypt.rst | 2 +- Documentation/filesystems/locking.rst | 5

Re: [PATCH 17/21] drm/i915/display: Move vrr.guardband/pipeline_full out of !fastset block

2025-03-07 Thread Ville Syrjälä
On Thu, Mar 06, 2025 at 06:40:56PM +0530, Ankit Nautiyal wrote: > The vrr.guardband/pipeline_full depend on the vrr.vmin. Since we have > set vrr.vmin to adjusted_mode->crtc_vtotal, this shouldn't change on the > fly. With this we can move vrr.guardband/pipeline_full out from !fastset > block. > >

Re: [PATCH 05/11] drm/i915/dpll: Move away from using shared dpll

2025-03-07 Thread Ville Syrjälä
On Fri, Mar 07, 2025 at 12:02:09PM +, Kahola, Mika wrote: > > -Original Message- > > From: Ville Syrjälä > > Sent: Monday, 3 March 2025 14.52 > > To: Kandpal, Suraj > > Cc: Jani Nikula ; > > intel...@lists.freedesktop.org; > > intel-gfx@lists.freedesktop.org; Syrjala, Ville ; > > Na

[PATCH RFC v3 0/7] drm/display: dp: add new DPCD access functions

2025-03-07 Thread Dmitry Baryshkov
Existing DPCD access functions return an error code or the number of bytes being read / write in case of partial access. However a lot of drivers either (incorrectly) ignore partial access or mishandle error codes. In other cases this results in a boilerplate code which compares returned value with

Re: [PATCH v5 1/7] bits: split the definition of the asm and non-asm GENMASK()

2025-03-07 Thread David Laight
On Thu, 06 Mar 2025 20:29:52 +0900 Vincent Mailhol via B4 Relay wrote: > From: Vincent Mailhol > > In an upcoming change, GENMASK() and its friends will indirectly > depend on sizeof() which is not available in asm. > > Instead of adding further complexity to __GENMASK() to make it work > for

Re: [PATCH v5 2/7] bits: introduce fixed-type genmasks

2025-03-07 Thread Vincent Mailhol
On 06/03/2025 à 22:08, Andy Shevchenko wrote: > On Thu, Mar 06, 2025 at 08:29:53PM +0900, Vincent Mailhol via B4 Relay wrote: >> From: Yury Norov >> >> Add GENMASK_TYPE() which generalizes __GENMASK() to support different >> types, and implement fixed-types versions of GENMASK() based on it. >> Th

[PATCH RFC v3 3/7] drm/display: dp: use new DCPD access helpers

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Switch drm_dp_helper.c to use new set of DPCD read / write helpers. Reviewed-by: Lyude Paul Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_helper.c | 296 +--- 1 file changed, 116 insertions(+), 180

Re: [PATCH v4 4/8] bits: introduce fixed-type BIT

2025-03-07 Thread Vincent Mailhol
On 05/03/2025 at 23:33, Andy Shevchenko wrote: > On Wed, Mar 05, 2025 at 10:00:16PM +0900, Vincent Mailhol via B4 Relay wrote: >> From: Lucas De Marchi >> >> Implement fixed-type BIT to help drivers add stricter checks, like was > > Here and in the Subject I would use BIT_Uxx(). > >> done for GE

[PATCH v4 7/8] test_bits: add tests for fixed-type genmasks

2025-03-07 Thread Vincent Mailhol via B4 Relay
From: Lucas De Marchi Add some additional tests in lib/test_bits.c to cover the expected/non-expected values of the fixed-type genmasks. Also check that the result value matches the expected type. Since those are known at build time, use static_assert() instead of normal kunit tests. Signed-off

Re: [PATCH v4 1/8] bits: fix typo 'unsigned __init128' -> 'unsigned __int128'

2025-03-07 Thread Yury Norov
Hi Vincent! On Wed, Mar 05, 2025 at 10:00:13PM +0900, Vincent Mailhol via B4 Relay wrote: > From: Vincent Mailhol > > "int" was misspelled as "init" in GENMASK_U128() comments. Fix the typo. > > Signed-off-by: Vincent Mailhol Thanks for respinning the series. I'll take this fix in bitmap-for-

Re: [PATCH 07/11] drm/i915/dpll: Change argument for enable hook in intel_global_dpll_funcs

2025-03-07 Thread Ville Syrjälä
On Tue, Feb 25, 2025 at 01:39:23PM +0530, Suraj Kandpal wrote: > Change the arguments for enable hook in intel_global_dpll_funcs to only > accept crtc_state. This is because we really don't need those extra > arguments everything can be derived from crtc_state and we need > intel_encoder for PLL en

[PATCH 02/11] f2fs: Remove f2fs_write_data_page()

2025-03-07 Thread Matthew Wilcox (Oracle)
Mappings which implement writepages should not implement writepage as it can only harm writeback patterns. Signed-off-by: Matthew Wilcox (Oracle) --- fs/f2fs/data.c | 24 1 file changed, 24 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index a80d5ef9acbb..cd

Re: [PATCH v5 6/8] drm/i915/lobf: Check for sink error and disable LOBF

2025-03-07 Thread Hogander, Jouni
On Mon, 2025-03-03 at 14:05 +0530, Animesh Manna wrote: > Disable LOBF/ALPM for any erroneous condition from sink side. > > v1: Initial version. > v2: Add centralized alpm error handling. [Jouni] > > Signed-off-by: Animesh Manna > --- >  drivers/gpu/drm/i915/display/intel_alpm.c | 25 > +

Re: [PATCH v5 0/7] bits: Fixed-type GENMASK()/BIT()

2025-03-07 Thread Vincent Mailhol
On 06/03/2025 at 22:02, Andy Shevchenko wrote: > On Thu, Mar 06, 2025 at 08:29:51PM +0900, Vincent Mailhol via B4 Relay wrote: >> Introduce some fixed width variant of the GENMASK() and the BIT() >> macros in bits.h. Note that the main goal is not to get the correct >> type, but rather to enforce m

Re: [PATCH v5 1/7] bits: split the definition of the asm and non-asm GENMASK()

2025-03-07 Thread Vincent Mailhol
On 06/03/2025 at 22:05, Andy Shevchenko wrote: > On Thu, Mar 06, 2025 at 08:29:52PM +0900, Vincent Mailhol via B4 Relay wrote: >> From: Vincent Mailhol >> >> In an upcoming change, GENMASK() and its friends will indirectly >> depend on sizeof() which is not available in asm. >> >> Instead of addin

[PATCH v4 8/8] test_bits: add tests for fixed-type BIT

2025-03-07 Thread Vincent Mailhol via B4 Relay
From: Vincent Mailhol Add some additional tests in lib/test_bits.c to cover the expected results of the BIT_U*() macros. Signed-off-by: Vincent Mailhol --- lib/test_bits.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/test_bits.c b/lib/test_bits.c index c3a40995a25773222

Re: [PATCH v4 1/8] bits: fix typo 'unsigned __init128' -> 'unsigned __int128'

2025-03-07 Thread Vincent Mailhol
On 05/03/2025 at 23:38, Yury Norov wrote: > On Wed, Mar 05, 2025 at 04:36:12PM +0200, Andy Shevchenko wrote: >> On Wed, Mar 05, 2025 at 09:30:20AM -0500, Yury Norov wrote: >>> On Wed, Mar 05, 2025 at 10:00:13PM +0900, Vincent Mailhol via B4 Relay >>> wrote: From: Vincent Mailhol "i

Re: [PATCH v4 4/8] bits: introduce fixed-type BIT

2025-03-07 Thread Vincent Mailhol
On 06/03/2025 at 00:48, Andy Shevchenko wrote: > On Wed, Mar 05, 2025 at 11:48:10PM +0900, Vincent Mailhol wrote: >> On 05/03/2025 at 23:33, Andy Shevchenko wrote: >>> On Wed, Mar 05, 2025 at 10:00:16PM +0900, Vincent Mailhol via B4 Relay >>> wrote: > > ... > +#define BIT_U8(b) (BIT_INPUT_C

Re: [PATCH v4 3/8] bits: introduce fixed-type genmasks

2025-03-07 Thread Yury Norov
On Wed, Mar 05, 2025 at 10:00:15PM +0900, Vincent Mailhol via B4 Relay wrote: > From: Yury Norov > > Add __GENMASK_t() which generalizes __GENMASK() to support different > types, and implement fixed-types versions of GENMASK() based on it. > The fixed-type version allows more strict checks to the

[PATCH v5 7/7] test_bits: add tests for BIT_U*()

2025-03-07 Thread Vincent Mailhol via B4 Relay
From: Vincent Mailhol Add some additional tests in lib/test_bits.c to cover the expected results of the fixed type BIT_U*() macros. Signed-off-by: Vincent Mailhol --- Changelog v4 -> v5: - BIT_U8()/BIT_U16() are now back to u8/u16. v3 -> v4: - New patch. --- lib/test_bits.c | 1

[PATCH RFC v3 7/7] drm/display: dp-tunnel: use new DCPD access helpers

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Switch drm_dp_tunnel.c to use new set of DPCD read / write helpers. Reviewed-by: Lyude Paul Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_tunnel.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) d

[PATCH v5 2/7] bits: introduce fixed-type genmasks

2025-03-07 Thread Vincent Mailhol via B4 Relay
From: Yury Norov Add GENMASK_TYPE() which generalizes __GENMASK() to support different types, and implement fixed-types versions of GENMASK() based on it. The fixed-type version allows more strict checks to the min/max values accepted, which is useful for defining registers like implemented by i9

[PATCH v5 4/7] drm/i915: Convert REG_GENMASK*() to fixed-width GENMASK_U*()

2025-03-07 Thread Vincent Mailhol via B4 Relay
From: Lucas De Marchi Now that include/linux/bits.h implements fixed-width GENMASK_U*(), use them to implement the i915/xe specific macros. Converting each driver to use the generic macros are left for later, when/if other driver-specific macros are also generalized. Signed-off-by: Lucas De Marc

Re: Discussion: Moving away from Patchwork for Intel i915/Xe CI

2025-03-07 Thread Ryszard Knop
On Wed, 2025-03-05 at 19:52 +0200, Jani Nikula wrote: > On Wed, 05 Mar 2025, "Knop, Ryszard" wrote: > > Hey everyone, > > > > Patchwork has been having lots of issues recently, dropping patches, > > being unusably slow and generally starting to become more of a pain > > than help. Over on the CI

[PATCH v4 4/8] bits: introduce fixed-type BIT

2025-03-07 Thread Vincent Mailhol via B4 Relay
From: Lucas De Marchi Implement fixed-type BIT to help drivers add stricter checks, like was done for GENMASK(). Signed-off-by: Lucas De Marchi Acked-by: Jani Nikula Signed-off-by: Vincent Mailhol --- Changelog: v3 -> v4: - Use const_true() to simplify BIT_INPUT_CHECK(). - Make B

[PATCH RFC v3 6/7] drm/display: dp-mst-topology: use new DCPD access helpers

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Switch drm_dp_mst_topology.c to use new set of DPCD read / write helpers. Reviewed-by: Lyude Paul Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 105 +- 1 file changed, 51 insertions(+),

[PATCH v5 1/7] bits: split the definition of the asm and non-asm GENMASK()

2025-03-07 Thread Vincent Mailhol via B4 Relay
From: Vincent Mailhol In an upcoming change, GENMASK() and its friends will indirectly depend on sizeof() which is not available in asm. Instead of adding further complexity to __GENMASK() to make it work for both asm and non asm, just split the definition of the two variants. Signed-off-by: Vi

Re: [PATCH v4 4/8] bits: introduce fixed-type BIT

2025-03-07 Thread David Laight
On Wed, 5 Mar 2025 21:56:22 +0200 Andy Shevchenko wrote: > On Thu, Mar 06, 2025 at 02:17:18AM +0900, Vincent Mailhol wrote: > > On 06/03/2025 at 00:48, Andy Shevchenko wrote: > > > On Wed, Mar 05, 2025 at 11:48:10PM +0900, Vincent Mailhol wrote: > > >> On 05/03/2025 at 23:33, Andy Shevchenko

[PATCH RFC v3 2/7] drm/display: dp: change drm_dp_dpcd_read_link_status() return value

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov drm_dp_dpcd_read_link_status() follows the "return error code or number of bytes read" protocol, with the code returning less bytes than requested in case of some errors. However most of the drivers interpreted that as "return error code in case of any error". Switch drm_dp

[PATCH v4 5/8] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

2025-03-07 Thread Vincent Mailhol via B4 Relay
From: Lucas De Marchi Now that include/linux/bits.h implements fixed-width GENMASK_*, use them to implement the i915/xe specific macros. Converting each driver to use the generic macros are left for later, when/if other driver-specific macros are also generalized. Signed-off-by: Lucas De Marchi

Re: Discussion: Moving away from Patchwork for Intel i915/Xe CI

2025-03-07 Thread Konstantin Ryabitsev
On Wed, Mar 05, 2025 at 07:52:31PM +0200, Jani Nikula wrote: > > - For each new series on lore.kernel.org a bridge would create a PR by > > taking the latest mirrored drm-tip source, then applying a new series > > with `b4 shazam`. > > There's a small catch here. Patchwork is currently more clever

Re: [PATCH v5 7/7] test_bits: add tests for BIT_U*()

2025-03-07 Thread Vincent Mailhol
On 06/03/2025 at 22:11, Andy Shevchenko wrote: > On Thu, Mar 06, 2025 at 08:29:58PM +0900, Vincent Mailhol via B4 Relay wrote: >> From: Vincent Mailhol >> >> Add some additional tests in lib/test_bits.c to cover the expected >> results of the fixed type BIT_U*() macros. > > Still would be good to

Re: [PATCH v4 4/8] bits: introduce fixed-type BIT

2025-03-07 Thread Vincent Mailhol
On 06/03/2025 at 18:12, Andy Shevchenko wrote: > On Wed, Mar 05, 2025 at 09:50:27PM +, David Laight wrote: >> On Wed, 5 Mar 2025 21:56:22 +0200 >> Andy Shevchenko wrote: >>> On Thu, Mar 06, 2025 at 02:17:18AM +0900, Vincent Mailhol wrote: On 06/03/2025 at 00:48, Andy Shevchenko wrote: >

Re: [PATCH v5 1/7] bits: split the definition of the asm and non-asm GENMASK()

2025-03-07 Thread Vincent Mailhol
On 06/03/2025 at 23:34, Lucas De Marchi wrote: > On Thu, Mar 06, 2025 at 08:29:52PM +0900, Vincent Mailhol via B4 Relay > wrote: (...) > it seems we now have 1 inconsistency that we comment why > GENMASK_U128() is not available in asm, but we don't comment why > GENMASK_INPUT_CHECK() is not avail

  1   2   >