Re: [PATCH 04/10] drm/i915/vrr: Compute vrr vsync if platforms support it

2024-07-15 Thread Nautiyal, Ankit K
On 7/16/2024 9:36 AM, Golani, Mitulkumar Ajitkumar wrote: -Original Message- From: Nautiyal, Ankit K Sent: Tuesday, July 9, 2024 8:57 AM To: intel-gfx@lists.freedesktop.org Cc: jani.nik...@linux.intel.com; ville.syrj...@linux.intel.com; Golani, Mitulkumar Ajitkumar Subject: [PATCH 0

Re: [PATCH 02/10] drm/i915/display: Add member fixed_rr to denote Fixed refresh rate with VRRTG

2024-07-15 Thread Nautiyal, Ankit K
On 7/16/2024 9:33 AM, Golani, Mitulkumar Ajitkumar wrote: -Original Message- From: Nautiyal, Ankit K Sent: Tuesday, July 9, 2024 8:57 AM To: intel-gfx@lists.freedesktop.org Cc: jani.nik...@linux.intel.com; ville.syrj...@linux.intel.com; Golani, Mitulkumar Ajitkumar Subject: [PATCH 0

RE: Regression on linux-next (next-20240709)

2024-07-15 Thread Borah, Chaitanya Kumar
> -Original Message- > From: Lai Jiangshan > Sent: Friday, July 12, 2024 2:23 PM > To: Borah, Chaitanya Kumar > Cc: jiangshan@antgroup.com; linux-ker...@vger.kernel.org; Nikula, Jani > ; Saarinen, Jani ; Kurmi, > Suresh Kumar > Subject: Re: Regression on linux-next (next-20240709)

✓ Fi.CI.BAT: success for drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp (rev2)

2024-07-15 Thread Patchwork
== Series Details == Series: drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp (rev2) URL : https://patchwork.freedesktop.org/series/136072/ State : success == Summary == CI Bug Log - changes from CI_DRM_15081 -> Patchwork_136072v2

Regression on linux-next (next-20240712)

2024-07-15 Thread Borah, Chaitanya Kumar
Hello Pei, Hope you are doing well. I am Chaitanya from the linux graphics team in Intel. This mail is regarding a regression we are seeing in our CI runs[1] on linux-next repository. In version next-20240712[2], we saw the following regression (currently being masked by another regression) `

RE: [PATCH 08/10] drm/i915/vrr: Avoid sending PUSH when VRR TG is used with Fixed refresh rate

2024-07-15 Thread Golani, Mitulkumar Ajitkumar
> -Original Message- > From: Nautiyal, Ankit K > Sent: Tuesday, July 9, 2024 8:57 AM > To: intel-gfx@lists.freedesktop.org > Cc: jani.nik...@linux.intel.com; ville.syrj...@linux.intel.com; Golani, > Mitulkumar Ajitkumar > Subject: [PATCH 08/10] drm/i915/vrr: Avoid sending PUSH when VRR

RE: [PATCH 04/10] drm/i915/vrr: Compute vrr vsync if platforms support it

2024-07-15 Thread Golani, Mitulkumar Ajitkumar
> -Original Message- > From: Nautiyal, Ankit K > Sent: Tuesday, July 9, 2024 8:57 AM > To: intel-gfx@lists.freedesktop.org > Cc: jani.nik...@linux.intel.com; ville.syrj...@linux.intel.com; Golani, > Mitulkumar Ajitkumar > Subject: [PATCH 04/10] drm/i915/vrr: Compute vrr vsync if platfo

RE: [PATCH 02/10] drm/i915/display: Add member fixed_rr to denote Fixed refresh rate with VRRTG

2024-07-15 Thread Golani, Mitulkumar Ajitkumar
> -Original Message- > From: Nautiyal, Ankit K > Sent: Tuesday, July 9, 2024 8:57 AM > To: intel-gfx@lists.freedesktop.org > Cc: jani.nik...@linux.intel.com; ville.syrj...@linux.intel.com; Golani, > Mitulkumar Ajitkumar > Subject: [PATCH 02/10] drm/i915/display: Add member fixed_rr to

RE: [PATCH v3] drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8

2024-07-15 Thread Gote, Nitin R
Hi, > -Original Message- > From: Andi Shyti > Sent: Tuesday, July 16, 2024 3:44 AM > To: Gote, Nitin R > Cc: Vivi, Rodrigo ; Cavitt, Jonathan > ; Wilson, Chris P ; > tursu...@ursulin.net; intel-gfx@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; Das, Nirmoy ; > janusz.krzyszto

Re: [PATCH 2/2] drm/i915/guc: Extend w/a 14019159160

2024-07-15 Thread Belgaumkar, Vinay
On 6/21/2024 5:46 PM, john.c.harri...@intel.com wrote: From: John Harrison There is a new part to an existing workaround, so enable that piece as well. v2: Extend even further. v3: Drop DG2 as there are CI failures still to resolve. Also re-order the parameters to a function to reduce excess

Re: [PATCH 1/2] drm/i915/arl: Enable Wa_14019159160 for ARL

2024-07-15 Thread Belgaumkar, Vinay
On 6/21/2024 5:46 PM, john.c.harri...@intel.com wrote: From: John Harrison The context switch out workaround also applies to ARL. Signed-off-by: John Harrison LGTM, Reviewed-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel

Re: [PATCH v3] drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8

2024-07-15 Thread Andi Shyti
Hi, On Fri, Jul 12, 2024 at 03:25:23PM +0200, Gote, Nitin R wrote: > > -Original Message- > > From: Vivi, Rodrigo > > Sent: Thursday, July 11, 2024 11:39 PM > > To: Cavitt, Jonathan > > Cc: Gote, Nitin R ; Wilson, Chris P > > ; tursu...@ursulin.net; intel- > > g...@lists.freedesktop.org;

✓ Fi.CI.BAT: success for drm/xe/fbdev: Limit the usage of stolen for LNL+ (rev3)

2024-07-15 Thread Patchwork
== Series Details == Series: drm/xe/fbdev: Limit the usage of stolen for LNL+ (rev3) URL : https://patchwork.freedesktop.org/series/135971/ State : success == Summary == CI Bug Log - changes from CI_DRM_15081 -> Patchwork_135971v3 Summary -

[v3] drm/xe/fbdev: Limit the usage of stolen for LNL+

2024-07-15 Thread Uma Shankar
As per recommendation in the workarounds: WA_22019338487 There is an issue with accessing Stolen memory pages due a hardware limitation. Limit the usage of stolen memory for fbdev for LNL+. Don't use BIOS FB from stolen on LNL+ and assign the same from system memory. v2: Corrected the WA Number,

RE: [v2] drm/xe/fbdev: Limit the usage of stolen for LNL+

2024-07-15 Thread Shankar, Uma
> -Original Message- > From: De Marchi, Lucas > Sent: Monday, July 15, 2024 6:53 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org; > ville.syrj...@linux.intel.com; Ceraolo Spurio, Daniele > ; Belgaumkar, Vinay > ; Roper, Matthew D > > Subject

[PATCH i-g-t v2 3/5] lib/gem_engine_topology: Fix premature break from primary find loop

2024-07-15 Thread Janusz Krzysztofik
When looking for a primary counterpart of a render device, we try to open each primary minor. When one fails, we should continue rather then break, since contiguity of minor numbers assigned to devices is not guaranteed. Signed-off-by: Janusz Krzysztofik --- lib/i915/gem_engine_topology.c | 2 +

[PATCH i-g-t v2 5/5] lib/gem_engine_topology: Fix broken compare of device links

2024-07-15 Thread Janusz Krzysztofik
When looking for a primary counterpart of a render device, we compare "device" links of both nodes. If those links point to the same device then we know we've found the correct primary node. However, readlinkat() function we use doesn't explicitly terminate read in strings with null characters, a

[PATCH i-g-t v2 4/5] lib/gem_engine_topology: Simplify the method of opening a primary

2024-07-15 Thread Janusz Krzysztofik
When opening a potential primary counterpart of a render device, we first open a parent directory of the render node and pass it to openat() that can open a path relative to that directory. But on the other hand, we build and pass to that function a path of that primary that is absolute, not relat

[PATCH i-g-t v2 2/5] lib: Add more debug messages to error paths

2024-07-15 Thread Janusz Krzysztofik
On an attempt to resolve the issue of mysteriously failing updates of sysfs entries representing engine preempt timeout values, add debug messages to error paths of involved library functions. Link: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6268 Signed-off-by: Janusz Krzysztofik ---

[PATCH i-g-t v2 1/5] tests/gem_ctx_exec: Fail on unsuccessful preempt timeout update

2024-07-15 Thread Janusz Krzysztofik
CI reports the following failures from basic-nohangcheck subtest: (gem_ctx_exec:1115) CRITICAL: Test assertion failure function nohangcheck_hostile, file ../../../usr/src/igt-gpu-tools/tests/intel/gem_ctx_exec.c:374: (gem_ctx_exec:1115) CRITICAL: Failed assertion: err == 0 (gem_ctx_exec:1115) CR

[PATCH i-g-t v2 0/5] tests/gem_ctx_exec: Fix failing preempt timeout updates

2024-07-15 Thread Janusz Krzysztofik
CI reports the following failures from basic-nohangcheck subtest: (gem_ctx_exec:1115) CRITICAL: Test assertion failure function nohangcheck_hostile, file ../../../usr/src/igt-gpu-tools/tests/intel/gem_ctx_exec.c:374: (gem_ctx_exec:1115) CRITICAL: Failed assertion: err == 0 (gem_ctx_exec:1115) CR

[PATCH i-g-t 5/5] lib/gem_engine_topology: Fix broken compare of device links

2024-07-15 Thread Janusz Krzysztofik
When looking for a primary counterpart of a render device, we compare "device" links of both nodes. If those links point to the same device then we know we've found the correct primary node. However, readlinkat() function we use doesn't explicitly terminate read in strings with null characters, a

[PATCH i-g-t 4/5] lib/gem_engine_topology: Simplify the method of opening a primary

2024-07-15 Thread Janusz Krzysztofik
When opening a potential primary counterpart of a render device, we first open a parent directory of the render node and pass it to openat() that can open a path relative to that directory. But on the other hand, we build and pass to that function a path of that primary that is absolute, not relat

[PATCH i-g-t 3/5] lib/gem_engine_topology: Fix premature break from primary find loop

2024-07-15 Thread Janusz Krzysztofik
When looking for a primary counterpart of a render device, we try to open each primary minor. When one fails, we should continue rather then break, since contiguity of minor numbers assigned to devices is not guaranteed. Signed-off-by: Janusz Krzysztofik --- lib/i915/gem_engine_topology.c | 2 +

[PATCH i-g-t 2/5] lib: Add more debug messages to error paths

2024-07-15 Thread Janusz Krzysztofik
On an attempt to resolve the issue of mysteriously failing updates of sysfs entries representing engine preempt timeout values, add debug messages to error paths of involved library functions. Link: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6268 Signed-off-by: Janusz Krzysztofik ---

[PATCH i-g-t 1/5] tests/gem_ctx_exec: Fail on unsuccessful preempt timeout update

2024-07-15 Thread Janusz Krzysztofik
CI reports the following failures from basic-nohangcheck subtest: (gem_ctx_exec:1115) CRITICAL: Test assertion failure function nohangcheck_hostile, file ../../../usr/src/igt-gpu-tools/tests/intel/gem_ctx_exec.c:374: (gem_ctx_exec:1115) CRITICAL: Failed assertion: err == 0 (gem_ctx_exec:1115) CR

[PATCH i-g-t 0/5] tests/gem_ctx_exec: Fix failing preempt timeout updates

2024-07-15 Thread Janusz Krzysztofik
CI reports the following failures from basic-nohangcheck subtest: (gem_ctx_exec:1115) CRITICAL: Test assertion failure function nohangcheck_hostile, file ../../../usr/src/igt-gpu-tools/tests/intel/gem_ctx_exec.c:374: (gem_ctx_exec:1115) CRITICAL: Failed assertion: err == 0 (gem_ctx_exec:1115) CR

✗ Fi.CI.BAT: failure for drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp (rev2)

2024-07-15 Thread Patchwork
== Series Details == Series: drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp (rev2) URL : https://patchwork.freedesktop.org/series/136072/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15081 -> Patchwork_136072v2

✗ Fi.CI.SPARSE: warning for drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp (rev2)

2024-07-15 Thread Patchwork
== Series Details == Series: drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp (rev2) URL : https://patchwork.freedesktop.org/series/136072/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH v5] drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp

2024-07-15 Thread Mitul Golani
Describe newly added parameter target_rr_divider in struct drm_dp_as_sdp. -v2: Remove extra line from commit message.(Lucas) -v3: Rebase. Fixes: a20c6d954d75 ("drm/dp: Add refresh rate divider to struct representing AS SDP") Cc: Mitul Golani Cc: Arun R Murthy Cc: Suraj Kandpal Cc: Ankit Naut

Re: [v2] drm/xe/fbdev: Limit the usage of stolen for LNL+

2024-07-15 Thread Lucas De Marchi
On Mon, Jul 15, 2024 at 02:26:59AM GMT, Uma Shankar wrote: As per recommendation in the workarounds: WA_22019338487 There is an issue with accessing Stolen memory pages due a hardware limitation. Limit the usage of stolen memory for fbdev for LNL+. Don't use BIOS FB from stolen on LNL+ and assig

RE: ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/dp: Retrain SST links via a modeset commit

2024-07-15 Thread Illipilli, TejasreeX
Hi, https://patchwork.freedesktop.org/series/136044/ - Re-reported Thanks, Tejasree -Original Message- From: I915-ci-infra On Behalf Of Imre Deak Sent: Friday, July 12, 2024 9:01 PM To: i915-ci-in...@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Subject: Re: ✗ Fi.CI.BAT: fa

✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/dp: Retrain SST links via a modeset commit

2024-07-15 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/dp: Retrain SST links via a modeset commit URL : https://patchwork.freedesktop.org/series/136044/ State : success == Summary == CI Bug Log - changes from CI_DRM_15071 -> Patchwork_136044v1 ===

Re: linux-next: build warning after merge of the drm-intel tree

2024-07-15 Thread Maarten Lankhorst
Hey, Den 2024-07-15 kl. 06:21, skrev Golani, Mitulkumar Ajitkumar: > > On 15-07-2024 04:42, Stephen Rothwell wrote: >> Hi all, >> >> On Wed, 12 Jun 2024 14:11:10 +1000 Stephen Rothwell >> wrote: >>> After merging the drm-intel tree, today's linux-next build (htmldocs) >>> produced this warning:

Re: [PATCH v3] drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp

2024-07-15 Thread Maarten Lankhorst
Acked-by: Maarten Lankhorst Den 2024-07-15 kl. 06:02, skrev Mitul Golani: > Describe newly added parameter target_rr_divider in struct > drm_dp_as_sdp. > > -v2: > Remove extra line from commit message.(Lucas) > > -v3: > Rebase. > > Fixes: a20c6d954d75 ("drm/dp: Add refresh rate divider to stru

Re: [PATCH 1/2] drm: Add might_fault to drm_modeset_lock priming

2024-07-15 Thread Daniel Vetter
On Wed, Jul 10, 2024 at 02:40:04PM +0200, Christian König wrote: > Am 10.07.24 um 13:58 schrieb Daniel Vetter: > > On Wed, 10 Jul 2024 at 13:39, Christian König > > wrote: > > > Am 10.07.24 um 11:31 schrieb Daniel Vetter: > > > > We already teach lockdep that dma_resv nests within drm_modeset_loc

Re: [PATCH v9 00/53] fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y

2024-07-15 Thread Łukasz Bartosik
On Sat, Jul 13, 2024 at 11:45 PM wrote: > > On Fri, Jul 12, 2024 at 9:44 AM Łukasz Bartosik wrote: > > > > On Wed, Jul 3, 2024 at 12:14 AM wrote: > > > > > > On Tue, Jul 2, 2024 at 4:01 PM Luis Chamberlain wrote: > > > > > > > > On Tue, Jul 02, 2024 at 03:56:50PM -0600, Jim Cromie wrote: > > >

Re: [PATCH] bcachefs: no console_lock in bch2_print_string_as_lines

2024-07-15 Thread Daniel Vetter
On Wed, Jul 10, 2024 at 04:19:53PM +0206, John Ogness wrote: > On 2024-07-10, Daniel Vetter wrote: > > console_lock is the outermost subsystem lock for a lot of subsystems, > > which means get/put_user must nest within. Which means it cannot be > > acquired somewhere deeply nested in other locks,

RE: [PATCH 05/10] drm/i915/hdmi: Use VRR Timing generator for HDMI

2024-07-15 Thread Golani, Mitulkumar Ajitkumar
> -Original Message- > From: Nautiyal, Ankit K > Sent: Tuesday, July 9, 2024 8:57 AM > To: intel-gfx@lists.freedesktop.org > Cc: jani.nik...@linux.intel.com; ville.syrj...@linux.intel.com; Golani, > Mitulkumar Ajitkumar > Subject: [PATCH 05/10] drm/i915/hdmi: Use VRR Timing generator f

RE: [PATCH 03/10] drm/i915/dp: Set FAVT mode in DP SDP with fixed refresh rate

2024-07-15 Thread Golani, Mitulkumar Ajitkumar
> -Original Message- > From: Nautiyal, Ankit K > Sent: Tuesday, July 9, 2024 8:57 AM > To: intel-gfx@lists.freedesktop.org > Cc: jani.nik...@linux.intel.com; ville.syrj...@linux.intel.com; Golani, > Mitulkumar Ajitkumar > Subject: [PATCH 03/10] drm/i915/dp: Set FAVT mode in DP SDP with