RE: [PATCH 03/10] drm/i915/dp: Set FAVT mode in DP SDP with fixed refresh rate

[Golani, Mitulkumar Ajitkumar]

> -----Original Message-----
> From: Nautiyal, Ankit K <ankit.k.nauti...@intel.com>
> Sent: Tuesday, July 9, 2024 8:57 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: jani.nik...@linux.intel.com; ville.syrj...@linux.intel.com; Golani,
> Mitulkumar Ajitkumar <mitulkumar.ajitkumar.gol...@intel.com>
> Subject: [PATCH 03/10] drm/i915/dp: Set FAVT mode in DP SDP with fixed
> refresh rate
> 
> While running with fixed refresh rate and VRR timing generator set FAVT
> mode (Fixed Vtotal) in DP Adaptive Sync SDP to intimate the panel about
> Fixed refresh rate.
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nauti...@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 3f46e13bb7b8..dcb94526cf00 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2642,6 +2642,10 @@ static void intel_dp_compute_as_sdp(struct
> intel_dp *intel_dp,
>               as_sdp->target_rr = drm_mode_vrefresh(adjusted_mode);
>               as_sdp->target_rr_divider = true;
>       } else {
> +             if (crtc_state->vrr.fixed_rr)
> +                     as_sdp->mode = DP_AS_SDP_AVT_FIXED_VTOTAL;
> +             else
> +                     as_sdp->mode =
> DP_AS_SDP_AVT_DYNAMIC_VTOTAL;

Changes LGTM.
Reviewed-by: Mitul Golani <mitulkumar.ajitkumar.gol...@intel.com>

>               as_sdp->mode = DP_AS_SDP_AVT_DYNAMIC_VTOTAL;
>               as_sdp->vtotal = adjusted_mode->vtotal;
>               as_sdp->target_rr = 0;
> --
> 2.40.1